Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68040 )
Change subject: cpu/intel/car/romstage.c: Clean up includes and add <types.h>
......................................................................
cpu/intel/car/romstage.c: Clean up includes and add <types.h>
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
Change-Id: I84639389ac1066468b82bb13d684e5423b909fcb
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68040
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Martin L Roth <gaumless(a)gmail.com>
---
M src/cpu/intel/car/romstage.c
1 file changed, 16 insertions(+), 3 deletions(-)
Approvals:
build bot (Jenkins): Verified
Martin L Roth: Looks good to me, approved
diff --git a/src/cpu/intel/car/romstage.c b/src/cpu/intel/car/romstage.c
index 7a7d077..4c68ded 100644
--- a/src/cpu/intel/car/romstage.c
+++ b/src/cpu/intel/car/romstage.c
@@ -1,14 +1,14 @@
/* SPDX-License-Identifier: GPL-2.0-only */
-#include <arch/cpu.h>
#include <arch/romstage.h>
-#include <console/console.h>
-#include <cpu/x86/smm.h>
#include <arch/symbols.h>
#include <commonlib/helpers.h>
+#include <console/console.h>
+#include <cpu/x86/smm.h>
#include <program_loading.h>
#include <romstage_common.h>
#include <security/vboot/vboot_common.h>
+#include <types.h>
/* If we do not have a constrained _car_stack region size, use the
following as a guideline for acceptable stack usage. */
--
To view, visit https://review.coreboot.org/c/coreboot/+/68040
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I84639389ac1066468b82bb13d684e5423b909fcb
Gerrit-Change-Number: 68040
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68036 )
Change subject: console/die.c: Add <stdarg.h>
......................................................................
console/die.c: Add <stdarg.h>
Signed-off-by: Elyes Haouas <ehaouas(a)noos.fr>
Change-Id: I2ee8ef017d8a3409cbf47f1ed252a512dead224e
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68036
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Martin L Roth <gaumless(a)gmail.com>
---
M src/console/die.c
1 file changed, 14 insertions(+), 0 deletions(-)
Approvals:
build bot (Jenkins): Verified
Martin L Roth: Looks good to me, approved
diff --git a/src/console/die.c b/src/console/die.c
index 3fc88a3..d9e1dee 100644
--- a/src/console/die.c
+++ b/src/console/die.c
@@ -2,6 +2,7 @@
#include <console/console.h>
#include <halt.h>
+#include <stdarg.h>
/*
* The method should be overwritten in mainboard directory to signal that a
--
To view, visit https://review.coreboot.org/c/coreboot/+/68036
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ee8ef017d8a3409cbf47f1ed252a512dead224e
Gerrit-Change-Number: 68036
Gerrit-PatchSet: 2
Gerrit-Owner: Elyes Haouas <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged