Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68099 )
Change subject: mb/lenovo/t440p: Enable PCI 00:01.1 bridge for dGPU
......................................................................
mb/lenovo/t440p: Enable PCI 00:01.1 bridge for dGPU
An optional dGPU can be connected to the second PEG bridge:
-[0000:00]-+-00.0 Intel Corporation Xeon E3-1200 v3/4th Gen Core Processor DRAM Controller
+-01.0-[01]--
+-01.1-[02]----00.0 NVIDIA Corporation GK208M [GeForce GT 730M]
It's possible that the 01.0 bridge is never populated, but we have to
leave it on anyway so 01.1 can be enumerated.
Change-Id: Ieab7a7bf3b31b4ee9d9f12b5d827d866c87356e1
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/68099
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
---
M src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
1 file changed, 24 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb b/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
index b7588ea..c8772cc 100644
--- a/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
+++ b/src/mainboard/lenovo/haswell/variants/t440p/devicetree.cb
@@ -23,8 +23,8 @@
subsystemid 0x17aa 0x220e inherit
device pci 00.0 on end # Host bridge
- device pci 01.0 on end # PCIe Bridge for discrete graphics
- device pci 01.1 off end # Unused PCIe Bridge
+ device pci 01.0 on end # PCIe Bridge for discrete graphics (optional)
+ device pci 01.1 on end # PCIe Bridge for discrete graphics (optional)
device pci 02.0 on end # Internal graphics VGA controller
device pci 03.0 on end # Mini-HD audio
--
To view, visit https://review.coreboot.org/c/coreboot/+/68099
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieab7a7bf3b31b4ee9d9f12b5d827d866c87356e1
Gerrit-Change-Number: 68099
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martin.roth(a)amd.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Justin van Son, Patrick Rudolph, Christian Walter, Angel Pons.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67759 )
Change subject: mb/prodrive/hermes: Add part numbers to SMBIOS
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
should be fine is the recommended change is done?
--
To view, visit https://review.coreboot.org/c/coreboot/+/67759
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I26c17ab37859c3306fe72c3f0cdc1d3787b48157
Gerrit-Change-Number: 67759
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Justin van Son <justin.van.son(a)prodrive-technologies.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Thu, 06 Oct 2022 18:19:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment