coreboot-gerrit October 2022

coreboot-gerrit@coreboot.org

1 participants
5881 discussions

[M] Change in coreboot[master]: payloads/edk2: Add an option to use EDK2 Universal Payload
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer. Hello build bot (Jenkins), Martin L Roth, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65934 to look at the new patch set (#39). Change subject: payloads/edk2: Add an option to use EDK2 Universal Payload ...................................................................... payloads/edk2: Add an option to use EDK2 Universal Payload This add's an option to use EDK2's Universal Payload, instead of the standard UefiPayloadPkg. This is started via the ShimLayer, which is added as the primary payload. The ShimLayer will build the HOBs that Universal Payload requires and start it directly. This is the reason that the Universal Payload is added to CBFS as a raw file. Universal Payload is based on Intel's USF specification: https://universalscalablefirmware.github.io/documentation/ This has been added with the repository pointing to https://github.com/starlabsltd. The required ShimLayer patches will be merged into master, only when this patch is merged. This is because the EDK2 engineers believe it is an impossible task to patch coreboot to build and use Universal Payload. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I17cc86d5eac0d5d91551ba5bea73fbc07ebdf0d3 --- M payloads/external/Makefile.inc M payloads/external/edk2/Kconfig 2 files changed, 58 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/65934/39 -- To view, visit https://review.coreboot.org/c/coreboot/+/65934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17cc86d5eac0d5d91551ba5bea73fbc07ebdf0d3 Gerrit-Change-Number: 65934 Gerrit-PatchSet: 39 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: payloads/edk2: Add a recipe to build UniversalPayload.elf
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68183 ) Change subject: payloads/edk2: Add a recipe to build UniversalPayload.elf ...................................................................... Set Ready For Review -- To view, visit https://review.coreboot.org/c/coreboot/+/68183 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2aa318513244f576e07e72713fad3b4f7bd7c22e Gerrit-Change-Number: 68183 Gerrit-PatchSet: 2 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Comment-Date: Thu, 06 Oct 2022 20:57:44 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

[M] Change in coreboot[master]: payloads/edk2: Disable the CPU Timer Lib unless supported
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes, Nico Huber, Tarun Tuli, Subrata Banik, Matt DeVillier, Kapil Porwal. Hello build bot (Jenkins), Jeff Daly, Raul Rangel, Mariusz Szafrański, Matt DeVillier, Matt DeVillier, Stefan Reinauer, Andrey Petrov, Jason Glenesk, Tarun Tuli, Nico Huber, Martin L Roth, Subrata Banik, Marshall Dawson, Kapil Porwal, Suresh Bellampalli, Tim Wawrzynczak, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65950 to look at the new patch set (#35). Change subject: payloads/edk2: Disable the CPU Timer Lib unless supported ...................................................................... payloads/edk2: Disable the CPU Timer Lib unless supported For recent X86 CPUs, the 0x15 CPUID instruction will return Time Stamp Counter Frequence. For CPUs that do not support this instruction, EDK2 must include a different library which is the reason why this must be configured at build time. If this is enabled, and the CPU doesn't support 0x15, it will fail to boot. If is not enabled, and the CPU does support 0x15, it will still boot but without support for the leaf. Consequently, disabled it by default. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I4f0f43ce50c4f6f7eb03063fff34d015468f6daa --- M payloads/external/Makefile.inc M payloads/external/edk2/Kconfig M payloads/external/edk2/Makefile M src/soc/intel/alderlake/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/icelake/Kconfig M src/soc/intel/jasperlake/Kconfig M src/soc/intel/meteorlake/Kconfig M src/soc/intel/skylake/Kconfig M src/soc/intel/tigerlake/Kconfig 13 files changed, 54 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/65950/35 -- To view, visit https://review.coreboot.org/c/coreboot/+/65950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f0f43ce50c4f6f7eb03063fff34d015468f6daa Gerrit-Change-Number: 65950 Gerrit-PatchSet: 35 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: payloads/edk2: Add the recipes to assemble UniversalPayload
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

1 0

[M] Change in coreboot[master]: payloads/edk2: Add an option to use EDK2 Universal Payload
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer. Hello build bot (Jenkins), Martin L Roth, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65934 to look at the new patch set (#38). Change subject: payloads/edk2: Add an option to use EDK2 Universal Payload ...................................................................... payloads/edk2: Add an option to use EDK2 Universal Payload This add's an option to use EDK2's Universal Payload, instead of the standard UefiPayloadPkg. This is started via the ShimLayer, which is added as the primary payload. The ShimLayer will build the HOBs that Universal Payload requires and start it directly. This is the reason that the Universal Payload is added to CBFS as a raw file. Universal Payload is based on Intel's USF specification: https://universalscalablefirmware.github.io/documentation/ This has been added with the repository pointing to https://github.com/starlabsltd. The required ShimLayer patches will be merged into master, only when this patch is merged. This is because the EDK2 engineers believe it is an impossible task to patch coreboot to build and use Universal Payload. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I17cc86d5eac0d5d91551ba5bea73fbc07ebdf0d3 --- M payloads/external/edk2/Kconfig 1 file changed, 56 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/65934/38 -- To view, visit https://review.coreboot.org/c/coreboot/+/65934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17cc86d5eac0d5d91551ba5bea73fbc07ebdf0d3 Gerrit-Change-Number: 65934 Gerrit-PatchSet: 38 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: payloads/edk2: Disable the CPU Timer Lib unless supported
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes, Nico Huber, Tarun Tuli, Subrata Banik, Matt DeVillier, Kapil Porwal. Hello build bot (Jenkins), Jeff Daly, Raul Rangel, Mariusz Szafrański, Matt DeVillier, Matt DeVillier, Stefan Reinauer, Andrey Petrov, Jason Glenesk, Tarun Tuli, Nico Huber, Martin L Roth, Subrata Banik, Marshall Dawson, Kapil Porwal, Suresh Bellampalli, Tim Wawrzynczak, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65950 to look at the new patch set (#34). Change subject: payloads/edk2: Disable the CPU Timer Lib unless supported ...................................................................... payloads/edk2: Disable the CPU Timer Lib unless supported For recent X86 CPUs, the 0x15 CPUID instruction will return Time Stamp Counter Frequence. For CPUs that do not support this instruction, EDK2 must include a different library which is the reason why this must be configured at build time. If this is enabled, and the CPU doesn't support 0x15, it will fail to boot. If is not enabled, and the CPU does support 0x15, it will still boot but without support for the leaf. Consequently, disabled it by default. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I4f0f43ce50c4f6f7eb03063fff34d015468f6daa --- M payloads/external/Makefile.inc M payloads/external/edk2/Kconfig M payloads/external/edk2/Makefile M src/soc/intel/alderlake/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/icelake/Kconfig M src/soc/intel/jasperlake/Kconfig M src/soc/intel/meteorlake/Kconfig M src/soc/intel/skylake/Kconfig M src/soc/intel/tigerlake/Kconfig 13 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/65950/34 -- To view, visit https://review.coreboot.org/c/coreboot/+/65950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f0f43ce50c4f6f7eb03063fff34d015468f6daa Gerrit-Change-Number: 65950 Gerrit-PatchSet: 34 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[S] Change in coreboot[master]: payloads/edk2: Add a recipe to build the ShimLayer
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Martin L Roth, Stefan Reinauer. Hello build bot (Jenkins), Martin L Roth, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/64485 to look at the new patch set (#61). Change subject: payloads/edk2: Add a recipe to build the ShimLayer ...................................................................... payloads/edk2: Add a recipe to build the ShimLayer The ShimLayer is required to start the Universal Payload. It will build the required HOBs and pass them accordingly. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I043271994f40813d9059a89420d4311d9d5802b1 --- M payloads/external/edk2/Makefile 1 file changed, 28 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/64485/61 -- To view, visit https://review.coreboot.org/c/coreboot/+/64485 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I043271994f40813d9059a89420d4311d9d5802b1 Gerrit-Change-Number: 64485 Gerrit-PatchSet: 61 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: payloads/edk2: Add an option to use EDK2 Universal Payload
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes, Martin L Roth, Stefan Reinauer. Hello build bot (Jenkins), Martin L Roth, Stefan Reinauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65934 to look at the new patch set (#37). Change subject: payloads/edk2: Add an option to use EDK2 Universal Payload ...................................................................... payloads/edk2: Add an option to use EDK2 Universal Payload This add's an option to use EDK2's Universal Payload, instead of the standard UefiPayloadPkg. This is started via the ShimLayer, which is added as the primary payload. The ShimLayer will build the HOBs that Universal Payload requires and start it directly. This is the reason that the Universal Payload is added to CBFS as a raw file. Universal Payload is based on Intel's USF specification: https://universalscalablefirmware.github.io/documentation/ This has been added with the repository pointing to https://github.com/starlabsltd. The required ShimLayer patches will be merged into master, only when this patch is merged. This is because the EDK2 engineers believe it is an impossible task to patch coreboot to build and use Universal Payload. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I17cc86d5eac0d5d91551ba5bea73fbc07ebdf0d3 --- M payloads/external/edk2/Kconfig 1 file changed, 56 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/65934/37 -- To view, visit https://review.coreboot.org/c/coreboot/+/65934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I17cc86d5eac0d5d91551ba5bea73fbc07ebdf0d3 Gerrit-Change-Number: 65934 Gerrit-PatchSet: 37 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

[M] Change in coreboot[master]: payloads/edk2: Disable the CPU Timer Lib unless supported
by Sean Rhodes (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Sean Rhodes, Nico Huber, Tarun Tuli, Subrata Banik, Matt DeVillier, Kapil Porwal. Hello build bot (Jenkins), Jeff Daly, Raul Rangel, Mariusz Szafrański, Matt DeVillier, Matt DeVillier, Stefan Reinauer, Andrey Petrov, Jason Glenesk, Tarun Tuli, Nico Huber, Martin L Roth, Subrata Banik, Marshall Dawson, Kapil Porwal, Suresh Bellampalli, Tim Wawrzynczak, Vanessa Eusebio, Lean Sheng Tan, Werner Zeh, Fred Reitberger, Felix Held, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/65950 to look at the new patch set (#33). Change subject: payloads/edk2: Disable the CPU Timer Lib unless supported ...................................................................... payloads/edk2: Disable the CPU Timer Lib unless supported For recent X86 CPUs, the 0x15 CPUID instruction will return Time Stamp Counter Frequence. For CPUs that do not support this instruction, EDK2 must include a different library which is the reason why this must be configured at build time. If this is enabled, and the CPU doesn't support 0x15, it will fail to boot. If is not enabled, and the CPU does support 0x15, it will still boot but without support for the leaf. Consequently, disabled it by default. Signed-off-by: Sean Rhodes <sean(a)starlabs.systems> Change-Id: I4f0f43ce50c4f6f7eb03063fff34d015468f6daa --- M payloads/external/Makefile.inc M payloads/external/edk2/Kconfig M payloads/external/edk2/Makefile M src/soc/intel/alderlake/Kconfig M src/soc/intel/apollolake/Kconfig M src/soc/intel/cannonlake/Kconfig M src/soc/intel/denverton_ns/Kconfig M src/soc/intel/elkhartlake/Kconfig M src/soc/intel/icelake/Kconfig M src/soc/intel/jasperlake/Kconfig M src/soc/intel/meteorlake/Kconfig M src/soc/intel/skylake/Kconfig M src/soc/intel/tigerlake/Kconfig 13 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/65950/33 -- To view, visit https://review.coreboot.org/c/coreboot/+/65950 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4f0f43ce50c4f6f7eb03063fff34d015468f6daa Gerrit-Change-Number: 65950 Gerrit-PatchSet: 33 Gerrit-Owner: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Fred Reitberger <reitbergerfred(a)gmail.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Jeff Daly <jeffd(a)silicom-usa.com> Gerrit-Reviewer: Kapil Porwal <kapilporwal(a)google.com> Gerrit-Reviewer: Lean Sheng Tan <sheng.tan(a)9elements.com> Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)amd.corp-partner.google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com> Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com> Gerrit-Reviewer: Tarun Tuli <taruntuli(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com> Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com> Gerrit-Reviewer: Werner Zeh <werner.zeh(a)siemens.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Sean Rhodes <sean(a)starlabs.systems> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Tarun Tuli <taruntuli(a)google.com> Gerrit-Attention: Subrata Banik <subratabanik(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Kapil Porwal <kapilporwal(a)google.com> Gerrit-MessageType: newpatchset

1 0

[XL] Change in coreboot[master]: payloads/cbui: Add new payload CBUI
by build bot (Jenkins) (Code Review) 06 Oct '22

06 Oct '22

Attention is currently required from: Iman Bingi, Martin L Roth, Julius Werner, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/23586 ) Change subject: payloads/cbui: Add new payload CBUI ...................................................................... Patch Set 60: (55 comments) File payloads/cbui/NuklearUI/NuklearDatePicker.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/63c2f950_31c4ae5b PS60, Line 36: case 6: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/6d7396af_7c44d5f5 PS60, Line 37: case 9: /* fallthrough */ Prefer 'fallthrough;' over fallthrough comment File payloads/cbui/NuklearUI/NuklearRW.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/56a5fc51_6b6d0086 PS60, Line 289: static const char *titles[] = { "Hex-View", "Header", "Index/Data" }; static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/48aab952_10d2ed3b PS60, Line 323: static const char *entries[] = { "NVRAM" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwAcpi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/3fb60f07_6f431238 PS60, Line 40: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/fe3e3505_bd72527f PS60, Line 43: static const char *tabs[] = { "RSDP", "XSDT", "RSDT", "FACP", "HPET", "APIC", "MCFG", static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwAtaAtapi.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/a8e8e520_86ff19e5 PS60, Line 23: static const char *tools[] = { lang_translate(LANG_SAVE, 0), lang_translate( static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/982d6dee_da9b62da PS60, Line 26: static const char *tabs[] = { "Hex-View", "Info", "Summary" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwClock.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/548d006f_c4a5c639 PS60, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/f9ffde00_01a218bf PS60, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwCpuMsr.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/4ec52b04_953da3dd PS60, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/cbd39d12_987dbeb8 PS60, Line 22: static const char *tabs[] = { "MTRR", "User", "Summary" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwDimmSpd.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/2092f742_7532ddd0 PS60, Line 61: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save all", "Save bin", static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/5bd51274_0cceba5d PS60, Line 65: static const char *tabs[] = { "Hex-View", "Info", "Text", "Summary" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwE820.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/b74f72ab_f1251b25 PS60, Line 20: static const char *tools[] = { lang_translate(LANG_SAVE, 0) }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwEc.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/a9bcc326_60cefcb6 PS60, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/f8b4e3b2_2b8b4dae PS60, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwIo.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/990f4175_25370447 PS60, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/bdc710f7_215303f3 PS60, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwIoIndexData.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/5bba8af4_a69bbb30 PS60, Line 49: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/540b1f63_2b7cf03f PS60, Line 52: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwMemory.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/0d235439_95ce25fe PS60, Line 53: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/adea9483_0228e254 PS60, Line 56: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const File payloads/cbui/NuklearUI/NuklearRwMemoryIndexData.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/89ce05ee_328468a3 PS60, Line 34: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/69885072_cf2084f9 PS60, Line 37: static const char *tools[] = { lang_translate(LANG_SAVE, 0), "Save bin", "Load", static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/7360cc24_dcc3e988 PS60, Line 40: static const char *tabs[] = { "Hex-View", "Info", "Text" }; static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/41beaafb_972c8656 PS60, Line 73: struct nuklear_memory_index_data_view *this = (struct nuklear_memory_index_data_view *) obj; line length of 100 exceeds 96 columns File payloads/cbui/arch/x86/int32.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/d61c8fbf_d27b804e PS60, Line 20: typedef struct __attribute__ ((packed)) { Prefer __packed over __attribute__((packed)) File payloads/cbui/arch/x86/int32.nasm: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/696d66f6_46181bb3 PS60, Line 38: struc regs16_t 'struc' may be misspelled - perhaps 'struct'? File payloads/cbui/gfx/vbe.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/aad7d043_2c41204c PS60, Line 24: static u8 low_mem[0x1000] __attribute__ ((section(".lowmem"))); Prefer __section(".lowmem") over __attribute__((section(".lowmem"))) File payloads/cbui/lang/de.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/6c0f4238_cb06f96d PS60, Line 39: "Kein Framebuffer gefunden. CBUI funktioniert nicht" \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/ad86df4a_e5f4ff3b PS60, Line 44: "Der coreboot framebuffer hat keine physikalische " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/3c5e7c80_551211c5 PS60, Line 47: "Kein Platz auf dem Heap.\nBitte vergroBere den" \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/5afd6433_63192e4e PS60, Line 50: "Konnte die nuklear Bibliothek nicht intitialisieren.\nBitte" \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/acd5d0ff_6944fa0c PS60, Line 52: "stelle sicher, das der Framebuffer entweder das RGBX8 oder " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/f36539f2_105ae6f8 PS60, Line 65: "Fehler: Keine CMOS Eintrage gefunden. Bitte schalte die " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/54508aea_a9ada9bb PS60, Line 86: "Fehler: Keine Zeitstempel gefunden. Bitte schalte die " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/210628c6_cdd37356 PS60, Line 89: "Fehler: Bootlog nicht gefunden. Bitte schalte die Kconfig " \ Avoid unnecessary line continuations File payloads/cbui/lang/en.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/d15645f2_5efd2b22 PS60, Line 38: "No framebuffer found. CBUI doesn't work in text mode.\n" \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/2c4bb4d2_11d391b3 PS60, Line 46: "Failed to init nuklear library.\nMake sure you have enough " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/2ac2c19e_029e8b9c PS60, Line 60: "ERROR: No CMOS options found. Please make sure to enable " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/ba0fe983_ff3f6918 PS60, Line 81: "ERROR: No timestamps found. Please make sure to enable " \ Avoid unnecessary line continuations Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/9bc2e2cc_980746c5 PS60, Line 84: "ERROR: Bootlog not found. Please make sure to enable " \ Avoid unnecessary line continuations File payloads/cbui/modules/bootlog_module.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/29913ea2_9152268f PS60, Line 28: } __attribute__ ((__packed__)); Prefer __packed over __attribute__((__packed__)) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/12664c04_795dc92d PS60, Line 82: } void function return statements are not generally useful File payloads/cbui/modules/cbfs_module.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/4910fa9a_055bbca7 PS60, Line 50: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed)) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/5a4058db_91d812ac PS60, Line 59: } __attribute__ ((packed)); Prefer __packed over __attribute__((packed)) File payloads/cbui/modules/cpuinfo_module.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/90ca7863_f30565fb PS60, Line 35: static const char *intel_cap_edx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/76b67cb0_4384db41 PS60, Line 43: static const char *amd_cap_edx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/1bbaff45_7845505b PS60, Line 51: static const char *intel_cap_ecx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/dae79e8d_a76711a6 PS60, Line 59: static const char *amd_cap_ecx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/597346d9_c4cd1ede PS60, Line 67: static const char *intel_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/173e11aa_6a23a84a PS60, Line 75: static const char *intel_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/fbd689b3_fb0a6d49 PS60, Line 83: static const char *amd_cap_extended_edx_flags[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159884): https://review.coreboot.org/c/coreboot/+/23586/comment/5e436f7c_c1baf2c1 PS60, Line 92: static const char *amd_cap_extended_ecx_flags[] = { static const char * array should probably be static const char * const -- To view, visit https://review.coreboot.org/c/coreboot/+/23586 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib9a1a07c1065880aa675380625021750d5cab7d1 Gerrit-Change-Number: 23586 Gerrit-PatchSet: 60 Gerrit-Owner: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Martin L Roth <gaumless(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Iman Bingi <imanbingy(a)gmail.com> Gerrit-Attention: Martin L Roth <gaumless(a)gmail.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Thu, 06 Oct 2022 20:44:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit October 2022