Attention is currently required from: Raul Rangel, Felix Held.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61095 )
Change subject: soc/amd/sabrina/include/smu: update mailbox SMN addresses
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61095
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie384de52b1efb1d52f9018315a4b72916a4c9cee
Gerrit-Change-Number: 61095
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 27 Jan 2022 23:26:17 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Lance Zhao, Anil Kumar K, Selma Bensaid, Paul Menzel, Thejaswani Putta, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61352 )
Change subject: soc/intel/common/block/pcie/rtd3: Add PM methods to the device.
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/common/block/pcie/rtd3/chip.h:
https://review.coreboot.org/c/coreboot/+/61352/comment/787d3723_a63b6f66
PS1, Line 53: ext_pm_support
> In addition, if no srcclk_pin is assigned, SRCK method will not be exported.
makes sense
> Also,PSD0 Method only exported for PCH root root
also makes sense
> Do we also want to consider for overall? or should we add CondRefof in the device prior to calling these exported rtd3 methods for the cases that not all three methods are available from the root port
Are you referring to other code that uses these (e.g., your wwan driver) potentially exported Methods using a CondRefOf to determine if things like PSD0 are required? Makes sense to me I think.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61352
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79de76f26c8424b036cb7d2719df68937599ca2f
Gerrit-Change-Number: 61352
Gerrit-PatchSet: 1
Gerrit-Owner: Cliff Huang <cliff.huang(a)intel.com>
Gerrit-Reviewer: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Reviewer: Thejaswani Putta <thejaswani.putta(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Lance Zhao
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Selma Bensaid <selma.bensaid(a)intel.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thejaswani Putta <thejaswani.putta(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 27 Jan 2022 23:22:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Comment-In-Reply-To: Cliff Huang <cliff.huang(a)intel.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Anil Kumar K.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61432
to look at the new patch set (#4).
Change subject: [Debug] [Do not merge] Redrix4es: Device tree cleanup
......................................................................
[Debug] [Do not merge] Redrix4es: Device tree cleanup
Disable privacy screen support
Disable WWAN over USB (test on a B7 board with 5G)
Disable tcss port 1
Disable wakeon wlan
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
Change-Id: Iaed4e2dd84aab0dffbf2e3825ad30d2efa846f23
---
M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
M src/mainboard/google/brya/variants/redrix4es/gpio.c
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
3 files changed, 14 insertions(+), 64 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/61432/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/61432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaed4e2dd84aab0dffbf2e3825ad30d2efa846f23
Gerrit-Change-Number: 61432
Gerrit-PatchSet: 4
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Frans Hendriks, Tristan Corrick, Paul Menzel, Nick Vaccaro, Angel Pons, Arthur Heymans, Piotr Król, Erik van den Bogaert, Nico Huber, Michał Żygowski, HAOUAS Elyes, Wim Vervoorn.
Hello build bot (Jenkins), Frans Hendriks, Tristan Corrick, Paul Menzel, Nick Vaccaro, Angel Pons, Arthur Heymans, Piotr Król, Erik van den Bogaert, Nico Huber, Martin Roth, Michał Żygowski, Tim Wawrzynczak, Nick Vaccaro, Wim Vervoorn,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/59880
to look at the new patch set (#8).
Change subject: IASL: Ignore IASL's "Missing dependency" warning
......................................................................
IASL: Ignore IASL's "Missing dependency" warning
IASL compiler check for usage of _CRS, _DIS, _PRS, and _SRS objects:
1) If _PRS is present, must have _CRS and _SRS
2) If _SRS is present, must have _PRS (_PRS requires _CRS and _SRS)
3) If _DIS is present, must have _SRS (_SRS requires _PRS, _PRS requires _CRS and _SRS)
4) If _SRS is present, probably should have a _DIS (Remark only)
IASL will issue a warning for each missing dependency.
Ignore this warnings for existing ASL code and issue a message when the build is complete.
Change-Id: I28b437194f08232727623009372327fec15215dd
Signed-off-by: Elyes HAOUAS <ehaouas(a)noos.fr>
---
M Makefile.inc
M src/mainboard/acer/g43t-am3/Kconfig
M src/mainboard/asrock/h81m-hds/Kconfig
M src/mainboard/asus/am1i-a/Kconfig
M src/mainboard/asus/h61-series/Kconfig
M src/mainboard/asus/p5qpl-am/Kconfig
M src/mainboard/bap/ode_e20XX/Kconfig
M src/mainboard/biostar/am1ml/Kconfig
M src/mainboard/dell/optiplex_9010/Kconfig
M src/mainboard/facebook/fbg1701/Kconfig
M src/mainboard/facebook/monolith/Kconfig
M src/mainboard/foxconn/d41s/Kconfig
M src/mainboard/foxconn/g41s-k/Kconfig
M src/mainboard/gigabyte/ga-d510ud/Kconfig
M src/mainboard/google/auron/Kconfig
M src/mainboard/google/beltino/Kconfig
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/butterfly/Kconfig
M src/mainboard/google/cyan/Kconfig
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/deltaur/Kconfig
M src/mainboard/google/drallion/Kconfig
M src/mainboard/google/eve/Kconfig
M src/mainboard/google/fizz/Kconfig
M src/mainboard/google/glados/Kconfig
M src/mainboard/google/guybrush/Kconfig
M src/mainboard/google/hatch/Kconfig
M src/mainboard/google/jecht/Kconfig
M src/mainboard/google/kahlee/Kconfig
M src/mainboard/google/link/Kconfig
M src/mainboard/google/octopus/Kconfig
M src/mainboard/google/poppy/Kconfig
M src/mainboard/google/rambi/Kconfig
M src/mainboard/google/reef/Kconfig
M src/mainboard/google/sarien/Kconfig
M src/mainboard/google/slippy/Kconfig
M src/mainboard/google/stout/Kconfig
M src/mainboard/google/volteer/Kconfig
M src/mainboard/google/zork/Kconfig
M src/mainboard/ibase/mb899/Kconfig
M src/mainboard/intel/adlrvp/Kconfig
M src/mainboard/intel/baskingridge/Kconfig
M src/mainboard/intel/dcp847ske/Kconfig
M src/mainboard/intel/dg41wv/Kconfig
M src/mainboard/intel/dg43gt/Kconfig
M src/mainboard/intel/emeraldlake2/Kconfig
M src/mainboard/intel/glkrvp/Kconfig
M src/mainboard/intel/jasperlake_rvp/Kconfig
M src/mainboard/intel/kblrvp/Kconfig
M src/mainboard/intel/kunimitsu/Kconfig
M src/mainboard/intel/shadowmountain/Kconfig
M src/mainboard/intel/strago/Kconfig
M src/mainboard/intel/tglrvp/Kconfig
M src/mainboard/kontron/986lcd-m/Kconfig
M src/mainboard/portwell/m107/Kconfig
M src/mainboard/protectli/vault_bsw/Kconfig
M src/mainboard/samsung/lumpy/Kconfig
M src/mainboard/samsung/stumpy/Kconfig
M src/mainboard/supermicro/x10slm-f/Kconfig
M src/mainboard/supermicro/x9scl/Kconfig
60 files changed, 204 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/59880/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/59880
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I28b437194f08232727623009372327fec15215dd
Gerrit-Change-Number: 59880
Gerrit-PatchSet: 8
Gerrit-Owner: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Attention: Tristan Corrick <tristan(a)corrick.kiwi>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Erik van den Bogaert <ebogaert(a)eltan.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: HAOUAS Elyes <ehaouas(a)noos.fr>
Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60995 )
Change subject: mb/google/brya: Add GPIO table for nissa
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS7:
> You could rebase this on top of that so it will compile if you want
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/60995
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic923fd22abcaf7da0c607f66705a6e16c14cf8f2
Gerrit-Change-Number: 60995
Gerrit-PatchSet: 8
Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Haribalaraman Ramasubramanian <haribalaraman.r(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-CC: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 27 Jan 2022 22:57:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Reka Norman <rekanorman(a)chromium.org>
Gerrit-MessageType: comment
Hello Reka Norman, build bot (Jenkins), Kangheui Won, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61348
to look at the new patch set (#4).
Change subject: mb/google/brya: Fill in gpio.h for nissa baseboard
......................................................................
mb/google/brya: Fill in gpio.h for nissa baseboard
BUG=b:197479026
TEST=abuild -a -x -c max -p none -t google/brya -b nivviks
abuild -a -x -c max -p none -t google/brya -b nereid
Change-Id: I7ec4b9368e0a63c0c0c9a92c8367a89d57f10d51
Signed-off-by: Reka Norman <rekanorman(a)google.com>
---
M src/mainboard/google/brya/variants/baseboard/nissa/include/baseboard/gpio.h
1 file changed, 10 insertions(+), 5 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/48/61348/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/61348
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ec4b9368e0a63c0c0c9a92c8367a89d57f10d51
Gerrit-Change-Number: 61348
Gerrit-PatchSet: 4
Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Reka Norman <rekanorman(a)google.com>
Gerrit-MessageType: newpatchset