Attention is currently required from: Benson Leung, Prashant Malani.
Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61388 )
Change subject: mb/google/brya: Add custom PLD fields to device tree for brya0 and brya4es
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS9:
> Setting -1 for code review until we agree upon horizontal position values and whether to also add PL […]
unresolving
--
To view, visit https://review.coreboot.org/c/coreboot/+/61388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea975a4f436a204d4edd19fad0f5652fb44c6301
Gerrit-Change-Number: 61388
Gerrit-PatchSet: 9
Gerrit-Owner: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: Benson Leung <bleung(a)chromium.org>
Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Benson Leung <bleung(a)chromium.org>
Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Comment-Date: Fri, 28 Jan 2022 02:40:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Won Chung <wonchung(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Benson Leung, Prashant Malani.
Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61388 )
Change subject: mb/google/brya: Add custom PLD fields to device tree for brya0 and brya4es
......................................................................
Patch Set 9: Code-Review-1
(1 comment)
Patchset:
PS9:
Setting -1 for code review until we agree upon horizontal position values and whether to also add PLD for USB-A. This is being discussed in Custom PLD requirement document.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea975a4f436a204d4edd19fad0f5652fb44c6301
Gerrit-Change-Number: 61388
Gerrit-PatchSet: 9
Gerrit-Owner: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: Benson Leung <bleung(a)chromium.org>
Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Benson Leung <bleung(a)chromium.org>
Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Comment-Date: Fri, 28 Jan 2022 02:19:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Kangheui Won, Rizwan Qureshi, Tim Wawrzynczak, Krishna P Bhat D, Usha P.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61439 )
Change subject: mb/google/brya: Add memory config for nissa
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/variants/baseboard/nissa/memory.c:
https://review.coreboot.org/c/coreboot/+/61439/comment/0984c477_a03c83b2
PS1, Line 73: BOARD_TYPE_MOBILE
I'm not sure about this.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61439
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6958c7b74851879dbea41d181ef8f1282bf0101d
Gerrit-Change-Number: 61439
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Attention: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Usha P <usha.p(a)intel.com>
Gerrit-Comment-Date: Fri, 28 Jan 2022 01:56:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Tyler Wang has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/61438 )
Change subject: mb/google/dedede/var/magolor: Add custom Wifi SAR for magneto
......................................................................
mb/google/dedede/var/magolor: Add custom Wifi SAR for magneto
Add wifi sar for magneto.
Due to fw-config cannot distinguish between magolor and magneto.
Using sku_id to decide to load magneto custom wifi sar.
BUG=b:208261420
TEST= emerge-dedede coreboot
Signed-off-by: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Change-Id: I77f141372ba8e7b8f5849b00e115ad8bb1e7ca00
---
M src/mainboard/google/dedede/variants/magolor/variant.c
1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/61438/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61438
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I77f141372ba8e7b8f5849b00e115ad8bb1e7ca00
Gerrit-Change-Number: 61438
Gerrit-PatchSet: 2
Gerrit-Owner: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Subrata Banik, Reka Norman, Rizwan Qureshi, Tim Wawrzynczak, Krishna P Bhat D, Patrick Rudolph.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61106 )
Change subject: soc/intel/alderlake: Add GPP_I GPIO group for Alder Lake N SOC
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61106
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia71a399c03cb7d098a381bd9439d448e8a620761
Gerrit-Change-Number: 61106
Gerrit-PatchSet: 10
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subratabanik(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Subrata Banik <subratabanik(a)google.com>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 28 Jan 2022 01:07:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Rizwan Qureshi, Krishna P Bhat D.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61128 )
Change subject: soc/intel/alderlake: Select SOC_INTEL_COMMON_BLOCK_SCS for Alder Lake N
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61128
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I577ffdc80ef09471309c827551a347d4397a33d1
Gerrit-Change-Number: 61128
Gerrit-PatchSet: 6
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Usha P <usha.p(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Comment-Date: Fri, 28 Jan 2022 01:05:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Reka Norman, Paul Menzel, Rizwan Qureshi, Krishna P Bhat D, Patrick Rudolph.
Kangheui Won has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61126 )
Change subject: soc/intel/alderlake: Add eMMC PCR Port ID for Alder Lake N
......................................................................
Patch Set 3: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/61126
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6dc494d1748e66b8b4058954f127ec226863e8af
Gerrit-Change-Number: 61126
Gerrit-PatchSet: 3
Gerrit-Owner: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Reka Norman <rekanorman(a)google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Reka Norman <rekanorman(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Attention: Krishna P Bhat D <krishna.p.bhat.d(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 28 Jan 2022 01:04:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment