Attention is currently required from: Benson Leung, Prashant Malani.
Hello build bot (Jenkins), Tim Wawrzynczak, Benson Leung, Prashant Malani,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61388
to look at the new patch set (#9).
Change subject: mb/google/brya: Add custom PLD fields to device tree for brya0 and brya4es
......................................................................
mb/google/brya: Add custom PLD fields to device tree for brya0 and brya4es
For Type C USB ports, we want to use custom PLD fields with more details
to indicate physical location. Custom PLD will also be added to other
brya variants in the future as we figure out physical port locations on
those devices.
BUG=b:216490477
TEST=emerge-brya coreboot & SSDT dump in Brya test device
Signed-off-by: Won Chung <wonchung(a)google.com>
Change-Id: Iea975a4f436a204d4edd19fad0f5652fb44c6301
---
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/brya4es/overridetree.cb
2 files changed, 84 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/61388/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/61388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea975a4f436a204d4edd19fad0f5652fb44c6301
Gerrit-Change-Number: 61388
Gerrit-PatchSet: 9
Gerrit-Owner: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: Benson Leung <bleung(a)chromium.org>
Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Benson Leung <bleung(a)chromium.org>
Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org>
Gerrit-MessageType: newpatchset
Anil Kumar K has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/61432 )
Change subject: [Debug] [Do not merge] Redrix4es: remove unwanted entries in devicetree
......................................................................
Removed reviewer Tim Wawrzynczak.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaed4e2dd84aab0dffbf2e3825ad30d2efa846f23
Gerrit-Change-Number: 61432
Gerrit-PatchSet: 3
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Anil Kumar K, Tim Wawrzynczak.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61432
to look at the new patch set (#3).
Change subject: [Debug] [Do not merge] Redrix4es: remove unwanted entries in devicetree
......................................................................
[Debug] [Do not merge] Redrix4es: remove unwanted entries in devicetree
Disable privacy screen support
Disable WWAN over USB (test on a B7 board with 5G)
Disable tcss port 1
Disable wakeon wlan
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
Change-Id: Iaed4e2dd84aab0dffbf2e3825ad30d2efa846f23
---
M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
M src/mainboard/google/brya/variants/redrix4es/gpio.c
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
3 files changed, 14 insertions(+), 64 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/61432/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/61432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaed4e2dd84aab0dffbf2e3825ad30d2efa846f23
Gerrit-Change-Number: 61432
Gerrit-PatchSet: 3
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Anil Kumar K, Tim Wawrzynczak.
Hello build bot (Jenkins), Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61432
to look at the new patch set (#2).
Change subject: [Debug] [Do not merge] Redrix4es: remove unwanted entries in devicetree
......................................................................
[Debug] [Do not merge] Redrix4es: remove unwanted entries in devicetree
Signed-off-by: Anil Kumar <anil.kumar.k(a)intel.com>
Change-Id: Iaed4e2dd84aab0dffbf2e3825ad30d2efa846f23
---
M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
M src/mainboard/google/brya/variants/redrix4es/gpio.c
M src/mainboard/google/brya/variants/redrix4es/overridetree.cb
3 files changed, 14 insertions(+), 64 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/32/61432/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/61432
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaed4e2dd84aab0dffbf2e3825ad30d2efa846f23
Gerrit-Change-Number: 61432
Gerrit-PatchSet: 2
Gerrit-Owner: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Anil Kumar K <anil.kumar.k(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Benson Leung, Prashant Malani.
Won Chung has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61388 )
Change subject: brya: Add custom PLD fields to device tree for brya0 and brya4es
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS7:
> Do you (or someone) plan to do this for all of the brya variants?
Yes, I will check with HW team to figure out ports locations in other variants and add custom PLD for them too. Added this to commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/61388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea975a4f436a204d4edd19fad0f5652fb44c6301
Gerrit-Change-Number: 61388
Gerrit-PatchSet: 8
Gerrit-Owner: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: Benson Leung <bleung(a)chromium.org>
Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Benson Leung <bleung(a)chromium.org>
Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Comment-Date: Thu, 27 Jan 2022 21:46:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Won Chung, Benson Leung, Prashant Malani.
Hello build bot (Jenkins), Tim Wawrzynczak, Benson Leung, Prashant Malani,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61388
to look at the new patch set (#8).
Change subject: brya: Add custom PLD fields to device tree for brya0 and brya4es
......................................................................
brya: Add custom PLD fields to device tree for brya0 and brya4es
For Type C USB ports, we want to use custom PLD fields with more details
to indicate physical location. Custom PLD will also be added to other
brya variants in the future as we figure out physical port locations on
those devices.
BUG=b:216490477
TEST=emerge-brya coreboot & SSDT dump in Brya test device
Signed-off-by: Won Chung <wonchung(a)google.com>
Change-Id: Iea975a4f436a204d4edd19fad0f5652fb44c6301
---
M src/mainboard/google/brya/variants/brya0/overridetree.cb
M src/mainboard/google/brya/variants/brya4es/overridetree.cb
2 files changed, 84 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/61388/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/61388
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iea975a4f436a204d4edd19fad0f5652fb44c6301
Gerrit-Change-Number: 61388
Gerrit-PatchSet: 8
Gerrit-Owner: Won Chung <wonchung(a)google.com>
Gerrit-Reviewer: Benson Leung <bleung(a)chromium.org>
Gerrit-Reviewer: Prashant Malani <pmalani(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Won Chung <wonchung(a)google.com>
Gerrit-Attention: Benson Leung <bleung(a)chromium.org>
Gerrit-Attention: Prashant Malani <pmalani(a)chromium.org>
Gerrit-MessageType: newpatchset