Attention is currently required from: Raul Rangel, Paul Menzel.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61086 )
Change subject: soc/amd/sabrina: add additional UART controllers
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/61086/comment/77726f76_c473c79d
PS5, Line 8:
> Please mention the datasheet name and revision, and if it’s not public also say how many controllers […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/61086
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I628b1a7a0930f3409acdcabda2b864d42bf6bd23
Gerrit-Change-Number: 61086
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 27 Jan 2022 22:17:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel.
Hello Jason Glenesk, build bot (Jenkins), Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61086
to look at the new patch set (#7).
Change subject: soc/amd/sabrina: add additional UART controllers
......................................................................
soc/amd/sabrina: add additional UART controllers
Compared to Cezanne there are 3 more UART controllers. Revision 1.50 of
the PPR #57243 was used as a reference.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I628b1a7a0930f3409acdcabda2b864d42bf6bd23
---
M src/soc/amd/sabrina/Kconfig
M src/soc/amd/sabrina/acpi/mmio.asl
M src/soc/amd/sabrina/aoac.c
M src/soc/amd/sabrina/chip.c
M src/soc/amd/sabrina/chipset.cb
M src/soc/amd/sabrina/include/soc/uart.h
M src/soc/amd/sabrina/uart.c
7 files changed, 132 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/61086/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/61086
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I628b1a7a0930f3409acdcabda2b864d42bf6bd23
Gerrit-Change-Number: 61086
Gerrit-PatchSet: 7
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Raul Rangel, Felix Held.
Hello Jason Glenesk, build bot (Jenkins), Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61086
to look at the new patch set (#6).
Change subject: soc/amd/sabrina: add additional UART controllers
......................................................................
soc/amd/sabrina: add additional UART controllers
Revision 1.50 of the PPR #57243 was used as a reference.
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I628b1a7a0930f3409acdcabda2b864d42bf6bd23
---
M src/soc/amd/sabrina/Kconfig
M src/soc/amd/sabrina/acpi/mmio.asl
M src/soc/amd/sabrina/aoac.c
M src/soc/amd/sabrina/chip.c
M src/soc/amd/sabrina/chipset.cb
M src/soc/amd/sabrina/include/soc/uart.h
M src/soc/amd/sabrina/uart.c
7 files changed, 132 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/61086/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/61086
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I628b1a7a0930f3409acdcabda2b864d42bf6bd23
Gerrit-Change-Number: 61086
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/61434 )
Change subject: util/lint: Remove SuperIO from checkpatch spellcheck
......................................................................
util/lint: Remove SuperIO from checkpatch spellcheck
Patch 423e9e0fc0: Documentation/lint: Use Super I/O instead of SuperIO
added the word SuperIO to the checkpatch spelling list.
There were unfortunately some issues with this.
1) This introduced a problem because the comparison is used in different
cases in different places. The misspelled word is compared ignoring
the case, but when looking for the correct word, it looks through the
list for the misspelling in all lowercase. When it couldn't find the
word "superio" in the list, the variable came back uninitialized.
2) The spellcheck feature isn't enabled in checkpatch unless the option
--strict is enabled, so this wasn't getting reported anyway.
3) SuperIO (or superio) will match the KCONFIG options such as
CONFIG_SUPERIO_NUVOTON_NCT5104D, and suggest "Super I/O" which doesn't
make any sense.
Signed-off-by: Martin Roth <gaumless(a)gmail.com>
Change-Id: I464305af539926ac8a45c9c0d59eeb2c78dea17a
---
M util/lint/spelling.txt
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/34/61434/1
diff --git a/util/lint/spelling.txt b/util/lint/spelling.txt
index 3ab42b1..f694717 100644
--- a/util/lint/spelling.txt
+++ b/util/lint/spelling.txt
@@ -27,7 +27,7 @@
FTBS||FTBFS
POSIX-complient||POSIX-compliant
READEME||README
-SuperIO||Super I/O
+superio||Super I/O
aaccessibility||accessibility
aaccession||accession
abailable||available
--
To view, visit https://review.coreboot.org/c/coreboot/+/61434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I464305af539926ac8a45c9c0d59eeb2c78dea17a
Gerrit-Change-Number: 61434
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-MessageType: newchange