Attention is currently required from: Furquan Shaikh, Derek Huang, Brandon Breitenstein, Curtis Chen.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Zhuohao Lee, Brandon Breitenstein, Curtis Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57138
to look at the new patch set (#6).
Change subject: src/ec/google/chromeec: Add and modify APIs for USB-C DP ALT mode
......................................................................
src/ec/google/chromeec: Add and modify APIs for USB-C DP ALT mode
Add API to allow AP to send the direction to EC to enter DP ALT mode
when EC supports EC_FEATURE_TYPEC_REQUIRE_AP_MODE_ENTRY. Modify some
APIs to get information for specified port.
BUG=b:192947843
Signed-off-by: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3
---
M src/ec/google/chromeec/ec.c
M src/ec/google/chromeec/ec.h
M src/mainboard/google/fizz/mainboard.c
M src/mainboard/google/hatch/variants/baseboard/mainboard.c
4 files changed, 38 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/57138/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/57138
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id11510c1ff58579ae2cddfe5a4d69646fd84f5c3
Gerrit-Change-Number: 57138
Gerrit-PatchSet: 6
Gerrit-Owner: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Reviewer: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Derek Huang <derek.huang(a)intel.corp-partner.google.com>
Gerrit-Attention: Brandon Breitenstein <brandon.breitenstein(a)intel.com>
Gerrit-Attention: Curtis Chen <curtis.chen(a)intel.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Paul Menzel, Weimin Wu, Karthik Ramasubramanian.
Sunwei Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57105 )
Change subject: mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS
......................................................................
Patch Set 8:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57105/comment/f030ae89_115cda70
PS7, Line 9: commit b9c22e09(util/sconfig: Compare probe conditions for override device match),
> Please add a space before the (, and you can wrap the line after *for*.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/57105
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iac09663b095e758f1bc0cfaf7adb6e84d203788a
Gerrit-Change-Number: 57105
Gerrit-PatchSet: 8
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Ginger Zhang <zhangqingchun(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 02 Sep 2021 09:02:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: zanxi chen.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57336
to look at the new patch set (#6).
Change subject: mb/google/trogdor: Mipi panel support for mrbland
......................................................................
mb/google/trogdor: Mipi panel support for mrbland
Add mipi panel support for mrbland
- setup gpio and modify LCD sequence.
- use the following panel for mrbland:
AUO B101UAN08.3
BOE TV101WUM-N53
- use panel_id to distinguish which mipi panel to use.
BUG=b:195516474
BRANCH=none
TEST=emerge-strongbad coreboot
Change-Id: Ib7cd2da429b114bf6bad5af312044a0f01319b46
Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/trogdor/Kconfig
M src/mainboard/google/trogdor/board.h
M src/mainboard/google/trogdor/chromeos.c
M src/mainboard/google/trogdor/mainboard.c
4 files changed, 54 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/57336/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/57336
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7cd2da429b114bf6bad5af312044a0f01319b46
Gerrit-Change-Number: 57336
Gerrit-PatchSet: 6
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: zanxi chen.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57336
to look at the new patch set (#5).
Change subject: mb/google/trogdor: mipi panel support for mrbland
......................................................................
mb/google/trogdor: mipi panel support for mrbland
Add mipi panel support for mrbland
- setup gpio and modify LCD sequence.
- use the following panel for mrbland:
AUO B101UAN08.3
BOE TV101WUM-N53
- use panel_id to distinguish which mipi panel to use.
BUG=b:195516474
BRANCH=none
TEST=builds mrbland image and working properly
Change-Id: Ib7cd2da429b114bf6bad5af312044a0f01319b46
Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com>
---
M src/mainboard/google/trogdor/Kconfig
M src/mainboard/google/trogdor/board.h
M src/mainboard/google/trogdor/chromeos.c
M src/mainboard/google/trogdor/mainboard.c
4 files changed, 54 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/57336/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/57336
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib7cd2da429b114bf6bad5af312044a0f01319b46
Gerrit-Change-Number: 57336
Gerrit-PatchSet: 5
Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: Xuxin Xiong <xuxinxiong(a)huaqin.corp-partner.google.com>
Gerrit-Attention: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Paul Menzel, YH Lin.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57332 )
Change subject: mb/google/brya/variants/taeko: Add initial fw config for taeko
......................................................................
Patch Set 7:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57332
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifef750338d777b76e9710d6bca9a166120db6a0a
Gerrit-Change-Number: 57332
Gerrit-PatchSet: 7
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: YH Lin <yueherngl(a)chromium.org>
Gerrit-Comment-Date: Thu, 02 Sep 2021 08:44:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sumeet Pawnikar, Furquan Shaikh, Paul Menzel, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57290 )
Change subject: mb/google/brya/variants: fix override values for power limits
......................................................................
Patch Set 4:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57290/comment/8b58a7d2_1bcc3e77
PS3, Line 8:
> Please state the problem, and why TDP needs to be checked.
Done
https://review.coreboot.org/c/coreboot/+/57290/comment/e22068e0_5bf789f1
PS3, Line 9: Fix override values for power limits for 28W and 45W TDP based 682 SKU.
> Where do you get the values from?
It's mentioned in patch comment at line number 8 : https://review.coreboot.org/c/coreboot/+/57290/4/src/mainboard/google/brya/…
These values as per discussion in bug:191906315 comment #10
File src/mainboard/google/brya/variants/brya0/ramstage.c:
https://review.coreboot.org/c/coreboot/+/57290/comment/89d220fd_f7451fba
PS3, Line 7: TDP(Watts)
> TDP (Watts)
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/57290
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I796e56321ae9c8312530a4b8986cd73a2245f5fa
Gerrit-Change-Number: 57290
Gerrit-PatchSet: 4
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sumeet Pawnikar <sumeet.r.pawnikar(a)intel.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 02 Sep 2021 08:42:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment