coreboot-gerrit September 2021

coreboot-gerrit@coreboot.org

1 participants
6530 discussions

Change in coreboot[master]: arch/x86: Skip returning default leaf value as `0`
by Subrata Banik (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Angel Pons, Kyösti Mälkki. Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Angel Pons, Kyösti Mälkki, Swift Geek (Sebastian Grzywna), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57305 to look at the new patch set (#3). Change subject: arch/x86: Skip returning default leaf value as `0` ...................................................................... arch/x86: Skip returning default leaf value as `0` `cpu_get_cache_info_leaf()` function is responsible to report leaf value for CPU that have support for deterministic cache cpuid. As per available datasheets from AMD and Intel the supported CPUID leafs are 0x8000_001d for AMD and 0x04 for Intel. Hence, this CL skips returning default leaf value as `0`. TEST=Verified fixes: e2b5fee3b006 (arch/x86: smbios write 7 table using deterministic cache functions) hang issue on ASRock E350M1. Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b Signed-off-by: Subrata Banik <subrata.banik(a)intel.com> --- M src/arch/x86/cpu_common.c 1 file changed, 5 insertions(+), 8 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/57305/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/57305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b Gerrit-Change-Number: 57305 Gerrit-PatchSet: 3 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: arch/x86: Skip returning default leaf value as `0`
by Subrata Banik (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel, Angel Pons, Kyösti Mälkki. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57305 ) Change subject: arch/x86: Skip returning default leaf value as `0` ...................................................................... Patch Set 2: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57305/comment/96af5062_e1d1e9e0 PS2, Line 11: leaf > leafs? Ack https://review.coreboot.org/c/coreboot/+/57305/comment/96e6bbe6_dc08f740 PS2, Line 16: e2b5fee > Please add: […] Ack Patchset: PS2: > No VIA support? 😜 @Tim, can you please take a look into cpu_check_deterministic_cache_cpuid_supported(), aren't we already claim the support for Intel and AMD and anything else is considered unknown/invalid. For invalid CPUID we are returning from below code anyway. https://review.coreboot.org/c/coreboot/+/57306/2/src/arch/x86/smbios.c#769 File src/arch/x86/cpu_common.c: https://review.coreboot.org/c/coreboot/+/57305/comment/0343075c_9a511478 PS2, Line 115: return DETERMINISTIC_CACHE_PARAMETERS_CPUID_IA; > You could use the ternary operator. Ack -- To view, visit https://review.coreboot.org/c/coreboot/+/57305 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iee33b39298e7821ac5280d998172b58a70c8715b Gerrit-Change-Number: 57305 Gerrit-PatchSet: 2 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Swift Geek (Sebastian Grzywna) <swiftgeek(a)gmail.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 07:31:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/trogdor: mipi panel support for mrbland
by zanxi chen (Code Review) 02 Sep '21

02 Sep '21

zanxi chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57336 ) Change subject: mb/google/trogdor: mipi panel support for mrbland ...................................................................... mb/google/trogdor: mipi panel support for mrbland Add mipi panel support for mrbland - setup gpio and modify LCD sequence. - use the following panel for mrbland: AUO B101UAN08.3 BOE TV101WUM-N53 - use panel_id to distinguish which mipi panel to use. BUG=b:195516474 BRANCH=none TEST=builds mrbland image and working properly Change-Id: Ib7cd2da429b114bf6bad5af312044a0f01319b46 Signed-off-by: Zanxi Chen <chenzanxi(a)huaqin.corp-partner.google.com> --- M src/mainboard/google/trogdor/Kconfig M src/mainboard/google/trogdor/board.h M src/mainboard/google/trogdor/chromeos.c M src/mainboard/google/trogdor/mainboard.c 4 files changed, 50 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/57336/1 diff --git a/src/mainboard/google/trogdor/Kconfig b/src/mainboard/google/trogdor/Kconfig index 164c05f..88e72dc 100644 --- a/src/mainboard/google/trogdor/Kconfig +++ b/src/mainboard/google/trogdor/Kconfig @@ -14,8 +14,10 @@ config TROGDOR_HAS_MIPI_PANEL bool + default y if BOARD_GOOGLE_MRBLAND + select MIPI_PANEL_AUO_B101UAN08_3 if BOARD_GOOGLE_MRBLAND + select MIPI_PANEL_BOE_TV101WUM_N53 if BOARD_GOOGLE_MRBLAND default n - select MIPI_PANEL_VIS_RM69299 config TROGDOR_HAS_FINGERPRINT bool diff --git a/src/mainboard/google/trogdor/board.h b/src/mainboard/google/trogdor/board.h index 79dafc0..663c793 100644 --- a/src/mainboard/google/trogdor/board.h +++ b/src/mainboard/google/trogdor/board.h @@ -15,13 +15,18 @@ #define GPIO_AMP_ENABLE GPIO(23) /* Display specific GPIOS */ -#define GPIO_BACKLIGHT_ENABLE GPIO(12) +#define GPIO_BACKLIGHT_ENABLE ((CONFIG(BOARD_GOOGLE_MRBLAND)) ? \ + GPIO(85) : GPIO(12)) #define GPIO_EDP_BRIDGE_ENABLE (CONFIG(TROGDOR_REV0) ? GPIO(14) : GPIO(104)) #define GPIO_EN_PP3300_DX_EDP (CONFIG(TROGDOR_REV0) ? GPIO(106) : \ (CONFIG(BOARD_GOOGLE_TROGDOR) && board_id() == 1 ? GPIO(30) : \ (CONFIG(BOARD_GOOGLE_COACHZ) && board_id() == 0 ? GPIO(52) : \ (CONFIG(BOARD_GOOGLE_LAZOR) || CONFIG(BOARD_GOOGLE_POMPOM) ? GPIO(30) : \ GPIO(67))))) +#define GPIO_MIPI_1V8_ENABLE GPIO(86) +#define GPIO_AVDD_LCD_ENABLE GPIO(88) +#define GPIO_AVEE_LCD_ENABLE GPIO(21) +#define GPIO_VDD_RESET_1V8 GPIO(87) /* Fingerprint-specific GPIOs. Only for fingerprint-enabled devices (e.g. CoachZ). */ #if CONFIG(TROGDOR_HAS_FINGERPRINT) diff --git a/src/mainboard/google/trogdor/chromeos.c b/src/mainboard/google/trogdor/chromeos.c index c218388..051480c 100644 --- a/src/mainboard/google/trogdor/chromeos.c +++ b/src/mainboard/google/trogdor/chromeos.c @@ -17,6 +17,13 @@ gpio_output(GPIO_EN_PP3300_DX_EDP, 0); gpio_output(GPIO_EDP_BRIDGE_ENABLE, 0); + if (CONFIG(TROGDOR_HAS_MIPI_PANEL)) { + gpio_output(GPIO_MIPI_1V8_ENABLE, 0); + gpio_output(GPIO_AVDD_LCD_ENABLE, 0); + gpio_output(GPIO_VDD_RESET_1V8, 0); + gpio_output(GPIO_AVEE_LCD_ENABLE, 0); + } + if (CONFIG(TROGDOR_HAS_FINGERPRINT)) { gpio_output(GPIO_FPMCU_BOOT0, 0); gpio_output(GPIO_FP_RST_L, 0); diff --git a/src/mainboard/google/trogdor/mainboard.c b/src/mainboard/google/trogdor/mainboard.c index 4b395ba..ba8b6ab 100644 --- a/src/mainboard/google/trogdor/mainboard.c +++ b/src/mainboard/google/trogdor/mainboard.c @@ -78,9 +78,41 @@ gpio_output(GPIO_EN_PP3300_DX_EDP, 1); } +static void configure_mipi_panel(void) +{ + int panel_id = sku_id() >> 4; + gpio_output(GPIO_MIPI_1V8_ENABLE, 1); + mdelay(5); + gpio_output(GPIO_AVDD_LCD_ENABLE, 1); + mdelay(5); + gpio_output(GPIO_AVEE_LCD_ENABLE, 1); + mdelay(15); + gpio_output(GPIO_VDD_RESET_1V8, 1); + mdelay(15); + if (CONFIG(BOARD_GOOGLE_MRBLAND)&(panel_id)) { + gpio_output(GPIO_VDD_RESET_1V8, 0); + mdelay(5); + gpio_output(GPIO_VDD_RESET_1V8, 1); + } +} + static struct panel_serializable_data *get_mipi_panel(void) { - const char *cbfs_filename = "panel-VIS_RM69299"; + const char *cbfs_filename; + int panel_id = sku_id() >> 4; + + if (CONFIG(BOARD_GOOGLE_MRBLAND)) { + switch (panel_id) { + case 0: + cbfs_filename = "panel-AUO_B101UAN08_3"; + break; + case 1: + cbfs_filename = "panel-BOE_TV101WUM_N53"; + break; + default: + return NULL; + } + } struct panel_serializable_data *panel = cbfs_map(cbfs_filename, NULL); if (!panel) { @@ -126,6 +158,7 @@ if (CONFIG(TROGDOR_HAS_MIPI_PANEL)) { panel = get_mipi_panel(); + configure_mipi_panel(); if (!panel) return; } else { -- To view, visit https://review.coreboot.org/c/coreboot/+/57336 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7cd2da429b114bf6bad5af312044a0f01319b46 Gerrit-Change-Number: 57336 Gerrit-PatchSet: 1 Gerrit-Owner: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS
by Sunwei Li (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Weimin Wu, Karthik Ramasubramanian. Hello build bot (Jenkins), Henry Sun, Weimin Wu, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57105 to look at the new patch set (#6). Change subject: mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS ...................................................................... mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS Based on commit b9c22e09(util/sconfig: Compare probe conditions for override device match), add fw_config probe for ALC5682I-VS headphone Audio Codec. BUG=b:197546020 BRANCH=dedede TEST=ALC5682I-VD/VS and CS42l42 work normally according fw_config Signed-off-by: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com> Change-Id: Iac09663b095e758f1bc0cfaf7adb6e84d203788a --- M src/mainboard/google/dedede/variants/cappy2/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/57105/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/57105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac09663b095e758f1bc0cfaf7adb6e84d203788a Gerrit-Change-Number: 57105 Gerrit-PatchSet: 6 Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Ginger Zhang <zhangqingchun(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/jasperlake: Utilize vbt data size Kconfig option
by shkim (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Jamie Chen, Paul Menzel, SH Kim, Patrick Rudolph, Karthik Ramasubramanian. shkim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57201 ) Change subject: soc/intel/jasperlake: Utilize vbt data size Kconfig option ...................................................................... Patch Set 9: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57201/comment/8b8424b6_af021d24 PS6, Line 8: > Please describe the problem first. Done https://review.coreboot.org/c/coreboot/+/57201/comment/07e480de_9652491a PS6, Line 9: had changed > changes or changed Removed previous commit detail. https://review.coreboot.org/c/coreboot/+/57201/comment/a0c4df71_d4c77372 PS6, Line 9: cf5d58328f(increase vbt_data size) > Please add a space before the (. Removed previous commit detail. https://review.coreboot.org/c/coreboot/+/57201/comment/3461d4b5_bfd168a9 PS6, Line 10: to pick : the size for jasperlake. > … to set the size to 9 KB for Jasper Lake. Done https://review.coreboot.org/c/coreboot/+/57201/comment/4d1fe7a1_30530e75 PS6, Line 11: jasperlake > Jasper Lake Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Gerrit-Change-Number: 57201 Gerrit-PatchSet: 9 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 07:25:50 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/jasperlake: Utilize vbt data size Kconfig option
by shkim (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Jamie Chen, SH Kim, Patrick Rudolph, Karthik Ramasubramanian. Hello build bot (Jenkins), Jamie Chen, SH Kim, Patrick Rudolph, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57201 to look at the new patch set (#9). Change subject: soc/intel/jasperlake: Utilize vbt data size Kconfig option ...................................................................... soc/intel/jasperlake: Utilize vbt data size Kconfig option Currently maximum VBT data size for Jasper Lake is 8KB, but Bugzzy would use VBT data over 8KB. This change makes use of Kconfig option to increase the maximum VBT data size to 9KB for Jasper Lake. BUG=b:194029827 BRANCH=dedede TEST=build and boot bugzzy and verify fw screen is loaded Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/57201/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/57201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Gerrit-Change-Number: 57201 Gerrit-PatchSet: 9 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS
by Sunwei Li (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Weimin Wu, Karthik Ramasubramanian. Sunwei Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57105 ) Change subject: mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/57105/comment/3a174840_327baa0e PS4, Line 9: Base on patch: https://review.coreboot.org/c/coreboot/+/57111, > As git operates with hashes, please also use the hashes: Based on commit b9c22e09 (util/sconfig: Com […] Done https://review.coreboot.org/c/coreboot/+/57105/comment/3fa0d9e6_f80164f1 PS4, Line 9: Base > Based Done -- To view, visit https://review.coreboot.org/c/coreboot/+/57105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac09663b095e758f1bc0cfaf7adb6e84d203788a Gerrit-Change-Number: 57105 Gerrit-PatchSet: 5 Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Ginger Zhang <zhangqingchun(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 07:23:00 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS
by Sunwei Li (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Furquan Shaikh, Sunwei Li, Weimin Wu, Karthik Ramasubramanian. Hello build bot (Jenkins), Henry Sun, Weimin Wu, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57105 to look at the new patch set (#5). Change subject: mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS ...................................................................... mb/google/dedede/var/cappy2: Add fw_config probe for ALC5682I-VS Based on commit b9c22e09 , add fw_config probe for ALC5682I-VS headphone Audio Codec. BUG=b:197546020 BRANCH=dedede TEST=ALC5682I-VD/VS and CS42l42 work normally according fw_config Signed-off-by: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com> Change-Id: Iac09663b095e758f1bc0cfaf7adb6e84d203788a --- M src/mainboard/google/dedede/variants/cappy2/overridetree.cb 1 file changed, 14 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/57105/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/57105 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iac09663b095e758f1bc0cfaf7adb6e84d203788a Gerrit-Change-Number: 57105 Gerrit-PatchSet: 5 Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Ginger Zhang <zhangqingchun(a)huaqin.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com> Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/jasperlake: Utilize vbt data size Kconfig option
by shkim (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Jamie Chen, SH Kim, Patrick Rudolph, Karthik Ramasubramanian. Hello build bot (Jenkins), Jamie Chen, SH Kim, Patrick Rudolph, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/57201 to look at the new patch set (#8). Change subject: soc/intel/jasperlake: Utilize vbt data size Kconfig option ...................................................................... soc/intel/jasperlake: Utilize vbt data size Kconfig option Currently maximum VBT data size is 8KB, but Bugzzy would use VBT data over 8KB. This change makes use of Kconfig option to increase the maximum VBT data size to 9KB for Jasper Lake. BUG=b:194029827 BRANCH=dedede TEST=build and boot bugzzy and verify fw screen is loaded Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Signed-off-by: Seunghwan Kim <sh_.kim(a)samsung.corp-partner.google.com> --- M src/soc/intel/jasperlake/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/01/57201/8 -- To view, visit https://review.coreboot.org/c/coreboot/+/57201 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0abe1ba5609b48a8a8b15f88bec28342ce26c78f Gerrit-Change-Number: 57201 Gerrit-PatchSet: 8 Gerrit-Owner: shkim <sh_.kim(a)samsung.com> Gerrit-Reviewer: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jamie Chen <jamie.chen(a)intel.corp-partner.google.com> Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vc/mediatek/mt8195: Remove unused code
by Hung-Te Lin (Code Review) 02 Sep '21

02 Sep '21

Attention is currently required from: Rex-BC Chen, Paul Menzel, Ryan Chuang. Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57275 ) Change subject: vc/mediatek/mt8195: Remove unused code ...................................................................... Patch Set 4: (1 comment) Patchset: PS4: Hi Rex, is there a particular benefit in removing those implementations? Do they also not exist on the MTK internal release version? If they do exist, then I wonder if removing these will make it harder when you want to cherry pick changes from the internal releases. -- To view, visit https://review.coreboot.org/c/coreboot/+/57275 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3b235cbceb231898f00fce7905f596eab54ca595 Gerrit-Change-Number: 57275 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Ryan Chuang <ryan.chuang(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 02 Sep 2021 07:22:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit September 2021