Attention is currently required from: Paul Menzel, Zhi7 Li.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57358 )
Change subject: mb/google/dedede: Create beetley variant
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57358/comment/c5ca326f_956d28c4
PS1, Line 12: (Auto-Generated by create_coreboot_variant.sh version 4.5.0).
> Please move the dot/period before the ).
1. This commit was Auto-Generated by new_variant.py script.
2. If move dot before the ')', like this "version 4.5.0.)", looks strange.
Could we just keep or delete the dot?
--
To view, visit https://review.coreboot.org/c/coreboot/+/57358
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d52be55270361406a67f91707b71dff5c725f35
Gerrit-Change-Number: 57358
Gerrit-PatchSet: 1
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Krystal Han <hanlijing(a)huaqin.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 03 Sep 2021 09:06:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Julius Werner, Yu-Ping Wu.
Hsuan-ting Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57048 )
Change subject: vboot_logic: Set VB2_CONTEXT_EC_TRUSTED in verstage_main
......................................................................
Patch Set 5:
(2 comments)
This change is ready for review.
Patchset:
PS5:
PS5:
* Support beltino, daisy, nyan, nyan_big, nyan_blaze, peach_pit, parrot, stout, butterfly again
* Set storm, veyron_mickey, and veyron_rialto as always trusted
File src/mainboard/google/butterfly/chromeos.c:
https://review.coreboot.org/c/coreboot/+/57048/comment/2f1abf02_92c0d588
PS2, Line 84: Always return trusted. */
> okay, sorry, I was wrong. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/57048
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I479c8f80e45cc524ba87db4293d19b29bdfa2192
Gerrit-Change-Number: 57048
Gerrit-PatchSet: 5
Gerrit-Owner: Hsuan-ting Chen <roccochen(a)google.com>
Gerrit-Reviewer: Hsuan Ting Chen <roccochen(a)chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 03 Sep 2021 08:51:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen <roccochen(a)google.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak.
Malik Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57331 )
Change subject: mb/google/brya/variants/primus: update gpio and fw_config for next build phase
......................................................................
Patch Set 1:
(2 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/57331/comment/a1444c8f_f2ac1bca
PS1, Line 7: evt
> OEMs usually prefer we don't call out build phases directly in commit messages, comments, etc. […]
Done
https://review.coreboot.org/c/coreboot/+/57331/comment/1d9069d0_d1035f5f
PS1, Line 8:
> Please elaborate, what you are updating, and what the “source“ is (schematics, datasheet, …).
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/57331
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14907faeb631193715b1e0e451e427fb79a68279
Gerrit-Change-Number: 57331
Gerrit-PatchSet: 1
Gerrit-Owner: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Fri, 03 Sep 2021 08:43:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: shkim, SH Kim, Karthik Ramasubramanian, Felix Held.
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57107 )
Change subject: mb/google/dedede/var/bugzzy: Configure DDI port A as MIPI DSI
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Patchset:
PS2:
LGTM, differ to Felix and Karthik for CR+2 approval. Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/57107
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If308f9d69fea56176527e7b67f36b29c43adb525
Gerrit-Change-Number: 57107
Gerrit-PatchSet: 2
Gerrit-Owner: shkim <sh_.kim(a)samsung.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Raymond Chung <raymondchung(a)ami.corp-partner.google.com>
Gerrit-Attention: shkim <sh_.kim(a)samsung.com>
Gerrit-Attention: SH Kim <sh_.kim(a)samsung.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 03 Sep 2021 08:40:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Piotr Król.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56808 )
Change subject: mb/pcengines/apu2/gpio_ftns.h: add comment about GPIO numbers
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56808
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie30bf5483ea2e2516d7e3fdd21ea9338362e526e
Gerrit-Change-Number: 56808
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 03 Sep 2021 08:38:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Felix Held, Piotr Król.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56784 )
Change subject: [TESTME] mb/pcengines/apu2/romstage: use proper GPIO configuration API
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
Patchset:
PS2:
Works well, no issues detected by our testing suites. Felix you may add
`Tested-by: Michał Kopeć <michal.kopec(a)3mdeb.com>` to the commit mesage
--
To view, visit https://review.coreboot.org/c/coreboot/+/56784
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If121941c8a6ba88913653192740997aeef426548
Gerrit-Change-Number: 56784
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Comment-Date: Fri, 03 Sep 2021 08:37:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stanley Wu, Paul Fagerburg.
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57297 )
Change subject: mb/google/dedede/var/gooey: Configure I2C times for I2C devices
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> CR+2 approved.
Thank you, please wait for next weeks bunch merge then, should be with this CL in.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57297
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic5d5660181f36f161ae04cbf5003f6d7ad4bc16f
Gerrit-Change-Number: 57297
Gerrit-PatchSet: 1
Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Comment-Date: Fri, 03 Sep 2021 08:35:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Henry Sun <henrysun(a)google.com>
Comment-In-Reply-To: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Ravi kumar, mturney mturney, Julius Werner.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55964 )
Change subject: src/mainboard/herobrine: Load GSI FW in ramstage
......................................................................
Patch Set 17:
(1 comment)
File src/mainboard/google/herobrine/mainboard.c:
https://review.coreboot.org/c/coreboot/+/55964/comment/340115a9_8b83cfed
PS17, Line 25: qupv3_se_fw_load_and_init(QUPV3_0_SE1, SE_PROTOCOL_I2C, GSI); /* APPS I2C */
How much time does this take? Please add that to the commit message.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55964
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d9caa0921fcf9ad67f1071cdf769a99fb6d1a30
Gerrit-Change-Number: 55964
Gerrit-PatchSet: 17
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rajesh Patil <rajpat(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-CC: Roja Rani Yarubandi <c_rojay(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 03 Sep 2021 08:28:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment