Attention is currently required from: Paul Menzel, Tim Wawrzynczak.
Malik Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57331 )
Change subject: mb/google/brya/variants/primus: update gpio and fw_config for next build phase
......................................................................
Patch Set 1:
(2 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/coreboot/+/57331/comment/a1444c8f_f2ac1bca
PS1, Line 7: evt
OEMs usually prefer we don't call out build phases directly in commit messages, comments, etc. […]
Done
https://review.coreboot.org/c/coreboot/+/57331/comment/1d9069d0_d1035f5f
PS1, Line 8:
Please elaborate, what you are updating, and what the “source“ is (schematics, datasheet, …).
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57331
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14907faeb631193715b1e0e451e427fb79a68279
Gerrit-Change-Number: 57331
Gerrit-PatchSet: 1
Gerrit-Owner: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Comment-Date: Fri, 03 Sep 2021 08:43:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment