Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57398 )
Change subject: device/device.h: Drop unused function declaration
......................................................................
device/device.h: Drop unused function declaration
The `dev_optimize()` function is neither defined nor used anywhere in
the tree. Drop its unnecessary declaration.
Change-Id: I902bda3244c6496a04f364fad3ecbbdd118dd543
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57398
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/include/device/device.h
1 file changed, 0 insertions(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Nico Huber: Looks good to me, approved
Felix Held: Looks good to me, approved
Arthur Heymans: Looks good to me, approved
diff --git a/src/include/device/device.h b/src/include/device/device.h
index 8f0650f..5a9b9e5 100644
--- a/src/include/device/device.h
+++ b/src/include/device/device.h
@@ -175,7 +175,6 @@
void dev_configure(void);
void dev_enable(void);
void dev_initialize(void);
-void dev_optimize(void);
void dev_finalize(void);
void dev_finalize_chips(void);
/* Function used to override device state */
--
To view, visit https://review.coreboot.org/c/coreboot/+/57398
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I902bda3244c6496a04f364fad3ecbbdd118dd543
Gerrit-Change-Number: 57398
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Nico Huber, Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Angel Pons, Andrey Petrov, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51575 )
Change subject: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/51575/comment/936915dd_480f38a1
PS2, Line 6: select HAVE_DISPLAY_MTRRS
> Does Pentium 2 have MTRRs? If it doesn't, one can still flip the default for `HAVE_DISPLAY_MTRRS` an […]
pentium pro and pentium 2 were the two first intel cpus with mtrrs
--
To view, visit https://review.coreboot.org/c/coreboot/+/51575
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2894689ce58e7404d9d5a894f3c288bc4016ea19
Gerrit-Change-Number: 51575
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 06 Sep 2021 17:33:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, awokd(a)danwin1210.me.
Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57319 )
Change subject: src/device/Kconfig: introduce the AMD_DGPU_WITHOUT_EEPROM symbols
......................................................................
Patch Set 3:
(2 comments)
Patchset:
PS2:
> How is the situation different from that for nvidia?
I am not aware of any "with NVidia" boards which could benefit from this patch, so it is for AMD only.
PS2:
> Are there any cases where MAINBOARD_HAS_AMD_DGPU_WITHOUT_EEPROM != AMD_DGPU_WITHOUT_EEPROM ? […]
Thank you, I tried to clarify the situation by renaming it to "MAINBOARD_VERSION_HAS_AMD_DGPU_WITHOUT_EEPROM". In example, G505S has both a "with DGPU" and "without DGPU" motherboard versions, and need to enable AMD_DGPU_WITHOUT_EEPROM only for the 1st version.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I424f93961c9d4a856dd6f5285417597cb117084d
Gerrit-Change-Number: 57319
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: awokd(a)danwin1210.me
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: awokd(a)danwin1210.me
Gerrit-Comment-Date: Mon, 06 Sep 2021 17:08:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: awokd(a)danwin1210.me
Gerrit-MessageType: comment
Attention is currently required from: Nico Huber, Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Andrey Petrov, Patrick Rudolph, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51575 )
Change subject: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/51575/comment/9852a3d8_cc9f0a5d
PS2, Line 6: select HAVE_DISPLAY_MTRRS
> ah, you're right, the fsp driver doesn't provide that functionality. […]
Does Pentium 2 have MTRRs? If it doesn't, one can still flip the default for `HAVE_DISPLAY_MTRRS` and disable it where needed. This should be a better long-term approach.
--
To view, visit https://review.coreboot.org/c/coreboot/+/51575
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2894689ce58e7404d9d5a894f3c288bc4016ea19
Gerrit-Change-Number: 51575
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Mon, 06 Sep 2021 16:36:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment
Attention is currently required from: Mike Banon.
Hello build bot (Jenkins), awokd(a)danwin1210.me,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57319
to look at the new patch set (#3).
Change subject: src/device/Kconfig: introduce the AMD_DGPU_WITHOUT_EEPROM symbols
......................................................................
src/device/Kconfig: introduce the AMD_DGPU_WITHOUT_EEPROM symbols
Some platforms like Lenovo G505S have the motherboard versions
with the onboard AMD discrete GPU without its own dedicated EEPROM
storage for VGA Option ROM. For such a discrete GPU to be usable
with coreboot, the PCI init of GPUs has to be done differently.
These AMD_DGPU_WITHOUT_EEPROM symbols can help for such cases.
Change-Id: I424f93961c9d4a856dd6f5285417597cb117084d
Signed-off-by: Mike Banon <mike.banon(a)3mdeb.com>
---
M src/device/Kconfig
1 file changed, 17 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/57319/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/57319
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I424f93961c9d4a856dd6f5285417597cb117084d
Gerrit-Change-Number: 57319
Gerrit-PatchSet: 3
Gerrit-Owner: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-Reviewer: awokd(a)danwin1210.me
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mike Banon <mikebdp2(a)gmail.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Dtrain Hsu, Sumeet R Pawnikar, Paul F Yang, Shou-Chieh Hsu, Karthik Ramasubramanian.
Henry Sun has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57404 )
Change subject: mb/google/dedede/var/cret: Update DPTF parameters
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
Data format LGTM, differ to Karthik to CR+2 if no concern. Thanks!
--
To view, visit https://review.coreboot.org/c/coreboot/+/57404
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25d3909144d6e38d7a6eb859d33585c319a84b04
Gerrit-Change-Number: 57404
Gerrit-PatchSet: 3
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul F Yang <paul.f.yang(a)intel.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Paul F Yang <paul.f.yang(a)intel.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 06 Sep 2021 15:17:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57399 )
Change subject: mb/**/gma-mainboard.ads: Use lowercase for `others`
......................................................................
mb/**/gma-mainboard.ads: Use lowercase for `others`
These two files are the only places where the `others` keyword is
capitalised. Use lowercase for consistency with the rest of the tree.
Change-Id: I6b785e28d1d00a11b802a44348a7132ceb6b599d
Signed-off-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57399
Reviewed-by: Nico Huber <nico.h(a)gmx.de>
Reviewed-by: Arthur Heymans <arthur(a)aheymans.xyz>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/51nb/x210/gma-mainboard.ads
M src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/gma-mainboard.ads
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Nico Huber: Looks good to me, approved
Arthur Heymans: Looks good to me, approved
diff --git a/src/mainboard/51nb/x210/gma-mainboard.ads b/src/mainboard/51nb/x210/gma-mainboard.ads
index 6fb2080..d65c25d 100644
--- a/src/mainboard/51nb/x210/gma-mainboard.ads
+++ b/src/mainboard/51nb/x210/gma-mainboard.ads
@@ -12,6 +12,6 @@
(DP1,
DP2,
eDP,
- Others => Disabled);
+ others => Disabled);
end GMA.Mainboard;
diff --git a/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/gma-mainboard.ads b/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/gma-mainboard.ads
index aa8a70d..b5bfff1 100644
--- a/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/gma-mainboard.ads
+++ b/src/mainboard/asus/p8x7x-series/variants/p8z77-v_lx2/gma-mainboard.ads
@@ -11,6 +11,6 @@
ports : constant Port_List :=
(HDMI3,
Analog,
- Others => Disabled);
+ others => Disabled);
end GMA.Mainboard;
--
To view, visit https://review.coreboot.org/c/coreboot/+/57399
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b785e28d1d00a11b802a44348a7132ceb6b599d
Gerrit-Change-Number: 57399
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Nico Huber, Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Angel Pons, Andrey Petrov, Patrick Rudolph.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51575 )
Change subject: drivers/intel/fsp2_0/Kconfig: select HAVE_DISPLAY_MTRRS
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51575/comment/a5df74ef_fa6ed061
PS1, Line 7: drivers/intel/fsp2_0: move selection of HAVE_DISPLAY_MTRRS to FSP driver
> I guess we could simply guard the debug option with some ARCH_X86. I never […]
the code works on the fsp-based amd platforms; haven't checked if the mtrr printing code looks at the additional bits that get set when X86_AMD_FIXED_MTRRS is selected, but it wouldn't be really wrong not to look at those when just printing the mtrrs
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/51575/comment/5f269b38_df12c49f
PS2, Line 6: select HAVE_DISPLAY_MTRRS
> > no, a depends on isn't the right thing to do here, since the fsp driver itself provides some funct […]
ah, you're right, the fsp driver doesn't provide that functionality. what i probably intended to write was that the fsp driver has a lot of calls to display_mtrrs that only do something when DISPLAY_MTRRS is selected which is guarded by HAVE_DISPLAY_MTRRS, so we should select HAVE_DISPLAY_MTRRS at least for all platforms hat use the fsp driver. did a quick git grep display_mtrrs and it's also called in postcar, so there's also a call to that for non-fsp platforms. i don't think that we have any x86 platform in tree that doesn't support mtrrs, so we can probably remove the HAVE_DISPLAY_MTRRS option completely
--
To view, visit https://review.coreboot.org/c/coreboot/+/51575
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2894689ce58e7404d9d5a894f3c288bc4016ea19
Gerrit-Change-Number: 51575
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 06 Sep 2021 13:37:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: comment