Michael Niewöhner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/52092 )
Change subject: mb/ocp/tiogapass: enable SOL console via Kconfig
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/52092
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idaf854d5f0ed17cfa493937df7e9b51b55216c03
Gerrit-Change-Number: 52092
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Michael Niewöhner has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/52091 )
Change subject: mb/ocp/deltalake: enable SOL console via Kconfig
......................................................................
Abandoned
--
To view, visit https://review.coreboot.org/c/coreboot/+/52091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida0632c6d5a3c8a951bf84600e06e394a2bdf022
Gerrit-Change-Number: 52091
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: abandon
Attention is currently required from: Felix Held.
Hello Felix Held,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/57430
to review the following change.
Change subject: mb/amd/{bilby,mandolin}: Turn empty `chip` entry into comment
......................................................................
mb/amd/{bilby,mandolin}: Turn empty `chip` entry into comment
A chip entry in the devicetree is not hooked up without a device
beneath it. It seems the intention was to leave these superio
drivers unconfigured, so there should be no harm to turn the
entries into comments.
Change-Id: I6b606f35eba089b74c562084772d95be41cac39c
Signed-off-by: Nico Huber <nico.h(a)gmx.de>
---
M src/mainboard/amd/bilby/devicetree.cb
M src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
3 files changed, 3 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/57430/1
diff --git a/src/mainboard/amd/bilby/devicetree.cb b/src/mainboard/amd/bilby/devicetree.cb
index c089d0d..aaf1c3b 100644
--- a/src/mainboard/amd/bilby/devicetree.cb
+++ b/src/mainboard/amd/bilby/devicetree.cb
@@ -160,8 +160,7 @@
device ref xgbe_1 off end # integrated Ethernet MAC
end
device ref lpc_bridge on
- chip superio/smsc/sio1036 # optional debug card
- end
+ # chip superio/smsc/sio1036 # optional debug card
end
end # domain
diff --git a/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb b/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
index dbb1a14..6342c29 100644
--- a/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
+++ b/src/mainboard/amd/mandolin/variants/cereme/devicetree.cb
@@ -149,8 +149,7 @@
device ref xgbe_1 off end # integrated Ethernet MAC
end
device ref lpc_bridge on
- chip superio/smsc/sio1036 # optional debug card
- end
+ # chip superio/smsc/sio1036 # optional debug card
end
end # domain
diff --git a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
index 6b5a60b..035bb70 100644
--- a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
+++ b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
@@ -149,8 +149,7 @@
device ref xgbe_1 off end # integrated Ethernet MAC
end
device ref lpc_bridge on
- chip superio/smsc/sio1036 # optional debug card
- end
+ # chip superio/smsc/sio1036 # optional debug card
end
end # domain
--
To view, visit https://review.coreboot.org/c/coreboot/+/57430
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6b606f35eba089b74c562084772d95be41cac39c
Gerrit-Change-Number: 57430
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newchange
Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Tim Wawrzynczak, Morgan Jang.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52091 )
Change subject: mb/ocp/deltalake: enable SOL console via Kconfig
......................................................................
Patch Set 6: Verified+1
(1 comment)
File src/mainboard/ocp/deltalake/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-127548):
https://review.coreboot.org/c/coreboot/+/52091/comment/efb42553_55f69af4
PS6, Line 45: (1 << 28) | (1 << 16) | (1 << 17));
code indent should use tabs where possible
--
To view, visit https://review.coreboot.org/c/coreboot/+/52091
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ida0632c6d5a3c8a951bf84600e06e394a2bdf022
Gerrit-Change-Number: 52091
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Comment-Date: Mon, 06 Sep 2021 21:56:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Matt DeVillier, Angel Pons, Balaji Manigandan, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56367 )
Change subject: soc/intel/common: timer: Select legacy 8254 timer for TianoCore
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56367/comment/9d2ef349_0127e476
PS3, Line 11: Without this a hang is seen
Where does it hang exactly?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56367
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9de18a026e66e3503909dd60570336c02eb8ff29
Gerrit-Change-Number: 56367
Gerrit-PatchSet: 3
Gerrit-Owner: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 06 Sep 2021 21:39:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57407 )
Change subject: wifi: Update deny list entry size to uint16_t
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57407/comment/bcf606f3_4ff09d77
PS1, Line 12: cc50770cd0("wifi:
Please add a space before (.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57407
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I045c21350cf4c2266df108eede6350d090322ba0
Gerrit-Change-Number: 57407
Gerrit-PatchSet: 1
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Mon, 06 Sep 2021 21:35:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57400 )
Change subject: Doc/Intel: Remove out-of-date documentation
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57400/comment/2b541983_8c4adad4
PS1, Line 13: Oh, and it doesn't seem to have a license
: associated to it.
As it was committed to the coreboot repository, it’s GPLv2, isn’t it? Maybe remove this statement.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57400
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If359f554e85d32cdb65c3d928b5155db30bc40a5
Gerrit-Change-Number: 57400
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 06 Sep 2021 21:35:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment