Tim Wawrzynczak has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56865 )
Change subject: mb/system76/oryp6: Drop DIMM_SPD_SIZE
......................................................................
mb/system76/oryp6: Drop DIMM_SPD_SIZE
The board uses the default size specified in the SoC.
Change-Id: Ie71a0fea1ff9de6c4f1ce8db2db09bb3cd35d04d
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56865
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Reviewed-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/mainboard/system76/oryp6/Kconfig
1 file changed, 0 insertions(+), 4 deletions(-)
Approvals:
build bot (Jenkins): Verified
Paul Menzel: Looks good to me, but someone else must approve
Felix Singer: Looks good to me, approved
diff --git a/src/mainboard/system76/oryp6/Kconfig b/src/mainboard/system76/oryp6/Kconfig
index 56ccd175..d063f40 100644
--- a/src/mainboard/system76/oryp6/Kconfig
+++ b/src/mainboard/system76/oryp6/Kconfig
@@ -54,10 +54,6 @@
int
default 2
-config DIMM_SPD_SIZE
- int
- default 512
-
config VGA_BIOS_ID
string
default "8086,9bc4"
--
To view, visit https://review.coreboot.org/c/coreboot/+/56865
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie71a0fea1ff9de6c4f1ce8db2db09bb3cd35d04d
Gerrit-Change-Number: 56865
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Scott Chao.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56879 )
Change subject: mb/google/brya/variants/primus: Remove DPTF fan control
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56879
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If758d75ff24c88c9eaf0de90ac0ef08d172a2edd
Gerrit-Change-Number: 56879
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 09 Aug 2021 15:01:11 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, EricR Lai.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56877 )
Change subject: drivers/generic/alc1015: Add HID to support alc1019
......................................................................
Patch Set 2:
(1 comment)
File src/drivers/generic/alc1015/chip.h:
https://review.coreboot.org/c/coreboot/+/56877/comment/424f2c9d_fe4f8cff
PS2, Line 6: const char *hid; /* ACPI _HID */
WDYT about an enum, e.g.:
```
enum alc101x_type {
ALC1015,
ALC1019,
};
```
then alc1015.c just writes the _HID corresponding to the enum values.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56877
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e98297f3a39048b24d61e61ca95c60cd2037eb5
Gerrit-Change-Number: 56877
Gerrit-PatchSet: 2
Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 09 Aug 2021 14:58:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford.
Jeremy Soller has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52417 )
Change subject: mb/system76/oryp6: Enable TAS5825M smart amp
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/52417
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57781a7223a52b8fc5295cf686412926529c3a7f
Gerrit-Change-Number: 52417
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Comment-Date: Mon, 09 Aug 2021 13:38:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Scott Chao.
Hello build bot (Jenkins), Tim Wawrzynczak, Sumeet R Pawnikar,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56879
to look at the new patch set (#2).
Change subject: mb/google/brya/variants/primus: Remove DPTF fan control
......................................................................
mb/google/brya/variants/primus: Remove DPTF fan control
BUG=b:195901486, b:195387997
BRANCH=none
TEST=Check fan is able to control by EC
Signed-off-by: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Change-Id: If758d75ff24c88c9eaf0de90ac0ef08d172a2edd
---
M src/mainboard/google/brya/variants/primus/overridetree.cb
1 file changed, 0 insertions(+), 32 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/79/56879/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56879
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If758d75ff24c88c9eaf0de90ac0ef08d172a2edd
Gerrit-Change-Number: 56879
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-CC: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52580 )
Change subject: MAINTAINERS: Add Tim Crawford as a maintainer for System76
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52580/comment/c2919374_66357a0c
PS2, Line 7: myself
> Please use your name for people reading only the summary.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/52580
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8aa9ee1627bf319660b193b4602d8c2d0b562424
Gerrit-Change-Number: 52580
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 09 Aug 2021 13:21:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford.
Hello Felix Singer, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52580
to look at the new patch set (#3).
Change subject: MAINTAINERS: Add Tim Crawford as a maintainer for System76
......................................................................
MAINTAINERS: Add Tim Crawford as a maintainer for System76
Change-Id: I8aa9ee1627bf319660b193b4602d8c2d0b562424
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M MAINTAINERS
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/52580/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/52580
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8aa9ee1627bf319660b193b4602d8c2d0b562424
Gerrit-Change-Number: 52580
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-MessageType: newpatchset