coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4519 discussions

Change in coreboot[master]: elogtool: add "clear" command
by build bot (Jenkins) (Code Review) 09 Aug '21

09 Aug '21

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56883 ) Change subject: elogtool: add "clear" command ...................................................................... Patch Set 1: (2 comments) File util/cbfstool/elogtool.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125931): https://review.coreboot.org/c/coreboot/+/56883/comment/66c75441_67a56718 PS1, Line 127: void* data_offset; "foo* bar" should be "foo *bar" File util/cbfstool/eventlog.h: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-125931): https://review.coreboot.org/c/coreboot/+/56883/comment/df66615f_fee4ceec PS1, Line 11: void eventlog_init_event(struct event_header* event, uint8_t type, "foo* bar" should be "foo *bar" -- To view, visit https://review.coreboot.org/c/coreboot/+/56883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585 Gerrit-Change-Number: 56883 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Comment-Date: Mon, 09 Aug 2021 16:47:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: elogtool: add "clear" command
by Ricardo Quesada (Code Review) 09 Aug '21

09 Aug '21

Ricardo Quesada has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56883 ) Change subject: elogtool: add "clear" command ...................................................................... elogtool: add "clear" command Adds "clear" command to cbfsutil/elogtool tool. "clear" clears the RW_ELOG using flashrom with ELOG_TYPE_EOL. And inserts a ELOG_TYPE_LOG_CLEAR event. Usage: $ elogtool clear BUG=b:172210863 Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585 Signed-off-by: Ricardo Quesada <ricardoq(a)google.com> --- M src/commonlib/bsd/elog.c M src/commonlib/bsd/include/commonlib/bsd/elog.h M util/cbfstool/elogtool.c M util/cbfstool/eventlog.c M util/cbfstool/eventlog.h 5 files changed, 166 insertions(+), 6 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/56883/1 diff --git a/src/commonlib/bsd/elog.c b/src/commonlib/bsd/elog.c index 6c927aa..27fe808 100644 --- a/src/commonlib/bsd/elog.c +++ b/src/commonlib/bsd/elog.c @@ -40,7 +40,55 @@ /* return the data associated to the event_header. */ const void *event_get_data(const struct event_header *event) { - // Pointing to the next event returns the data, since data is the first field - // right after the header. + /* + * Pointing to the next event returns the data, since data is the first + * field right after the header. + */ return (const void *)(&event[1]); } + +static inline uint8_t mybin2bcd(uint8_t val) +{ + return ((val / 10) << 4) | (val % 10); +} + +/* Populate timestamp in event header with given time. */ +void elog_fill_timestamp(struct event_header *event, uint8_t sec, uint8_t min, + uint8_t hour, uint8_t mday, uint8_t mon, uint8_t year) +{ + event->second = mybin2bcd(sec); + event->minute = mybin2bcd(min); + event->hour = mybin2bcd(hour); + event->day = mybin2bcd(mday); + event->month = mybin2bcd(mon); + event->year = mybin2bcd(year % 100); + + /* Basic sanity check of expected ranges. */ + if (event->month > 0x12 || event->day > 0x31 || event->hour > 0x23 || + event->minute > 0x59 || event->second > 0x59) { + event->year = 0; + event->month = 0; + event->day = 0; + event->hour = 0; + event->minute = 0; + event->second = 0; + } +} + +/* Update the checksum at the last byte. */ +void elog_update_checksum(struct event_header *event, uint8_t checksum) +{ + uint8_t *event_data = (uint8_t *)event; + event_data[event->length - 1] = checksum; +} + +/* Simple byte checksum for events. */ +uint8_t elog_checksum_event(struct event_header *event) +{ + uint8_t index, checksum = 0; + uint8_t *data = (uint8_t *)event; + + for (index = 0; index < event->length; index++) + checksum += data[index]; + return checksum; +} diff --git a/src/commonlib/bsd/include/commonlib/bsd/elog.h b/src/commonlib/bsd/include/commonlib/bsd/elog.h index 0d41157..54e7ec4 100644 --- a/src/commonlib/bsd/include/commonlib/bsd/elog.h +++ b/src/commonlib/bsd/include/commonlib/bsd/elog.h @@ -313,5 +313,9 @@ enum cb_err elog_verify_header(const struct elog_header *header); const struct event_header *elog_get_next_event(const struct event_header *event); const void *event_get_data(const struct event_header *event); +void elog_fill_timestamp(struct event_header *event, uint8_t sec, uint8_t min, + uint8_t hour, uint8_t mday, uint8_t mon, uint8_t year); +void elog_update_checksum(struct event_header *event, uint8_t checksum); +uint8_t elog_checksum_event(struct event_header *event); #endif /* _COMMONLIB_BSD_ELOG_H_ */ diff --git a/util/cbfstool/elogtool.c b/util/cbfstool/elogtool.c index ba59eac..7a05aff 100644 --- a/util/cbfstool/elogtool.c +++ b/util/cbfstool/elogtool.c @@ -33,7 +33,9 @@ "USAGE:\n" "\t%s COMMAND [-f <filename>]\n\n" "where, COMMAND is:\n" - " list = lists all the event logs in human readable format\n\n" + " list = lists all the event logs in human readable format\n" + " clear = clears the contents RW_ELOG region from flash\n" + "\n" "ARGS\n" "-f, --file <filename> Input file that holds event log partition.\n" " If empty it will try to read from the RW_ELOG ROM region\n" @@ -41,8 +43,11 @@ invoked_as); } -// If filename is empty, read RW_ELOG from flashrom. Otherwise read the RW_ELOG from a file. -// Buffer must be freed by caller. +/* + * If filename is empty, read RW_ELOG from flashrom. + * Otherwise read the RW_ELOG from a file. + * Buffer must be freed by caller. + */ static int elog_read(const char *filename, struct buffer *buffer) { if (filename == NULL) { @@ -99,7 +104,7 @@ { int ret; - // Returned buffer must be freed. + /* Returned buffer must be freed. */ struct buffer buf; ret = elog_read(filename, &buf); if (ret != 0) @@ -111,6 +116,74 @@ return ret; } +/* + * Clears the elog events from buf, which is a valid RW_ELOG region. + * A LOG_CLEAR event is appended. + */ +static int elog_clear_events(struct buffer *buf) +{ + const struct event_header *event; + uint32_t used_data_size = 0; + void* data_offset; + size_t data_size; + + data_size = buf->size - sizeof(struct elog_header); + data_offset = buf->data + sizeof(struct elog_header); + + /* Must have at least size for event + data + checksum */ + if (data_size < sizeof(struct event_header) + sizeof(used_data_size) + 1) + return ELOGTOOL_EXIT_INVALID_ELOG_FORMAT; + + /* + * Calculate the size of the "used" buffer, needed for ELOG_TYPE_LOG_CLEAR. + * Then overwritte the entire buffer with ELOG_TYPE_EOL. + * Finally insert a LOG_CLEAR event into the buffer. + */ + event = (const struct event_header *)(data_offset); + + while ((const char *)(event) < buf->data + buf->size) { + if (event->type == ELOG_TYPE_EOL || event->length == 0) + break; + + used_data_size += event->length; + event = elog_get_next_event(event); + } + + memset(data_offset, ELOG_TYPE_EOL, data_size); + + eventlog_init_event(data_offset, ELOG_TYPE_LOG_CLEAR, + &used_data_size, sizeof(used_data_size)); + + return ELOGTOOL_EXIT_SUCCESS; +} + +static int cmd_clear(void) +{ + int ret; + + /* Returned buffer must be freed. */ + struct buffer buf; + ret = elog_read(NULL, &buf); + if (ret != 0) + return ret; + + ret = elog_clear_events(&buf); + if (ret != 0) { + buffer_delete(&buf); + return ret; + } + + if (flashrom_write(FLASHROM_PROGRAMMER_INTERNAL_AP, "RW_ELOG", + (void *)buf.data, buf.size) != VB2_SUCCESS) { + + fprintf(stderr, + "Failed to write to RW_ELOG region using flashrom\n"); + ret = ELOGTOOL_EXIT_BAD_INPUT_PATH; + } + + buffer_delete(&buf); + return ret; +} int main(int argc, char **argv) { @@ -157,5 +230,8 @@ if (!strcmp(argv[optind], "list")) return cmd_list(input_file); + if (!strcmp(argv[optind], "clear")) + return cmd_clear(); + return ELOGTOOL_EXIT_SUCCESS; } diff --git a/util/cbfstool/eventlog.c b/util/cbfstool/eventlog.c index 2d99f92..67168c3 100644 --- a/util/cbfstool/eventlog.c +++ b/util/cbfstool/eventlog.c @@ -634,3 +634,31 @@ eventlog_printf_ignore_separator_once = 1; eventlog_printf("\n"); } + +/* + * Initializes the eventlog header with the given type and data, + * and calculates the checksum. + */ +void eventlog_init_event(struct event_header *event, uint8_t type, + const void *data, int data_size) +{ + time_t secs = time(NULL); + struct tm tm; + + event->type = type; + gmtime_r(&secs, &tm); + elog_fill_timestamp(event, tm.tm_sec, tm.tm_min, tm.tm_hour, + tm.tm_mday, tm.tm_mon, tm.tm_year); + + if (data && data) { + void *ptr = (uint32_t *) &event[1]; + memcpy(ptr, data, data_size); + } + + /* Header + data + checksum */ + event->length = sizeof(*event) + data_size + 1; + + /* Zero the checksum byte and then compute checksum */ + elog_update_checksum(event, 0); + elog_update_checksum(event, -(elog_checksum_event(event))); +} diff --git a/util/cbfstool/eventlog.h b/util/cbfstool/eventlog.h index baecb21..670a64e 100644 --- a/util/cbfstool/eventlog.h +++ b/util/cbfstool/eventlog.h @@ -3,8 +3,12 @@ #ifndef EVENTLOG_H_ #define EVENTLOG_H_ +#include <stdint.h> + struct event_header; void eventlog_print_event(const struct event_header *event, int count); +void eventlog_init_event(struct event_header* event, uint8_t type, + const void *data, int data_size); #endif // EVENTLOG_H_ -- To view, visit https://review.coreboot.org/c/coreboot/+/56883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia28a6eb34c82103ab078a0841b022e2e5e430585 Gerrit-Change-Number: 56883 Gerrit-PatchSet: 1 Gerrit-Owner: Ricardo Quesada <ricardoq(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: Add console deinit API, use in SMM handler
by Rocky Phagura (Code Review) 09 Aug '21

09 Aug '21

Attention is currently required from: Nico Huber, Jonathan Zhang, Johnny Lin, Paul Menzel, Christian Walter, Rocky Phagura, Angel Pons, Arthur Heymans, Kyösti Mälkki, Deomid "rojer" Ryabkov. Rocky Phagura has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56386 ) Change subject: Add console deinit API, use in SMM handler ...................................................................... Patch Set 11: Code-Review+1 (1 comment) Patchset: PS11: Confirmed to be working on DeltaLake and CraterLake platforms. -- To view, visit https://review.coreboot.org/c/coreboot/+/56386 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia5e51f385f83cb998c244ca1d1ffc10339d3a714 Gerrit-Change-Number: 56386 Gerrit-PatchSet: 11 Gerrit-Owner: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Rocky Phagura Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Rocky Phagura <rphagura(a)fb.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Attention: Deomid "rojer" Ryabkov <rojer9(a)fb.com> Gerrit-Comment-Date: Mon, 09 Aug 2021 16:28:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/soc/tgl: Unselect MICROCODE_BLOB_UNDISCLOSED
by Tim Crawford (Code Review) 09 Aug '21

09 Aug '21

Tim Crawford has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/56863 ) Change subject: src/soc/tgl: Unselect MICROCODE_BLOB_UNDISCLOSED ...................................................................... Abandoned Done in CB:56862 -- To view, visit https://review.coreboot.org/c/coreboot/+/56863 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibbe15f520b2602eb5a93aeb398cf5523414ab27b Gerrit-Change-Number: 56863 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: soc/intel/tgl: Add ucode for TGL-U and TGL-R
by Tim Crawford (Code Review) 09 Aug '21

09 Aug '21

Attention is currently required from: Felix Singer, Tim Wawrzynczak, Patrick Rudolph. Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56862 ) Change subject: soc/intel/tgl: Add ucode for TGL-U and TGL-R ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56862/comment/90b2593b_8c278d56 PS1, Line 7: soc/intel/tgl: Add ucode for TGL-U and TGL-R > +1 Done https://review.coreboot.org/c/coreboot/+/56862/comment/a4a1d09f_ac249a95 PS1, Line 12: > In combination with CB:56863, please verify that the microcode blob has been built into the CBFS. Confirmed that the blob is found in CBFS when booting darp7. -- To view, visit https://review.coreboot.org/c/coreboot/+/56862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I210c0133dad7ade63b9f7177aaa9a69b019469af Gerrit-Change-Number: 56862 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 09 Aug 2021 16:16:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common/block/spi: Don't update spi speed if EFS is changed
by Martin Roth (Code Review) 09 Aug '21

09 Aug '21

Attention is currently required from: Furquan Shaikh, Karthik Ramasubramanian, Felix Held. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56818 ) Change subject: soc/amd/common/block/spi: Don't update spi speed if EFS is changed ...................................................................... Patch Set 2: (1 comment) File src/soc/amd/common/block/spi/fch_spi.c: https://review.coreboot.org/c/coreboot/+/56818/comment/5133f80b_f63a1807 PS2, Line 84: if (CONFIG(EM100)) : fch_spi_config_em100_modes(); : else : fch_spi_config_mb_modes(); > ah, that's what you meant I think we're all in agreement that the EFS should be the basis for the speed and mode setting. That was something that I'd talked to felix about a few weeks back so that we could get rid of the structure in devicetree. (Or alternatively we update the sconfig code to create a separate header file and makefile-includable file which would allow us to use devicetree to set Makefile & pre-compiler values). Here's where I think we go from here: - Move 3 other 3 SPI speeds into Kconfig. - Add the code to use those 3 values instead of getting the values from devicetree. - Felix wanted to make sure that coreboot sets the SPI speed independently of having EFS set it, so read the values from EFS and re-program those. - Get rid of the current programming methods. Tentative: - Additionally add a Kconfig to allow coreboot to ignore EFS (EFS is in the RO section, so this would allow us to change away from those speeds if needed.) -- To view, visit https://review.coreboot.org/c/coreboot/+/56818 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I278768e361499919666d07e1dd92d83c2390035e Gerrit-Change-Number: 56818 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Marvin Drees <marvin.drees(a)9elements.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Mon, 09 Aug 2021 16:15:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/tgl: Add ucode for TGL-U and TGL-R
by Tim Crawford (Code Review) 09 Aug '21

09 Aug '21

Attention is currently required from: Felix Singer, Tim Crawford, Patrick Rudolph. Hello Felix Singer, build bot (Jenkins), Tim Wawrzynczak, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56862 to look at the new patch set (#2). Change subject: soc/intel/tgl: Add ucode for TGL-U and TGL-R ...................................................................... soc/intel/tgl: Add ucode for TGL-U and TGL-R Add microcode from 3rdparty repo for: - 06-8c-01 (CPUID signature: 0x806c1) - 06-8c-02 (CPUID signature: 0x806c2) Verified microcode blob was found in CBFS on system76/darp7 (TGL-U). Change-Id: I210c0133dad7ade63b9f7177aaa9a69b019469af Signed-off-by: Tim Crawford <tcrawford(a)system76.com> --- M src/soc/intel/tigerlake/Kconfig M src/soc/intel/tigerlake/Makefile.inc 2 files changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/56862/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I210c0133dad7ade63b9f7177aaa9a69b019469af Gerrit-Change-Number: 56862 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/tgl: Add ucode for TGL-U and TGL-R
by Tim Wawrzynczak (Code Review) 09 Aug '21

09 Aug '21

Attention is currently required from: Felix Singer, Tim Crawford, Patrick Rudolph. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56862 ) Change subject: soc/intel/tgl: Add ucode for TGL-U and TGL-R ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56862/comment/be2cd048_237b6f16 PS1, Line 7: soc/intel/tgl: Add ucode for TGL-U and TGL-R > I think you can squash CB:56863 into this one. +1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56862 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I210c0133dad7ade63b9f7177aaa9a69b019469af Gerrit-Change-Number: 56862 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 09 Aug 2021 15:33:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: arch/x86: smbios write 7 table using deterministic cache functions
by Tim Wawrzynczak (Code Review) 09 Aug '21

09 Aug '21

Attention is currently required from: Furquan Shaikh, Subrata Banik, Angel Pons. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56121 ) Change subject: arch/x86: smbios write 7 table using deterministic cache functions ...................................................................... Patch Set 8: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56121 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iedbd3b745629dea57c3ad6b0d187eab2bcc3f7d3 Gerrit-Change-Number: 56121 Gerrit-PatchSet: 8 Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Mon, 09 Aug 2021 15:30:19 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variant/taeko: Update devicetree settings
by Tim Wawrzynczak (Code Review) 09 Aug '21

09 Aug '21

Attention is currently required from: Joey Peng, Nick Vaccaro, YH Lin. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56802 ) Change subject: mb/google/brya/variant/taeko: Update devicetree settings ...................................................................... Patch Set 8: (1 comment) File src/mainboard/google/brya/variants/taeko/overridetree.cb: https://review.coreboot.org/c/coreboot/+/56802/comment/3b8b94da_33d293e6 PS8, Line 248: probe UFC UFC_USB fw_config is not defined yet for taeko, so this doesn't compile -- To view, visit https://review.coreboot.org/c/coreboot/+/56802 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I96aaf48284a226edc39115f870bf0f3dd83ab8b4 Gerrit-Change-Number: 56802 Gerrit-PatchSet: 8 Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com> Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Comment-Date: Mon, 09 Aug 2021 15:28:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021