Attention is currently required from: Paul Menzel.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56861 )
Change subject: 3rdparty/intel-microcode: Update submodule to 20210608 release
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56861/comment/c4804dac_e4dac3f7
PS1, Line 10:
> Is there anything specifically coreboot related that needs testing (and how)? […]
Well, coreboot reports a microcode revision that doesn't exist, at least on my CFL-H and CML-H boards. But that's not new. e.g., on oryp6,
Before this change:
microcode: sig=0xa0652 pf=0x20 revision=0xc7
After this change:
microcode: sig=0xa0652 pf=0x20 revision=0xe9
0xc7 and 0xc9
--
To view, visit https://review.coreboot.org/c/coreboot/+/56861
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I084ba67e8eaf7383f1c05fa5589b63c92ff900b1
Gerrit-Change-Number: 56861
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Mon, 09 Aug 2021 21:03:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Dtrain Hsu, Henry Sun, Shou-Chieh Hsu.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56870 )
Change subject: mb/google/dedede/var/cret: Fix DPTF passive and critical policies
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56870
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I849662cbb3adc8e528d65af2c90e7c8e4880d607
Gerrit-Change-Number: 56870
Gerrit-PatchSet: 1
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Mon, 09 Aug 2021 20:13:49 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Karthik Ramasubramanian has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56828 )
Change subject: mb/google/dedede/var/storo: Fixed iasl can not run on Dut
......................................................................
mb/google/dedede/var/storo: Fixed iasl can not run on Dut
The TSR1._PSV has been redefined.
It will report errors when disassembling the ACPI tables with the iasl.
It is OK when Removing the TSR1._PSV and adding the TSR0._PSV
BUG=b:194509417
BRANCH=dedede
TEST=The iasl can run on Dut successfully
Signed-off-by: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Change-Id: I524255c79d3c71573d122944da5058389f79d95d
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56828
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com>
Reviewed-by: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Reviewed-by: Evan Green <evgreen(a)chromium.org>
---
M src/mainboard/google/dedede/variants/storo/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Sumeet R Pawnikar: Looks good to me, approved
Evan Green: Looks good to me, approved
Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/mainboard/google/dedede/variants/storo/overridetree.cb b/src/mainboard/google/dedede/variants/storo/overridetree.cb
index aedb285..90ad9ad 100644
--- a/src/mainboard/google/dedede/variants/storo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/storo/overridetree.cb
@@ -86,7 +86,7 @@
chip drivers/intel/dptf
## Passive Policy
register "policies.passive" = "{
- [0] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 67, 3000),
+ [0] = DPTF_PASSIVE(CPU, TEMP_SENSOR_0, 67, 3000),
[1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 67, 3000),
[2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_1, 67, 3000),}"
## Critical Policy
--
To view, visit https://review.coreboot.org/c/coreboot/+/56828
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I524255c79d3c71573d122944da5058389f79d95d
Gerrit-Change-Number: 56828
Gerrit-PatchSet: 2
Gerrit-Owner: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Evan Green <evgreen(a)chromium.org>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Edward Dai <edwarddai(a)google.com>
Gerrit-CC: Jinfang Mao <maojinfang(a)huaqin.corp-partner.google.com>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-CC: zanxi chen <chenzanxi(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: merged
Attention is currently required from: Tim Crawford, Jeremy Soller.
Hello build bot (Jenkins), Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52349
to look at the new patch set (#7).
Change subject: mb/system76/darp7: Add System76 Darter Pro 7
......................................................................
mb/system76/darp7: Add System76 Darter Pro 7
https://tech-docs.system76.com/models/darp7/README.html
Tested with TianoCore (UefiPayloadPkg).
Working:
- PS/2 keyboard, touchpad
- Both DIMM slots
- M.2 NVMe SSD
- M.2 SATA SSD
- All USB ports
- USB-PD
- Webcam
- Ethernet
- Integrated graphics using Intel GOP driver
- HDMI output
- DP over USB-C output
- Internal microphone
- Internal speakers
- Combined headphone + mic 3.5mm jack
- Booting to Ubuntu Linux 21.04 and Windows 10
Not working:
- S0ix (no PC10 residency)
- Flashing with flashrom (chipset not supported)
Not tested:
- Thunderbolt functionality
Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Signed-off-by: Jeremy Soller <jeremy(a)system76.com>
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/system76/darp7.md
A src/mainboard/system76/darp7/Kconfig
A src/mainboard/system76/darp7/Kconfig.name
A src/mainboard/system76/darp7/Makefile.inc
A src/mainboard/system76/darp7/acpi/mainboard.asl
A src/mainboard/system76/darp7/acpi/sleep.asl
A src/mainboard/system76/darp7/board_info.txt
A src/mainboard/system76/darp7/bootblock.c
A src/mainboard/system76/darp7/data.vbt
A src/mainboard/system76/darp7/devicetree.cb
A src/mainboard/system76/darp7/dsdt.asl
A src/mainboard/system76/darp7/gpio.h
A src/mainboard/system76/darp7/hda_verb.c
A src/mainboard/system76/darp7/ramstage.c
A src/mainboard/system76/darp7/romstage.c
16 files changed, 883 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/52349/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/52349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Gerrit-Change-Number: 52349
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jeremy Soller.
Hello build bot (Jenkins), Jeremy Soller,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52349
to look at the new patch set (#6).
Change subject: mb/system76/darp7: Add System76 Darter Pro 7
......................................................................
mb/system76/darp7: Add System76 Darter Pro 7
https://tech-docs.system76.com/models/darp7/README.html
Tested with TianoCore (UefiPayloadPkg).
Working:
- PS/2 keyboard, touchpad
- Both DIMM slots
- M.2 NVMe SSD
- M.2 SATA SSD
- All USB ports
- USB-PD
- Webcam
- Ethernet
- Integrated graphics using Intel GOP driver
- HDMI output
- DP over USB-C output
- Internal microphone
- Internal speakers
- Combined headphone + mic 3.5mm jack
- Booting to Ubuntu Linux 21.04 and Windows 10
Not working:
- S0ix (no PC10 residency)
- Flashing with flashrom (chipset not supported)
Not tested:
- Thunderbolt functionality
Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Signed-off-by: Jeremy Soller <jeremy(a)system76.com>
Signed-off-by: Tim Crawford <tcrawford(a)system76.com>
---
M Documentation/mainboard/index.md
A Documentation/mainboard/system76/darp7.md
A src/mainboard/system76/darp7/Kconfig
A src/mainboard/system76/darp7/Kconfig.name
A src/mainboard/system76/darp7/Makefile.inc
A src/mainboard/system76/darp7/acpi/mainboard.asl
A src/mainboard/system76/darp7/acpi/sleep.asl
A src/mainboard/system76/darp7/board_info.txt
A src/mainboard/system76/darp7/bootblock.c
A src/mainboard/system76/darp7/data.vbt
A src/mainboard/system76/darp7/devicetree.cb
A src/mainboard/system76/darp7/dsdt.asl
A src/mainboard/system76/darp7/gpio.h
A src/mainboard/system76/darp7/hda_verb.c
A src/mainboard/system76/darp7/ramstage.c
A src/mainboard/system76/darp7/romstage.c
16 files changed, 884 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/52349/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/52349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Gerrit-Change-Number: 52349
Gerrit-PatchSet: 6
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jeremy Soller.
Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52349 )
Change subject: mb/system76/darp7: Add System76 Darter Pro 7
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/52349
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I80e5c5375f9d3881fc89a45a91ba68ed2e104a93
Gerrit-Change-Number: 52349
Gerrit-PatchSet: 5
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Comment-Date: Mon, 09 Aug 2021 18:59:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56458 )
Change subject: soc/intel/alderlake: Set LpmStateEnableMask UPD
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56458
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5bb8b3671e78c5f2706db2d3a21b25cf90a14275
Gerrit-Change-Number: 56458
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Mon, 09 Aug 2021 18:50:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment