coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: mb/google/brya: Fix idle S0ix due to dynamic GPIO PM disabled
by Meera Ravindranath (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak. Hello Maulik V Vaghela, Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56926 to look at the new patch set (#2). Change subject: mb/google/brya: Fix idle S0ix due to dynamic GPIO PM disabled ...................................................................... mb/google/brya: Fix idle S0ix due to dynamic GPIO PM disabled Change list: 1) Re-Enable dynamic GPIO PM 2) Select CR50_USE_LONG_INTERRUPT_PULSES to avoid CR50 IRQ short pulse issue Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com> Change-Id: I0c7b66b5514d8b80775ab7578ce7b12181af7882 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb 2 files changed, 1 insertion(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/56926/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c7b66b5514d8b80775ab7578ce7b12181af7882 Gerrit-Change-Number: 56926 Gerrit-PatchSet: 2 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Fix idle S0ix
by Meera Ravindranath (Code Review) 12 Aug '21

12 Aug '21

Meera Ravindranath has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56926 ) Change subject: mb/google/brya: Fix idle S0ix ...................................................................... mb/google/brya: Fix idle S0ix Change list: 1) Re-Enable dynamic GPIO PM 2) Select CR50_USE_LONG_INTERRUPT_PULSES to avoid CR50 IRQ short pulse issue Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com> Change-Id: I0c7b66b5514d8b80775ab7578ce7b12181af7882 --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb 2 files changed, 1 insertion(+), 11 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/56926/1 diff --git a/src/mainboard/google/brya/Kconfig b/src/mainboard/google/brya/Kconfig index 9279f4b..e398fd2 100644 --- a/src/mainboard/google/brya/Kconfig +++ b/src/mainboard/google/brya/Kconfig @@ -11,6 +11,7 @@ config BOARD_GOOGLE_BRYA_COMMON def_bool y select BOARD_ROMSIZE_KB_32768 + select CR50_USE_LONG_INTERRUPT_PULSES select DRIVERS_GENERIC_MAX98357A select DRIVERS_I2C_GENERIC select DRIVERS_I2C_HID diff --git a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb index 8a779bc..71967af 100644 --- a/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb +++ b/src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb @@ -22,17 +22,6 @@ # Enable heci communication register "HeciEnabled" = "1" - # This disabled autonomous GPIO power management, otherwise - # old cr50 FW only supports short pulses; need to clarify - # the minimum PCH IRQ pulse width with Intel, b/180111628 - register "gpio_override_pm" = "1" - register "gpio_pm[COMM_0]" = "0" - register "gpio_pm[COMM_1]" = "0" - register "gpio_pm[COMM_2]" = "0" - register "gpio_pm[COMM_3]" = "0" - register "gpio_pm[COMM_4]" = "0" - register "gpio_pm[COMM_5]" = "0" - # Enable CNVi BT register "CnviBtCore" = "true" -- To view, visit https://review.coreboot.org/c/coreboot/+/56926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0c7b66b5514d8b80775ab7578ce7b12181af7882 Gerrit-Change-Number: 56926 Gerrit-PatchSet: 1 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/intel/adlrvp: Update DIMM type as memory down for DDR5 MR SKU
by Maulik V Vaghela (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Meera Ravindranath. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56881 ) Change subject: mb/intel/adlrvp: Update DIMM type as memory down for DDR5 MR SKU ...................................................................... Patch Set 6: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56881 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b7a96b5534d8b80776aa7578ce7c13181af7882 Gerrit-Change-Number: 56881 Gerrit-PatchSet: 6 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Comment-Date: Thu, 12 Aug 2021 06:54:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/adlrvp: Rename spd_info struct based on memory topology
by Maulik V Vaghela (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Meera Ravindranath, Angel Pons. Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56899 ) Change subject: mb/intel/adlrvp: Rename spd_info struct based on memory topology ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56899 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I0b7a66b5524d8b80776ab7578ce7b13181af7882 Gerrit-Change-Number: 56899 Gerrit-PatchSet: 2 Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com> Gerrit-Attention: Angel Pons <angel.pons(a)9elements.com> Gerrit-Comment-Date: Thu, 12 Aug 2021 06:54:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede: add gooey variant
by Stanley Wu (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Henry Sun, Stanley Wu, Aseda Aboagye. Hello build bot (Jenkins), Henry Sun, Aseda Aboagye, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56858 to look at the new patch set (#7). Change subject: mb/google/dedede: add gooey variant ...................................................................... mb/google/dedede: add gooey variant gooey is the same design as boten, and differs only in replacing Cr50 with discrete TPM. BUG=b:193366710 TEST=FW_NAME=gooey emerge-keeby coreboot Signed-off-by: stanley.wu <stanley1.wu(a)lcfc.corp-partner.google.com> Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/gooey/Makefile.inc A src/mainboard/google/dedede/variants/gooey/gpio.c A src/mainboard/google/dedede/variants/gooey/include/variant/ec.h A src/mainboard/google/dedede/variants/gooey/include/variant/gpio.h A src/mainboard/google/dedede/variants/gooey/memory/Makefile.inc A src/mainboard/google/dedede/variants/gooey/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/gooey/memory/mem_list_variant.txt A src/mainboard/google/dedede/variants/gooey/overridetree.cb A src/mainboard/google/dedede/variants/gooey/variant.c 11 files changed, 479 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/56858/7 -- To view, visit https://review.coreboot.org/c/coreboot/+/56858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b Gerrit-Change-Number: 56858 Gerrit-PatchSet: 7 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede: add gooey variant
by Stanley Wu (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Henry Sun, Stanley Wu, Aseda Aboagye. Hello build bot (Jenkins), Henry Sun, Aseda Aboagye, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56858 to look at the new patch set (#6). Change subject: mb/google/dedede: add gooey variant ...................................................................... mb/google/dedede: add gooey variant gooey is the same design as boten, and differs only in replacing Cr50 with discrete TPM. BUG=b:193366710 TEST=FW_NAME=gooey emerge-keeby coreboot Signed-off-by: stanley.wu <stanley1.wu(a)lcfc.corp-partner.google.com> Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/gooey/Makefile.inc A src/mainboard/google/dedede/variants/gooey/gpio.c A src/mainboard/google/dedede/variants/gooey/include/variant/ec.h A src/mainboard/google/dedede/variants/gooey/include/variant/gpio.h A src/mainboard/google/dedede/variants/gooey/memory/Makefile.inc A src/mainboard/google/dedede/variants/gooey/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/gooey/memory/mem_list_variant.txt A src/mainboard/google/dedede/variants/gooey/overridetree.cb A src/mainboard/google/dedede/variants/gooey/variant.c 11 files changed, 479 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/56858/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/56858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b Gerrit-Change-Number: 56858 Gerrit-PatchSet: 6 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede: add gooey variant
by Stanley Wu (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Henry Sun, Stanley Wu, Aseda Aboagye. Hello build bot (Jenkins), Henry Sun, Aseda Aboagye, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56858 to look at the new patch set (#5). Change subject: mb/google/dedede: add gooey variant ...................................................................... mb/google/dedede: add gooey variant gooey is the same design as boten, and differs only in replacing Cr50 with discrete TPM. BUG=b:193366710 TEST=FW_NAME=gooey emerge-keeby coreboot Signed-off-by: stanley.wu <stanley1.wu(a)lcfc.corp-partner.google.com> Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/gooey/Makefile.inc A src/mainboard/google/dedede/variants/gooey/gpio.c A src/mainboard/google/dedede/variants/gooey/include/variant/ec.h A src/mainboard/google/dedede/variants/gooey/include/variant/gpio.h A src/mainboard/google/dedede/variants/gooey/memory/Makefile.inc A src/mainboard/google/dedede/variants/gooey/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/gooey/memory/mem_list_variant.txt A src/mainboard/google/dedede/variants/gooey/overridetree.cb A src/mainboard/google/dedede/variants/gooey/variant.c 11 files changed, 479 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/56858/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/56858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b Gerrit-Change-Number: 56858 Gerrit-PatchSet: 5 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede: add gooey variant
by Stanley Wu (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Henry Sun, Stanley Wu, Aseda Aboagye. Hello build bot (Jenkins), Henry Sun, Aseda Aboagye, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56858 to look at the new patch set (#4). Change subject: mb/google/dedede: add gooey variant ...................................................................... mb/google/dedede: add gooey variant gooey is the same design as boten, and differs only in replacing Cr50 with discrete TPM. BUG=b:193366710 TEST=FW_NAME=gooey emerge-keeby coreboot Signed-off-by: stanley.wu <stanley1.wu(a)lcfc.corp-partner.google.com> Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b --- M src/mainboard/google/dedede/Kconfig M src/mainboard/google/dedede/Kconfig.name A src/mainboard/google/dedede/variants/gooey/Makefile.inc A src/mainboard/google/dedede/variants/gooey/gpio.c A src/mainboard/google/dedede/variants/gooey/include/variant/ec.h A src/mainboard/google/dedede/variants/gooey/include/variant/gpio.h A src/mainboard/google/dedede/variants/gooey/memory/Makefile.inc A src/mainboard/google/dedede/variants/gooey/memory/dram_id.generated.txt A src/mainboard/google/dedede/variants/gooey/memory/mem_list_variant.txt A src/mainboard/google/dedede/variants/gooey/overridetree.cb A src/mainboard/google/dedede/variants/gooey/variant.c 11 files changed, 479 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/56858/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/56858 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b Gerrit-Change-Number: 56858 Gerrit-PatchSet: 4 Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com> Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com> Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com> Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/variants/primus: config G2 touchscreen
by Casper Chang (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Tim Wawrzynczak, Casper Chang. Hello build bot (Jenkins), Tim Wawrzynczak, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56923 to look at the new patch set (#2). Change subject: mb/google/brya/variants/primus: config G2 touchscreen ...................................................................... mb/google/brya/variants/primus: config G2 touchscreen modify reset_gpio as active low to meet touchscreen spec BUG=b:195490284 BRANCH=none TEST=build coreboot and touchscreen works Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Change-Id: I7ce1b3025db8abebf5693b34da846a7e969246fb --- M src/mainboard/google/brya/variants/primus/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/56923/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56923 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7ce1b3025db8abebf5693b34da846a7e969246fb Gerrit-Change-Number: 56923 Gerrit-PatchSet: 2 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8192: initialize DFD
by Rex-BC Chen (Code Review) 12 Aug '21

12 Aug '21

Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56797 ) Change subject: soc/mediatek/mt8192: initialize DFD ...................................................................... Patch Set 4: (2 comments) File src/soc/mediatek/mt8192/Kconfig: https://review.coreboot.org/c/coreboot/+/56797/comment/a008f83c_4e352f63 PS4, Line 70: This option enables DFD (Design for Debug) settings. > maybe add some description like commit message in future version . Done File src/soc/mediatek/mt8192/dfd.c: https://review.coreboot.org/c/coreboot/+/56797/comment/3a988e8b_7419851d PS4, Line 9: printk(BIOS_INFO, "[%s]\n", __func__); > maybe add more message like "dfd initialize" in future version. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56797 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I39a4391c1d1e832d77b709f8f899bb1c6dcacd69 Gerrit-Change-Number: 56797 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Thu, 12 Aug 2021 05:10:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021