Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, Meera Ravindranath.
Hello build bot (Jenkins), Maulik V Vaghela, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56926
to look at the new patch set (#3).
Change subject: mb/google/brya: Fix Idle S0ix issue due to dynamic GPIO PM disabled
......................................................................
mb/google/brya: Fix Idle S0ix issue due to dynamic GPIO PM disabled
Change list:
1) Re-Enable dynamic GPIO PM
2) Select CR50_USE_LONG_INTERRUPT_PULSES to avoid CR50 IRQ short pulse issue
Signed-off-by: Meera Ravindranath <meera.ravindranath(a)intel.com>
Change-Id: I0c7b66b5514d8b80775ab7578ce7b12181af7882
---
M src/mainboard/google/brya/Kconfig
M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
2 files changed, 1 insertion(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/56926/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56926
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c7b66b5514d8b80775ab7578ce7b12181af7882
Gerrit-Change-Number: 56926
Gerrit-PatchSet: 3
Gerrit-Owner: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56928
to look at the new patch set (#3).
Change subject: mb/google/poppy/variants/atlas: stop setting touchscreen probed=1
......................................................................
mb/google/poppy/variants/atlas: stop setting touchscreen probed=1
This allows the touchscreen ACPI device in Linux to re-enumerate when
rebinding its I2C adapter device.
BUG=b:177350937
TEST=With Atlas DUT running CrOS top-of-tree build, tested new RW and
new RO+RW built with this change applied in Atlas CrOS firmware branch.
Without this change, after rebinding the touchscreen's I2C adapter
device using sysfs, the touchscreen ACPI and HID devices are absent, and
the touchscreen is unresponsive.
With this change, the touchscreen ACPI and HID devices are re-created
after rebinding its I2C adapter device, and the touchscreen becomes
responsive again.
Signed-off-by: Matthew Blecker <matthewb(a)chromium.org>
Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
---
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/56928/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
Gerrit-Change-Number: 56928
Gerrit-PatchSet: 3
Gerrit-Owner: Matthew Blecker <matthewb(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56928
to look at the new patch set (#2).
Change subject: mb/google/poppy/variants/atlas: remove probed=1 from touchscreen
......................................................................
mb/google/poppy/variants/atlas: remove probed=1 from touchscreen
This allows the touchscreen ACPI device in Linux to re-enumerate when
re-binding its I2C adapter device.
BUG=b:177350937
TEST=With Atlas DUT running CrOS top-of-tree build, tested new RW and
new RO+RW built with this change applied in Atlas CrOS firmware branch.
Without this change, after re-binding the touchscreen's I2C adapter
device using sysfs, the touchscreen ACPI and HID devices are absent, and
the touchscreen is unresponsive.
With this change, the touchscreen ACPI and HID devices are re-created
after re-binding its I2C adapter device, and the touchscreen becomes
responsive again.
Signed-off-by: Matthew Blecker <matthewb(a)chromium.org>
Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
---
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/56928/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
Gerrit-Change-Number: 56928
Gerrit-PatchSet: 2
Gerrit-Owner: Matthew Blecker <matthewb(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: newpatchset
Matthew Blecker has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56928 )
Change subject: mainboard/google/poppy/variants/atlas: Stop setting touchscreen probed=1
......................................................................
mainboard/google/poppy/variants/atlas: Stop setting touchscreen probed=1
This allows the touchscreen ACPI device in Linux to re-enumerate when
re-binding its I2C adapter device.
BUG=b:177350937
TEST=With Atlas DUT running CrOS top-of-tree build, tested new RW and
new RO+RW built with this change applied in Atlas CrOS firmware branch.
Without this change, after re-binding the touchscreen's I2C adapter
device using sysfs, the touchscreen ACPI and HID devices are absent, and
the touchscreen is unresponsive.
With this change, the touchscreen ACPI and HID devices are re-created
after re-binding its I2C adapter device, and the touchscreen becomes
responsive again.
Signed-off-by: Matthew Blecker <matthewb(a)chromium.org>
Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
---
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/56928/1
diff --git a/src/mainboard/google/poppy/variants/atlas/devicetree.cb b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
index e779ae4..4319948 100644
--- a/src/mainboard/google/poppy/variants/atlas/devicetree.cb
+++ b/src/mainboard/google/poppy/variants/atlas/devicetree.cb
@@ -273,7 +273,6 @@
register "generic.desc" = ""STM Touchscreen""
register "generic.irq" = "ACPI_IRQ_LEVEL_LOW(GPP_E7_IRQ)"
register "generic.speed" = "I2C_SPEED_FAST"
- register "generic.probed" = "1"
register "generic.has_power_resource" = "1"
register "generic.disable_gpio_export_in_crs" = "1"
register "generic.enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_C22)"
--
To view, visit https://review.coreboot.org/c/coreboot/+/56928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
Gerrit-Change-Number: 56928
Gerrit-PatchSet: 1
Gerrit-Owner: Matthew Blecker <matthewb(a)chromium.org>
Gerrit-MessageType: newchange
Attention is currently required from: Zhi7 Li.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56927
to look at the new patch set (#3).
Change subject: src/drivers/i2c: Add rt5682 driver for codec ALC5682I-VD & VS compatibility
......................................................................
src/drivers/i2c: Add rt5682 driver for codec ALC5682I-VD & VS compatibility
For codec ALC5682I-VD & VS compatibility,add a new driver to dynamically report HID instead of using generic i2c driver.
BUG=b:193623380
BRANCH=dedede
TEST=With the new driver added,verify the codec ALC5682I-VD or VS works normally.
Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com>
Change-Id: Iba55accb5b8cafbdd08045aef0e3125606c0120d
---
A src/drivers/i2c/rt5682/Kconfig
A src/drivers/i2c/rt5682/Makefile.inc
A src/drivers/i2c/rt5682/chip.h
A src/drivers/i2c/rt5682/rt5682.c
4 files changed, 305 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/56927/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56927
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba55accb5b8cafbdd08045aef0e3125606c0120d
Gerrit-Change-Number: 56927
Gerrit-PatchSet: 3
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Zhi7 Li has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/56927 )
Change subject: src/drivers/i2c: Add rt5682 driver for codec ALC5682I-VD & VS compatibility
......................................................................
src/drivers/i2c: Add rt5682 driver for codec ALC5682I-VD & VS compatibility
For codec ALC5682I-VD & VS compatibility,add a new driver to dynamically report HID instead of using generic i2c driver.
BUG=193623380
BRANCH=dedede
TEST=With the new driver added,verify the codec ALC5682I-VD or VS works normally.
Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com>
Change-Id: Iba55accb5b8cafbdd08045aef0e3125606c0120d
---
A src/drivers/i2c/rt5682/Kconfig
A src/drivers/i2c/rt5682/Makefile.inc
A src/drivers/i2c/rt5682/chip.h
A src/drivers/i2c/rt5682/rt5682.c
4 files changed, 305 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/56927/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56927
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba55accb5b8cafbdd08045aef0e3125606c0120d
Gerrit-Change-Number: 56927
Gerrit-PatchSet: 2
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Marco Chen.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 )
Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/octopus/variants/phaser/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56380/comment/bcf44e3f_393b7d5e
PS4, Line 153: register "irq" = "ACPI_IRQ_LEVEL_LOW(GPIO_212_IRQ)"
> Have a question in the issue tracker to check whether this change will impact current Elan touchscre […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3
Gerrit-Change-Number: 56380
Gerrit-PatchSet: 5
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alec Wang <alec.wang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Marco Chen <marcochen(a)google.com>
Gerrit-Attention: Marco Chen <marcochen(a)chromium.org>
Gerrit-Comment-Date: Thu, 12 Aug 2021 07:22:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marco Chen <marcochen(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Marco Chen.
Joey Peng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 )
Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level
......................................................................
Patch Set 5:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56380/comment/7e5da890_b3fdb6a8
PS4, Line 2: joey.peng
> Please use Joey Peng.
Done
https://review.coreboot.org/c/coreboot/+/56380/comment/94f225c2_b854b39f
PS4, Line 14:
> The commit above is for G2Touch not for Elan so might not be relevant. […]
According to Marco's comment, change this comment to resolved
https://review.coreboot.org/c/coreboot/+/56380/comment/234fd799_1de5fc0e
PS4, Line 16: TEST=Build coreboot and check that device works
> Did the touchpad work before that change?
We never used Elan touchpad.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3
Gerrit-Change-Number: 56380
Gerrit-PatchSet: 5
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alec Wang <alec.wang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Marco Chen <marcochen(a)google.com>
Gerrit-Attention: Marco Chen <marcochen(a)chromium.org>
Gerrit-Comment-Date: Thu, 12 Aug 2021 07:22:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Marco Chen <marcochen(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Joey Peng, Paul Menzel, Marco Chen.
Hello build bot (Jenkins), Henry Sun, Marco Chen, Marco Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56380
to look at the new patch set (#5).
Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level
......................................................................
mb/google/octopus/var/phaser: Change IRQ trigger method to level
The change from Synaptics S7817 to Elan 3915N and pin distribution
of touch IC is the same.
According to vendor spec definition IRQ trigger method needs to
change to level.
BUG=b:190574692
TEST=Build coreboot and check that device works
Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3
Signed-off-by: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
---
M src/mainboard/google/octopus/variants/phaser/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/80/56380/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/56380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3
Gerrit-Change-Number: 56380
Gerrit-PatchSet: 5
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alec Wang <alec.wang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Marco Chen <marcochen(a)chromium.org>
Gerrit-MessageType: newpatchset