Attention is currently required from: Zhi7 Li.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56929 )
Change subject: src/drivers/i2c: Add rt5682 driver for codec ALC5682I-VD & VS compatibility
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56929/comment/28aeac78_fe9daf27
PS1, Line 9: For codec ALC5682I-VD & VS compatibility, add a new driver to dynamically report HID instead of using generic i2c driver.
Please reflow for 75 characters per line.
https://review.coreboot.org/c/coreboot/+/56929/comment/b855bba5_de168fa0
PS1, Line 10:
Please mention the datasheet name and revision.
File src/drivers/i2c/rt5682/rt5682.c:
PS1:
What is the difference to `src/drivers/i2c/rt5663/`? Could code be shared?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56929
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6d0a73d5fdef09df33e8a6feab34bcf14eb46d8a
Gerrit-Change-Number: 56929
Gerrit-PatchSet: 1
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:26:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Matthew Blecker.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56928 )
Change subject: mb/google/poppy/variants/atlas: stop setting touchscreen probed=1
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56928/comment/78746f37_b0bfcb56
PS3, Line 9: Linux
Which Linux version did you test with?
https://review.coreboot.org/c/coreboot/+/56928/comment/142ac70a_e2bfa3f8
PS3, Line 16: Without this change, after rebinding the touchscreen's I2C adapter
: device using sysfs, the touchscreen ACPI and HID devices are absent, and
: the touchscreen is unresponsive.
Nit: I’d start the commit message body with the detailed problem description.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
Gerrit-Change-Number: 56928
Gerrit-PatchSet: 4
Gerrit-Owner: Matthew Blecker <matthewb(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Matthew Blecker <matthewb(a)chromium.org>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:23:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Raul Rangel, Martin Roth, Marshall Dawson, Karthik Ramasubramanian, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56919 )
Change subject: soc/amd/common: Skip psp_verstage on S0i3 resume
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56919/comment/ea223e92_bb4d55a8
PS1, Line 8:
Please add a reasoning, why psp_verstage is not needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56919
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia7b2560ff3d7621922ec4bc0e8793961f5d7550f
Gerrit-Change-Number: 56919
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:22:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Matthew Blecker.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56928
to look at the new patch set (#4).
Change subject: mb/google/poppy/variants/atlas: stop setting touchscreen probed=1
......................................................................
mb/google/poppy/variants/atlas: stop setting touchscreen probed=1
This allows the touchscreen ACPI device in Linux to re-enumerate when
rebinding its I2C adapter device.
BUG=b:177350937
TEST=With Atlas DUT running CrOS top-of-tree build, tested new RW and
new RO+RW built with this change applied in Atlas CrOS firmware branch.
Without this change, after rebinding the touchscreen's I2C adapter
device using sysfs, the touchscreen ACPI and HID devices are absent, and
the touchscreen is unresponsive.
With this change, the touchscreen ACPI and HID devices are re-created
after rebinding its I2C adapter device, and the touchscreen becomes
responsive again.
Test sequence:
1) Boot DUT, verify basic touchscreen functionality.
2) $ cd /sys/bus/platform/drivers/i2c_designware
3) $ ls -ld i2c_designware.0{,/i2c-6{,/i2c-ACPI0C50:00{,/0018:0483:1058.*{,/hidraw{,/hidraw*}}}}}
lrwxrwxrwx. 1 root root 0 Aug 12 01:07 i2c_designware.0 -> ../../../../devices/pci0000:00/0000:00:15.0/i2c_designware.0
drwxr-xr-x. 5 root root 0 Aug 12 01:07 i2c_designware.0/i2c-6
drwxr-xr-x. 4 root root 0 Aug 12 01:07 i2c_designware.0/i2c-6/i2c-ACPI0C50:00
drwxr-xr-x. 5 root root 0 Aug 12 01:07 i2c_designware.0/i2c-6/i2c-ACPI0C50:00/0018:0483:1058.0002
drwxr-xr-x. 3 root root 0 Aug 12 01:07 i2c_designware.0/i2c-6/i2c-ACPI0C50:00/0018:0483:1058.0002/hidraw
drwxr-xr-x. 3 root root 0 Aug 12 01:07 i2c_designware.0/i2c-6/i2c-ACPI0C50:00/0018:0483:1058.0002/hidraw/hidraw1
4) $ echo i2c_designware.0 > unbind
5) Verify touchscreen is unresponsive.
6) $ ls -ld i2c_designware.0
ls: cannot access 'i2c_designware.0': No such file or directory
7) $ echo i2c_designware.0 > bind
*** Without this change: ***
8) Touchscreen remains unresponsive.
9) $ ls -ld i2c_designware.0{,/i2c-6{,/i2c-ACPI0C50:00}}
ls: cannot access 'i2c_designware.0/i2c-6/i2c-ACPI0C50:00': No such file or directory
lrwxrwxrwx. 1 root root 0 Aug 12 01:18 i2c_designware.0 -> ../../../../devices/pci0000:00/0000:00:15.0/i2c_designware.0
drwxr-xr-x. 4 root root 0 Aug 12 01:18 i2c_designware.0/i2c-6
*** With this change: ***
8) Touchscreen is functional again.
9) $ ls -ld i2c_designware.0{,/i2c-6{,/i2c-ACPI0C50:00{,/0018:0483:1058.*{,/hidraw{,/hidraw*}}}}}
lrwxrwxrwx. 1 root root 0 Aug 12 01:09 i2c_designware.0 -> ../../../../devices/pci0000:00/0000:00:15.0/i2c_designware.0
drwxr-xr-x. 5 root root 0 Aug 12 01:09 i2c_designware.0/i2c-6
drwxr-xr-x. 4 root root 0 Aug 12 01:09 i2c_designware.0/i2c-6/i2c-ACPI0C50:00
drwxr-xr-x. 5 root root 0 Aug 12 01:09 i2c_designware.0/i2c-6/i2c-ACPI0C50:00/0018:0483:1058.0003
drwxr-xr-x. 3 root root 0 Aug 12 01:09 i2c_designware.0/i2c-6/i2c-ACPI0C50:00/0018:0483:1058.0003/hidraw
drwxr-xr-x. 3 root root 0 Aug 12 01:09 i2c_designware.0/i2c-6/i2c-ACPI0C50:00/0018:0483:1058.0003/hidraw/hidraw1
Signed-off-by: Matthew Blecker <matthewb(a)chromium.org>
Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
---
M src/mainboard/google/poppy/variants/atlas/devicetree.cb
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/56928/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/56928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
Gerrit-Change-Number: 56928
Gerrit-PatchSet: 4
Gerrit-Owner: Matthew Blecker <matthewb(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Matthew Blecker <matthewb(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Raul Rangel, Martin Roth, Paul Fagerburg, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56921 )
Change subject: mb/google/guybrush: Create nipperkin variant
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56921/comment/bdac58b2_e5bff789
PS1, Line 12: (Auto-Generated by create_coreboot_variant.sh version 4.5.0).
Please put the dot/period before the ).
--
To view, visit https://review.coreboot.org/c/coreboot/+/56921
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie525ea501e6c3d5d94e67c1db1d4e307fb7ccba7
Gerrit-Change-Number: 56921
Gerrit-PatchSet: 1
Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:20:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Ravi kumar, Taniya Das, mturney mturney, Sudheer Amrabadi.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56587 )
Change subject: qualcomm/sc7180: Cleanups for drivers with common clock
......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56587/comment/3742eda1_ae93c46e
PS5, Line 7: Cleanups for drivers with common clock
Clean up drivers with common clock
--
To view, visit https://review.coreboot.org/c/coreboot/+/56587
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic334fd0d43e5b4b1e43a27d5db7665f0bc151d66
Gerrit-Change-Number: 56587
Gerrit-PatchSet: 5
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Reviewer: mturney mturney <mturney(a)codeaurora.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Ravi Kumar Bokka <c_rbokka(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Taniya Das <tdas(a)codeaurora.org>
Gerrit-Attention: mturney mturney <mturney(a)codeaurora.org>
Gerrit-Attention: Sudheer Amrabadi <samrabad(a)codeaurora.org>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:20:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Patrick Huang, Felix Held.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56895 )
Change subject: src/mainboard/google/guybrush/variants/baseboard: Set Clk request for WLAN/SD/WWAN/SSD device.
......................................................................
Patch Set 2:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56895/comment/bcb03a01_41b4d80d
PS2, Line 7: src/mainboard/google/guybrush/variants/baseboard
mb/google/guybrush/var/baseboard
https://review.coreboot.org/c/coreboot/+/56895/comment/49b54172_724b25a9
PS2, Line 9: deponds
depends
https://review.coreboot.org/c/coreboot/+/56895/comment/1ac5dc18_4e1459a6
PS2, Line 9: Set
Setting
https://review.coreboot.org/c/coreboot/+/56895/comment/c25f0b55_86afdb9b
PS2, Line 10: guybeush
guybrush
https://review.coreboot.org/c/coreboot/+/56895/comment/22d03df4_c5aed4c9
PS2, Line 9: Set the clock source deponds on clock request pin for WLAN/SD/SSD device. Also turn off the unused (4/5/6) clock sources.
: Currently in guybeush, clock source 0/1/2/3 are routed for WLAN/SD/WWAN/SSD device.
Please reflow for 75 characters per line.
https://review.coreboot.org/c/coreboot/+/56895/comment/cf9200ad_f9030267
PS2, Line 14: TEST:
TEST=
--
To view, visit https://review.coreboot.org/c/coreboot/+/56895
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I240543e92cbc178cee034c37d7c26da0a6bbb7f6
Gerrit-Change-Number: 56895
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Huang <patrick.huang(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Patrick Huang <patrick.huang(a)amd.corp-partner.google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:19:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Rob Barnes, Ivy Jian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56925 )
Change subject: mb/google/guybrush: update USB 2.0 Lane Parameter settings
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56925/comment/c3751cb4_abf34e5f
PS1, Line 7: mb/google/guybrush: update USB 2.0 Lane Parameter settings
Please mention port 5 in here.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1ede34bdbee0c1f9f7d10fc7ffbc9648af31e3e
Gerrit-Change-Number: 56925
Gerrit-PatchSet: 1
Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:17:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Malik Hsu, Tim Wawrzynczak, Casper Chang.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56923 )
Change subject: mb/google/brya/variants/primus: config G2 touchscreen
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56923/comment/74f5aba1_1eecf420
PS2, Line 9: touchscreen spec
Please add the name and revision of the spec.
https://review.coreboot.org/c/coreboot/+/56923/comment/fa7dbe49_6f4617a3
PS2, Line 13: TEST=build coreboot and touchscreen works
Before it didn’t?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56923
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ce1b3025db8abebf5693b34da846a7e969246fb
Gerrit-Change-Number: 56923
Gerrit-PatchSet: 2
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:17:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment