Attention is currently required from: Kedar J. Karanje, Furquan Shaikh, Tim Wawrzynczak, Sridhar Siricilla, Subrata Banik, Vinay Kumar, Ronak Kanabar, Patrick Rudolph, Baieswara Reddy Sagili.
V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56176 )
Change subject: soc/intel/alderlake: Update the VccIn Aux Imon IccMax for ADL
......................................................................
Patch Set 12:
(1 comment)
Patchset:
PS12:
> Does this still need to be private?
No, actually some private CL was rebased on top these CL's. These two are ready for merge.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56176
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6c159035cba781d3661a0a0cef16f9591a583912
Gerrit-Change-Number: 56176
Gerrit-PatchSet: 12
Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com>
Gerrit-Reviewer: Baieswara Reddy Sagili <baieswara.reddy.sagili(a)intel.com>
Gerrit-Reviewer: Kedar J. Karanje <kedar.j.karanje(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Reviewer: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Vinay Kumar <vinay.kumar(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Kedar J. Karanje <kedar.j.karanje(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Sridhar Siricilla <sridhar.siricilla(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Attention: Vinay Kumar <vinay.kumar(a)intel.com>
Gerrit-Attention: Ronak Kanabar <ronak.kanabar(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Baieswara Reddy Sagili <baieswara.reddy.sagili(a)intel.com>
Gerrit-Comment-Date: Thu, 12 Aug 2021 09:46:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Karthik Ramasubramanian.
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56858 )
Change subject: mb/google/dedede: add gooey variant
......................................................................
Patch Set 9:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56858/comment/8f4ee1d8_35efbc75
PS8, Line 10: in replacing Cr50 with discrete TPM.
> Please reflow for 75 characters per line.
Done
File src/mainboard/google/dedede/variants/gooey/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56858/comment/319c0f32_c147d93d
PS3, Line 18: .scl_lcnt = 190,
: .scl_hcnt = 100,
: .sda_hold = 40,
> The proto phase of Gooey project for debug and test from 8/23, and Gooey motherboard just shipment f […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56858
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b
Gerrit-Change-Number: 56858
Gerrit-PatchSet: 9
Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Thu, 12 Aug 2021 09:41:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Stanley Wu, Karthik Ramasubramanian.
Hello build bot (Jenkins), Henry Sun, Aseda Aboagye, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56858
to look at the new patch set (#9).
Change subject: mb/google/dedede: add gooey variant
......................................................................
mb/google/dedede: add gooey variant
gooey is the same design as boten, and differs only in replacing Cr50
with discrete TPM.
BUG=b:193366710
TEST=FW_NAME=gooey emerge-keeby coreboot
Signed-off-by: stanley.wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b
---
M src/mainboard/google/dedede/Kconfig
M src/mainboard/google/dedede/Kconfig.name
A src/mainboard/google/dedede/variants/gooey/Makefile.inc
A src/mainboard/google/dedede/variants/gooey/gpio.c
A src/mainboard/google/dedede/variants/gooey/include/variant/ec.h
A src/mainboard/google/dedede/variants/gooey/include/variant/gpio.h
A src/mainboard/google/dedede/variants/gooey/memory/Makefile.inc
A src/mainboard/google/dedede/variants/gooey/memory/dram_id.generated.txt
A src/mainboard/google/dedede/variants/gooey/memory/mem_list_variant.txt
A src/mainboard/google/dedede/variants/gooey/overridetree.cb
A src/mainboard/google/dedede/variants/gooey/variant.c
11 files changed, 479 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/58/56858/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/56858
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a54f872a7d5c0bee76a9e6e309613d9357b380b
Gerrit-Change-Number: 56858
Gerrit-PatchSet: 9
Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Zheng Bao, Felix Held.
Bao Zheng has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56773 )
Change subject: amdfwtool: Add support for A/B recovery
......................................................................
Patch Set 3:
(4 comments)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/56773/comment/3a854f50_1ad3970c
PS3, Line 614: break;
indent one more tab.
https://review.coreboot.org/c/coreboot/+/56773/comment/2a6980d8_7a687d87
PS3, Line 768: /* BIOS TABLE */
delete
https://review.coreboot.org/c/coreboot/+/56773/comment/49f74628_2b3ee5af
PS3, Line 1297: case PLATFORM_MENDOCINO
move to previous patch in the stack.
https://review.coreboot.org/c/coreboot/+/56773/comment/e50f5c00_809831a1
PS3, Line 1774: case PLATFORM_MENDOCINO:
move to previous patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56773
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I27f5d3476f648fcecafb8d258ccb6cfad4f50036
Gerrit-Change-Number: 56773
Gerrit-PatchSet: 3
Gerrit-Owner: Bao Zheng <fishbaozi(a)gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:51:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Caveh Jalali, Tim Wawrzynczak.
Matthew Blecker has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56928 )
Change subject: mb/google/poppy/variants/atlas: stop setting touchscreen probed=1
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
The Atlas touchscreen device has had generic.probed=1 since it was first added in https://review.coreboot.org/c/coreboot/+/27127 , however Caveh doesn't recall why (was 3 years ago). All Atlas have this touchscreen controller. Is there any reason to keep generic.probed=1?
Getting rid of generic.probed=1 (this CL) allows me to clean up the driver rebind sequence after touchscreen firmware update, which allows removing a hardcoded i2c_hid Linux driver name, which in turn completely avoids https://issuetracker.google.com/177350937 bug.
I vaguely recall noticing ~ 2 years ago that ACPI re-enumeration of this touchscreen controller didn't work, but I didn't do any digging for a fix, I just left in an existing workaround of hardcoding its Linux driver.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56928
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7b90690b0591e8748d7a007f8cc9688d393e59db
Gerrit-Change-Number: 56928
Gerrit-PatchSet: 4
Gerrit-Owner: Matthew Blecker <matthewb(a)chromium.org>
Gerrit-Reviewer: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Caveh Jalali <caveh(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:46:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Rob Barnes.
Ivy Jian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56925 )
Change subject: mb/google/guybrush: update USB 2.0 Lane Parameter settings for USB port5
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56925/comment/9be42864_a2593a5f
PS1, Line 7: mb/google/guybrush: update USB 2.0 Lane Parameter settings
> Please mention port 5 in here.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1ede34bdbee0c1f9f7d10fc7ffbc9648af31e3e
Gerrit-Change-Number: 56925
Gerrit-PatchSet: 2
Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Thu, 12 Aug 2021 08:43:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Rob Barnes, Ivy Jian.
Hello build bot (Jenkins), Rob Barnes,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56925
to look at the new patch set (#2).
Change subject: mb/google/guybrush: update USB 2.0 Lane Parameter settings for USB port5
......................................................................
mb/google/guybrush: update USB 2.0 Lane Parameter settings for USB port5
Tune the USB phy settings to update TXVREFTUNE0/COMPDISTUNE0 to
higher value for USB port 5 (Type-A).
BUG=b:194053549
TEST= Pass USB 2.0 SI Eye diagram measurement.
Signed-off-by: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Change-Id: Id1ede34bdbee0c1f9f7d10fc7ffbc9648af31e3e
---
M src/mainboard/google/guybrush/variants/baseboard/devicetree.cb
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/25/56925/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56925
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id1ede34bdbee0c1f9f7d10fc7ffbc9648af31e3e
Gerrit-Change-Number: 56925
Gerrit-PatchSet: 2
Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset