coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: mb/google/guybrush: Create nipperkin variant
by Bhanu Prakash Maiya (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Raul Rangel, Martin Roth, Paul Fagerburg, Karthik Ramasubramanian. Bhanu Prakash Maiya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56921 ) Change subject: mb/google/guybrush: Create nipperkin variant ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie525ea501e6c3d5d94e67c1db1d4e307fb7ccba7 Gerrit-Change-Number: 56921 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 12 Aug 2021 00:03:56 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/mb/google: add template files for guybrush
by Bhanu Prakash Maiya (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Paul Fagerburg, Karthik Ramasubramanian. Bhanu Prakash Maiya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56918 ) Change subject: util/mb/google: add template files for guybrush ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If62c1a63d0890539d4b43f840f75ee9d7ceab4f8 Gerrit-Change-Number: 56918 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 12 Aug 2021 00:03:43 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/mb/google: add template files for guybrush
by Paul Fagerburg (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Bhanu Prakash Maiya, Paul Fagerburg, Karthik Ramasubramanian. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56918 ) Change subject: util/mb/google: add template files for guybrush ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56918 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: If62c1a63d0890539d4b43f840f75ee9d7ceab4f8 Gerrit-Change-Number: 56918 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Paul Fagerburg <pfagerburg(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 12 Aug 2021 00:02:55 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Create nipperkin variant
by Karthik Ramasubramanian (Code Review) 12 Aug '21

12 Aug '21

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56921 ) Change subject: mb/google/guybrush: Create nipperkin variant ...................................................................... mb/google/guybrush: Create nipperkin variant Create the nipperkin variant of the guybrush reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=None BRANCH=None TEST=util/abuild/abuild -p none -t google/guybrush -x -a make sure the build includes GOOGLE_NIPPERKIN Signed-off-by: Karthikeyan Ramasubramanian <kramasub(a)google.com> Change-Id: Ie525ea501e6c3d5d94e67c1db1d4e307fb7ccba7 --- M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/guybrush/Kconfig.name A src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc A src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h A src/mainboard/google/guybrush/variants/nipperkin/include/variant/gpio.h A src/mainboard/google/guybrush/variants/nipperkin/memory/Makefile.inc A src/mainboard/google/guybrush/variants/nipperkin/memory/dram_id.generated.txt A src/mainboard/google/guybrush/variants/nipperkin/memory/mem_parts_used.txt A src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb 9 files changed, 39 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/56921/1 diff --git a/src/mainboard/google/guybrush/Kconfig b/src/mainboard/google/guybrush/Kconfig index 17cdada..2da9230 100644 --- a/src/mainboard/google/guybrush/Kconfig +++ b/src/mainboard/google/guybrush/Kconfig @@ -72,6 +72,7 @@ config MAINBOARD_PART_NUMBER default "Guybrush" if BOARD_GOOGLE_GUYBRUSH + default "Nipperkin" if BOARD_GOOGLE_NIPPERKIN config AMD_FWM_POSITION_INDEX int @@ -103,6 +104,7 @@ config VARIANT_DIR default "guybrush" if BOARD_GOOGLE_GUYBRUSH + default "nipperkin" if BOARD_GOOGLE_NIPPERKIN config DEVICETREE default "variants/baseboard/devicetree.cb" diff --git a/src/mainboard/google/guybrush/Kconfig.name b/src/mainboard/google/guybrush/Kconfig.name index 076516c..edddbf8 100644 --- a/src/mainboard/google/guybrush/Kconfig.name +++ b/src/mainboard/google/guybrush/Kconfig.name @@ -3,3 +3,7 @@ config BOARD_GOOGLE_GUYBRUSH bool "-> Guybrush" select BOARD_GOOGLE_BASEBOARD_GUYBRUSH + +config BOARD_GOOGLE_NIPPERKIN + bool "-> Nipperkin" + select BOARD_GOOGLE_BASEBOARD_GUYBRUSH diff --git a/src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc b/src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc new file mode 100644 index 0000000..88e75bd --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/Makefile.inc @@ -0,0 +1,3 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +subdirs-y += ./memory diff --git a/src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h b/src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h new file mode 100644 index 0000000..9e61a44 --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/include/variant/ec.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/ec.h> diff --git a/src/mainboard/google/guybrush/variants/nipperkin/include/variant/gpio.h b/src/mainboard/google/guybrush/variants/nipperkin/include/variant/gpio.h new file mode 100644 index 0000000..dfaeec3 --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/include/variant/gpio.h @@ -0,0 +1,3 @@ +/* SPDX-License-Identifier: GPL-2.0-or-later */ + +#include <baseboard/gpio.h> diff --git a/src/mainboard/google/guybrush/variants/nipperkin/memory/Makefile.inc b/src/mainboard/google/guybrush/variants/nipperkin/memory/Makefile.inc new file mode 100644 index 0000000..b0ca222 --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/memory/Makefile.inc @@ -0,0 +1,5 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! +## Add memory parts in mem_parts_used.txt and run spd_tools to regenerate. + +SPD_SOURCES = placeholder.spd.hex diff --git a/src/mainboard/google/guybrush/variants/nipperkin/memory/dram_id.generated.txt b/src/mainboard/google/guybrush/variants/nipperkin/memory/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/memory/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/src/mainboard/google/guybrush/variants/nipperkin/memory/mem_parts_used.txt b/src/mainboard/google/guybrush/variants/nipperkin/memory/mem_parts_used.txt new file mode 100644 index 0000000..8124e4f --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/memory/mem_parts_used.txt @@ -0,0 +1,11 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Generated IDs are dependent on the order of parts in this file, +# so new parts must always be added at the end of the file! +# +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/{ddr4,lp4x}. +# See util/spd_tools/{ddr4,lp4x}/README.md for more details and instructions. + +# Part Name, Fixed ID (optional) diff --git a/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb new file mode 100644 index 0000000..c182265 --- /dev/null +++ b/src/mainboard/google/guybrush/variants/nipperkin/overridetree.cb @@ -0,0 +1,7 @@ +# SPDX-License-Identifier: GPL-2.0-or-later + +chip soc/amd/cezanne + device domain 0 on + + end # domain +end # chip soc/amd/cezanne -- To view, visit https://review.coreboot.org/c/coreboot/+/56921 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie525ea501e6c3d5d94e67c1db1d4e307fb7ccba7 Gerrit-Change-Number: 56921 Gerrit-PatchSet: 1 Gerrit-Owner: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/common: Skip psp_verstage on S0i3 resume
by Furquan Shaikh (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Raul Rangel, Martin Roth, Marshall Dawson, Karthik Ramasubramanian, Felix Held. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56919 ) Change subject: soc/amd/common: Skip psp_verstage on S0i3 resume ...................................................................... Patch Set 1: (1 comment) File src/soc/amd/common/psp_verstage/psp_verstage.c: https://review.coreboot.org/c/coreboot/+/56919/comment/7b59e453_2e133ddb PS1, Line 205: Currently, we want to skip running verstage on all S0i3 resumes. This relies : on an assumption that the PSP will be checksumming all of its components. > Yes that is the eventual goal. We decided to introduce this change for 2 reasons: […] Thanks for the background, Karthik. Let's capture the motivation behind the change in commit message as well. Also, it would be good to add a TODO and b/???? here to ensure we track dropping of this workaround once PSP behavior is finalized. -- To view, visit https://review.coreboot.org/c/coreboot/+/56919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b2560ff3d7621922ec4bc0e8793961f5d7550f Gerrit-Change-Number: 56919 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 11 Aug 2021 23:48:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common: Skip psp_verstage on S0i3 resume
by Jason Glenesk (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Martin Roth, Marshall Dawson, Karthik Ramasubramanian, Felix Held. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56919 ) Change subject: soc/amd/common: Skip psp_verstage on S0i3 resume ...................................................................... Patch Set 1: Code-Review+1 (1 comment) File src/soc/amd/common/psp_verstage/psp_verstage.c: https://review.coreboot.org/c/coreboot/+/56919/comment/0a7310ae_d5ca015a PS1, Line 207: svc_get_boot_mode(&bootmode); > Preferably not. Please refer to the above comment. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b2560ff3d7621922ec4bc0e8793961f5d7550f Gerrit-Change-Number: 56919 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 11 Aug 2021 21:48:52 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Jason Glenesk <jason.glenesk(a)gmail.com> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/common: Skip psp_verstage on S0i3 resume
by Karthik Ramasubramanian (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Martin Roth, Marshall Dawson, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56919 ) Change subject: soc/amd/common: Skip psp_verstage on S0i3 resume ...................................................................... Patch Set 1: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56919/comment/a9fa8da5_9a4a506c PS1, Line 10: : = https://review.coreboot.org/c/coreboot/+/56919/comment/c9ed48fd_a1b07810 PS1, Line 10: S0i3 psp_verstage File src/soc/amd/common/psp_verstage/psp_verstage.c: https://review.coreboot.org/c/coreboot/+/56919/comment/e0e444cb_1fd4025e PS1, Line 205: Currently, we want to skip running verstage on all S0i3 resumes. This relies : on an assumption that the PSP will be checksumming all of its components. > If verstage must not run on S0i3 resume, then I would expect PSP BL to not load this component at al […] Yes that is the eventual goal. We decided to introduce this change for 2 reasons: 1) PSP release takes some time. 2) Also PSP team has been waiting on inputs on this bug: b/177064859 to avoid loading PSP verstage on S0i3. The concern is that PSP is loading lots of firmware components from SPI ROM on S0i3 resume This is an alternative approach until a consensus is reached on the above 2 factors. https://review.coreboot.org/c/coreboot/+/56919/comment/f83de323_5db2f1c2 PS1, Line 207: svc_get_boot_mode(&bootmode); > I think we are doing this in verstage because it was the shortest path. […] Preferably not. Please refer to the above comment. -- To view, visit https://review.coreboot.org/c/coreboot/+/56919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b2560ff3d7621922ec4bc0e8793961f5d7550f Gerrit-Change-Number: 56919 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 11 Aug 2021 21:44:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Jason Glenesk <jason.glenesk(a)gmail.com> Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/kahlee/treeya: Update Realtek ALC5682 codec SKU IDs
by Martin Roth (Code Review) 12 Aug '21

12 Aug '21

Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56920 ) Change subject: mb/google/kahlee/treeya: Update Realtek ALC5682 codec SKU IDs ...................................................................... mb/google/kahlee/treeya: Update Realtek ALC5682 codec SKU IDs Use SKU IDs 0xBE & 0xBF instead of 0xAE & 0xAF. BUG=b:185972050 TEST=build test only. Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: Ia1dab3a9bcd4b7f8281721346eb86dd556dfe0e1 --- M src/mainboard/google/kahlee/variants/treeya/audio.c M src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h 2 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/56920/1 diff --git a/src/mainboard/google/kahlee/variants/treeya/audio.c b/src/mainboard/google/kahlee/variants/treeya/audio.c index 8265298..ac69a9a 100644 --- a/src/mainboard/google/kahlee/variants/treeya/audio.c +++ b/src/mainboard/google/kahlee/variants/treeya/audio.c @@ -40,8 +40,8 @@ } switch (google_chromeec_get_sku_id()) { - case SKU_TREEYA_ALC5682_AE: - case SKU_TREEYA_ALC5682_AF: + case SKU_TREEYA_ALC5682_BE: + case SKU_TREEYA_ALC5682_BF: /* alc5682 only */ if (da7219_dev) da7219_dev->enabled = 0; diff --git a/src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h b/src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h index ff2b086..249b71d 100644 --- a/src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h +++ b/src/mainboard/google/kahlee/variants/treeya/include/variant/sku.h @@ -3,6 +3,6 @@ /* SKU ID enumeration */ enum treeya_sku { SKU_UNKNOWN = -1, - SKU_TREEYA_ALC5682_AE = 174, - SKU_TREEYA_ALC5682_AF = 175, + SKU_TREEYA_ALC5682_BE = 0xbe, + SKU_TREEYA_ALC5682_BF = 0xbf, }; -- To view, visit https://review.coreboot.org/c/coreboot/+/56920 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia1dab3a9bcd4b7f8281721346eb86dd556dfe0e1 Gerrit-Change-Number: 56920 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/common: Skip psp_verstage on S0i3 resume
by Jason Glenesk (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Raul Rangel, Martin Roth, Marshall Dawson, Felix Held. Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56919 ) Change subject: soc/amd/common: Skip psp_verstage on S0i3 resume ...................................................................... Patch Set 1: (1 comment) File src/soc/amd/common/psp_verstage/psp_verstage.c: https://review.coreboot.org/c/coreboot/+/56919/comment/edd95c9e_ba8ffd0d PS1, Line 207: svc_get_boot_mode(&bootmode); I think we are doing this in verstage because it was the shortest path. Are we going to keep it this way after the PSP implements their fix not to load during resume? -- To view, visit https://review.coreboot.org/c/coreboot/+/56919 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia7b2560ff3d7621922ec4bc0e8793961f5d7550f Gerrit-Change-Number: 56919 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 11 Aug 2021 21:13:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Update GPIOs for fingerprint
by Karthik Ramasubramanian (Code Review) 12 Aug '21

12 Aug '21

Attention is currently required from: Raul Rangel, Martin Roth, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56499 ) Change subject: mb/google/guybrush: Update GPIOs for fingerprint ...................................................................... Patch Set 7: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56499 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaae5feec60abb2480777d1f99174254c5132bb43 Gerrit-Change-Number: 56499 Gerrit-PatchSet: 7 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Wed, 11 Aug 2021 20:56:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021