Attention is currently required from: Shelley Chen, Julius Werner, Yu-Ping Wu.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 06:57:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Vinod Polimera, Shelley Chen, Hung-Te Lin.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56966 )
Change subject: qualcomm/sc7180: Switch to common MIPI panel library
......................................................................
Patch Set 1:
(1 comment)
File src/soc/qualcomm/sc7180/display/dsi.c:
https://review.coreboot.org/c/coreboot/+/56966/comment/ac4d9e1d_1e9f0762
PS1, Line 226: size = ALIGN_UP(cm->size, DSI_PAYLOAD_SIZE_ALIGN);
This looks like it has always been wrong to me. If the payload size is not a multiple of 4 (and at least for some of the new Wormdingler panels it won't be) the memcpy() below would read over the end of the array. I changed it to just zero-fill to the next alignment boundary instead, I hope that will work. Let me know if something else needs to be done here, Vinod.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56966
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f6efbaa9da88a3574d5c6a51061e308412340e
Gerrit-Change-Number: 56966
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Vinod Polimera <vpolimer(a)qualcomm.corp-partner.google.com>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Fri, 13 Aug 2021 06:41:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Shelley Chen, Hung-Te Lin.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 1:
(3 comments)
File src/include/device/mipi_panel.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126172):
https://review.coreboot.org/c/coreboot/+/56965/comment/bb43a0c1_7e677ed8
PS1, Line 39: #define PANEL_DCS(...) \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126172):
https://review.coreboot.org/c/coreboot/+/56965/comment/d5df71c8_1edfed9e
PS1, Line 44: #define PANEL_GENERIC(...) \
Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126172):
https://review.coreboot.org/c/coreboot/+/56965/comment/0f64f792_c9ad7fa2
PS1, Line 49: #define PANEL_DELAY(delay) \
Macros with complex values should be enclosed in parentheses
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Fri, 13 Aug 2021 06:39:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Hello Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56964
to look at the new patch set (#2).
Change subject: mb/google/brya/{redrix,taeko}: Deduplicate lockdown config
......................................................................
mb/google/brya/{redrix,taeko}: Deduplicate lockdown config
Lockdown configuration is done in their baseboards. Thus, remove the
setting from the variants overridetree.
Change-Id: Iadb1201718466503987e4f6bd72bf711a2d3128e
Signed-off-by: Felix Singer <felixsinger(a)posteo.net>
---
M src/mainboard/google/brya/variants/redrix/overridetree.cb
M src/mainboard/google/brya/variants/taeko/overridetree.cb
2 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/64/56964/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56964
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iadb1201718466503987e4f6bd72bf711a2d3128e
Gerrit-Change-Number: 56964
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Arthur Heymans, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56717 )
Change subject: soc/intel/common: Calculate and configure SF Mask 2
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
> @Tim, any things on these CLs ? did you see any progress with hang at your side ?
@Tim, Ping!
--
To view, visit https://review.coreboot.org/c/coreboot/+/56717
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I442bed75f13d26f357cfb32c54c5fe9efa4b474b
Gerrit-Change-Number: 56717
Gerrit-PatchSet: 7
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Fri, 13 Aug 2021 04:16:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56208 )
Change subject: mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP
......................................................................
mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP
With current setting Display audio codec probe fails.
Hence HDMI/DP audio fails.
Earlier, with FSP 2037 was used the mode was incorrectly programmed to 4T
This setting was carried ahead with below change:
Commit : 50f8b4ebdd7db8077b87ab7686637599c9d93af3
The issue was fixed in later FSPs and with current
FSP v2237, we need to set the TMODE to 8T as per spec.
TEST=Verify HDMI/DP Playback on ADL P RVP
Fixes: 50f8b4ebdd7db8077b87ab7686637599c9d93af3
(soc/intel/alderlake: Add enum for HDA audio configuration)
Signed-off-by: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56208
Reviewed-by: Subrata Banik <subrata.banik(a)intel.com>
Reviewed-by: Balaji Manigandan <balaji.manigandan(a)intel.com>
Reviewed-by: Meera Ravindranath <meera.ravindranath(a)intel.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/mainboard/intel/adlrvp/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
build bot (Jenkins): Verified
Balaji Manigandan: Looks good to me, but someone else must approve
Subrata Banik: Looks good to me, approved
Sathya Prakash M R: Looks good to me, but someone else must approve
Meera Ravindranath: Looks good to me, but someone else must approve
diff --git a/src/mainboard/intel/adlrvp/devicetree.cb b/src/mainboard/intel/adlrvp/devicetree.cb
index d4a2eb7..c9d7da6 100644
--- a/src/mainboard/intel/adlrvp/devicetree.cb
+++ b/src/mainboard/intel/adlrvp/devicetree.cb
@@ -169,7 +169,7 @@
# HD Audio
register "PchHdaDspEnable" = "1"
- register "PchHdaIDispLinkTmode" = "HDA_TMODE_4T"
+ register "PchHdaIDispLinkTmode" = "HDA_TMODE_8T"
register "PchHdaIDispLinkFrequency" = "HDA_LINKFREQ_96MHZ"
register "PchHdaIDispCodecEnable" = "1"
--
To view, visit https://review.coreboot.org/c/coreboot/+/56208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33
Gerrit-Change-Number: 56208
Gerrit-PatchSet: 6
Gerrit-Owner: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: merged
Attention is currently required from: Jason Glenesk, Martin Roth, Marshall Dawson, Felix Held.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56815 )
Change subject: mb/amd/majolica/Kconfig: add EFS SPI settings
......................................................................
Patch Set 2:
(2 comments)
File src/mainboard/amd/majolica/Kconfig:
https://review.coreboot.org/c/coreboot/+/56815/comment/cfbe0644_5807dbbd
PS2, Line 57: int
Remove? It is declared in soc/amd/common/block/spi/Kconfig
https://review.coreboot.org/c/coreboot/+/56815/comment/e0a851f4_47168fd7
PS2, Line 62: int
Same
--
To view, visit https://review.coreboot.org/c/coreboot/+/56815
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8996c2bf606ccd21686092beac8d96b22c0b7869
Gerrit-Change-Number: 56815
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Felix Singer <felixsinger(a)posteo.net>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Fri, 13 Aug 2021 04:04:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment