Attention is currently required from: Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Rizwan Qureshi.
Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56751 )
Change subject: drivers/wifi/generic: Enable DSM ACPI entries for Intel WIFI card
......................................................................
Patch Set 10:
(2 comments)
Patchset:
PS10:
> Can the vendorcode change be split out?
It can be split but while verifying the changes we need to make sure both the patches are present. Please let me know if you prefer to split it up.
File src/drivers/wifi/generic/acpi.c:
https://review.coreboot.org/c/coreboot/+/56751/comment/e6efec72_606fdda7
PS10, Line 41: /* Unique ID for the WIFI _DSM. */
> Please remove the dot/period.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56751
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie154edf188531fe6c260274edaa694cf3b3605d3
Gerrit-Change-Number: 56751
Gerrit-PatchSet: 10
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-CC: Janiex Tu <janiex.tu(a)intel.corp-partner.google.com>
Gerrit-CC: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sherry An <sherry.an(a)intel.com>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 10:30:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Tim Wawrzynczak, Rizwan Qureshi.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak, Rizwan Qureshi,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56751
to look at the new patch set (#11).
Change subject: drivers/wifi/generic: Enable DSM ACPI entries for Intel WIFI card
......................................................................
drivers/wifi/generic: Enable DSM ACPI entries for Intel WIFI card
Add support for DSM functions as per the document
559910_Intel_Connectivity_Platforms_BIOS_Guidelines_Rev6_4.pdf
BUG=b:191720858
TEST=Check the generated SSDT tables for DSM method
Change-Id: Ie154edf188531fe6c260274edaa694cf3b3605d3
Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
---
M src/drivers/wifi/generic/acpi.c
M src/include/sar.h
M src/vendorcode/google/chromeos/sar_v2.c
3 files changed, 164 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/56751/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/56751
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie154edf188531fe6c260274edaa694cf3b3605d3
Gerrit-Change-Number: 56751
Gerrit-PatchSet: 11
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-CC: Janiex Tu <janiex.tu(a)intel.corp-partner.google.com>
Gerrit-CC: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Sherry An <sherry.an(a)intel.com>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, Tim Wawrzynczak.
Hello build bot (Jenkins), Furquan Shaikh, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56750
to look at the new patch set (#11).
Change subject: vc/google/chromeos: Add support for new SAR tables revisions
......................................................................
vc/google/chromeos: Add support for new SAR tables revisions
Existing SAR infrastructure supports only revision 0 of the SAR tables.
This patch modifies it to extend support intel wifi 6 and wifi 6e
configs as per the connectivity document:
559910_Intel_Connectivity_Platforms_BIOS_Guidelines_Rev6_4.pdf
The SAR table and wdgs configuration blocks size with in the earlier
SAR binary was static with option to enable wdgs block dynamically
using a coreboot config. The new binary format can support to have any
block as dynamic and the size of the configuration block depends on the
revision of the entry. This patch also adds support for PPAG ACPI
entries related to antenna gains.
BUG=b:193665559
TEST=Checked the SSDT entries for WRDS, EWRD, WGDS and PPAG with
different binaries generated by setting different versions in the
config.star
Change-Id: I08c3f321938eba04e8bcff4d87cb215422715bb2
Signed-off-by: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
---
M src/drivers/wifi/generic/Kconfig
M src/drivers/wifi/generic/Makefile.inc
M src/drivers/wifi/generic/acpi.c
M src/include/sar.h
M src/vendorcode/google/chromeos/Makefile.inc
M src/vendorcode/google/chromeos/sar.c
A src/vendorcode/google/chromeos/sar_v2.c
7 files changed, 403 insertions(+), 55 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/56750/11
--
To view, visit https://review.coreboot.org/c/coreboot/+/56750
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c3f321938eba04e8bcff4d87cb215422715bb2
Gerrit-Change-Number: 56750
Gerrit-PatchSet: 11
Gerrit-Owner: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Jamie Chen <jamie.chen(a)intel.com>
Gerrit-CC: Janiex Tu <janiex.tu(a)intel.corp-partner.google.com>
Gerrit-CC: Matt Chen <matt.chen(a)intel.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com>
Gerrit-CC: Simon Yang <simon1.yang(a)intel.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Shelley Chen, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56965 )
Change subject: device: Move MIPI panel library from mainboard/google/kukui into common
......................................................................
Patch Set 1:
(6 comments)
Commit Message:
PS1:
rk3399 also has lots of duplicate code. Would you like to remove it as well?
https://review.coreboot.org/c/coreboot/+/56965/comment/2a1a9b42_c012f04c
PS1, Line 15: at
a?
File src/device/mipi/Kconfig:
https://review.coreboot.org/c/coreboot/+/56965/comment/878d7842_24e35cdb
PS1, Line 38:
Extra blank line.
File src/include/device/mipi_panel.h:
https://review.coreboot.org/c/coreboot/+/56965/comment/d053b050_9541859b
PS1, Line 11: PANEL_END_CMD
I'd prefer consistent prefixes: PANEL_CMD_*.
https://review.coreboot.org/c/coreboot/+/56965/comment/ffd1abcf_81898b86
PS1, Line 24: that
remove
File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/56965/comment/7161cf1f_8bc1e1e8
PS1, Line 359: TODO
It's considered an error according in rk_mipi_dsi_write().
--
To view, visit https://review.coreboot.org/c/coreboot/+/56965
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I877f2b0c7ab984412b288e2ed27f37cd93c70863
Gerrit-Change-Number: 56965
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Shelley Chen <shchen(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 13 Aug 2021 10:28:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Paul Menzel.
linear has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56868 )
Change subject: crossgcc: upgrade Expat from 2.2.9 to 2.4.1
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56868/comment/2b96fb9c_45d325a4
PS2, Line 11: crossgcc
> … with GDB.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec2cf560902dc556a41206d7dcd65c22cf3e1215
Gerrit-Change-Number: 56868
Gerrit-PatchSet: 3
Gerrit-Owner: linear <ky0ko(a)disroot.org>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 13 Aug 2021 10:10:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Zhi7 Li, Karthik Ramasubramanian.
Hello build bot (Jenkins), Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56930
to look at the new patch set (#6).
Change subject: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
......................................................................
mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
Change the `_HID` value depending on the the fw_config values
BUG=b:193623380
BRANCH=dedede
TEST=ALC5682I-VD or VS audio codec can work normally
Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com>
Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
---
M src/mainboard/google/dedede/variants/sasukette/Makefile.inc
M src/mainboard/google/dedede/variants/sasukette/overridetree.cb
A src/mainboard/google/dedede/variants/sasukette/ramstage.c
3 files changed, 38 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/56930/6
--
To view, visit https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 6
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Zhi7 Li, Karthik Ramasubramanian.
Hello build bot (Jenkins), Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56930
to look at the new patch set (#5).
Change subject: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
......................................................................
mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
Change the `_HID` value depending on the the fw_config values
BUG=b:193623380
BRANCH=dedede
TEST=ALC5682I-VD or VS audio codec can work normally
Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com>
Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
---
M src/mainboard/google/dedede/variants/sasukette/Makefile.inc
M src/mainboard/google/dedede/variants/sasukette/overridetree.cb
A src/mainboard/google/dedede/variants/sasukette/ramstage.c
3 files changed, 38 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/56930/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 5
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Wisley Chen.
Hello Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56971
to look at the new patch set (#2).
Change subject: mb/google/dedede/var/kracko: Configure Acoustic noise mitigation
......................................................................
mb/google/dedede/var/kracko: Configure Acoustic noise mitigation
Enable Acoustic noise mitigation for kracko and set slew rate to 1/8
which is calibrated value for the board.
BUG=None
BRANCH=dedede
TEST=build firmware and verified by power team
Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Change-Id: I3e7f10a99aa00a00713d930c5a9cc24f17280ab0
---
M src/mainboard/google/dedede/variants/kracko/overridetree.cb
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/56971/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e7f10a99aa00a00713d930c5a9cc24f17280ab0
Gerrit-Change-Number: 56971
Gerrit-PatchSet: 2
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Wisley Chen.
Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/56971
to review the following change.
Change subject: mb/google/dedede/var/kracko: Configure Acoustic noise mitigation
......................................................................
mb/google/dedede/var/kracko: Configure Acoustic noise mitigation
Enable Acoustic noise mitigation for blipper and set slew rate to 1/8
which is calibrated value for the board.
BUG=None
BRANCH=dedede
TEST=build firmware and verified by power team
Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Change-Id: I3e7f10a99aa00a00713d930c5a9cc24f17280ab0
---
M src/mainboard/google/dedede/variants/kracko/overridetree.cb
1 file changed, 6 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/56971/1
diff --git a/src/mainboard/google/dedede/variants/kracko/overridetree.cb b/src/mainboard/google/dedede/variants/kracko/overridetree.cb
index 3561898..4335aa0 100644
--- a/src/mainboard/google/dedede/variants/kracko/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/kracko/overridetree.cb
@@ -58,6 +58,12 @@
},
}"
+ # Enable Acoustic noise mitigation and set slew rate to 1/4
+ # Rest of the parameters are 0 by default.
+ register "AcousticNoiseMitigation" = "1"
+ register "SlowSlewRate" = "SlewRateFastBy8"
+ register "FastPkgCRampDisable" = "1"
+
device domain 0 on
device pci 14.0 on
chip drivers/usb/acpi
--
To view, visit https://review.coreboot.org/c/coreboot/+/56971
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3e7f10a99aa00a00713d930c5a9cc24f17280ab0
Gerrit-Change-Number: 56971
Gerrit-PatchSet: 1
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-MessageType: newchange