coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: trogdor: Fix "TPM interrupt" lb_gpio to be ACTIVE_HIGH
by Paul Menzel (Code Review) 13 Aug '21

13 Aug '21

Attention is currently required from: Shelley Chen, Julius Werner. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56901 ) Change subject: trogdor: Fix "TPM interrupt" lb_gpio to be ACTIVE_HIGH ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56901 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie1586b0e10b64df0712e28552411c4d540a7e457 Gerrit-Change-Number: 56901 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Douglas Anderson <dianders(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Shelley Chen <shchen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Shelley Chen <shchen(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 13 Aug 2021 09:49:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Configure EN_FCAM_PWR to high
by Varshit B Pandya (Code Review) 13 Aug '21

13 Aug '21

Attention is currently required from: Maulik V Vaghela, Paul Menzel, Tim Wawrzynczak. Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56882 ) Change subject: mb/google/brya: Configure EN_FCAM_PWR to high ...................................................................... Patch Set 4: (4 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56882/comment/d0d42359_d34b6fd2 PS3, Line 7: Configure A17 GPIO to high > Use 3. […] Done https://review.coreboot.org/c/coreboot/+/56882/comment/526c4337_413d14bf PS3, Line 9: Recent change https://review.coreboot.org/c/coreboot/+/56655 > As it’s merged already, please reference the commit hash and summary. Done https://review.coreboot.org/c/coreboot/+/56882/comment/506fd69e_980a093e PS3, Line 11: probing, however > probing. […] Done https://review.coreboot.org/c/coreboot/+/56882/comment/7ff127c9_73349351 PS3, Line 12: by A17, this caused USB UFC enumeration to fail > Please add dot/period at the end of sentences. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56882 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I88c204ec07b1f7511f0d88074e336cfc9116a7d2 Gerrit-Change-Number: 56882 Gerrit-PatchSet: 4 Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)google.com> Gerrit-Comment-Date: Fri, 13 Aug 2021 09:43:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
by build bot (Jenkins) (Code Review) 13 Aug '21

13 Aug '21

1 0

Change in coreboot[master]: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
by build bot (Jenkins) (Code Review) 13 Aug '21

13 Aug '21

1 0

Change in coreboot[master]: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
by Zhi7 Li (Code Review) 13 Aug '21

13 Aug '21

Attention is currently required from: Zhi7 Li, Karthik Ramasubramanian. Hello build bot (Jenkins), Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56930 to look at the new patch set (#3). Change subject: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility ...................................................................... mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility Change the `_HID` value depending on the the fw_config values BUG=b:193623380 BRANCH=dedede TEST=ALC5682I-VD or VS audio codec can work normally Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com> Change-Id: Ic8840454e4934162ea59c742634a56f70b153238 --- M src/mainboard/google/dedede/variants/sasukette/Makefile.inc M src/mainboard/google/dedede/variants/sasukette/overridetree.cb A src/mainboard/google/dedede/variants/sasukette/ramstage.c 3 files changed, 38 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/56930/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/56930 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238 Gerrit-Change-Number: 56930 Gerrit-PatchSet: 3 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/guybrush/var/baseboard: Set Clk request for WLAN/SD/WWAN/SS...
by Paul Menzel (Code Review) 13 Aug '21

13 Aug '21

Attention is currently required from: Martin Roth, Patrick Huang, Felix Held. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56895 ) Change subject: mb/google/guybrush/var/baseboard: Set Clk request for WLAN/SD/WWAN/SSD device ...................................................................... Patch Set 6: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56895 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I240543e92cbc178cee034c37d7c26da0a6bbb7f6 Gerrit-Change-Number: 56895 Gerrit-PatchSet: 6 Gerrit-Owner: Patrick Huang <patrick.huang(a)amd.corp-partner.google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Patrick Huang <patrick.huang(a)amd.corp-partner.google.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Fri, 13 Aug 2021 09:31:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Add I2C parameter
by Varshit B Pandya (Code Review) 13 Aug '21

13 Aug '21

Attention is currently required from: Tim Wawrzynczak, EricR Lai. Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56970 ) Change subject: mb/google/brya: Add I2C parameter ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib47228b8684c44f6acfec9e9e4b6e7b18ba6f6c0 Gerrit-Change-Number: 56970 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Varshit B Pandya <varshit.b.pandya(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Fri, 13 Aug 2021 09:28:07 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
by build bot (Jenkins) (Code Review) 13 Aug '21

13 Aug '21

Attention is currently required from: Zhi7 Li, Karthik Ramasubramanian. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 ) Change subject: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility ...................................................................... Patch Set 2: (24 comments) File src/mainboard/google/dedede/variants/sasukette/ramstage.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/60561274_66b0b6bf PS2, Line 16: { .type = DEVICE_PATH_I2C, .i2c.device = 0x1a } code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/41e5a023_1a47ed3e PS2, Line 16: { .type = DEVICE_PATH_I2C, .i2c.device = 0x1a } please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/6c719c63_8701b83a PS2, Line 16: { .type = DEVICE_PATH_I2C, .i2c.device = 0x1a } please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/e605375d_6901a0ee PS2, Line 17: }; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/c6fc3fa9_9c1a32b1 PS2, Line 18: const struct device *codec = find_dev_nested_path(pci_root_bus(), codec_path, ARRAY_SIZE(codec_path)); line over 96 characters Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/37074891_e7414b19 PS2, Line 18: const struct device *codec = find_dev_nested_path(pci_root_bus(), codec_path, ARRAY_SIZE(codec_path)); please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/d93a167a_92492d7e PS2, Line 19: struct drivers_i2c_generic_config *config; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/a50b8eb5_be27fa0c PS2, Line 20: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/c2122bae_6b448c9c PS2, Line 20: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/e84f06a0_aeb9b590 PS2, Line 21: if (!codec || (codec->chip_ops != &drivers_i2c_generic_ops) || !codec->chip_info) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/028f860a_9711722b PS2, Line 22: return; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/de42bd21_e083872c PS2, Line 22: return; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/efe25583_131a98a1 PS2, Line 22: return; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/5dd640b5_98f7c882 PS2, Line 23: trailing whitespace Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/577fcad7_c6739bf3 PS2, Line 23: please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/fa77ff14_98aa1fe7 PS2, Line 24: config = codec->chip_info; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/7ea357aa_a8c2a4e0 PS2, Line 25: if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682))) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/64e37b45_0ce3109e PS2, Line 26: config->hid = "10EC5682"; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/628405d8_7b22ebbb PS2, Line 26: config->hid = "10EC5682"; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/4bab6a2e_b21fbddc PS2, Line 26: config->hid = "10EC5682"; please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/f54d2f26_6eb3f8ff PS2, Line 27: else if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS))) please, no spaces at the start of a line Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/62d49af8_9e490db4 PS2, Line 28: config->hid = "RTL5682"; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/44b319a6_10f0ff6e PS2, Line 28: config->hid = "RTL5682"; please, no space before tabs Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126178): https://review.coreboot.org/c/coreboot/+/56930/comment/e5f85549_536b72ec PS2, Line 28: config->hid = "RTL5682"; please, no spaces at the start of a line -- To view, visit https://review.coreboot.org/c/coreboot/+/56930 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238 Gerrit-Change-Number: 56930 Gerrit-PatchSet: 2 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Fri, 13 Aug 2021 09:27:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
by Zhi7 Li (Code Review) 13 Aug '21

13 Aug '21

Attention is currently required from: Zhi7 Li, Karthik Ramasubramanian. Hello build bot (Jenkins), Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56930 to look at the new patch set (#2). Change subject: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility ...................................................................... mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility Change the `_HID` value depending on the the fw_config values BUG=b:193623380 BRANCH=dedede TEST=ALC5682I-VD or VS audio codec can work normally Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com> Change-Id: Ic8840454e4934162ea59c742634a56f70b153238 --- M src/mainboard/google/dedede/variants/sasukette/Makefile.inc M src/mainboard/google/dedede/variants/sasukette/overridetree.cb A src/mainboard/google/dedede/variants/sasukette/ramstage.c 3 files changed, 37 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/56930/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56930 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238 Gerrit-Change-Number: 56930 Gerrit-PatchSet: 2 Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Add I2C parameter
by EricR Lai (Code Review) 13 Aug '21

13 Aug '21

Attention is currently required from: Tim Wawrzynczak. EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56970 ) Change subject: mb/google/brya: Add I2C parameter ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: HW waveform is in https://partnerissuetracker.corp.google.com/issues/188793264#comment56. -- To view, visit https://review.coreboot.org/c/coreboot/+/56970 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib47228b8684c44f6acfec9e9e4b6e7b18ba6f6c0 Gerrit-Change-Number: 56970 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 13 Aug 2021 09:08:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021