Attention is currently required from: Furquan Shaikh, Paul Menzel, Sugnan Prabhu S, Subrata Banik.
Hello build bot (Jenkins), Furquan Shaikh, Sugnan Prabhu S, Subrata Banik, Meera Ravindranath, Balaji Manigandan,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56208
to look at the new patch set (#5).
Change subject: mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP
......................................................................
mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP
With current setting Display audio codec probe fails.
Hence HDMI/DP audio fails.
Earlier, with FSP 2037 was used the mode was incorrectly programmed to 4T
This setting was carried ahead with below change:
Commit : 50f8b4ebdd7db8077b87ab7686637599c9d93af3
The issue was fixed in later FSPs and with current
FSP v2237, we need to set the TMODE to 8T as per spec.
TEST=Verify HDMI/DP Playback on ADL P RVP
Fixes: 50f8b4ebdd7db8077b87ab7686637599c9d93af3
(soc/intel/alderlake: Add enum for HDA audio configuration)
Signed-off-by: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33
---
M src/mainboard/intel/adlrvp/devicetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/08/56208/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/56208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33
Gerrit-Change-Number: 56208
Gerrit-PatchSet: 5
Gerrit-Owner: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Furquan Shaikh, Paul Menzel, Sugnan Prabhu S, Subrata Banik.
Sathya Prakash M R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56208 )
Change subject: mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56208/comment/f7a1464f_20d41ae1
PS1, Line 17:
> can u rebase
ok
--
To view, visit https://review.coreboot.org/c/coreboot/+/56208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33
Gerrit-Change-Number: 56208
Gerrit-PatchSet: 4
Gerrit-Owner: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 03:53:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Comment-In-Reply-To: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Paul Menzel, Sugnan Prabhu S, Sathya Prakash M R.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56208 )
Change subject: mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56208/comment/88c1d191_7e244935
PS1, Line 17:
> Done
can u rebase
--
To view, visit https://review.coreboot.org/c/coreboot/+/56208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33
Gerrit-Change-Number: 56208
Gerrit-PatchSet: 4
Gerrit-Owner: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Attention: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 03:50:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Comment-In-Reply-To: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Paul Menzel, Sugnan Prabhu S.
Sathya Prakash M R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56208 )
Change subject: mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56208/comment/2ead3497_cc0993a3
PS1, Line 17:
> @Paul: anything pending here ?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33
Gerrit-Change-Number: 56208
Gerrit-PatchSet: 3
Gerrit-Owner: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 03:42:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Comment-In-Reply-To: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Paul Menzel, Sugnan Prabhu S.
Sathya Prakash M R has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56208 )
Change subject: mb/intel/adlrvp: Use HDA TMODE 8T to match spec for ADL P RVP
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
Patchset:
PS3:
> @subrata - can we merge ?
Guess we can merge this now. no opens
--
To view, visit https://review.coreboot.org/c/coreboot/+/56208
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia39a33f5da2fea0dc2eaf4eae45999a711c61c33
Gerrit-Change-Number: 56208
Gerrit-PatchSet: 3
Gerrit-Owner: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 03:37:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sathya Prakash M R <sathya.prakash.m.r(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Julius Werner.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56878 )
Change subject: Documentation/util/kconfig: Remove silentoldconfig
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
gentle ping ^^
--
To view, visit https://review.coreboot.org/c/coreboot/+/56878
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8416bd4a96d15415f46c591ceb26ebb29aef1ab0
Gerrit-Change-Number: 56878
Gerrit-PatchSet: 1
Gerrit-Owner: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 13 Aug 2021 03:06:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Tim Crawford, Paul Menzel.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56861 )
Change subject: 3rdparty/intel-microcode: Update submodule to 20210608 release
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56861/comment/dcdccc8c_375a5507
PS1, Line 10:
> I wasn't able to verify if that's what's actually happening, so I documented the behavior I see in t […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56861
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I084ba67e8eaf7383f1c05fa5589b63c92ff900b1
Gerrit-Change-Number: 56861
Gerrit-PatchSet: 4
Gerrit-Owner: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 13 Aug 2021 02:50:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Crawford <tcrawford(a)system76.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Malik Hsu, Paul Menzel, Casper Chang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56923 )
Change subject: mb/google/brya/primus: Fix G2 touchscreen reset GPIO polarity
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56923
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ce1b3025db8abebf5693b34da846a7e969246fb
Gerrit-Change-Number: 56923
Gerrit-PatchSet: 3
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 13 Aug 2021 02:49:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Malik Hsu, Tim Wawrzynczak, Paul Menzel.
Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56923 )
Change subject: mb/google/brya/primus: Fix G2 touchscreen reset GPIO polarity
......................................................................
Patch Set 3:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56923/comment/39d320aa_72d86990
PS2, Line 7: config G2 touchscreen
> suggestion: […]
Done
https://review.coreboot.org/c/coreboot/+/56923/comment/9f2c007e_c773deb2
PS2, Line 9: touchscreen spec
> It was just a typo, using the incorrect polarity on the reset GPIO
Ack
https://review.coreboot.org/c/coreboot/+/56923/comment/c223a81b_3463b02e
PS2, Line 13: TEST=build coreboot and touchscreen works
> not if the reset GPIO polarity was backwards 😊
Ack
Patchset:
PS3:
Thanks Tim.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56923
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ce1b3025db8abebf5693b34da846a7e969246fb
Gerrit-Change-Number: 56923
Gerrit-PatchSet: 3
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 13 Aug 2021 01:28:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Malik Hsu, Paul Menzel, Casper Chang.
Hello build bot (Jenkins), Malik Hsu, Tim Wawrzynczak,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56923
to look at the new patch set (#3).
Change subject: mb/google/brya/primus: Fix G2 touchscreen reset GPIO polarity
......................................................................
mb/google/brya/primus: Fix G2 touchscreen reset GPIO polarity
modify reset_gpio as active low to meet touchscreen spec
BUG=b:195490284
BRANCH=none
TEST=build coreboot and touchscreen works
Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Change-Id: I7ce1b3025db8abebf5693b34da846a7e969246fb
---
M src/mainboard/google/brya/variants/primus/overridetree.cb
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/56923/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56923
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7ce1b3025db8abebf5693b34da846a7e969246fb
Gerrit-Change-Number: 56923
Gerrit-PatchSet: 3
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-MessageType: newpatchset