Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Weimin Wu, Karthik Ramasubramanian.
Zhi7 Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for ALC5682I-VD & VS
......................................................................
Patch Set 10:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56930/comment/d52accad_7694fa8e
PS6, Line 7: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
> I have modified this place
Done
Commit Message:
https://review.coreboot.org/c/coreboot/+/56930/comment/88486882_40dfb092
PS9, Line 7: mb/google/dedede/var/sasukette:Add
> Please add a space after the colon.
Done
https://review.coreboot.org/c/coreboot/+/56930/comment/95dfdfeb_ed485c1c
PS9, Line 8: codec ALC5682I-VD & VS compatibility
> Please put it on one line.
Done
https://review.coreboot.org/c/coreboot/+/56930/comment/41560c51_43298e61
PS9, Line 10: Change the `_HID` value depending on the the fw_config values
> Please elaborate, and maybe note, where you copied this from.
Done
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56930/comment/4d5fc526_2e48cbe9
PS7, Line 29: config->hid = "RTL5682";
> I have modified this place.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 10
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 13:38:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak, Zhi7 Li, Karthik Ramasubramanian.
Hello build bot (Jenkins), Tim Wawrzynczak, Weimin Wu, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56930
to look at the new patch set (#10).
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for ALC5682I-VD & VS
......................................................................
mb/google/dedede/var/sasukette: Add fw_config probe for ALC5682I-VD & VS
Update the `HID` value in the devtree depending on the fw_config values
BUG=b:193623380
BRANCH=dedede
TEST=ALC5682I-VD or VS audio codec can work normally
Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com>
Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
---
M src/mainboard/google/dedede/variants/sasukette/Makefile.inc
M src/mainboard/google/dedede/variants/sasukette/overridetree.cb
A src/mainboard/google/dedede/variants/sasukette/ramstage.c
3 files changed, 46 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/56930/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 10
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Zhi7 Li, Karthik Ramasubramanian.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette:Add fw_config probe for codec ALC5682I-VD & VS compatibility
......................................................................
Patch Set 9:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56930/comment/e10b229f_ab26e4c5
PS9, Line 7: mb/google/dedede/var/sasukette:Add
Please add a space after the colon.
https://review.coreboot.org/c/coreboot/+/56930/comment/17474ea5_9b404714
PS9, Line 8: codec ALC5682I-VD & VS compatibility
Please put it on one line.
https://review.coreboot.org/c/coreboot/+/56930/comment/c55e61c9_8a768eba
PS9, Line 10: Change the `_HID` value depending on the the fw_config values
Please elaborate, and maybe note, where you copied this from.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 9
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 12:47:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Weimin Wu, Zhi7 Li, Karthik Ramasubramanian.
Hello build bot (Jenkins), Henry Sun,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56804
to look at the new patch set (#10).
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
......................................................................
mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
commit df520855 (soc/intel/jsl: Add disable_external_bypass_vr config)
Add fw_config probe for don't stuffing ANPEC APW8738BQBI IC.
BUG=b:190727416
BRANCH=dedede
TEST=test for enter S0ix and resume normally by powerd_dbus_suspend
Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com>
Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
---
M src/mainboard/google/dedede/variants/baseboard/devicetree.cb
M src/mainboard/google/dedede/variants/sasukette/Makefile.inc
A src/mainboard/google/dedede/variants/sasukette/ramstage.c
3 files changed, 23 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/56804/10
--
To view, visit https://review.coreboot.org/c/coreboot/+/56804
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
Gerrit-Change-Number: 56804
Gerrit-PatchSet: 10
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Paul Menzel, Weimin Wu, Karthik Ramasubramanian.
Zhi7 Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56804 )
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
......................................................................
Patch Set 9:
(2 comments)
File src/mainboard/google/dedede/variants/sasukette/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56804/comment/62e22de4_6dc5baf4
PS8, Line 2: field EXT_VR 17
: option EXT_VR_PRESENT 0
: option EXT_VR_ABSENT 1
: end
> Please move this to baseboard devicetree, so that other projects dont overwrite this bit.
I have modified this place.
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56804/comment/e46482a9_10a6f5ba
PS8, Line 10: #ifdef USE_SKU_METHOD
> Please use the FW_CONFIG approach.
I have modified this place.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56804
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
Gerrit-Change-Number: 56804
Gerrit-PatchSet: 9
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 12:32:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Weimin Wu, Zhi7 Li.
Hello build bot (Jenkins), Henry Sun,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56804
to look at the new patch set (#9).
Change subject: mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
......................................................................
mb/google/dedede/var/sasukette: Add fw_config probe for non-ext VR
commit df520855 (soc/intel/jsl: Add disable_external_bypass_vr config)
Add fw_config probe for don't stuffing ANPEC APW8738BQBI IC.
BUG=b:190727416
BRANCH=dedede
TEST=test for enter S0ix and resume normally by powerd_dbus_suspend
Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com>
Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
---
M src/mainboard/google/dedede/variants/baseboard/devicetree.cb
M src/mainboard/google/dedede/variants/sasukette/Makefile.inc
A src/mainboard/google/dedede/variants/sasukette/ramstage.c
3 files changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/56804/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/56804
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I15ab30f14df9dc02157009091aa8398e2fa75188
Gerrit-Change-Number: 56804
Gerrit-PatchSet: 9
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Joey Peng, Paul Menzel, Marco Chen.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56380 )
Change subject: mb/google/octopus/var/phaser: Change IRQ trigger method to level
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56380
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I44ee779242779c78ceafdddd34dca2571e714dd3
Gerrit-Change-Number: 56380
Gerrit-PatchSet: 6
Gerrit-Owner: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)chromium.org>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alec Wang <alec.wang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Jerry2 Huang <jerry2.huang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Joey Peng <joey.peng(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Marco Chen <marcochen(a)chromium.org>
Gerrit-Comment-Date: Mon, 16 Aug 2021 11:53:54 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Zhi7 Li, Karthik Ramasubramanian.
Weimin Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette:Add fw_config probe for codec ALC5682I-VD & VS compatibility
......................................................................
Patch Set 9: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56930/comment/edd2efe0_399444dd
PS6, Line 7: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
> I have modified this place
Done
File src/mainboard/google/dedede/variants/sasukette/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56930/comment/f42d255e_e2e4d0c7
PS7, Line 2: field AUDIO_CODEC_SOURCE 41 43
> Yes, this is the result after confirmation.
Done
https://review.coreboot.org/c/coreboot/+/56930/comment/f62f0731_c57ff907
PS7, Line 4: 3
> Due to the historical project of HQ, different audio codec ICs are numbered uniformly, so there is s […]
Done
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56930/comment/099e8397_bb11325f
PS7, Line 29: config->hid = "RTL5682";
> I have modified this place.
Done
https://review.coreboot.org/c/coreboot/+/56930/comment/27349dd8_ab9dcf88
PS7, Line 14: const struct device_path codec_path[] = {
: { .type = DEVICE_PATH_PCI, .pci.devfn = PCH_DEVFN_I2C4 },
: { .type = DEVICE_PATH_I2C, .i2c.device = 0x1a }
: };
: const struct device *codec = find_dev_nested_path(pci_root_bus(),
: codec_path, ARRAY_SIZE(codec_path));
: struct drivers_i2c_generic_config *config;
:
: if (!codec || (codec->chip_ops != &drivers_i2c_generic_ops) || !codec->chip_info)
: return;
:
: config = codec->chip_info;
: if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682)))
: config->hid = "10EC5682";
: else if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS)))
: config->hid = "RTL5682";
> I have modified this place, do you think it is appropriate to modify this way?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 9
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 11:44:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment