Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/56868 )
Change subject: crossgcc: upgrade Expat from 2.2.9 to 2.4.1
......................................................................
crossgcc: upgrade Expat from 2.2.9 to 2.4.1
Versions of expat before 2.4.0 have been renamed to prevent their
use, due to some kind of vulnerability. without updating this
dependency it is currently not possible to build crossgcc with GDB.
Change-Id: Iec2cf560902dc556a41206d7dcd65c22cf3e1215
Signed-off-by: Mackenzie May <ky0ko(a)disroot.org>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/56868
Reviewed-by: Angel Pons <th3fanbus(a)gmail.com>
Reviewed-by: Paul Menzel <paulepanter(a)mailbox.org>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M util/crossgcc/buildgcc
D util/crossgcc/sum/expat-2.2.9.tar.bz2.cksum
A util/crossgcc/sum/expat-2.4.1.tar.bz2.cksum
3 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
build bot (Jenkins): Verified
Paul Menzel: Looks good to me, but someone else must approve
Angel Pons: Looks good to me, approved
diff --git a/util/crossgcc/buildgcc b/util/crossgcc/buildgcc
index aee55f9..7176e6b 100755
--- a/util/crossgcc/buildgcc
+++ b/util/crossgcc/buildgcc
@@ -41,7 +41,7 @@
GDB_VERSION=9.2
IASL_VERSION=20210331
PYTHON_VERSION=3.8.5
-EXPAT_VERSION=2.2.9
+EXPAT_VERSION=2.4.1
# CLANG version number
CLANG_VERSION=12.0.0
CMAKE_VERSION=3.20.3
diff --git a/util/crossgcc/sum/expat-2.2.9.tar.bz2.cksum b/util/crossgcc/sum/expat-2.2.9.tar.bz2.cksum
deleted file mode 100644
index 924b412..0000000
--- a/util/crossgcc/sum/expat-2.2.9.tar.bz2.cksum
+++ /dev/null
@@ -1 +0,0 @@
-ef5c1c55913a6ab18496ee99166f86269c7cdc31 tarballs/expat-2.2.9.tar.bz2
diff --git a/util/crossgcc/sum/expat-2.4.1.tar.bz2.cksum b/util/crossgcc/sum/expat-2.4.1.tar.bz2.cksum
new file mode 100644
index 0000000..5b520f3
--- /dev/null
+++ b/util/crossgcc/sum/expat-2.4.1.tar.bz2.cksum
@@ -0,0 +1 @@
+b677b9a1cf3a1424fda183223fae2c58f50151af tarballs/expat-2.4.1.tar.bz2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56868
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iec2cf560902dc556a41206d7dcd65c22cf3e1215
Gerrit-Change-Number: 56868
Gerrit-PatchSet: 4
Gerrit-Owner: linear <ky0ko(a)disroot.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Lance Zhao, Bora Guvendik, John Zhao.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56979 )
Change subject: util/crossgcc: Update to expat 2.4.1
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Duplicate of CB:56868
--
To view, visit https://review.coreboot.org/c/coreboot/+/56979
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iba50f645321ced85dd2423585bd19446b484866d
Gerrit-Change-Number: 56979
Gerrit-PatchSet: 1
Gerrit-Owner: Lance Zhao
Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com>
Gerrit-Attention: John Zhao <john.zhao(a)intel.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 10:00:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Karthik Ramasubramanian.
Zhi7 Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56930 )
Change subject: mb/google/dedede/var/sasukette:Add fw_config probe for codec ALC5682I-VD & VS compatibility
......................................................................
Patch Set 9:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56930/comment/39844dfd_030b78b7
PS6, Line 7: mb/google/dedede/var/sasukette: Codec ALC5682I-VD & VS compatibility
> Please make it a statement by using a verb (in imperative mood) [1]. […]
I have modified this place
File src/mainboard/google/dedede/variants/sasukette/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56930/comment/a705e87f_56520357
PS6, Line 185: register "name" = ""RT58""
> Thanks for your patience and guidance that help me a lot.
Done
File src/mainboard/google/dedede/variants/sasukette/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56930/comment/cf45e55d_39c1332f
PS7, Line 2: field AUDIO_CODEC_SOURCE 41 43
> Can you please confirm that there are no conflicts with the second source of other components in Sas […]
Yes, this is the result after confirmation.
https://review.coreboot.org/c/coreboot/+/56930/comment/240802f7_c0cd31f0
PS7, Line 4: 3
> Why is it 3 instead of 2 - i.e. […]
Due to the historical project of HQ, different audio codec ICs are numbered uniformly, so there is sequence gaps.
I have added other related configurations.
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56930/comment/f440d55b_232ce4e0
PS6, Line 19: codec_path, ARRAY_SIZE(codec_path));
> Line lengths in coreboot are 96 wide, so feel free to use the whole width, or break it up into multi […]
Done
File src/mainboard/google/dedede/variants/sasukette/ramstage.c:
https://review.coreboot.org/c/coreboot/+/56930/comment/e10536f1_608ed0fa
PS7, Line 29: config->hid = "RTL5682";
> Nit: Seems there are 2 spaces between = and "RTL5682"
I have modified this place.
https://review.coreboot.org/c/coreboot/+/56930/comment/516312f3_f12acc1a
PS7, Line 14: const struct device_path codec_path[] = {
: { .type = DEVICE_PATH_PCI, .pci.devfn = PCH_DEVFN_I2C4 },
: { .type = DEVICE_PATH_I2C, .i2c.device = 0x1a }
: };
: const struct device *codec = find_dev_nested_path(pci_root_bus(),
: codec_path, ARRAY_SIZE(codec_path));
: struct drivers_i2c_generic_config *config;
:
: if (!codec || (codec->chip_ops != &drivers_i2c_generic_ops) || !codec->chip_info)
: return;
:
: config = codec->chip_info;
: if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682)))
: config->hid = "10EC5682";
: else if (fw_config_probe(FW_CONFIG(AUDIO_CODEC_SOURCE, AUDIO_CODEC_ALC5682I_VS)))
: config->hid = "RTL5682";
> W.r.t CB:56804, move this to a separate function - eg. […]
I have modified this place, do you think it is appropriate to modify this way?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 9
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 09:27:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Comment-In-Reply-To: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Diana Zigterman, Paul Menzel, Nikolai Vyssotski.
Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55434 )
Change subject: mb/google/guybrush: Enable STT in device tree
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/55434/comment/0899143c_f6787c40
PS3, Line 66: register "stt_skin_temp_apu" = "0x2D00"
> It’d be great if the unit would be part of the name, and, if degree celcius, it’d be to the basis te […]
Thanks Paul. Ordinarily i would agree, but all of these values are encoded in a way that is consumed further down the line. It might be worthwhile later to revisit the encoding scheme to make it easier to work with from coreboot.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55434
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I37b5da1b56586ef75ad17f6766cd00ddac87aa5a
Gerrit-Change-Number: 55434
Gerrit-PatchSet: 3
Gerrit-Owner: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Diana Zigterman <dzigterman(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Matt Papageorge <matthewpapa07(a)gmail.com>
Gerrit-Reviewer: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Diana Zigterman <dzigterman(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Nikolai Vyssotski <nikolai.vyssotski(a)amd.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 09:15:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Zhi7 Li.
Hello build bot (Jenkins), Tim Wawrzynczak, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56930
to look at the new patch set (#9).
Change subject: mb/google/dedede/var/sasukette:Add fw_config probe for codec ALC5682I-VD & VS compatibility
......................................................................
mb/google/dedede/var/sasukette:Add fw_config probe for
codec ALC5682I-VD & VS compatibility
Change the `_HID` value depending on the the fw_config values
BUG=b:193623380
BRANCH=dedede
TEST=ALC5682I-VD or VS audio codec can work normally
Signed-off-by: Zhi Li <lizhi7(a)huaqin.corp-partner.google.com>
Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
---
M src/mainboard/google/dedede/variants/sasukette/Makefile.inc
M src/mainboard/google/dedede/variants/sasukette/overridetree.cb
A src/mainboard/google/dedede/variants/sasukette/ramstage.c
3 files changed, 46 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/56930/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/56930
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic8840454e4934162ea59c742634a56f70b153238
Gerrit-Change-Number: 56930
Gerrit-PatchSet: 9
Gerrit-Owner: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Zhi7 Li <lizhi7(a)huaqin.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Henry Sun, Paul Menzel, Aseda Aboagye, Shou-Chieh Hsu.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56798 )
Change subject: mb/google/dedede: Create driblee variant
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
Hi Google,
Would you help to merge the CL?
We can go on creating the variant process once the CL is merged and being cherry-picked to ToT.
Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56798
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ad9a4e0cf7999337b55d62d5cc94e4f6c2e98f3
Gerrit-Change-Number: 56798
Gerrit-PatchSet: 6
Gerrit-Owner: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 06:51:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Ian Feng, Henry Sun, Paul Menzel, Aseda Aboagye, EricR Lai.
Frank Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56796 )
Change subject: mb/google/dedede: Create corori variant
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Hi Google,
Would you help to merge the CL?
We can go on creating the variant process once the CL is merged and being cherry-picked to ToT.
Thank you.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56796
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8380d5aab61c99d545625789ff1251ec1caa84a2
Gerrit-Change-Number: 56796
Gerrit-PatchSet: 7
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Frank Wu <frank_wu(a)compal.corp-partner.google.com>
Gerrit-CC: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com>
Gerrit-CC: John Su <john_su(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Mon, 16 Aug 2021 06:51:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment