Attention is currently required from: Sean Rhodes, Nico Huber, Martin Roth, Andy Pont, Paul Menzel, Stefan Reinauer, Angel Pons.
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56223 )
Change subject: payloads/external/tianocore: Add build argument for 4G Decode
......................................................................
Patch Set 21:
(1 comment)
File payloads/external/tianocore/Makefile:
https://review.coreboot.org/c/coreboot/+/56223/comment/5a8142f6_410bb7fe
PS21, Line 38: 4G=-D ABOVE_4G_DECODE=TRUE
: else
: 4G=-D ABOVE_4G_DECODE=FALSE
variable change to match Kconfig?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56223
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b1d15196c0ec611431af29031682fea626d19d
Gerrit-Change-Number: 56223
Gerrit-PatchSet: 21
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 14:10:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Paul Menzel, Meera Ravindranath, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56993 )
Change subject: soc/intel/alderlake: Move INTEL_CAR_NEM selection from SoC to mainboard
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56993/comment/f44a58c9_bd6b9170
PS1, Line 11: feature on OEM/ODM reference designs.
> its kind of precaution steps so we don't want to run into the issue and be in catching situation.
@Paul, anything pending here? marking this to resolve ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56993
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I709185159d9869501b1d8e8d00f6d25ec77838bf
Gerrit-Change-Number: 56993
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Meera Ravindranath <meera.ravindranath(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 18 Aug 2021 13:27:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Felix Singer, Timofey Komarov, Nico Huber, Maciej Pijanowski, Michał Żygowski, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Krystian Hebel, Marcello Sylvester Bauer.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 )
Change subject: util/liveiso: Add NixOS configs for bootable live systems
......................................................................
Patch Set 31: Code-Review+1
(1 comment)
File util/liveiso/build-graphical.sh:
https://review.coreboot.org/c/coreboot/+/50194/comment/9bbcddc2_58f612c5
PS30, Line 3: config.system.build.isoImage
> It looks promising. I will look into this, but I don't have the time for this now. […]
agreed
--
To view, visit https://review.coreboot.org/c/coreboot/+/50194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c
Gerrit-Change-Number: 50194
Gerrit-PatchSet: 31
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Maciej Pijanowski
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io>
Gerrit-Comment-Date: Wed, 18 Aug 2021 12:48:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Mariusz Szafrański, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, King Sumo.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57033 )
Change subject: soc/intel/denverton_ns: Fix MRC cache write
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57033/comment/cd505a5e_59a0a30b
PS1, Line 10:
Please give a little more details on how it fails.
https://review.coreboot.org/c/coreboot/+/57033/comment/6736bf96_17affb1f
PS1, Line 12: Change-Id: I50cc4f8ced0b0524b39eece5a2bb4f0d99fb4eff
Please add a tag: Link: https://mail.coreboot.org/hyperkitty/list/coreboot@coreboot.org/thread/W2E7…
Patchset:
PS1:
Thanking you for pushing your fix for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57033
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50cc4f8ced0b0524b39eece5a2bb4f0d99fb4eff
Gerrit-Change-Number: 57033
Gerrit-PatchSet: 1
Gerrit-Owner: King Sumo <kingsumos(a)gmail.com>
Gerrit-Reviewer: Mariusz Szafrański <mariuszx.szafranski(a)intel.com>
Gerrit-Reviewer: Michal Motyl <michalx.motyl(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Suresh Bellampalli <suresh.bellampalli(a)intel.com>
Gerrit-Reviewer: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Mariusz Szafrański <mariuszx.szafranski(a)intel.com>
Gerrit-Attention: Suresh Bellampalli <suresh.bellampalli(a)intel.com>
Gerrit-Attention: Vanessa Eusebio <vanessa.f.eusebio(a)intel.com>
Gerrit-Attention: Michal Motyl <michalx.motyl(a)intel.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: King Sumo <kingsumos(a)gmail.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 12:42:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Timofey Komarov, Nico Huber, Maciej Pijanowski, Michał Żygowski, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Michael Niewöhner, Krystian Hebel, Marcello Sylvester Bauer.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 )
Change subject: util/liveiso: Add NixOS configs for bootable live systems
......................................................................
Patch Set 31:
(1 comment)
File util/liveiso/build-graphical.sh:
https://review.coreboot.org/c/coreboot/+/50194/comment/f9340822_fbceed53
PS30, Line 3: config.system.build.isoImage
> https://github.com/NixOS/nixpkgs/tree/master/nixos/lib […]
It looks promising. I will look into this, but I don't have the time for this now. So I would appreciate if we could get this into the tree that it is usable. We can add disk image support later.
--
To view, visit https://review.coreboot.org/c/coreboot/+/50194
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c
Gerrit-Change-Number: 50194
Gerrit-PatchSet: 31
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io>
Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Reviewer: Maciej Pijanowski
Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de>
Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Maciej Pijanowski
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Thomas Heijligen <src(a)posteo.de>
Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com>
Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io>
Gerrit-Comment-Date: Wed, 18 Aug 2021 12:24:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer <felixsinger(a)posteo.net>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment