Attention is currently required from: Nico Huber, Martin Roth, Matt DeVillier, Andy Pont, Paul Menzel, Stefan Reinauer, Angel Pons.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56223 )
Change subject: payloads/external/tianocore: Add build argument for 4G Decode
......................................................................
Patch Set 20:
(2 comments)
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/56223/comment/811bdf88_8bf368c5
PS16, Line 86: bool "Avoid above 4G memory"
: default n
: help
: Select this option to not reserve memory above 4G. This will allow
: the payload to use all of the memory.
> The current version says this: […]
Ack
File payloads/external/tianocore/Kconfig:
https://review.coreboot.org/c/coreboot/+/56223/comment/5c372b74_15c4cd11
PS20, Line 92: reserve memory above 4G
> I fear this was written after my misunderstanding of what is `reserved`. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56223
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia3b1d15196c0ec611431af29031682fea626d19d
Gerrit-Change-Number: 56223
Gerrit-PatchSet: 20
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-CC: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com>
Gerrit-Attention: Andy Pont <andy.pont(a)sdcsystems.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 07:30:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de>
Comment-In-Reply-To: Sean Rhodes <admin(a)starlabs.systems>
Comment-In-Reply-To: Matt DeVillier <matt.devillier(a)gmail.com>
Comment-In-Reply-To: Andy Pont <andy.pont(a)sdcsystems.com>
Comment-In-Reply-To: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Karthik Ramasubramanian, Felix Held.
Pratik Vishwakarma has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57012 )
Change subject: soc/amd/common/upep.asl: Correct device list format
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57012/comment/6cf8748e_ba464d4f
PS1, Line 7: soc/amd/common: Correct device list format
> soc/amd/common/upep. […]
Done
https://review.coreboot.org/c/coreboot/+/57012/comment/1c975620_97255737
PS1, Line 9: Use correct format for constraint list as expected
: by kernel driver. With this change, kernel is able
: to correctly list dummy device in constraint list.
> The lines can stretch to 72 characters. Please reflow the message accordingly.
Done
https://review.coreboot.org/c/coreboot/+/57012/comment/6cbfddaf_7ba3e4b9
PS1, Line 12:
> Please list […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/57012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7af1941ffd21cd5864c7285f44cb2d063d2f225f
Gerrit-Change-Number: 57012
Gerrit-PatchSet: 2
Gerrit-Owner: Pratik Vishwakarma <Pratik.Vishwakarma(a)amd.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 18 Aug 2021 07:14:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Pratik Vishwakarma, Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Felix Held.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/57012
to look at the new patch set (#2).
Change subject: soc/amd/common/upep.asl: Correct device list format
......................................................................
soc/amd/common/upep.asl: Correct device list format
Use correct format for constraint list as expected by kernel driver.
With this change, kernel is able to correctly list dummy device in
constraint list.
BUG=b:194687976
TEST=Build and boot to OS in Guybrush.
Change-Id: I7af1941ffd21cd5864c7285f44cb2d063d2f225f
Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma(a)amd.com>
---
M src/soc/amd/common/acpi/upep.asl
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/57012/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/57012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7af1941ffd21cd5864c7285f44cb2d063d2f225f
Gerrit-Change-Number: 57012
Gerrit-PatchSet: 2
Gerrit-Owner: Pratik Vishwakarma <Pratik.Vishwakarma(a)amd.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Pratik Vishwakarma <Pratik.Vishwakarma(a)amd.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-MessageType: newpatchset
Attention is currently required from: Pratik Vishwakarma, Jason Glenesk, Raul Rangel, Furquan Shaikh, Marshall Dawson, Felix Held.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57012 )
Change subject: soc/amd/common: Correct device list format
......................................................................
Patch Set 1:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57012/comment/61dd3fbf_c282e455
PS1, Line 7: soc/amd/common: Correct device list format
soc/amd/common/upep.asl: Correct device list format
https://review.coreboot.org/c/coreboot/+/57012/comment/9c29a047_618b5d27
PS1, Line 9: Use correct format for constraint list as expected
: by kernel driver. With this change, kernel is able
: to correctly list dummy device in constraint list.
The lines can stretch to 72 characters. Please reflow the message accordingly.
https://review.coreboot.org/c/coreboot/+/57012/comment/6f3a0e60_9aa82cff
PS1, Line 12:
Please list
BUG=b:194687976
TEST=Which device you tested it on.
--
To view, visit https://review.coreboot.org/c/coreboot/+/57012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7af1941ffd21cd5864c7285f44cb2d063d2f225f
Gerrit-Change-Number: 57012
Gerrit-PatchSet: 1
Gerrit-Owner: Pratik Vishwakarma <Pratik.Vishwakarma(a)amd.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-CC: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Attention: Pratik Vishwakarma <Pratik.Vishwakarma(a)amd.com>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Comment-Date: Wed, 18 Aug 2021 07:00:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment