Pratik Vishwakarma has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57012 )
Change subject: soc/amd/common: Correct device list format
......................................................................
soc/amd/common: Correct device list format
Use correct format for constraint list as expected
by kernel driver. With this change, kernel is able
to correctly list dummy device in constraint list.
Change-Id: I7af1941ffd21cd5864c7285f44cb2d063d2f225f
Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma(a)amd.com>
---
M src/soc/amd/common/acpi/upep.asl
1 file changed, 9 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/12/57012/1
diff --git a/src/soc/amd/common/acpi/upep.asl b/src/soc/amd/common/acpi/upep.asl
index 3fcf2f7..ef06845 100644
--- a/src/soc/amd/common/acpi/upep.asl
+++ b/src/soc/amd/common/acpi/upep.asl
@@ -34,11 +34,16 @@
* (`INTERNAL_POWER_ERROR`). Returning an empty package does not work.
*/
Name (DEVL, Package() {
+ 0,
+ 1, /* Only 1 dummy device for now */
+
Package() {
- 0, /* Disabled */
- "\\DUMY", /* \DUMY - not existent */
- 0, /* Function States */
- 0 /* Minimum D-state */
+ Package() {
+ 0, /* Disabled */
+ "\\DUMY", /* \DUMY - not existent */
+ 0, /* Function States */
+ 0 /* Minimum D-state */
+ }
}
})
--
To view, visit https://review.coreboot.org/c/coreboot/+/57012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7af1941ffd21cd5864c7285f44cb2d063d2f225f
Gerrit-Change-Number: 57012
Gerrit-PatchSet: 1
Gerrit-Owner: Pratik Vishwakarma <Pratik.Vishwakarma(a)amd.com>
Gerrit-MessageType: newchange
Attention is currently required from: Felix Singer, Patrick Rudolph, Jonathan Zhang, Jeremy Soller, Angel Pons, Michael Niewöhner, Piotr Król, Anjaneya "Reddy" Chagam, Nico Huber, Michał Żygowski, Johnny Lin, Tim Wawrzynczak, Christian Walter, Morgan Jang, Wim Vervoorn.
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56967 )
Change subject: soc/intel/common: Use CHIPSET_LOCKDOWN_COREBOOT by default
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56967
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I369f01d3da2e901e2fb57f2c83bd07380f3946a6
Gerrit-Change-Number: 56967
Gerrit-PatchSet: 5
Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Frans Hendriks <fhendriks(a)eltan.com>
Gerrit-Reviewer: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de>
Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Reviewer: Tim Crawford <tcrawford(a)system76.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Jeremy Soller <jeremy(a)system76.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Attention: Piotr Król <piotr.krol(a)3mdeb.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Nico Huber <nico.h(a)gmx.de>
Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 05:54:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Shou-Chieh Hsu, Karthik Ramasubramanian.
Ian Feng has removed Aseda Aboagye from this change. ( https://review.coreboot.org/c/coreboot/+/56968 )
Change subject: mb/google/dedede/var/cret: Modify Wifi SAR condition
......................................................................
Removed reviewer Aseda Aboagye.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56968
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie94c2a07ad43fe1cb426e543dd97ed0434c42f2d
Gerrit-Change-Number: 56968
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: deleteReviewer
Frank Chu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/57011 )
Change subject: mb/google/dedede/var/galtic: modify touchscreen to native I2C protocol
......................................................................
mb/google/dedede/var/galtic: modify touchscreen to native I2C protocol
BUG=b:195994810
TEST= verify only update RW FW can fix touchscreen no function issue
1.Build test firmware
2.prepare DUT enviroment (R93 image + update RW to test firmware)
3.verify touchscreen function normally
Signed-off-by: FrankChu <Frank_Chu(a)pegatron.corp-partner.google.com>
Change-Id: Ie9e0fe726854d0128ad1bb430544640dc8f034ac
---
M src/mainboard/google/dedede/variants/galtic/overridetree.cb
1 file changed, 10 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/11/57011/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/57011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9e0fe726854d0128ad1bb430544640dc8f034ac
Gerrit-Change-Number: 57011
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Frank Chu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57011 )
Change subject: mb/google/dedede/var/galtic: update touchscreen to native I2C protocol
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/57011
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie9e0fe726854d0128ad1bb430544640dc8f034ac
Gerrit-Change-Number: 57011
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Daniel Peng <daniel_peng(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 03:43:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Jakub Czapiga, Jan Dabros.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56601 )
Change subject: tests: Add lib/cbfs-verification-test test case
......................................................................
Patch Set 8:
(5 comments)
Patchset:
PS8:
Please reply to / resolve the old outstanding comments at some point so it's clearer to see what you're still planning to change.
File tests/include/tests/lib/cbfs_util.h:
https://review.coreboot.org/c/coreboot/+/56601/comment/b0f86c62_46ef2be3
PS8, Line 24: 90
Rather than having to check these by hand, I believe
sizeof((u8[]){TEST_DATA_1})
would also work to determine it programmatically.
https://review.coreboot.org/c/coreboot/+/56601/comment/b969aae7_64e09f97
PS8, Line 74: TEST_REGION(cbfs_cache, TEST_CBFS_CACHE_SIZE);
This defines a global variable, so I think it should go in the .c file, otherwise you have weirdness if you link two compilation units that both included this header (even though that seems unlikely in this test framework, but probably not impossible).
Maybe create a tests/mock/cbfs_util.c to go with this that defines this and all the corresponding struct cbfs_test_file globals for this? (I'd maybe call it cbfs_mock or cbfs_file_mock instead in that case...)
File tests/lib/cbfs-verification-test.c:
https://review.coreboot.org/c/coreboot/+/56601/comment/761e8234_4d0eb46e
PS2, Line 4: #define __noreturn
> `fail()` in CMocka calls either `exit()`, `abort()` or `siglongjmp()`. […]
Resolved?
File tests/lib/cbfs-verification-test.c:
https://review.coreboot.org/c/coreboot/+/56601/comment/aedd859b_b7f5988b
PS8, Line 244: return cmocka_run_group_tests(cbfs_verification_tests, NULL, NULL);
One problem with this copying approach I noticed is that when you run the test, it's hard to figure out which output belongs to which variant... they all just say "cbfs_verification_tests: Running 4 test(s).". I believe you could use cmocka_run_group_tests_name() here instead to make them distinguishable.
(Of course, you need to somehow get the distinguishing name you want to print first. And if we're going to do this copying a lot, that may be a recurring problem that would be better solved a single time for all tests. Maybe you could design a fancy macro like `cmocka_run_test_variations(tests, setup, teardown, ...)` that you would call here as `cmocka_run_test_variations(cbfs_verification_tests, NULL, NULL, CONFIG_CBFS_VERIFICATION, VB2_SUPPORT_SHA512);` and it would translate that into `cmocka_run_group_tests_name("cbfs_verification_tests(CONFIG_CBFS_VERIFICATION=1, VB2_SUPPORT_SHA512=0)", cbfs_verification_tests, NULL, NULL);`, with the numbers matching the configuration for this particular instance of the test.)
--
To view, visit https://review.coreboot.org/c/coreboot/+/56601
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d8cbb1c2d0a9db3236de065428b70a9c2a66330
Gerrit-Change-Number: 56601
Gerrit-PatchSet: 8
Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com>
Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 03:43:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga <jacz(a)semihalf.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Ian Feng has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57010 )
Change subject: mb/google/dedede/var/corori: Configure USB port settings
......................................................................
mb/google/dedede/var/corori: Configure USB port settings
Follow schematic to modify USB port settings.
USB2 [0]: USB Type C Port 0
USB2 [1]: None
USB2 [2]: USB Type A Port 0
USB2 [3]: None
USB2 [4]: None
USB2 [5]: Camera UFC
USB2 [6]: Camera WFC
USB2 [7]: Integrated Bluetooth
USB3 [0]: USB Type C Port 0 (M/B side)
USB3 [1]: None
USB3 [2]: USB Type A Port 0 (M/B side)
USB3 [3]: None
BUG=b:196998272
BRANCH=keeby
TEST=FW_NAME="corori" emerge-keeby coreboot
Signed-off-by: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Change-Id: I2045b2be9d79bfd394fa4520faa0fb552a704206
---
M src/mainboard/google/dedede/variants/corori/overridetree.cb
1 file changed, 37 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/57010/1
diff --git a/src/mainboard/google/dedede/variants/corori/overridetree.cb b/src/mainboard/google/dedede/variants/corori/overridetree.cb
index cbad0d2..1708283 100644
--- a/src/mainboard/google/dedede/variants/corori/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/corori/overridetree.cb
@@ -1,5 +1,14 @@
chip soc/intel/jasperlake
+ # USB Port Configuration
+ register "usb2_ports[1]" = "USB2_PORT_EMPTY" # None
+ register "usb2_ports[3]" = "USB2_PORT_EMPTY" # None
+ register "usb2_ports[4]" = "USB2_PORT_EMPTY" # None
+ register "usb2_ports[5]" = "USB2_PORT_MID(OC_SKIP)" # Camera (UFC)
+ register "usb2_ports[6]" = "USB2_PORT_MID(OC_SKIP)" # Camera (WFC)
+ register "usb3_ports[1]" = "USB3_PORT_EMPTY" # None
+ register "usb3_ports[3]" = "USB3_PORT_EMPTY" # None
+
# Intel Common SoC Config
#+-------------------+---------------------------+
#| Field | Value |
@@ -32,6 +41,34 @@
register "SerialIoGSpiCsMode[PchSerialIoIndexGSPI0]" = "0"
device domain 0 on
+ device pci 14.0 on
+ chip drivers/usb/acpi
+ device usb 0.0 on
+ chip drivers/usb/acpi
+ device usb 2.1 off end
+ end
+ chip drivers/usb/acpi
+ device usb 2.3 off end
+ end
+ chip drivers/usb/acpi
+ register "desc" = ""Camera (UFC)""
+ register "type" = "UPC_TYPE_INTERNAL"
+ device usb 2.5 on end
+ end
+ chip drivers/usb/acpi
+ register "desc" = ""Camera (WFC)""
+ register "type" = "UPC_TYPE_INTERNAL"
+ device usb 2.6 on end
+ end
+ chip drivers/usb/acpi
+ device usb 3.1 off end
+ end
+ chip drivers/usb/acpi
+ device usb 3.3 off end
+ end
+ end
+ end
+ end # USB xHCI
device pci 15.0 on end
device pci 1e.2 off end # GSPI 0
device pci 1f.0 on
--
To view, visit https://review.coreboot.org/c/coreboot/+/57010
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2045b2be9d79bfd394fa4520faa0fb552a704206
Gerrit-Change-Number: 57010
Gerrit-PatchSet: 1
Gerrit-Owner: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Furquan Shaikh, Paul Menzel, Sumeet R Pawnikar, Karthik Ramasubramanian.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57000 )
Change subject: mb/google/brya: set tcc_offset value to 10
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/57000
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22573e8ca935d99a16b0876768df169db4e61c4d
Gerrit-Change-Number: 57000
Gerrit-PatchSet: 2
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Wed, 18 Aug 2021 03:32:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment