build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57027 )
Change subject: HACK: Herobrine: Reinit TPM INT gpio in setup_usb()
......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/herobrine/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126337):
https://review.coreboot.org/c/coreboot/+/57027/comment/2ed9f9a4_32b2320d
PS1, Line 51: mainboard_blob_fix();
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126337):
https://review.coreboot.org/c/coreboot/+/57027/comment/7107a9c1_3ddff438
PS1, Line 51: mainboard_blob_fix();
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/57027
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0c79e0bdbe87128fab94b08412d21ceff25643e5
Gerrit-Change-Number: 57027
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 18 Aug 2021 08:36:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57025 )
Change subject: WIP: Herobrine: Reinit TPM INT gpio after qclib executes
......................................................................
Patch Set 1:
(2 comments)
File src/soc/qualcomm/common/qclib.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126335):
https://review.coreboot.org/c/coreboot/+/57025/comment/e2dc2f30_56f78c81
PS1, Line 220: mainboard_blob_fix();
code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126335):
https://review.coreboot.org/c/coreboot/+/57025/comment/74d68b13_fa2c4841
PS1, Line 220: mainboard_blob_fix();
please, no spaces at the start of a line
--
To view, visit https://review.coreboot.org/c/coreboot/+/57025
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4c43d120ebb49800c82aec263ff8c215b60c5201
Gerrit-Change-Number: 57025
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Comment-Date: Wed, 18 Aug 2021 08:35:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57024 )
Change subject: WIP: Herobrine: Fix board id read to use base3
......................................................................
WIP: Herobrine: Fix board id read to use base3
Board IDs are tristates, so we are going to use base3 gpio reads,
which also follows what we are using for trogdor board id.
Signed-off-by: Shelley Chen <shchen(a)google.com>
Change-Id: I99158a01862f8d9560664cd15714513b42ac7c84
---
M src/mainboard/google/herobrine/boardid.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/57024/1
diff --git a/src/mainboard/google/herobrine/boardid.c b/src/mainboard/google/herobrine/boardid.c
index e92d1ef9c..9290d92 100644
--- a/src/mainboard/google/herobrine/boardid.c
+++ b/src/mainboard/google/herobrine/boardid.c
@@ -15,7 +15,7 @@
const gpio_t pins[] = {[2] = GPIO(75), [1] = GPIO(74), [0] = GPIO(73)};
if (id == UNDEFINED_STRAPPING_ID)
- id = gpio_pulldown_base2_value(pins, ARRAY_SIZE(pins));
+ id = gpio_base3_value(pins, ARRAY_SIZE(pins));
if ((id == QCOM_SC7280_SKU1) || (id == QCOM_SC7280_SKU2) ||
(id == QCOM_SC7280_SKU3))
--
To view, visit https://review.coreboot.org/c/coreboot/+/57024
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99158a01862f8d9560664cd15714513b42ac7c84
Gerrit-Change-Number: 57024
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-MessageType: newchange
Shelley Chen has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/57023 )
Change subject: WIP: Herobrine: Fix board id GPIOs
......................................................................
WIP: Herobrine: Fix board id GPIOs
Board IDs did not correspond to the ones in the herobrine schematic
and also returned incorrect values. Correcting so they match the
schematic and also tested so that they returned 0, which is what is
expected.
Signed-off-by: Shelley Chen <shchen(a)google.com>
Change-Id: Idef54591610f4328a88f38e92113e047ffd2f0b7
---
M src/mainboard/google/herobrine/boardid.c
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/57023/1
diff --git a/src/mainboard/google/herobrine/boardid.c b/src/mainboard/google/herobrine/boardid.c
index 2f7ad03..e92d1ef9c 100644
--- a/src/mainboard/google/herobrine/boardid.c
+++ b/src/mainboard/google/herobrine/boardid.c
@@ -12,7 +12,7 @@
uint32_t board_id(void)
{
static uint32_t id = UNDEFINED_STRAPPING_ID;
- const gpio_t pins[] = {[2] = GPIO(50), [1] = GPIO(49), [0] = GPIO(48)};
+ const gpio_t pins[] = {[2] = GPIO(75), [1] = GPIO(74), [0] = GPIO(73)};
if (id == UNDEFINED_STRAPPING_ID)
id = gpio_pulldown_base2_value(pins, ARRAY_SIZE(pins));
--
To view, visit https://review.coreboot.org/c/coreboot/+/57023
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idef54591610f4328a88f38e92113e047ffd2f0b7
Gerrit-Change-Number: 57023
Gerrit-PatchSet: 1
Gerrit-Owner: Shelley Chen <shchen(a)google.com>
Gerrit-MessageType: newchange