Raul Rangel has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57012 )
Change subject: soc/amd/common/upep.asl: Correct device list format
......................................................................
soc/amd/common/upep.asl: Correct device list format
Use correct format for constraint list as expected by kernel driver.
With this change, kernel is able to correctly list dummy device in
constraint list.
BUG=b:194687976
TEST=Build and boot to OS in Guybrush.
Change-Id: I7af1941ffd21cd5864c7285f44cb2d063d2f225f
Signed-off-by: Pratik Vishwakarma <Pratik.Vishwakarma(a)amd.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/57012
Reviewed-by: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Reviewed-by: Raul Rangel <rrangel(a)chromium.org>
Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de>
Reviewed-by: Rob Barnes <robbarnes(a)google.com>
Reviewed-by: Karthik Ramasubramanian <kramasub(a)google.com>
Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org>
---
M src/soc/amd/common/acpi/upep.asl
1 file changed, 9 insertions(+), 4 deletions(-)
Approvals:
build bot (Jenkins): Verified
Felix Held: Looks good to me, approved
Raul Rangel: Looks good to me, approved
Karthik Ramasubramanian: Looks good to me, approved
Rob Barnes: Looks good to me, approved
Jason Glenesk: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/common/acpi/upep.asl b/src/soc/amd/common/acpi/upep.asl
index 3fcf2f7..ef06845 100644
--- a/src/soc/amd/common/acpi/upep.asl
+++ b/src/soc/amd/common/acpi/upep.asl
@@ -34,11 +34,16 @@
* (`INTERNAL_POWER_ERROR`). Returning an empty package does not work.
*/
Name (DEVL, Package() {
+ 0,
+ 1, /* Only 1 dummy device for now */
+
Package() {
- 0, /* Disabled */
- "\\DUMY", /* \DUMY - not existent */
- 0, /* Function States */
- 0 /* Minimum D-state */
+ Package() {
+ 0, /* Disabled */
+ "\\DUMY", /* \DUMY - not existent */
+ 0, /* Function States */
+ 0 /* Minimum D-state */
+ }
}
})
--
To view, visit https://review.coreboot.org/c/coreboot/+/57012
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7af1941ffd21cd5864c7285f44cb2d063d2f225f
Gerrit-Change-Number: 57012
Gerrit-PatchSet: 3
Gerrit-Owner: Pratik Vishwakarma <Pratik.Vishwakarma(a)amd.com>
Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)amd.corp-partner.google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-MessageType: merged
Attention is currently required from: Tim Wawrzynczak, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57035 )
Change subject: soc/intel/alderlake: set power limits dynamically for thermal
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/alderlake/systemagent.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126342):
https://review.coreboot.org/c/coreboot/+/57035/comment/77bff94a_ae369645
PS1, Line 107: soc_config = &config->power_limits_config[ADL_P_POWER_LIMITS_682_28W_CORE];
line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-126342):
https://review.coreboot.org/c/coreboot/+/57035/comment/72d15b0d_fef6f5f4
PS1, Line 109: soc_config = &config->power_limits_config[ADL_P_POWER_LIMITS_682_45W_CORE];
line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/57035
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic331a3debb076ef08a312a31edc1468974fd4902
Gerrit-Change-Number: 57035
Gerrit-PatchSet: 1
Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Wed, 18 Aug 2021 14:29:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment