coreboot-gerrit August 2021

coreboot-gerrit@coreboot.org

1 participants
4520 discussions

Change in coreboot[master]: mb/google/brya: set tcc_offset value to 10
by Paul Menzel (Code Review) 18 Aug '21

18 Aug '21

Attention is currently required from: Furquan Shaikh, Sumeet R Pawnikar, EricR Lai, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57000 ) Change subject: mb/google/brya: set tcc_offset value to 10 ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/57000/comment/727c06de_d9c90965 PS1, Line 10: Circuit (TCC) activation feature. Why 10? Please document, where you got the value from. -- To view, visit https://review.coreboot.org/c/coreboot/+/57000 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I22573e8ca935d99a16b0876768df169db4e61c4d Gerrit-Change-Number: 57000 Gerrit-PatchSet: 1 Gerrit-Owner: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Sumeet R Pawnikar <sumeet.r.pawnikar(a)intel.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 17 Aug 2021 20:30:23 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/variant/drawcia:Include SPD for MT53E512M32D1NP-046 ...
by Paul Menzel (Code Review) 18 Aug '21

18 Aug '21

Attention is currently required from: Henry Sun, Chen Wisley, Wisley Chen, Karthik Ramasubramanian. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56905 ) Change subject: mb/google/dedede/variant/drawcia:Include SPD for MT53E512M32D1NP-046 WT:B ...................................................................... Patch Set 2: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/56905/comment/768a06e2_56cb833f PS2, Line 7: mb/google/dedede/variant/drawcia:Include Please add a space after the colon. https://review.coreboot.org/c/coreboot/+/56905/comment/c96a33bf_08264032 PS2, Line 10: Please mention, why and that `lp4x-spd-1.hex` can be used. -- To view, visit https://review.coreboot.org/c/coreboot/+/56905 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic42e6357943ba651ffd92fb2974e9ea52fa19020 Gerrit-Change-Number: 56905 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Tue, 17 Aug 2021 20:29:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Add NixOS configs for bootable live systems
by Felix Singer (Code Review) 18 Aug '21

18 Aug '21

Attention is currently required from: Timofey Komarov, Nico Huber, Maciej Pijanowski, Michał Żygowski, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Michael Niewöhner, Krystian Hebel, Marcello Sylvester Bauer. Hello Timofey Komarov, build bot (Jenkins), Patrick Georgi, Patrick Rudolph, Paul Menzel, Thomas Heijligen, Michael Niewöhner, Krystian Hebel, Nico Huber, Maciej Pijanowski, Michał Żygowski, Maxim Polyakov, Edward O'Callaghan, Marcello Sylvester Bauer, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/50194 to look at the new patch set (#31). Change subject: util/liveiso: Add NixOS configs for bootable live systems ...................................................................... util/liveiso: Add NixOS configs for bootable live systems Add NixOS configurations for bootable live systems containing a set of tools which might be useful for firmware development in general and for working on coreboot. There are two configurations provided. One for console-only and a graphical one, which is mostly the same as the console image but it comes with Gnome Shell as window manager and some graphical tools in addition. An image can be built using `build-console.sh`, respectively `build-graphical.sh`. The resulting iso image can be found in `result/iso/`. The console image results in ~700MB, while the graphical one results in ~2GB. Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Signed-off-by: Felix Singer <felixsinger(a)posteo.net> --- M MAINTAINERS A util/liveiso/.gitignore A util/liveiso/build-console.sh A util/liveiso/build-graphical.sh A util/liveiso/common.nix A util/liveiso/console.nix A util/liveiso/description.md A util/liveiso/graphical.nix 8 files changed, 262 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/94/50194/31 -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 31 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Maciej Pijanowski Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: util/liveiso: Add NixOS configs for bootable live systems
by Felix Singer (Code Review) 18 Aug '21

18 Aug '21

Attention is currently required from: Timofey Komarov, Nico Huber, Maciej Pijanowski, Michał Żygowski, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Michael Niewöhner, Krystian Hebel, Marcello Sylvester Bauer. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 ) Change subject: util/liveiso: Add NixOS configs for bootable live systems ...................................................................... Patch Set 30: (1 comment) Patchset: PS30: > I wonder, if this should go to util/liveiso/nixos, because we might add other OSes, too. […] As long as we only have this, I would leave it at that. -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 30 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Maciej Pijanowski Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Comment-Date: Tue, 17 Aug 2021 20:25:19 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/(amd,google): Update SPI Kconfig settings based on devicetree
by Karthik Ramasubramanian (Code Review) 18 Aug '21

18 Aug '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Furquan Shaikh, Marshall Dawson, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56885 ) Change subject: mb/(amd,google): Update SPI Kconfig settings based on devicetree ...................................................................... Patch Set 5: (2 comments) File src/mainboard/amd/majolica/Kconfig: https://review.coreboot.org/c/coreboot/+/56885/comment/4ca65044_db32bf94 PS5, Line 61: default 0 # 66MHz Nit: Add a blank line between 2 config items. File src/mainboard/google/guybrush/Kconfig: https://review.coreboot.org/c/coreboot/+/56885/comment/5186159b_ff21f836 PS5, Line 110: config TPM_SPI_SPEED : default 0 # 66MHz : > Can we remove this since we don't use the TPM SPI interface on guybrush/zork? All 4 different SPI speeds are configured using a single register - each 4 bits. The AMD common fch block API requires all 4 speeds be passed for configuration. That API needs to be updated if this were to become an optional configuration. -- To view, visit https://review.coreboot.org/c/coreboot/+/56885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Icce1d57761465ae8255e5d9ce8679f3fdcb0ceed Gerrit-Change-Number: 56885 Gerrit-PatchSet: 5 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 17 Aug 2021 20:04:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Raul Rangel <rrangel(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/amd/majolica/Kconfig: add EFS SPI settings
by Karthik Ramasubramanian (Code Review) 18 Aug '21

18 Aug '21

Attention is currently required from: Felix Singer, Jason Glenesk, Martin Roth, Furquan Shaikh, Marshall Dawson, Felix Held. Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56815 ) Change subject: mb/amd/majolica/Kconfig: add EFS SPI settings ...................................................................... Patch Set 3: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/56815 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8996c2bf606ccd21686092beac8d96b22c0b7869 Gerrit-Change-Number: 56815 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Felix Singer <felixsinger(a)posteo.net> Gerrit-CC: Martin Roth <martinroth(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Tue, 17 Aug 2021 19:54:23 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Add NixOS configs for bootable live systems
by Michael Niewöhner (Code Review) 18 Aug '21

18 Aug '21

Attention is currently required from: Felix Singer, Timofey Komarov, Nico Huber, Maciej Pijanowski, Michał Żygowski, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Krystian Hebel, Marcello Sylvester Bauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 ) Change subject: util/liveiso: Add NixOS configs for bootable live systems ...................................................................... Patch Set 30: (1 comment) File util/liveiso/build-graphical.sh: https://review.coreboot.org/c/coreboot/+/50194/comment/aa663d42_9f4e8f6c PS30, Line 3: config.system.build.isoImage Disclaimer: I have no idea about nix-build. ;) Does this really creat a ISO image? What about defaulting to disk image? I doubt much people in these days will use optical media -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 30 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Maciej Pijanowski Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Comment-Date: Tue, 17 Aug 2021 19:42:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Add NixOS configs for bootable live systems
by Michael Niewöhner (Code Review) 18 Aug '21

18 Aug '21

Attention is currently required from: Felix Singer, Timofey Komarov, Nico Huber, Maciej Pijanowski, Michał Żygowski, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Krystian Hebel, Marcello Sylvester Bauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 ) Change subject: util/liveiso: Add NixOS configs for bootable live systems ...................................................................... Patch Set 30: (1 comment) Patchset: PS30: I wonder, if this should go to util/liveiso/nixos, because we might add other OSes, too. Could be moved later ofc. -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 30 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Maciej Pijanowski Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Comment-Date: Tue, 17 Aug 2021 19:40:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/liveiso: Add NixOS configs for bootable live systems
by Michael Niewöhner (Code Review) 18 Aug '21

18 Aug '21

Attention is currently required from: Felix Singer, Timofey Komarov, Nico Huber, Maciej Pijanowski, Michał Żygowski, Patrick Rudolph, Maxim Polyakov, Paul Menzel, Thomas Heijligen, Edward O'Callaghan, Krystian Hebel, Marcello Sylvester Bauer. Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50194 ) Change subject: util/liveiso: Add NixOS configs for bootable live systems ...................................................................... Patch Set 30: Code-Review+1 (2 comments) Patchset: PS30: I am not familiar with NixOS configs, so I just did a rough plausibility check on these. File util/liveiso/common.nix: https://review.coreboot.org/c/coreboot/+/50194/comment/0d2a3ee6_1c5b986b PS30, Line 3: # TODO : # - Use programs.flashrom.enable (#128205) and add `user` to `flashrom` group. : # Will be useable from the next NixOS release. : # - Generate customized bootloader configs; FILO is WIP : # - Add coreboot toolchain : I would move that to description.md -- To view, visit https://review.coreboot.org/c/coreboot/+/50194 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iaf49d198e99781434bd89d2a8a125a4988b77e1c Gerrit-Change-Number: 50194 Gerrit-PatchSet: 30 Gerrit-Owner: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Reviewer: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Maciej Pijanowski Gerrit-Reviewer: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Thomas Heijligen <src(a)posteo.de> Gerrit-Reviewer: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Felix Singer <felixsinger(a)posteo.net> Gerrit-Attention: Timofey Komarov <happycorsair(a)yandex.ru> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Maciej Pijanowski Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Maxim Polyakov <max.senia.poliak(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Thomas Heijligen <src(a)posteo.de> Gerrit-Attention: Edward O'Callaghan <quasisec(a)chromium.org> Gerrit-Attention: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Attention: Marcello Sylvester Bauer <sylv(a)sylv.io> Gerrit-Comment-Date: Tue, 17 Aug 2021 19:40:34 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: acpigen: Add ability to auto-generate _DSM Function 0
by Tim Wawrzynczak (Code Review) 18 Aug '21

18 Aug '21

Attention is currently required from: Furquan Shaikh, Sugnan Prabhu S, EricR Lai. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56459 ) Change subject: acpigen: Add ability to auto-generate _DSM Function 0 ...................................................................... Patch Set 5: (1 comment) File src/acpi/acpigen.c: https://review.coreboot.org/c/coreboot/+/56459/comment/a58014a5_a5ed5dc2 PS5, Line 1657: : for (size_t i = 1; i < id->count; i++) { : if (id->callbacks[i]) { : const size_t buffer_idx = i / (sizeof(uint8_t) * BITS_PER_BYTE); : const size_t bit_idx = i % (sizeof(uint8_t) * BITS_PER_BYTE); : : set = true; : buffer[buffer_idx] |= BIT(bit_idx); : } : } > Hi Tim, […] Thanks for testing Sugnan! I have fixed the, see the next patchset. -- To view, visit https://review.coreboot.org/c/coreboot/+/56459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id9be050442485b42202cf91649aa94e56f35032a Gerrit-Change-Number: 56459 Gerrit-PatchSet: 5 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Lance Zhao Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rizwan Qureshi <rizwan.qureshi(a)intel.com> Gerrit-CC: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Tue, 17 Aug 2021 19:37:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Sugnan Prabhu S <sugnan.prabhu.s(a)intel.com> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit August 2021