Dtrain Hsu has created a revert of this change. ( https://review.coreboot.org/c/coreboot/+/55935 )
Change subject: mb/google/dedede/var/cret: Disable SDCard controller
......................................................................
--
To view, visit https://review.coreboot.org/c/coreboot/+/55935
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I889f0545883aa75813dd91dc3e6a4dcfc246687f
Gerrit-Change-Number: 55935
Gerrit-PatchSet: 2
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-MessageType: revert
Attention is currently required from: Henry Sun, Ben Kao, Karthik Ramasubramanian.
Hello build bot (Jenkins), Patrick Georgi, Henry Sun, Ben Kao, Karthik Ramasubramanian,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/56729
to review the following change.
Change subject: Revert "mb/google/dedede/var/cret: Disable SDCard controller"
......................................................................
Revert "mb/google/dedede/var/cret: Disable SDCard controller"
This reverts commit f29437862269de24f85392d49f6afa6fa60ac43e.
Reason for revert: It makes cret can't boot to os without depthcharge change. The depthcharge change related with fw_config and will effect other variants.
BUG=b:194961854
TEST=Build and boot to OS.
Change-Id: I929369c9419375e74be61a4ff3e5566b0f41ce65
---
M src/mainboard/google/dedede/variants/cret/overridetree.cb
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/56729/1
diff --git a/src/mainboard/google/dedede/variants/cret/overridetree.cb b/src/mainboard/google/dedede/variants/cret/overridetree.cb
index 8b26d5d..be84c79 100644
--- a/src/mainboard/google/dedede/variants/cret/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/cret/overridetree.cb
@@ -100,7 +100,6 @@
end
end
end # USB xHCI
- device pci 14.5 off end # SDCard
device pci 15.0 on
chip drivers/i2c/generic
register "hid" = ""ELAN0000""
--
To view, visit https://review.coreboot.org/c/coreboot/+/56729
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I929369c9419375e74be61a4ff3e5566b0f41ce65
Gerrit-Change-Number: 56729
Gerrit-PatchSet: 1
Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com>
Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Ben Kao <ben.kao(a)intel.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: newchange
Attention is currently required from: Henry Sun, Bob Moragues, Aseda Aboagye.
Sunwei Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56658 )
Change subject: mb/google/dedede/var/cappy2: Add Tpm2.0 device support
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/dedede/variants/cappy2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56658/comment/dcf14880_8bc4697f
PS4, Line 102: 1f.5
> Can we move this to 1f. […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56658
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I216ceb6386ad57c9f1982187a4525d89869fa9c4
Gerrit-Change-Number: 56658
Gerrit-PatchSet: 5
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 08:59:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Bob Moragues, Aseda Aboagye.
Sunwei Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56687 )
Change subject: mb/google/dedede/var/cappy2: Disable external bypass VR
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56687/comment/e1e4c974_ef93853d
PS2, Line 7: For anpec apw8738bqbi shortage
> nit: A better subject might be "Disable external bypass VR"
Done
https://review.coreboot.org/c/coreboot/+/56687/comment/0d1eccda_00fe4e79
PS2, Line 9: Cappy2 have removed the anpec apw8738bqbi
> Can you elaborate about how removing that part corresponds with setting this option?
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56687
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb4182a989459db629e3b69757c293ca26e8b0cd
Gerrit-Change-Number: 56687
Gerrit-PatchSet: 4
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Attention: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 08:57:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Sunwei Li, Henry Sun, Bob Moragues.
Hello build bot (Jenkins), Henry Sun, Bob Moragues, Aseda Aboagye, Weimin Wu, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56687
to look at the new patch set (#4).
Change subject: mb/google/dedede/var/cappy2: Disable external bypass VR
......................................................................
mb/google/dedede/var/cappy2: Disable external bypass VR
The cappy2 removed the anpec apw8738bqbi and "disable_external_bypass_vr" should be set to "1" to disable
BUG=b:194146867
BRANCH=dedede
TEST=VCCIN_AUX is disable
Signed-off-by: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Change-Id: Ieb4182a989459db629e3b69757c293ca26e8b0cd
---
M src/mainboard/google/dedede/variants/cappy2/overridetree.cb
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/56687/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/56687
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb4182a989459db629e3b69757c293ca26e8b0cd
Gerrit-Change-Number: 56687
Gerrit-PatchSet: 4
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sunwei Li, Henry Sun, Bob Moragues.
Hello build bot (Jenkins), Henry Sun, Bob Moragues, Aseda Aboagye, Weimin Wu, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56687
to look at the new patch set (#3).
Change subject: mb/google/dedede/var/cappy2: Disable external bypass VR
......................................................................
mb/google/dedede/var/cappy2: Disable external bypass VR
The cappy2 removed the anpec apw8738bqbi and "disable_external_bypass_vr"
should be set to "1" to disable
BUG=b:194146867
BRANCH=dedede
TEST=VCCIN_AUX is disable
Signed-off-by: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Change-Id: Ieb4182a989459db629e3b69757c293ca26e8b0cd
---
M src/mainboard/google/dedede/variants/cappy2/overridetree.cb
1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/87/56687/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56687
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb4182a989459db629e3b69757c293ca26e8b0cd
Gerrit-Change-Number: 56687
Gerrit-PatchSet: 3
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Malik Hsu, Mark Hsieh, Anfernee Chen.
Casper Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56165 )
Change subject: mb/google/brya: Update the FIVR configurations
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Patchset:
PS5:
Hi Tim,
Will you help to submit this change?
Thanks a lot.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c6b97e0b003560e1e22c96c5c3a1328fe876f47
Gerrit-Change-Number: 56165
Gerrit-PatchSet: 5
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Attention: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 08:44:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Malik Hsu, Mark Hsieh, Anfernee Chen, Casper Chang.
Hello build bot (Jenkins), Malik Hsu, Tim Wawrzynczak, Mark Hsieh, Anfernee Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56165
to look at the new patch set (#5).
Change subject: mb/google/brya: Update the FIVR configurations
......................................................................
mb/google/brya: Update the FIVR configurations
This patch sets the disable the external voltage rails since brya
board doesn't have V1p05 and Vnn bypass rails implemented.
Reference CB:55704
BUG=b:191897776, b:191213263
Signed-off-by: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Change-Id: I5c6b97e0b003560e1e22c96c5c3a1328fe876f47
---
M src/mainboard/google/brya/variants/baseboard/brya/devicetree.cb
M src/mainboard/google/brya/variants/brya0/overridetree.cb
2 files changed, 6 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/65/56165/5
--
To view, visit https://review.coreboot.org/c/coreboot/+/56165
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c6b97e0b003560e1e22c96c5c3a1328fe876f47
Gerrit-Change-Number: 56165
Gerrit-PatchSet: 5
Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com>
Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com>
Gerrit-Attention: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com>
Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Sunwei Li, Henry Sun, Bob Moragues.
Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56687 )
Change subject: mb/google/dedede/var/cappy2: For anpec apw8738bqbi shortage
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56687/comment/83e63436_36ea7f4a
PS2, Line 7: For anpec apw8738bqbi shortage
nit: A better subject might be "Disable external bypass VR"
https://review.coreboot.org/c/coreboot/+/56687/comment/a578e2cd_1fa6c548
PS2, Line 9: Cappy2 have removed the anpec apw8738bqbi
Can you elaborate about how removing that part corresponds with setting this option?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56687
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieb4182a989459db629e3b69757c293ca26e8b0cd
Gerrit-Change-Number: 56687
Gerrit-PatchSet: 2
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 08:27:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sunwei Li, Henry Sun, Bob Moragues.
Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56658 )
Change subject: mb/google/dedede/var/cappy2: Add Tpm2.0 device support
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/dedede/variants/cappy2/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56658/comment/270ab490_c20ca18c
PS4, Line 102: 1f.5
Can we move this to 1f.0? On an earlier variant, we were getting messages in coreboot about the TPM going to the default ACPI address. I think the functionality should still be the same.
"Using default TPM ACPI path: '\_SB_.PCI0.LPCB'"
--
To view, visit https://review.coreboot.org/c/coreboot/+/56658
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I216ceb6386ad57c9f1982187a4525d89869fa9c4
Gerrit-Change-Number: 56658
Gerrit-PatchSet: 4
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 08:25:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment