Attention is currently required from: Ravi kumar, Sajida Bhanu, Paul Menzel, Julius Werner.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55376 )
Change subject: spi: Limit the SPI NOR size
......................................................................
Patch Set 16:
(1 comment)
Patchset:
PS1:
> Hi Julius, […]
The split has landed in chromium. Please use the board/piglin/defconfig to make the needed modifications.
--
To view, visit https://review.coreboot.org/c/coreboot/+/55376
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I78f3f402b383bbad303f26c31d3d973c5f20d172
Gerrit-Change-Number: 55376
Gerrit-PatchSet: 16
Gerrit-Owner: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Sajida Bhanu <sbhanu(a)codeaurora.org>
Gerrit-Reviewer: Shelley Chen <shchen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Ravi kumar <rbokka(a)codeaurora.org>
Gerrit-Attention: Sajida Bhanu <sbhanu(a)codeaurora.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 03:21:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sajida Bhanu <sbhanu(a)codeaurora.org>
Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com>
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Shou-Chieh Hsu, Karthik Ramasubramanian.
Ren Kuo has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56685 )
Change subject: mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
......................................................................
Patch Set 7:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56685/comment/6cc8fddc_a5917871
PS6, Line 12: magister and magma
> I am concerned if the impact is well understood across all Mag* devices with all possible RO/RW FW c […]
The other Mag* projects are under development stages,and haven't went to PVT stages. They can modify the ssfc value of the firmware change.
In current status, we only need to write SSFC for Elan6918 of Magister in production line. Other tocuhscreen devices have their own I2C slave address,and
using default value ssfc = 0x0.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Gerrit-Change-Number: 56685
Gerrit-PatchSet: 7
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Henry Sun <henrysun(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 02:19:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Tim Wawrzynczak.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56698 )
Change subject: MAINTAINERS: Add myself for src/security/vboot
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Could you explain to me what this file is for? Does Gerrit automatically add people as CL reviewers based on that?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56698
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I560a333c807ad5e055a0e035e675195d9cbbf954
Gerrit-Change-Number: 56698
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 02:14:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Ren Kuo, Shou-Chieh Hsu.
Hello build bot (Jenkins), David Wu, Furquan Shaikh, Tyler Wang, Shou-Chieh Hsu, Karthik Ramasubramanian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56685
to look at the new patch set (#7).
Change subject: mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
......................................................................
mb/google/dedede/var/magolor: Modify SSFC for camera and touchscreen
The all shipped magolor and maglia has been set as SSFC= 0x840 (5M MIPI camera)in CBI eeprom.
But the value:0x840 will confilict with the following definied touchcreen field.
It cause some touchsreen no funtion if user make auto-update new firmware.
The CL is a workaround to fix the problem,and it will impact magister and magma project's SSFC value for touchscreen.
The original field:
field CAMERA_WFC 38 40
field TS_SOURCE 41 44
Modify field and mipi camera value to consistent with released CBI bin:
CAMERA_OVTI5675 33 (SSFC = 0x840)
CAMERA_OVTI8856 34 (SSFC = 0x880)
Modified field:
field CAMERA_WFC 38 43
field TS_SOURCE 44 47
BUG=b:194639170
TEST=Build firmware and verify on camera and touch-sreen devices
Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Signed-off-by: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
---
M src/mainboard/google/dedede/variants/magolor/overridetree.cb
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/56685/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/56685
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I13d76ce8b932f483e20ca5388f1c67eb39ba12a1
Gerrit-Change-Number: 56685
Gerrit-PatchSet: 7
Gerrit-Owner: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-Reviewer: Tyler Wang <tyler.wang(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Henry Sun <henrysun(a)google.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Ren Kuo <ren.kuo(a)quanta.corp-partner.google.com>
Gerrit-Attention: Shou-Chieh Hsu <shouchieh(a)google.com>
Gerrit-MessageType: newpatchset
Attention is currently required from: Nick Vaccaro, Wisley Chen.
Chen Wisley has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56656 )
Change subject: mb/google/brya/variants/redrix: Init devicetree for redrix
......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
Hi Tim,
Please help to review again.
In https://crrev.com/i/4017807 which re-define fw_config bit field, so I revised fw_config bit field in overridetree.cb.
Thanks
--
To view, visit https://review.coreboot.org/c/coreboot/+/56656
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9fb752fe8280893b84c172d8a519578fa4220184
Gerrit-Change-Number: 56656
Gerrit-PatchSet: 5
Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 01:58:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson.
Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56700
to look at the new patch set (#2).
Change subject: soc/amd/common/block/gpio_banks/gpio: use gpio_t for GPIO numbers
......................................................................
soc/amd/common/block/gpio_banks/gpio: use gpio_t for GPIO numbers
Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de>
Change-Id: I7cf9cbd2a287dcfe3a47a8a6b164c2b3d8ae95d6
---
M src/soc/amd/common/block/gpio_banks/gpio.c
1 file changed, 10 insertions(+), 10 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/56700/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56700
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7cf9cbd2a287dcfe3a47a8a6b164c2b3d8ae95d6
Gerrit-Change-Number: 56700
Gerrit-PatchSet: 2
Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com>
Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com>
Gerrit-MessageType: newpatchset