Attention is currently required from: Varshit B Pandya, Maulik V Vaghela, Tim Wawrzynczak.
Hello build bot (Jenkins), Maulik V Vaghela, Tim Wawrzynczak, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56655
to look at the new patch set (#4).
Change subject: mb/google/brya: Configure H21 as GPO and A17 as low
......................................................................
mb/google/brya: Configure H21 as GPO and A17 as low
As per the schematics, UFC has on card oscillator so we donot need
H21 in NF1 that is IMGCLKOUT
H21 is used to enable this oscialltor so configuring it as 1
A17 is configured as high while _ON method is called by driver and
it is configured as low when _OFF method is called by driver.
Hence coreboot should configure it as low on boot.
BUG=b:190674542
Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Change-Id: I745169a5ab6a9c20b6e1bda792a43193d04ac48d
---
M src/mainboard/google/brya/variants/baseboard/brya/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/56655/4
--
To view, visit https://review.coreboot.org/c/coreboot/+/56655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I745169a5ab6a9c20b6e1bda792a43193d04ac48d
Gerrit-Change-Number: 56655
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Varshit B Pandya.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56621 )
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
Patchset:
PS8:
This is verified and we can capture raw image. Please rebase to parent.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 8
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 06:17:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Varshit B Pandya, Maulik V Vaghela, Tim Wawrzynczak.
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56655 )
Change subject: mb/google/brya: Configure GPP_H21 as GPO
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Patchset:
PS3:
nits: you should include A17 in comment and title.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I745169a5ab6a9c20b6e1bda792a43193d04ac48d
Gerrit-Change-Number: 56655
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 06:15:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, EricR Lai.
Hello build bot (Jenkins), Maulik V Vaghela, Tim Wawrzynczak, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56655
to look at the new patch set (#3).
Change subject: mb/google/brya: Configure GPP_H21 as GPO
......................................................................
mb/google/brya: Configure GPP_H21 as GPO
As per the schematics, UFC has on card oscillator so we donot need
H21 in NF1 that is IMGCLKOUT
H21 is used to enable this oscialltor so configuring it as 1
BUG=b:190674542
Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Change-Id: I745169a5ab6a9c20b6e1bda792a43193d04ac48d
---
M src/mainboard/google/brya/variants/baseboard/brya/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/56655/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/56655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I745169a5ab6a9c20b6e1bda792a43193d04ac48d
Gerrit-Change-Number: 56655
Gerrit-PatchSet: 3
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: newpatchset
Hello build bot (Jenkins), Tim Wawrzynczak, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56621
to look at the new patch set (#8).
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
mb/google/brya: Update entries for UFC to support IMX208
1. Replace OV5675 ACPI entries with IMX208
2. Replace FW_CONFIG name
3. Add support for NVM inside UFC
BUG=b:190674542
TEST=Build and boot to OS on Brya, raw capture on UFC
Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
---
M src/mainboard/google/brya/variants/brya0/overridetree.cb
1 file changed, 30 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/56621/8
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 8
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak, EricR Lai.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56655 )
Change subject: mb/google/brya: Configure GPP_H21 as GPO
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS1:
> How about set the power pins default low A17 F20 C3 H21.. etc? Also do this for WFC pins..
agreed, updated the patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I745169a5ab6a9c20b6e1bda792a43193d04ac48d
Gerrit-Change-Number: 56655
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 05:39:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56621 )
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
Patch Set 7:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 7
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 05:39:15 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Varshit B Pandya, Maulik V Vaghela, Tim Wawrzynczak.
Hello build bot (Jenkins), Maulik V Vaghela, Tim Wawrzynczak, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56655
to look at the new patch set (#2).
Change subject: mb/google/brya: Configure GPP_H21 as GPO
......................................................................
mb/google/brya: Configure GPP_H21 as GPO
As per the schematics, UFC has on card oscillator so we donot need
H21 in NF1 that is IMGCLKOUT
H21 is used to enable this oscialltor so configuring it as 1
Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Change-Id: I745169a5ab6a9c20b6e1bda792a43193d04ac48d
---
M src/mainboard/google/brya/variants/baseboard/brya/gpio.c
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/56655/2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I745169a5ab6a9c20b6e1bda792a43193d04ac48d
Gerrit-Change-Number: 56655
Gerrit-PatchSet: 2
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newpatchset
Attention is currently required from: Tim Wawrzynczak, Scott Chao, Rajat Jain.
Lance Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56709 )
Change subject: arch/x86/acpi: Add code for KEY_MICMUTE and KEY_KBDILLUMTOGGLE
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/56709
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic39ecb3118e885c9e6d84d7b78bf435cb903d17e
Gerrit-Change-Number: 56709
Gerrit-PatchSet: 1
Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Rajat Jain <rajatja(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com>
Gerrit-Attention: Rajat Jain <rajatja(a)google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 03:53:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment