Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Julius Werner.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56697 )
Change subject: MAINTAINERS: Remove Aaron Durbin
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
You can remove me. I can always be added back if needed.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife7c75ab8290873da1e02332609482c407373c45
Gerrit-Change-Number: 56697
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Comment-Date: Thu, 29 Jul 2021 23:50:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Rob Barnes.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56667 )
Change subject: guybrush: Document USB mapping in devicetree
......................................................................
Patch Set 3:
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/56667/comment/56986be1_94480d88
PS2, Line 222: register "desc" = ""Right Type-C Port""
> Should this actually be Left Type-C port / C0?
You are right. This should be corrected. Also the same for Right Type-A/Type-C ports.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14cbb6af021bb27c89aa82456722f21aa09617be
Gerrit-Change-Number: 56667
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Thu, 29 Jul 2021 23:28:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Rob Barnes <robbarnes(a)google.com>
Gerrit-MessageType: comment
Attention is currently required from: Aaron Durbin, Furquan Shaikh, Julius Werner.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56697 )
Change subject: MAINTAINERS: Remove Aaron Durbin
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
> People can usually keep their @chromium.org emails after leaving Google if they want to. […]
Ah I see, I thought it was a package deal. I'll abandon this if you want Aaron
--
To view, visit https://review.coreboot.org/c/coreboot/+/56697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife7c75ab8290873da1e02332609482c407373c45
Gerrit-Change-Number: 56697
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Aaron Durbin <adurbin(a)gmail.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Comment-Date: Thu, 29 Jul 2021 22:09:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56697 )
Change subject: MAINTAINERS: Remove Aaron Durbin
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
People can usually keep their @chromium.org emails after leaving Google if they want to. Not sure if Aaron did, or if he'd like to have this rewritten to his personal email. We should at least ask (coreboot maintainership is not tied to specific employment at any company, after all).
FWIW, if we want another entry for maintaining the vboot code, feel free to put my name in there (instead or in addition).
--
To view, visit https://review.coreboot.org/c/coreboot/+/56697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife7c75ab8290873da1e02332609482c407373c45
Gerrit-Change-Number: 56697
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-CC: Julius Werner <jwerner(a)chromium.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Thu, 29 Jul 2021 21:47:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Tim Wawrzynczak has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/56697 )
Change subject: MAINTAINERS: Remove Aaron Durbin
......................................................................
MAINTAINERS: Remove Aaron Durbin
Aaron is no longer employed at Google and probably doesn't have access
to a chromium.org email account anymore, therefore remove this account
from MAINTAINERS.
Change-Id: Ife7c75ab8290873da1e02332609482c407373c45
Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
---
M MAINTAINERS
1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/56697/1
diff --git a/MAINTAINERS b/MAINTAINERS
index 74f1854..02fe5fe 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -824,7 +824,6 @@
F: src/drivers/uart/
VERIFIED BOOT 2
-M: Aaron Durbin <adurbin(a)chromium.org>
F: src/security/vboot/
TPM SUPPORT
--
To view, visit https://review.coreboot.org/c/coreboot/+/56697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife7c75ab8290873da1e02332609482c407373c45
Gerrit-Change-Number: 56697
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: newchange
Tim Wawrzynczak has removed Aaron Durbin from this change. ( https://review.coreboot.org/c/coreboot/+/56673 )
Change subject: security/vboot: Initialize CMOS before attempting backup
......................................................................
Removed reviewer Aaron Durbin.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56673
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I711457a3ed5c22ec51ebd5fe7f05400da17d1b11
Gerrit-Change-Number: 56673
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: deleteReviewer
Attention is currently required from: Furquan Shaikh, Angel Pons, Patrick Rudolph.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56617 )
Change subject: soc/intel/alderlake: Clear RTC_BATTERY_DEAD
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/56617/comment/affd32f2_1516aefa
PS1, Line 188: soc_get_rtc_failed
> Find a patch at the end of the this train that re-initializes CMOS in this particular boot flow.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56617
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9dc21c19ea8ce561e9655e189ec26aba7a07967e
Gerrit-Change-Number: 56617
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 29 Jul 2021 21:31:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com>
Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-MessageType: comment