Attention is currently required from: Sunwei Li, Henry Sun, Bob Moragues.
Aseda Aboagye has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56647 )
Change subject: mb/google/dedede/var/cappy2: Add camera support
......................................................................
Patch Set 4: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56647
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3275ab408f6a03735a35eaa8025c36df09c9898c
Gerrit-Change-Number: 56647
Gerrit-PatchSet: 4
Gerrit-Owner: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: Aseda Aboagye <aaboagye(a)google.com>
Gerrit-Reviewer: Bob Moragues <moragues(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Weimin Wu <wuweimin(a)huaqin.corp-partner.google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Tao Xia <xiatao5(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Sunwei Li <lisunwei(a)huaqin.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Bob Moragues <moragues(a)google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 08:10:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Henry Sun, Stanley Wu, Paul Fagerburg.
Ben Kao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56689 )
Change subject: mb/google/dedede/var/boten: Set the xHCI LFPS period sampling off time to 0ms
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56689
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9328e758ed92389e44b25ff4daf6ec19b37ae7d6
Gerrit-Change-Number: 56689
Gerrit-PatchSet: 1
Gerrit-Owner: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.corp-partner.google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Melo Chuang <melo.chuang(a)lcfc.corp-partner.google.com>
Gerrit-CC: Rasheed Hsueh <rasheed.hsueh(a)lcfc.corp-partner.google.com>
Gerrit-CC: Sunshine Chao <sunshine.chao(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Attention: Stanley Wu <stanley1.wu(a)lcfc.corp-partner.google.com>
Gerrit-Attention: Paul Fagerburg <pfagerburg(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 07:34:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Martin Roth, Rob Barnes.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56667 )
Change subject: guybrush: Document USB mapping in devicetree
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56667/comment/d7fc5809_772d7af0
PS3, Line 7: guybrush
Please use the more common longer prefix:
> mb/google/guybrush:
--
To view, visit https://review.coreboot.org/c/coreboot/+/56667
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I14cbb6af021bb27c89aa82456722f21aa09617be
Gerrit-Change-Number: 56667
Gerrit-PatchSet: 3
Gerrit-Owner: Rob Barnes <robbarnes(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Martin Roth <martinroth(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Raul Rangel <rrangel(a)chromium.org>
Gerrit-Attention: Martin Roth <martinroth(a)google.com>
Gerrit-Attention: Rob Barnes <robbarnes(a)google.com>
Gerrit-Comment-Date: Fri, 30 Jul 2021 07:02:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56697 )
Change subject: MAINTAINERS: Remove Aaron Durbin
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56697/comment/5e04022d_17e4ff7e
PS1, Line 9: and probably doesn't have access
: to a chromium.org email account anymore
Maybe remove that statement, and replace it by: “and is not actively working on this anymore”
--
To view, visit https://review.coreboot.org/c/coreboot/+/56697
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ife7c75ab8290873da1e02332609482c407373c45
Gerrit-Change-Number: 56697
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org>
Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 06:59:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56621 )
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/variants/brya0/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56621/comment/a9e94080_f4241bd9
PS4, Line 28: option UFC_MIPI_5675 1
> yes will add that
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 9
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 06:34:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56621 )
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/brya/variants/brya0/gpio.c:
https://review.coreboot.org/c/coreboot/+/56621/comment/daa43017_c7b129f4
PS3, Line 68: PAD_CFG_GPO(GPP_H21, 1, DEEP),
> not correct, this is for P0 and P1 GPIO. P2 gpio is in the baseboard.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 9
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 06:34:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: Paul Menzel.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56621 )
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
Patch Set 9:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56621/comment/25627c63_45071d6a
PS4, Line 8:
> Yes Paul, I am still experimenting with this patch will have to split this patch also, will update t […]
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 9
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 06:34:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: comment
Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak.
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56655 )
Change subject: mb/google/brya: Configure H21 as GPO and A17 as low
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
> nits: you should include A17 in comment and title.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56655
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I745169a5ab6a9c20b6e1bda792a43193d04ac48d
Gerrit-Change-Number: 56655
Gerrit-PatchSet: 4
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 06:31:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Varshit B Pandya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56621 )
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
Patch Set 9:
(1 comment)
Patchset:
PS8:
> This is verified and we can capture raw image. Please rebase to parent.
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 9
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Fri, 30 Jul 2021 06:31:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-MessageType: comment
Hello build bot (Jenkins), Tim Wawrzynczak, EricR Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56621
to look at the new patch set (#9).
Change subject: mb/google/brya: Update entries for UFC to support IMX208
......................................................................
mb/google/brya: Update entries for UFC to support IMX208
1. Replace OV5675 ACPI entries with IMX208
2. Replace FW_CONFIG name
3. Add support for NVM inside UFC
BUG=b:190674542
TEST=Build and boot to OS on Brya, raw capture on UFC
Signed-off-by: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
---
M src/mainboard/google/brya/variants/brya0/overridetree.cb
1 file changed, 30 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/21/56621/9
--
To view, visit https://review.coreboot.org/c/coreboot/+/56621
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6a3bf13ec844fb46e11ce58382057fcc7187c135
Gerrit-Change-Number: 56621
Gerrit-PatchSet: 9
Gerrit-Owner: Varshit B Pandya <varshit.b.pandya(a)intel.com>
Gerrit-Reviewer: EricR Lai <ericr_lai(a)compal.corp-partner.google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Maulik V Vaghela <maulik.v.vaghela(a)intel.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-MessageType: newpatchset