coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5824 discussions

Change in coreboot[master]: mb/google/brya: introduce the brask to the baseboard
by Tim Wawrzynczak (Code Review) 30 Jul '21

30 Jul '21

Attention is currently required from: Furquan Shaikh, Paul Menzel, Zhuohao Lee. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56388 ) Change subject: mb/google/brya: introduce the brask to the baseboard ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56388/comment/a1b99c05_392087c7 PS5, Line 7: introduce the brask to the baseboard > Yeah, Brask is a new baseboard. […] What about quick changing the commit title to: `mb/google/brya: Introduce new baseboard brask` ? -- To view, visit https://review.coreboot.org/c/coreboot/+/56388 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1bb42c7bb2492402de0810bc4ab2e8d8c0e2392b Gerrit-Change-Number: 56388 Gerrit-PatchSet: 5 Gerrit-Owner: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Zhuohao Lee <zhuohao(a)google.com> Gerrit-Attention: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Comment-Date: Fri, 30 Jul 2021 14:16:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Zhuohao Lee <zhuohao(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/variants/redrix: Init devicetree for redrix
by Tim Wawrzynczak (Code Review) 30 Jul '21

30 Jul '21

Attention is currently required from: Chen Wisley, Nick Vaccaro, Wisley Chen. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56656 ) Change subject: mb/google/brya/variants/redrix: Init devicetree for redrix ...................................................................... Patch Set 5: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56656 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9fb752fe8280893b84c172d8a519578fa4220184 Gerrit-Change-Number: 56656 Gerrit-PatchSet: 5 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Comment-Date: Fri, 30 Jul 2021 14:14:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests/Makefile.inc: Add function wrapping mechanism
by Jakub Czapiga (Code Review) 30 Jul '21

30 Jul '21

Attention is currently required from: Julius Werner, Jan Dabros. Hello build bot (Jenkins), Julius Werner, Jan Dabros, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56719 to look at the new patch set (#2). Change subject: tests/Makefile.inc: Add function wrapping mechanism ...................................................................... tests/Makefile.inc: Add function wrapping mechanism This patch extends mocks functionality to allowing wrapping of mocked functions. Original function name will be prefixed with `__real_`. Example: - Mocked function: cbfs_lookup() - New function name: __real_cbfs_lookup() - Mock name: cbfs_lookup() Signed-off-by: Jakub Czapiga <jacz(a)semihalf.com> Change-Id: I7cd0d66a17029955cbf75c8b155a7ebb7f5513aa --- M tests/Makefile.inc 1 file changed, 10 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/19/56719/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56719 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7cd0d66a17029955cbf75c8b155a7ebb7f5513aa Gerrit-Change-Number: 56719 Gerrit-PatchSet: 2 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya/variants/gimble: add TcssAuxOri
by Tim Wawrzynczak (Code Review) 30 Jul '21

30 Jul '21

Attention is currently required from: Furquan Shaikh, Scott Chao. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56715 ) Change subject: mb/google/brya/variants/gimble: add TcssAuxOri ...................................................................... Patch Set 1: (1 comment) File src/mainboard/google/brya/variants/gimble/overridetree.cb: https://review.coreboot.org/c/coreboot/+/56715/comment/203a5e60_7e04df5b PS1, Line 23: register "TcssAuxOri" = "1" Without a retimer on port 0, I think you will also need to do the following: 1) Ensure the GPIOs used for AUX biasing on port 0 are programmed as NF6 (looks like GPP_E22 and GPP_E23 ?) 2) Add the following to the devicetree; this lets the SoC IOM firmware control the Aux DC bias voltages: `register "typec_aux_bias_pads[0]" = "{.pad_auxp_dc = GPP_E22, .pad_auxn_dc = GPP_E23}"` -- To view, visit https://review.coreboot.org/c/coreboot/+/56715 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I057048c14110bb81bf5b5fd0e3151deb031ca5d4 Gerrit-Change-Number: 56715 Gerrit-PatchSet: 1 Gerrit-Owner: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-CC: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Fri, 30 Jul 2021 14:11:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Update the FIVR configurations
by Tim Wawrzynczak (Code Review) 30 Jul '21

30 Jul '21

Attention is currently required from: Malik Hsu, Paul Menzel, Mark Hsieh, Anfernee Chen, Casper Chang. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56165 ) Change subject: mb/google/brya: Update the FIVR configurations ...................................................................... Patch Set 5: Code-Review+2 (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56165/comment/a72bdab9_cab391c2 PS5, Line 9: This patch sets the disable the external voltage rails > It’s hard for me to understand. […] `This patch disables the external voltage rails, since brya doesn't implement the V1p05 and Vnn bypass rails.` -- To view, visit https://review.coreboot.org/c/coreboot/+/56165 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5c6b97e0b003560e1e22c96c5c3a1328fe876f47 Gerrit-Change-Number: 56165 Gerrit-PatchSet: 5 Gerrit-Owner: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Scott Chao <scott_chao(a)wistron.corp-partner.google.com> Gerrit-Attention: Malik Hsu <malik_hsu(a)wistron.corp-partner.google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Mark Hsieh <mark_hsieh(a)wistron.corp-partner.google.com> Gerrit-Attention: Anfernee Chen <anfernee_chen(a)wistron.corp-partner.google.com> Gerrit-Attention: Casper Chang <casper_chang(a)wistron.corp-partner.google.com> Gerrit-Comment-Date: Fri, 30 Jul 2021 14:02:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: MAINTAINERS: Remove Aaron Durbin
by Tim Wawrzynczak (Code Review) 30 Jul '21

30 Jul '21

Attention is currently required from: Furquan Shaikh, Paul Menzel. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56697 ) Change subject: MAINTAINERS: Remove Aaron Durbin ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56697/comment/5f415ba3_b24f5143 PS1, Line 9: and probably doesn't have access : to a chromium.org email account anymore > Maybe remove that statement, and replace it by: “and is not actively working on this anymore” Done -- To view, visit https://review.coreboot.org/c/coreboot/+/56697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife7c75ab8290873da1e02332609482c407373c45 Gerrit-Change-Number: 56697 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 30 Jul 2021 13:54:49 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: MAINTAINERS: Remove Aaron Durbin
by Tim Wawrzynczak (Code Review) 30 Jul '21

30 Jul '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak. Hello build bot (Jenkins), Furquan Shaikh, Paul Menzel, Julius Werner, Aaron Durbin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/56697 to look at the new patch set (#2). Change subject: MAINTAINERS: Remove Aaron Durbin ...................................................................... MAINTAINERS: Remove Aaron Durbin Aaron is no longer employed at Google and is not actively working on coreboot anymore, therefore remove this account from MAINTAINERS. Change-Id: Ife7c75ab8290873da1e02332609482c407373c45 Signed-off-by: Tim Wawrzynczak <twawrzynczak(a)chromium.org> --- M MAINTAINERS 1 file changed, 0 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/56697/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/56697 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ife7c75ab8290873da1e02332609482c407373c45 Gerrit-Change-Number: 56697 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: MAINTAINERS: Add myself for src/security/vboot
by Tim Wawrzynczak (Code Review) 30 Jul '21

30 Jul '21

Tim Wawrzynczak has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/56698 ) Change subject: MAINTAINERS: Add myself for src/security/vboot ...................................................................... Abandoned -- To view, visit https://review.coreboot.org/c/coreboot/+/56698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I560a333c807ad5e055a0e035e675195d9cbbf954 Gerrit-Change-Number: 56698 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: MAINTAINERS: Add myself for src/security/vboot
by Tim Wawrzynczak (Code Review) 30 Jul '21

30 Jul '21

Attention is currently required from: Julius Werner. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56698 ) Change subject: MAINTAINERS: Add myself for src/security/vboot ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Do you have much experience with this code, Tim? I don't mind adding extra people to the list (or if […] I do have some, not nearly as much as Joel or you 😊 I just figured having someone there was better than no one. I didn't realize yupingso@ was going to take over, that's great to hear! I'll drop this one then. -- To view, visit https://review.coreboot.org/c/coreboot/+/56698 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I560a333c807ad5e055a0e035e675195d9cbbf954 Gerrit-Change-Number: 56698 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Fri, 30 Jul 2021 13:53:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/kconfig: Provide default for DEFCONFIG
by Patrick Georgi (Code Review) 30 Jul '21

30 Jul '21

Attention is currently required from: Martin Roth, Paul Menzel. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56718 ) Change subject: util/kconfig: Provide default for DEFCONFIG ...................................................................... Patch Set 1: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/56718/comment/4d74cb03_e314b852 PS1, Line 12: > It’d be great if you added a Fixes: tag. I use such tags if there's a reported bug somewhere to refer to, but I'm not aware of any such issue. -- To view, visit https://review.coreboot.org/c/coreboot/+/56718 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Idb88b69ffa855fa97df8c821601308e717575550 Gerrit-Change-Number: 56718 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Fri, 30 Jul 2021 13:34:46 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021