coreboot-gerrit July 2021

coreboot-gerrit@coreboot.org

1 participants
5256 discussions

Change in coreboot[master]: mb/google/dedede/var/cret: Disable SDCard controller
by Dtrain Hsu (Code Review) 30 Jun '21

30 Jun '21

Attention is currently required from: Henry Sun, Ben Kao, Karthik Ramasubramanian. Dtrain Hsu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55935 ) Change subject: mb/google/dedede/var/cret: Disable SDCard controller ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > Should we also configure the SD Card GPIOs as PAD_NC for Cret? Thank you for review. CB:51629 set GPP_H1, GPP_G0 ~ GPP_G7 to PAD_NC already, -- To view, visit https://review.coreboot.org/c/coreboot/+/55935 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I889f0545883aa75813dd91dc3e6a4dcfc246687f Gerrit-Change-Number: 55935 Gerrit-PatchSet: 1 Gerrit-Owner: Dtrain Hsu <dtrain_hsu(a)compal.corp-partner.google.com> Gerrit-Reviewer: Ben Kao <ben.kao(a)intel.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Alan Lee <alan_lee(a)compal.corp-partner.google.com> Gerrit-CC: Ian Feng <ian_feng(a)compal.corp-partner.google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Ben Kao <ben.kao(a)intel.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Thu, 01 Jul 2021 03:48:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Create redrix variant
by Wisley Chen (Code Review) 30 Jun '21

30 Jun '21

Attention is currently required from: Chen Wisley, Tim Wawrzynczak. Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55883 ) Change subject: mb/google/brya: Create redrix variant ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: Hi Tim/Nick, Please help to review again. Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/55883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfa0bd84e1ba9f8140f95d18a6da960da8124ad Gerrit-Change-Number: 55883 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Jul 2021 01:00:36 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/redrix: Generate SPD ID for supported parts
by Wisley Chen (Code Review) 30 Jun '21

30 Jun '21

Attention is currently required from: Chen Wisley. Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55885 ) Change subject: mb/google/brya/var/redrix: Generate SPD ID for supported parts ...................................................................... Patch Set 5: (1 comment) Patchset: PS5: Hi Tim/Nick, Please help to review again. Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/55885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62ee401e43bef22b4b09f41ea59bbdbc479f293c Gerrit-Change-Number: 55885 Gerrit-PatchSet: 5 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Comment-Date: Thu, 01 Jul 2021 01:00:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya/var/redrix: Generate SPD ID for supported parts
by Chen Wisley (Code Review) 30 Jun '21

30 Jun '21

Attention is currently required from: Wisley Chen. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Wisley Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55885 to look at the new patch set (#5). Change subject: mb/google/brya/var/redrix: Generate SPD ID for supported parts ...................................................................... mb/google/brya/var/redrix: Generate SPD ID for supported parts Add supported memory parts in mem_parts_used.txt, and generate SPD id for these parts. MT53E1G32D2NP-046 WT:A H9HCNNNBKMMLXR-NEE K4U6E3S4AA-MGCR MT53E512M32D2NP-046 WT:E H9HCNNNCPMMLXR-NEE K4UBE3D4AA-MGCR H9HCNNNFAMMLXR-NEE MT53E2G32D4NQ-046 WT:A BUG=b:190818098, b:190874372 TEST=build Change-Id: I62ee401e43bef22b4b09f41ea59bbdbc479f293c Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> --- M src/mainboard/google/brya/variants/redrix/memory/Makefile.inc M src/mainboard/google/brya/variants/redrix/memory/dram_id.generated.txt M src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt 3 files changed, 22 insertions(+), 13 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/55885/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/55885 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I62ee401e43bef22b4b09f41ea59bbdbc479f293c Gerrit-Change-Number: 55885 Gerrit-PatchSet: 5 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/brya: Create redrix variant
by Wisley Chen (Code Review) 30 Jun '21

30 Jun '21

Attention is currently required from: Chen Wisley, Tim Wawrzynczak. Wisley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55883 ) Change subject: mb/google/brya: Create redrix variant ...................................................................... Patch Set 2: (1 comment) Patchset: PS1: > needs a rebase sorry done, Thanks -- To view, visit https://review.coreboot.org/c/coreboot/+/55883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfa0bd84e1ba9f8140f95d18a6da960da8124ad Gerrit-Change-Number: 55883 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Thu, 01 Jul 2021 00:25:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/brya: Create redrix variant
by Chen Wisley (Code Review) 30 Jun '21

30 Jun '21

Attention is currently required from: Chen Wisley, Wisley Chen. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Wisley Chen, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55883 to look at the new patch set (#2). Change subject: mb/google/brya: Create redrix variant ...................................................................... mb/google/brya: Create redrix variant Create the redrix variant of the brya0 reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:192052098 BRANCH=None TEST=util/abuild/abuild -p none -t google/brya -x -a make sure the build includes GOOGLE_REDRIX Signed-off-by: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Change-Id: I4cfa0bd84e1ba9f8140f95d18a6da960da8124ad --- M src/mainboard/google/brya/Kconfig M src/mainboard/google/brya/Kconfig.name A src/mainboard/google/brya/variants/redrix/include/variant/ec.h A src/mainboard/google/brya/variants/redrix/include/variant/gpio.h A src/mainboard/google/brya/variants/redrix/memory/Makefile.inc A src/mainboard/google/brya/variants/redrix/memory/dram_id.generated.txt A src/mainboard/google/brya/variants/redrix/memory/mem_parts_used.txt A src/mainboard/google/brya/variants/redrix/overridetree.cb 8 files changed, 45 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/83/55883/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55883 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4cfa0bd84e1ba9f8140f95d18a6da960da8124ad Gerrit-Change-Number: 55883 Gerrit-PatchSet: 2 Gerrit-Owner: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Chen Wisley <wisley.chen(a)quantatw.com> Gerrit-Attention: Wisley Chen <wisley.chen(a)quanta.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit July 2021