Attention is currently required from: YH Lin, Nick Vaccaro.
David Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56087 )
Change subject: mb/google/volteer/var/voema: Remove stop delay time for ELAN TS
......................................................................
Patch Set 2:
This change is ready for review.
--
To view, visit https://review.coreboot.org/c/coreboot/+/56087
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id326fd4d9d71eef171580b1c6001505e698b40a3
Gerrit-Change-Number: 56087
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: YH Lin <yueherngl(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: YH Lin <yueherngl(a)google.com>
Gerrit-Attention: Nick Vaccaro <nvaccaro(a)google.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 02:30:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Kangheui Won, Isaac Lee.
Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56077 )
Change subject: mb/google/zork/var/shuboz: adjust telemetry settings
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/56077
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id997f9cd220d704c5b0882c257a596fb3d2485ef
Gerrit-Change-Number: 56077
Gerrit-PatchSet: 1
Gerrit-Owner: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Isaac Lee <isaaclee(a)google.com>
Gerrit-Reviewer: Kane Chen <kane_chen(a)pegatron.corp-partner.google.com>
Gerrit-Reviewer: Kangheui Won <khwon(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Frank Chu <frank_chu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Hank Lin <hank2_lin(a)pegatron.corp-partner.google.com>
Gerrit-CC: Ken Lu <ken_lu(a)pegatron.corp-partner.google.com>
Gerrit-CC: Randy I-Fan Wang <ifanw(a)google.com>
Gerrit-Attention: Kangheui Won <khwon(a)chromium.org>
Gerrit-Attention: Isaac Lee <isaaclee(a)google.com>
Gerrit-Comment-Date: Tue, 06 Jul 2021 00:59:22 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56088 )
Change subject: mainboard: Add Star Labs labtop series
......................................................................
Patch Set 7:
(2 comments)
File src/mainboard/starlabs/labtop/variants/cml/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123469):
https://review.coreboot.org/c/coreboot/+/56088/comment/f4e84bfc_aeb29570
PS7, Line 106: const uint8_t ht = get_uint_option("hyper_threading", memupd->FspmConfig.HyperThreading);
line over 96 characters
File src/mainboard/starlabs/labtop/variants/tgl/devtree.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123469):
https://review.coreboot.org/c/coreboot/+/56088/comment/428d000e_f93e5ca3
PS7, Line 13: // TODO: TGL needs power_limits_config[POWER_LIMITS_U_2_CORE] and power_limits_config[POWER_LIMITS_U_4_CORE]
line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/56088
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I090971a9e8d2be5b08be886d00d304607304b645
Gerrit-Change-Number: 56088
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Comment-Date: Mon, 05 Jul 2021 20:11:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/56088
to look at the new patch set (#7).
Change subject: mainboard: Add Star Labs labtop series
......................................................................
mainboard: Add Star Labs labtop series
Add support for:
LabTop Mk III (kbl-r)
LabTop Mk IV (cml)
StarBook Mk V (tgl)
Signed-off-by: Sean Rhodes <sean(a)starlabs.systems>
Change-Id: I090971a9e8d2be5b08be886d00d304607304b645
---
M Documentation/distributions.md
M Documentation/mainboard/index.md
A Documentation/mainboard/starlabs/labtop.md
M MAINTAINERS
A configs/config.starlabs_labtop_cml
A configs/config.starlabs_labtop_kbl
A configs/config.starlabs_labtop_tgl
A src/mainboard/starlabs/Kconfig
A src/mainboard/starlabs/Kconfig.name
A src/mainboard/starlabs/labtop/Kconfig
A src/mainboard/starlabs/labtop/Kconfig.name
A src/mainboard/starlabs/labtop/Makefile.inc
A src/mainboard/starlabs/labtop/acpi/ec.asl
A src/mainboard/starlabs/labtop/acpi/mainboard.asl
A src/mainboard/starlabs/labtop/acpi/sleep.asl
A src/mainboard/starlabs/labtop/acpi/superio.asl
A src/mainboard/starlabs/labtop/board_info.txt
A src/mainboard/starlabs/labtop/bootblock.c
A src/mainboard/starlabs/labtop/cmos.default
A src/mainboard/starlabs/labtop/cmos.layout
A src/mainboard/starlabs/labtop/dsdt.asl
A src/mainboard/starlabs/labtop/hda_verb.c
A src/mainboard/starlabs/labtop/mainboard.c
A src/mainboard/starlabs/labtop/ramstage.c
A src/mainboard/starlabs/labtop/spd/Makefile.inc
A src/mainboard/starlabs/labtop/spd/empty_ddr4.spd.hex
A src/mainboard/starlabs/labtop/spd/micron-MT40A1G16KD-062E-E.spd.hex
A src/mainboard/starlabs/labtop/spd/samsung-K4A8G165WB-BCRC.spd.hex
A src/mainboard/starlabs/labtop/spd/spd.h
A src/mainboard/starlabs/labtop/spd/spd_util.c
A src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/memory.h
A src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/romstage.h
A src/mainboard/starlabs/labtop/variants/baseboard/include/baseboard/variants.h
A src/mainboard/starlabs/labtop/variants/cml/Makefile.inc
A src/mainboard/starlabs/labtop/variants/cml/board.fmd
A src/mainboard/starlabs/labtop/variants/cml/data.vbt
A src/mainboard/starlabs/labtop/variants/cml/devicetree.cb
A src/mainboard/starlabs/labtop/variants/cml/devtree.c
A src/mainboard/starlabs/labtop/variants/cml/gma-mainboard.ads
A src/mainboard/starlabs/labtop/variants/cml/gpio.c
A src/mainboard/starlabs/labtop/variants/cml/hda_verb.c
A src/mainboard/starlabs/labtop/variants/cml/include/variant/ec.h
A src/mainboard/starlabs/labtop/variants/cml/romstage.c
A src/mainboard/starlabs/labtop/variants/kbl/Makefile.inc
A src/mainboard/starlabs/labtop/variants/kbl/board.fmd
A src/mainboard/starlabs/labtop/variants/kbl/data.vbt
A src/mainboard/starlabs/labtop/variants/kbl/devicetree.cb
A src/mainboard/starlabs/labtop/variants/kbl/devtree.c
A src/mainboard/starlabs/labtop/variants/kbl/gma-mainboard.ads
A src/mainboard/starlabs/labtop/variants/kbl/gpio.c
A src/mainboard/starlabs/labtop/variants/kbl/hda_verb.c
A src/mainboard/starlabs/labtop/variants/kbl/include/variant/ec.h
A src/mainboard/starlabs/labtop/variants/kbl/romstage.c
A src/mainboard/starlabs/labtop/variants/tgl/Makefile.inc
A src/mainboard/starlabs/labtop/variants/tgl/board.fmd
A src/mainboard/starlabs/labtop/variants/tgl/data.vbt
A src/mainboard/starlabs/labtop/variants/tgl/devicetree.cb
A src/mainboard/starlabs/labtop/variants/tgl/devtree.c
A src/mainboard/starlabs/labtop/variants/tgl/gma-mainboard.ads
A src/mainboard/starlabs/labtop/variants/tgl/gpio.c
A src/mainboard/starlabs/labtop/variants/tgl/hda_verb.c
A src/mainboard/starlabs/labtop/variants/tgl/include/variant/ec.h
A src/mainboard/starlabs/labtop/variants/tgl/romstage.c
63 files changed, 3,032 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/88/56088/7
--
To view, visit https://review.coreboot.org/c/coreboot/+/56088
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I090971a9e8d2be5b08be886d00d304607304b645
Gerrit-Change-Number: 56088
Gerrit-PatchSet: 7
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-MessageType: newpatchset
Attention is currently required from: Jan Tatje.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56071 )
Change subject: supermicro/x11-lga1151-series: Remove SkipExtGfxScan = 1
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS2:
> I just set MAINBOARD_DO_NATIVE_VGA_INIT and VGA_TEXT_FRAMEBUFFER, it's using drivers/aspeed/ast2050.
Can you try again with CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y, please?
--
To view, visit https://review.coreboot.org/c/coreboot/+/56071
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I41249112c65927b61ca5f791f8eb8c3f3d204fce
Gerrit-Change-Number: 56071
Gerrit-PatchSet: 3
Gerrit-Owner: Jan Tatje <jan(a)jnt.io>
Gerrit-Reviewer: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Jan Tatje <jan(a)jnt.io>
Gerrit-Comment-Date: Mon, 05 Jul 2021 20:00:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jan Tatje <jan(a)jnt.io>
Comment-In-Reply-To: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-MessageType: comment
Attention is currently required from: Subrata Banik.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54305 )
Change subject: util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
> > X11SSH-LN4F is C236 chipset. It passes "-p sklkbl" to ifdtool. […]
If anyone wants to do actual tests on the image, the full image including IFD and ME is available from https://www.supermicro.com/about/policies/disclaimer.cfm?SoftwareItemID=127…
--
To view, visit https://review.coreboot.org/c/coreboot/+/54305
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I25f69ce775454409974056d8326c02e29038ec8a
Gerrit-Change-Number: 54305
Gerrit-PatchSet: 10
Gerrit-Owner: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Angel Pons <angel.pons(a)9elements.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Lean Sheng Tan <lean.sheng.tan(a)intel.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org>
Gerrit-Reviewer: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <inforichland(a)gmail.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Jan Tatje <jan(a)jnt.io>
Gerrit-CC: Michael Niewöhner <foss(a)mniewoehner.de>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-CC: Subrata Banik <subi.banik(a)gmail.com>
Gerrit-Attention: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-Comment-Date: Mon, 05 Jul 2021 19:57:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jan Tatje <jan(a)jnt.io>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Subrata Banik <subrata.banik(a)intel.com>
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56088 )
Change subject: mainboard: Add Star Labs labtop series
......................................................................
Patch Set 6:
(2 comments)
File src/mainboard/starlabs/labtop/variants/cml/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123463):
https://review.coreboot.org/c/coreboot/+/56088/comment/27338918_74b1e8b2
PS6, Line 106: const uint8_t ht = get_uint_option("hyper_threading", memupd->FspmConfig.HyperThreading);
line over 96 characters
File src/mainboard/starlabs/labtop/variants/tgl/devtree.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123463):
https://review.coreboot.org/c/coreboot/+/56088/comment/fb4f4e41_7db4ac9b
PS6, Line 13: // TODO: TGL needs power_limits_config[POWER_LIMITS_U_2_CORE] and power_limits_config[POWER_LIMITS_U_4_CORE]
line over 96 characters
--
To view, visit https://review.coreboot.org/c/coreboot/+/56088
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I090971a9e8d2be5b08be886d00d304607304b645
Gerrit-Change-Number: 56088
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Comment-Date: Mon, 05 Jul 2021 19:46:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
Attention is currently required from: Sean Rhodes.
Sean Rhodes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56088 )
Change subject: mainboard: Add Star Labs labtop series
......................................................................
Set Ready For Review
--
To view, visit https://review.coreboot.org/c/coreboot/+/56088
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I090971a9e8d2be5b08be886d00d304607304b645
Gerrit-Change-Number: 56088
Gerrit-PatchSet: 6
Gerrit-Owner: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Sean Rhodes <admin(a)starlabs.systems>
Gerrit-Comment-Date: Mon, 05 Jul 2021 19:43:39 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment