coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: soc/amd/cezanne/include/iomap: properly align defines
by Felix Held (Code Review) 31 May '21

31 May '21

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/55100 ) Change subject: soc/amd/cezanne/include/iomap: properly align defines ...................................................................... soc/amd/cezanne/include/iomap: properly align defines Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I14647b3d88146602b96fc1dff2347a293bab0c26 --- M src/soc/amd/cezanne/include/soc/iomap.h 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/55100/1 diff --git a/src/soc/amd/cezanne/include/soc/iomap.h b/src/soc/amd/cezanne/include/soc/iomap.h index 486e3cf..4c4252a 100644 --- a/src/soc/amd/cezanne/include/soc/iomap.h +++ b/src/soc/amd/cezanne/include/soc/iomap.h @@ -45,7 +45,7 @@ /* I/O Ranges */ #define NCP_ERR 0x00f0 -#define ACPI_IO_BASE 0x0400 +#define ACPI_IO_BASE 0x0400 #define ACPI_PM_EVT_BLK (ACPI_IO_BASE + 0x00) #define ACPI_PM1_STS (ACPI_PM_EVT_BLK + 0x00) #define ACPI_PM1_EN (ACPI_PM_EVT_BLK + 0x02) -- To view, visit https://review.coreboot.org/c/coreboot/+/55100 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I14647b3d88146602b96fc1dff2347a293bab0c26 Gerrit-Change-Number: 55100 Gerrit-PatchSet: 1 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/amd/picasso: remove warm reset flag code
by Felix Held (Code Review) 31 May '21

31 May '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55059 ) Change subject: soc/amd/picasso: remove warm reset flag code ...................................................................... Patch Set 2: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/55059/comment/a71bf7e0_bcb2c40b PS2, Line 11: PPR > If there are several revisions, please mention yours, in case it gets updated. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/55059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e6df98ffd5d15ca204c9847a76c19c753726737 Gerrit-Change-Number: 55059 Gerrit-PatchSet: 2 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 31 May 2021 15:20:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/amd/picasso: remove warm reset flag code
by Felix Held (Code Review) 31 May '21

31 May '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Felix Held. Hello build bot (Jenkins), Jason Glenesk, Raul Rangel, Marshall Dawson, Paul Menzel, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55059 to look at the new patch set (#3). Change subject: soc/amd/picasso: remove warm reset flag code ...................................................................... soc/amd/picasso: remove warm reset flag code Since the MCA(X) registers have defined values on the cold boot path, the is_warm_reset check can be dropped. Also the warm reset bit in the NCP_ERR register doesn't behave as the PPR [1] suggested; no matter if something was written to the register or the machine went through a warm reset cycle, the NCP_WARM_BOOT bit never got set. [1] checked with PPR for AMD Family 17h Models 11h,18h B1 (RV,PCO) #55570 Rev 3.15 Signed-off-by: Felix Held <felix-coreboot(a)felixheld.de> Change-Id: I4e6df98ffd5d15ca204c9847a76c19c753726737 --- M src/soc/amd/picasso/cpu.c M src/soc/amd/picasso/include/soc/iomap.h M src/soc/amd/picasso/include/soc/southbridge.h M src/soc/amd/picasso/mca.c M src/soc/amd/picasso/reset.c 5 files changed, 25 insertions(+), 47 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/55059/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/55059 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I4e6df98ffd5d15ca204c9847a76c19c753726737 Gerrit-Change-Number: 55059 Gerrit-PatchSet: 3 Gerrit-Owner: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/amd/cezanne: Add pre-FSPM call to the mainboard
by Martin Roth (Code Review) 31 May '21

31 May '21

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54638 ) Change subject: soc/amd/cezanne: Add pre-FSPM call to the mainboard ...................................................................... soc/amd/cezanne: Add pre-FSPM call to the mainboard The Guybrush platform needs to set up some GPIOs immediately before the FSP-M runs. Add a platform specific call. This will be used in a follow-on commit. BUG=b:184796302, b:184598323 TEST=Build Signed-off-by: Martin Roth <martinroth(a)chromium.org> Change-Id: I37d2625ff426347852e98a9a50f15368e0213449 Reviewed-on: https://review.coreboot.org/c/coreboot/+/54638 Reviewed-by: Felix Held <felix-coreboot(a)felixheld.de> Reviewed-by: Marshall Dawson <marshalldawson3rd(a)gmail.com> Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> --- M src/soc/amd/cezanne/fsp_m_params.c M src/soc/amd/cezanne/include/soc/platform_descriptors.h 2 files changed, 7 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Marshall Dawson: Looks good to me, approved diff --git a/src/soc/amd/cezanne/fsp_m_params.c b/src/soc/amd/cezanne/fsp_m_params.c index 352aeef..9546721 100644 --- a/src/soc/amd/cezanne/fsp_m_params.c +++ b/src/soc/amd/cezanne/fsp_m_params.c @@ -36,6 +36,10 @@ return gfx_hda_dev->enabled; } +__weak void mb_pre_fspm(void) +{ +} + static void fill_dxio_descriptors(FSP_M_CONFIG *mcfg, const fsp_dxio_descriptor *descs, size_t num) { @@ -171,4 +175,5 @@ fsp_fill_pcie_ddi_descriptors(mcfg); fsp_assign_ioapic_upds(mcfg); + mb_pre_fspm(); } diff --git a/src/soc/amd/cezanne/include/soc/platform_descriptors.h b/src/soc/amd/cezanne/include/soc/platform_descriptors.h index d68cd7f..3a4bc62 100644 --- a/src/soc/amd/cezanne/include/soc/platform_descriptors.h +++ b/src/soc/amd/cezanne/include/soc/platform_descriptors.h @@ -12,4 +12,6 @@ const fsp_dxio_descriptor **dxio_descs, size_t *dxio_num, const fsp_ddi_descriptor **ddi_descs, size_t *ddi_num); +void mb_pre_fspm(void); + #endif /* AMD_PICASSO_PLATFORM_DESCRIPTORS_H */ -- To view, visit https://review.coreboot.org/c/coreboot/+/54638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37d2625ff426347852e98a9a50f15368e0213449 Gerrit-Change-Number: 54638 Gerrit-PatchSet: 4 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: soc/amd/cezanne: Add pre-FSPM call to the mainboard
by Martin Roth (Code Review) 31 May '21

31 May '21

Attention is currently required from: Jason Glenesk, Raul Rangel, Paul Menzel. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54638 ) Change subject: soc/amd/cezanne: Add pre-FSPM call to the mainboard ...................................................................... Patch Set 3: (1 comment) File src/soc/amd/cezanne/fsp_m_params.c: https://review.coreboot.org/c/coreboot/+/54638/comment/9ed51830_7fd2a57b PS1, Line 39: __weak void mb_pre_fspm(void) > i'd prefer the current code over init_gpios_before_psp. also: did you mean fsp? […] Absolutely. Thanks for being flexible here. As I said, I don't disagree with you. And yes, I meant FSP, not PSP. -- To view, visit https://review.coreboot.org/c/coreboot/+/54638 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I37d2625ff426347852e98a9a50f15368e0213449 Gerrit-Change-Number: 54638 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Jason Glenesk <jason.glenesk(a)gmail.com> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Mon, 31 May 2021 15:14:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Add helpers for cbi fw_config settings.
by Martin Roth (Code Review) 31 May '21

31 May '21

Attention is currently required from: Raul Rangel, Furquan Shaikh, Paul Menzel, Karthik Ramasubramanian. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54639 ) Change subject: mb/google/guybrush: Add helpers for cbi fw_config settings. ...................................................................... Patch Set 5: (5 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/54639/comment/d7d696f6_b2755899 PS4, Line 7: mb/google/guybrush: Add helpers for fw_config settings. > Nit: Could you please remove the dot/period at the end of the commit message summary. Done File src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h: https://review.coreboot.org/c/coreboot/+/54639/comment/871ac844_532646de PS1, Line 38: #define GUYBRUSH_WCN6856_WIFI 0x00 > If you look at the settings in devicetree, the WLAN settings are: […] Removed wifi. Aligned WWAN to match the CBI fields. File src/mainboard/google/guybrush/variants/guybrush/helpers.c: https://review.coreboot.org/c/coreboot/+/54639/comment/68ef597b_9c78b80a PS4, Line 32: if (config == UNDEFINED_FW_CONFIG || ! fw_config_probe(FW_CONFIG(FP, FP_PRESENT))) > That series is already +2ed. […] For now I'm going to keep just doing the manual probe. I don't think the devicetree method is better in these cases unless we have global CBI fields. If you think I'm wrong, let's talk about it more when I'm back in the office. https://review.coreboot.org/c/coreboot/+/54639/comment/4bd41b38_0698ca23 PS4, Line 44: get_variant_wwan_type > BTW, I think I used the wrong part `WWAN_LG850GL` for the probe statement above. […] You mention having this live in guybrush baseboard, but I don't see how that works if not every platform has WLAN and WWAN_FM350GL defined. Since we decided that fw_config would not be universal, that doesn't seem like it works. Why is it preferable to go find the device then seeing whether it's enabled or disabled to just calling fw_config_probe? I can see how it might be better in some cases, like if you can just rely on the enable/disable functions to do everything, but if you can't, like in this case, it just makes things harder, right? Am I missing something? https://review.coreboot.org/c/coreboot/+/54639/comment/7c93ab4a_f618e8e0 PS4, Line 60: get_variant_wifi_type > You're right, I don't need it right now, so I'll remove it. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/54639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I212e7f413b4d8a7d15122cde90100a0ec28e88a6 Gerrit-Change-Number: 54639 Gerrit-PatchSet: 5 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 31 May 2021 15:10:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Martin Roth <martinroth(a)google.com> Comment-In-Reply-To: Furquan Shaikh <furquan(a)google.com> Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org> Comment-In-Reply-To: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush: Add helpers for cbi fw_config settings.
by Martin Roth (Code Review) 31 May '21

31 May '21

Attention is currently required from: Raul Rangel, Martin Roth, Karthik Ramasubramanian. Hello build bot (Jenkins), Raul Rangel, Karthik Ramasubramanian, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54639 to look at the new patch set (#5). Change subject: mb/google/guybrush: Add helpers for cbi fw_config settings. ...................................................................... mb/google/guybrush: Add helpers for cbi fw_config settings. Turn on CBI and add helper functions for determining the board configuration from the firmware config settings in CBI. Move existing FPMCU helper function into the Guybrush folder because it's not necessarily the same for all Guybrush variants. BUG=b:187316460 TEST=Verify that configurations match what's set in CBI. Signed-off-by: Martin Roth <martinroth(a)chromium.org> Change-Id: I212e7f413b4d8a7d15122cde90100a0ec28e88a6 --- M src/mainboard/google/guybrush/Kconfig M src/mainboard/google/guybrush/variants/baseboard/Makefile.inc M src/mainboard/google/guybrush/variants/baseboard/helpers.c M src/mainboard/google/guybrush/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/guybrush/variants/guybrush/Makefile.inc A src/mainboard/google/guybrush/variants/guybrush/helpers.c 6 files changed, 38 insertions(+), 21 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/54639/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/54639 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I212e7f413b4d8a7d15122cde90100a0ec28e88a6 Gerrit-Change-Number: 54639 Gerrit-PatchSet: 5 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Furquan Shaikh <furquan(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Raul Rangel <rrangel(a)chromium.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/alderlake: Configure FIVR, VR, Turbo ratios
by V Sowmya (Code Review) 31 May '21

31 May '21

Attention is currently required from: V Sowmya. Hello build bot (Jenkins), Kedar J. Karanje, Maulik V Vaghela, vagdevi.p(a)intel.com, Tim Wawrzynczak, Vinay Kumar, Balaji Manigandan, Sanju Jose Thottan, Patrick Rudolph, Baieswara Reddy Sagili, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54055 to look at the new patch set (#6). Change subject: soc/intel/alderlake: Configure FIVR, VR, Turbo ratios ...................................................................... soc/intel/alderlake: Configure FIVR, VR, Turbo ratios This patch configures the following, * VR configurations * FIVR configurations * CPU Power Mgmt Test Config * Turbo ratios * LTR config for PCIE Signed-off-by: V Sowmya <v.sowmya(a)intel.com> Change-Id: I8d485872c8bae32f83ebf94bdaa4c6a793976ce7 --- M src/soc/intel/alderlake/fsp_params.c 1 file changed, 47 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/54055/6 -- To view, visit https://review.coreboot.org/c/coreboot/+/54055 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8d485872c8bae32f83ebf94bdaa4c6a793976ce7 Gerrit-Change-Number: 54055 Gerrit-PatchSet: 6 Gerrit-Owner: V Sowmya <v.sowmya(a)intel.com> Gerrit-Reviewer: Baieswara Reddy Sagili <baieswara.reddy.sagili(a)intel.com> Gerrit-Reviewer: Balaji Manigandan <balaji.manigandan(a)intel.com> Gerrit-Reviewer: Kedar J. Karanje <kedar.j.karanje(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Sanju Jose Thottan <sanjujose.thottan(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Vinay Kumar <vinay.kumar(a)intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Reviewer: vagdevi.p(a)intel.com Gerrit-Attention: V Sowmya <v.sowmya(a)intel.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/intel/xeon_sp/cpx: Move MSR Locks to CPU init and fix them
by Arthur Heymans (Code Review) 31 May '21

31 May '21

Attention is currently required from: Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Rocky Phagura, Morgan Jang, Patrick Rudolph. Hello build bot (Jenkins), Marc Jones, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Rocky Phagura, Morgan Jang, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55098 to look at the new patch set (#2). Change subject: soc/intel/xeon_sp/cpx: Move MSR Locks to CPU init and fix them ...................................................................... soc/intel/xeon_sp/cpx: Move MSR Locks to CPU init and fix them Move locking CPU MSRs during CPU init instead of using CONFIG_PARALLEL_MP_AP_WORK functions. The AES Lock enable bit caused CPU exception errors as this should not run on HT siblings. The set_aesni_lock() function takes care of that. Note that with a CBnT setup APs are already halted so this code was never run on APs! This is now also fixed. Change-Id: I21598c3e9a153dce25a09b187ddf9cf6363039d3 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/soc/intel/xeon_sp/cpx/chip.c M src/soc/intel/xeon_sp/cpx/cpu.c 2 files changed, 10 insertions(+), 18 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/55098/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55098 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I21598c3e9a153dce25a09b187ddf9cf6363039d3 Gerrit-Change-Number: 55098 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: Rocky Phagura Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Arthur Heymans <arthur.heymans(a)9elements.com> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Rocky Phagura Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: payloads/Linuxboot/u-root: Explicitly set GO111MODULE=off
by Arthur Heymans (Code Review) 31 May '21

31 May '21

Attention is currently required from: Martin Roth, Stefan Reinauer, Christian Walter, Arthur Heymans, Ron Minnich. Hello build bot (Jenkins), Martin Roth, Stefan Reinauer, Christian Walter, Ron Minnich, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/55095 to look at the new patch set (#2). Change subject: payloads/Linuxboot/u-root: Explicitly set GO111MODULE=off ...................................................................... payloads/Linuxboot/u-root: Explicitly set GO111MODULE=off With go1.16 the default for GO111MODULE was changed from 'off' to 'on' which breaks building u-root. Change-Id: Ie90b400418ccd06426a0e00ec7f7932066f57d7e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M payloads/external/LinuxBoot/targets/u-root.mk 1 file changed, 4 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/55095/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/55095 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ie90b400418ccd06426a0e00ec7f7932066f57d7e Gerrit-Change-Number: 55095 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Ron Minnich <rminnich(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Ron Minnich <rminnich(a)gmail.com> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021