coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: mb/google/brya: Enable TCSS
by Deepti Deshatty (Code Review) 10 May '21

10 May '21

Attention is currently required from: Maulik V Vaghela. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54006 ) Change subject: mb/google/brya: Enable TCSS ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/54006 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I794de3ecd5f4f18d6305fb9989a87af400b09d21 Gerrit-Change-Number: 54006 Gerrit-PatchSet: 1 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Comment-Date: Mon, 10 May 2021 01:39:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/intel/alderlake: mb/intel/sm: Add tcss code
by Deepti Deshatty (Code Review) 10 May '21

10 May '21

Attention is currently required from: Maulik V Vaghela. Deepti Deshatty has removed Tim Wawrzynczak from this change. ( https://review.coreboot.org/c/coreboot/+/54005 ) Change subject: soc/intel/alderlake: mb/intel/sm: Add tcss code ...................................................................... Removed reviewer Tim Wawrzynczak. -- To view, visit https://review.coreboot.org/c/coreboot/+/54005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36bf5ba7eb4b633c6e5c61fbc94b5b457ffb93d9 Gerrit-Change-Number: 54005 Gerrit-PatchSet: 1 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: soc/intel/alderlake: mb/intel/sm: Add tcss code
by Deepti Deshatty (Code Review) 10 May '21

10 May '21

Attention is currently required from: Maulik V Vaghela, Tim Wawrzynczak. Deepti Deshatty has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/54005 ) Change subject: soc/intel/alderlake: mb/intel/sm: Add tcss code ...................................................................... Removed reviewer Patrick Rudolph. -- To view, visit https://review.coreboot.org/c/coreboot/+/54005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36bf5ba7eb4b633c6e5c61fbc94b5b457ffb93d9 Gerrit-Change-Number: 54005 Gerrit-PatchSet: 1 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-MessageType: deleteReviewer

1 0

Change in coreboot[master]: soc/intel/alderlake: mb/intel/sm: Add tcss code
by Deepti Deshatty (Code Review) 10 May '21

10 May '21

Attention is currently required from: Maulik V Vaghela. Deepti Deshatty has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54005 ) Change subject: soc/intel/alderlake: mb/intel/sm: Add tcss code ...................................................................... Patch Set 1: This change is ready for review. -- To view, visit https://review.coreboot.org/c/coreboot/+/54005 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I36bf5ba7eb4b633c6e5c61fbc94b5b457ffb93d9 Gerrit-Change-Number: 54005 Gerrit-PatchSet: 1 Gerrit-Owner: Deepti Deshatty <deepti.deshatty(a)intel.com> Gerrit-Reviewer: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Attention: Maulik V Vaghela <maulik.v.vaghela(a)intel.com> Gerrit-Comment-Date: Mon, 10 May 2021 01:38:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer/variant/lindar: Increase Cbfs Mcache size
by Kevin Chang (Code Review) 10 May '21

10 May '21

Kevin Chang has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/53890 ) Change subject: mb/google/volteer/variant/lindar: Increase Cbfs Mcache size ...................................................................... Abandoned It has other CL do same thing -- To view, visit https://review.coreboot.org/c/coreboot/+/53890 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84f4f3d7c35165eba9c446ed6658f5bba15c5cfe Gerrit-Change-Number: 53890 Gerrit-PatchSet: 3 Gerrit-Owner: Kevin Chang <kevin.chang(a)lcfc.corp-partner.google.com> Gerrit-Reviewer: Zhuohao Lee <zhuohao(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: abandon

1 0

Change in coreboot[master]: drivers/amd/agesa/acpi_tables.c: Remove 00630F01 occurrence
by Michał Żygowski (Code Review) 10 May '21

10 May '21

Attention is currently required from: Marshall Dawson, Felix Held. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53995 ) Change subject: drivers/amd/agesa/acpi_tables.c: Remove 00630F01 occurrence ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > let's wait with removing unused chipset code until after the release Sure, I just wanted to be of any help for the release-related stuff -- To view, visit https://review.coreboot.org/c/coreboot/+/53995 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5b7ea886c4116ee2437e00639956ac9c3b0a9e48 Gerrit-Change-Number: 53995 Gerrit-PatchSet: 1 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 09 May 2021 23:57:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: northbridge/amd/pi/00630F01: Remove unused directory and code
by Michał Żygowski (Code Review) 10 May '21

10 May '21

Attention is currently required from: Marshall Dawson, Felix Held. Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53992 ) Change subject: northbridge/amd/pi/00630F01: Remove unused directory and code ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: > there's also a cpu directory for this family. […] Of course there is CB:53993 I just wanted to avoid unnecessary relation chains creating them only if needed. -- To view, visit https://review.coreboot.org/c/coreboot/+/53992 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I85a68f8fdb422ccfc80a5b85d47950e25cfff6df Gerrit-Change-Number: 53992 Gerrit-PatchSet: 2 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Marshall Dawson <marshalldawson3rd(a)gmail.com> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 09 May 2021 23:55:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: nb/amd/agesa/family14: Use generic allocation functions for northbridge
by Piotr Król (Code Review) 09 May '21

09 May '21

Attention is currently required from: Nico Huber, Michał Żygowski, Kyösti Mälkki. Piotr Król has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52934 ) Change subject: nb/amd/agesa/family14: Use generic allocation functions for northbridge ...................................................................... Patch Set 4: (1 comment) Patchset: PS2: > > It hurts me to see how deep in debts this code is and that the > > community has to constantly pay interest for it. Please do not > > make things worse by making the review harder than necessary. > > Every change should be reasoned about in the commit message > > before review starts. If reviewers constantly have to ask, why > > this and that, that's a waste of time. If the code should be > > kept upstream in the long run, unexplained changes and shallow > > reviews only add additional debts. If nobody wants to invest > > into the code, better make plans to maintain it on another > > branch. We never get so negative feedback in such style. For external entities trying to join coreboot development this would not sound welcoming. We would understand part of comment if Michał or 3mdeb would continuously provide low quality code, but AFAIK this is not the case here. We would like to understand and learn by examples how we can avoid such comments in future. Also we would appreciate precise explanation about interest community constantly have to pay, since we feel part of community and also would like to stop paying that interest, if possible. Last sentence worries me because business-wise it means arbitrary resource requests under the threat of exile. It will effectively cause wiping out any old hardware, even one which is still in wide use. I would appreciate if we can bring that topic to coreboot leadership meeting and talk together about that. -- To view, visit https://review.coreboot.org/c/coreboot/+/52934 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I74a0ed1fcbbc9e066c42c4d51d30ab1d7138134a Gerrit-Change-Number: 52934 Gerrit-PatchSet: 4 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Sun, 09 May 2021 21:43:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Nico Huber <nico.h(a)gmx.de> Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Documentation: Add suggestion to document flag days
by Piotr Król (Code Review) 09 May '21

09 May '21

Attention is currently required from: Martin Roth, Julius Werner, Felix Held. Piotr Król has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52576 ) Change subject: Documentation: Add suggestion to document flag days ...................................................................... Patch Set 1: (1 comment) File Documentation/getting_started/gerrit_guidelines.md: https://review.coreboot.org/c/coreboot/+/52576/comment/43193ffb_1f2c96a0 PS1, Line 332: requires a change in all mainboards using it) needs to be documented. > > 1. Sign of life - certain string showing as early as possible on platform boot > > Open to discussion but I think this might be reasonable as a Kconfig (depending on how complicated it looks). It would be sent upstream for review and we will see. > > 4. Experimental uCode inclusion > > Is this more than just setting the microcode file Kconfig to some file you maintain out-of-tree? (I think that's considered supported.) That seem to be the scope, but if you say it is supported for AMD we have to check that. > > > 5. ACPI difference, mentioned in email thread, required for OS compatibility > > I haven't fully understood that problem, but generally, I think OS compatibility stuff is something that can be included upstream (depends on whether we're talking about a publicly available OS or something custom used only by your customer, maybe). Again, I think coreboot itself gets developed as a sort of monolithic blob with no stable boundaries on its inside, but the boundary between coreboot and the payload or the OS is different and we spend more effort trying to keep that as stable and widely compatible as possible. We talking about BSD and its downstream distros eg. pfSense or OPNsense, which are important for firewall customers. Those distros typically do not use bleeding edge version of ACPI. > > > Maybe we should be clear about saying that coreboot is too expensive for small OEM/ODM, they should go to IBVs. > > I don't think anyone is trying to build any intentional barriers here to keep someone out. We're all interested in making all the things that people want to do with coreboot as cheap and easy as possible. I just don't think there are any easy answers to your problems here. "Everyone stop making big API changes" isn't something we can do, then we can't really develop big new features at all anymore. Then the project would basically become irrelevant and die out. "Spend a ton of extra effort on every global change you make" also becomes prohibitive and will effectively cause the same problems as forbidding big changes completely. I think we can discuss smaller effort process changes (e.g. writing spatches where it makes sense), but it needs to balance out the effort saved on one side and the extra effort caused on the other. Agree. I just brought 3mdeb perspective to discussion. We hope that continuation of discussed strategies will not eventually push out less-resourceful players out of tree. -- To view, visit https://review.coreboot.org/c/coreboot/+/52576 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic7c01a0f1008821ebbda43a426ba1e3d6410e861 Gerrit-Change-Number: 52576 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Julius Werner <jwerner(a)chromium.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Comment-Date: Sun, 09 May 2021 21:43:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Patrick Georgi <pgeorgi(a)google.com> Comment-In-Reply-To: Julius Werner <jwerner(a)chromium.org> Comment-In-Reply-To: Piotr Król <piotr.krol(a)3mdeb.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/msi/h81m-p33: Use `ACPI_DSDT_REV_2` macro
by Nico Huber (Code Review) 09 May '21

09 May '21

Attention is currently required from: Angel Pons. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54004 ) Change subject: mb/msi/h81m-p33: Use `ACPI_DSDT_REV_2` macro ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54004 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I15846bf23e49666e4948f623d6320d5c29e00bd4 Gerrit-Change-Number: 54004 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Sun, 09 May 2021 21:33:47 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021