coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: mb/google/volteer: Create chronicler variant
by Sheng-Liang Pan (Code Review) 10 May '21

10 May '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Sheng-Liang Pan, YH Lin. Hello build bot (Jenkins), Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro, YH Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/53907 to look at the new patch set (#3). Change subject: mb/google/volteer: Create chronicler variant ...................................................................... mb/google/volteer: Create chronicler variant Create the chronicler variant of the volteer reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:187318819 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_CHRONICLER Signed-off-by: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Change-Id: Iebfea87b7c4cfc2a83e88a6c479a0842774ae018 --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/chronicler/include/variant/ec.h A src/mainboard/google/volteer/variants/chronicler/include/variant/gpio.h A src/mainboard/google/volteer/variants/chronicler/memory/Makefile.inc A src/mainboard/google/volteer/variants/chronicler/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/chronicler/memory/mem_parts_used.txt A src/mainboard/google/volteer/variants/chronicler/overridetree.cb 8 files changed, 52 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/53907/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/53907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebfea87b7c4cfc2a83e88a6c479a0842774ae018 Gerrit-Change-Number: 53907 Gerrit-PatchSet: 3 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/volteer: Create chronicler variant
by Sheng-Liang Pan (Code Review) 10 May '21

10 May '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Sheng-Liang Pan, YH Lin. Sheng-Liang Pan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53907 ) Change subject: mb/google/volteer: Create chronicler variant ...................................................................... Patch Set 2: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/53907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebfea87b7c4cfc2a83e88a6c479a0842774ae018 Gerrit-Change-Number: 53907 Gerrit-PatchSet: 2 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Comment-Date: Mon, 10 May 2021 11:33:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Create chronicler variant
by build bot (Jenkins) (Code Review) 10 May '21

10 May '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, YH Lin. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53907 ) Change subject: mb/google/volteer: Create chronicler variant ...................................................................... Patch Set 2: (1 comment) File src/mainboard/google/volteer/Kconfig.name: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-118915): https://review.coreboot.org/c/coreboot/+/53907/comment/b1591ff4_63ff19be PS2, Line 94: select BOARD_GOOGLE_BASEBOARD_VOLTEER trailing whitespace -- To view, visit https://review.coreboot.org/c/coreboot/+/53907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebfea87b7c4cfc2a83e88a6c479a0842774ae018 Gerrit-Change-Number: 53907 Gerrit-PatchSet: 2 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-Comment-Date: Mon, 10 May 2021 11:33:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/volteer: Create chronicler variant
by Sheng-Liang Pan (Code Review) 10 May '21

10 May '21

Attention is currently required from: Tim Wawrzynczak, Nick Vaccaro, Sheng-Liang Pan, YH Lin. Hello build bot (Jenkins), Tim Wawrzynczak, Paul Fagerburg, Nick Vaccaro, YH Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/53907 to look at the new patch set (#2). Change subject: mb/google/volteer: Create chronicler variant ...................................................................... mb/google/volteer: Create chronicler variant Create the chronicler variant of the volteer reference board by copying the template files to a new directory named for the variant. (Auto-Generated by create_coreboot_variant.sh version 4.5.0). BUG=b:187318819 BRANCH=None TEST=util/abuild/abuild -p none -t google/volteer -x -a make sure the build includes GOOGLE_CHRONICLER Signed-off-by: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Change-Id: Iebfea87b7c4cfc2a83e88a6c479a0842774ae018 --- M src/mainboard/google/volteer/Kconfig M src/mainboard/google/volteer/Kconfig.name A src/mainboard/google/volteer/variants/chronicler/include/variant/ec.h A src/mainboard/google/volteer/variants/chronicler/include/variant/gpio.h A src/mainboard/google/volteer/variants/chronicler/memory/Makefile.inc A src/mainboard/google/volteer/variants/chronicler/memory/dram_id.generated.txt A src/mainboard/google/volteer/variants/chronicler/memory/mem_parts_used.txt A src/mainboard/google/volteer/variants/chronicler/overridetree.cb 8 files changed, 53 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/07/53907/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/53907 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iebfea87b7c4cfc2a83e88a6c479a0842774ae018 Gerrit-Change-Number: 53907 Gerrit-PatchSet: 2 Gerrit-Owner: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: YH Lin <yueherngl(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Nick Vaccaro <nvaccaro(a)chromium.org> Gerrit-Attention: Sheng-Liang Pan <sheng-liang.pan(a)quanta.corp-partner.google.com> Gerrit-Attention: YH Lin <yueherngl(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/intel/dg41wv/devicetree.cb: Fix up whitespace
by Felix Singer (Code Review) 10 May '21

10 May '21

Attention is currently required from: Angel Pons, Arthur Heymans, Patrick Rudolph. Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54017 ) Change subject: mb/intel/dg41wv/devicetree.cb: Fix up whitespace ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66f0a847720713c1d3445ac70a9e075228dfe88 Gerrit-Change-Number: 54017 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Mon, 10 May 2021 11:03:31 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/intel/dg41wv/devicetree.cb: Fix up whitespace
by Angel Pons (Code Review) 10 May '21

10 May '21

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54017 ) Change subject: mb/intel/dg41wv/devicetree.cb: Fix up whitespace ...................................................................... mb/intel/dg41wv/devicetree.cb: Fix up whitespace Remove a blank line and correct the indentation of another line. Change-Id: Id66f0a847720713c1d3445ac70a9e075228dfe88 Signed-off-by: Angel Pons <th3fanbus(a)gmail.com> --- M src/mainboard/intel/dg41wv/devicetree.cb 1 file changed, 1 insertion(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/17/54017/1 diff --git a/src/mainboard/intel/dg41wv/devicetree.cb b/src/mainboard/intel/dg41wv/devicetree.cb index e44554e..9b1aeb0 100644 --- a/src/mainboard/intel/dg41wv/devicetree.cb +++ b/src/mainboard/intel/dg41wv/devicetree.cb @@ -145,7 +145,7 @@ end device pci 1f.3 on # SMbus subsystemid 0x8086 0x5756 - chip drivers/i2c/ck505 + chip drivers/i2c/ck505 register "mask" = "{ 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, @@ -158,7 +158,6 @@ 0x06, 0x00, 0xea }" device i2c 69 on end end - end end end -- To view, visit https://review.coreboot.org/c/coreboot/+/54017 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id66f0a847720713c1d3445ac70a9e075228dfe88 Gerrit-Change-Number: 54017 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Enable SCP SRAM
by Rex-BC Chen (Code Review) 10 May '21

10 May '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Hello Hung-Te Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54014 to look at the new patch set (#3). Change subject: soc/mediatek/mt8195: Enable SCP SRAM ...................................................................... soc/mediatek/mt8195: Enable SCP SRAM Enable SCP SRAM to allow module in SCPSYS to access DRAM. TEST=AFE acess DRAM successfully Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I40862f8d74e5aa17361f1c91ea31a10b0a4ffb31 --- M src/mainboard/google/cherry/romstage.c M src/soc/mediatek/mt8195/Makefile.inc A src/soc/mediatek/mt8195/include/soc/scp.h A src/soc/mediatek/mt8195/scp.c 4 files changed, 36 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/54014/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/54014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40862f8d74e5aa17361f1c91ea31a10b0a4ffb31 Gerrit-Change-Number: 54014 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Enable SCP SRAM
by Rex-BC Chen (Code Review) 10 May '21

10 May '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Hello Hung-Te Lin, build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54014 to look at the new patch set (#2). Change subject: soc/mediatek/mt8195: Enable SCP SRAM ...................................................................... soc/mediatek/mt8195: Enable SCP SRAM Enable SCP SRAM to allow module in SCPSYS to access DRAM. TEST=AFE acess DRAM successfully Signed-off-by: Rex-BC Chen <rex-bc.chen(a)mediatek.com> Change-Id: I40862f8d74e5aa17361f1c91ea31a10b0a4ffb31 --- M src/mainboard/google/cherry/romstage.c M src/soc/mediatek/mt8195/Makefile.inc A src/soc/mediatek/mt8195/include/soc/scp.h A src/soc/mediatek/mt8195/scp.c 4 files changed, 37 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/14/54014/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54014 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I40862f8d74e5aa17361f1c91ea31a10b0a4ffb31 Gerrit-Change-Number: 54014 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/dedede/var/magolor: Select touchscreen panel size based on ...
by Marco Chen (Code Review) 10 May '21

10 May '21

Attention is currently required from: David Wu, Furquan Shaikh, Henry Sun, Karthik Ramasubramanian. Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52851 ) Change subject: mb/google/dedede/var/magolor: Select touchscreen panel size based on SSFC value ...................................................................... Patch Set 5: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/52851/comment/a3392aae_7e38a8e2 PS5, Line 7: Select touchscreen panel size based on SSFC value Select touchscreen based on SSFC in FW_CONFIG https://review.coreboot.org/c/coreboot/+/52851/comment/6c95e765_bdb9c15c PS5, Line 9: Select tocuhscreen panel size for 11" and 14", based on : the value set in the SSFC_CONFIG. Select touchscreen(s) based on touchscreen panel size provisioned in SSFC of CBI (higher 32 bits of FW_CONFIG in coreboot). The reason is to avoid to enable multiple touchscreen ICs with the same slave address. -- To view, visit https://review.coreboot.org/c/coreboot/+/52851 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I087ea677a8865fc8c5b3f7c9773bd7f97924dbb3 Gerrit-Change-Number: 52851 Gerrit-PatchSet: 5 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 10 May 2021 10:31:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/dedede/var/magolor: Select touchscreen panel size based on ...
by Marco Chen (Code Review) 10 May '21

10 May '21

Attention is currently required from: David Wu, Furquan Shaikh, Henry Sun, Karthik Ramasubramanian. Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52851 ) Change subject: mb/google/dedede/var/magolor: Select touchscreen panel size based on SSFC value ...................................................................... Patch Set 5: (1 comment) File src/mainboard/google/dedede/variants/magolor/overridetree.cb: https://review.coreboot.org/c/coreboot/+/52851/comment/e561be99_d7c4cead PS5, Line 2: field CAMERA_WFC 38 40 I am afraid that the bit usage of SSFC is out of sync with EC side already. Referring to [1], bits 6~8 of SSFC were allocated for USB Mux in EC already which is conflict with the definition here (bits 38~40 of FW_CONFIG is for bits 6~8 in SSFC). As a result, we need to fix this issue first then make a rule / policy to sync EC / Coreboot side and whether or not the fw_config definition is per baseboard or variants in coreboot. I will file an issue later in issue tracker latter. Now I would suggest a new CL to change this one to 41 ~ 43 first and also submit a CL to EC side to lock down these bits declaration in EC side too. [1] https://chromium.googlesource.com/chromiumos/platform/ec/+/refs/heads/main/… -- To view, visit https://review.coreboot.org/c/coreboot/+/52851 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I087ea677a8865fc8c5b3f7c9773bd7f97924dbb3 Gerrit-Change-Number: 52851 Gerrit-PatchSet: 5 Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Henry Sun <henrysun(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Marco Chen <marcochen(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Henry Sun <henrysun(a)google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Mon, 10 May 2021 10:25:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021