coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: security/intel/cbnt: Add logging
by build bot (Jenkins) (Code Review) 12 May '21

12 May '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54093 ) Change subject: security/intel/cbnt: Add logging ...................................................................... Patch Set 4: (9 comments) File src/security/intel/cbnt/logging.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/fc90a563_7e7e1387 PS4, Line 21: uint64_t : 24; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/ac1529ee_76e8c970 PS4, Line 23: uint64_t : 1; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/b0b9ce6e_06281a0e PS4, Line 25: uint64_t : 29; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/686e04ad_9e7d1cc9 PS4, Line 32: static const char *tpm_type[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/dbd95024_50c47bb9 PS4, Line 41: uint64_t : 59; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/54bac7d0_74655e60 PS4, Line 56: uint32_t : 15; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/9ca0ad7b_52fda7fd PS4, Line 66: uint32_t : 5; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/0f379cfe_38f446f1 PS4, Line 83: uint32_t : 2; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119162): https://review.coreboot.org/c/coreboot/+/54093/comment/99dd3049_862ac12f PS4, Line 94: uint32_t : 6; space prohibited before that ':' (ctx:WxW) -- To view, visit https://review.coreboot.org/c/coreboot/+/54093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b57132bedbd944b9861ab0e2e0d14723cb61635 Gerrit-Change-Number: 54093 Gerrit-PatchSet: 4 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 12 May 2021 14:40:35 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/txt: Split of microcode error type printing
by Arthur Heymans (Code Review) 12 May '21

12 May '21

Attention is currently required from: Arthur Heymans. Hello build bot (Jenkins), I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54092 to look at the new patch set (#3). Change subject: security/intel/txt: Split of microcode error type printing ...................................................................... security/intel/txt: Split of microcode error type printing The purpose is to reuse the types string in CBnT error printing. Change-Id: I435de402fef6d4702c9c7250c8bd31243a04a46e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/security/intel/txt/Makefile.inc M src/security/intel/txt/logging.c M src/security/intel/txt/txt.h 3 files changed, 33 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/54092/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/54092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I435de402fef6d4702c9c7250c8bd31243a04a46e Gerrit-Change-Number: 54092 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: security/intel/txt: Split of microcode error type printing
by build bot (Jenkins) (Code Review) 12 May '21

12 May '21

Attention is currently required from: Arthur Heymans. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54092 ) Change subject: security/intel/txt: Split of microcode error type printing ...................................................................... Patch Set 2: (1 comment) File src/security/intel/txt/logging.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119159): https://review.coreboot.org/c/coreboot/+/54092/comment/80394347_db616cbb PS2, Line 58: printk(BIOS_ERR, "%s\n", intel_txt_microcode_error_type(txt_error & TXT_ERROR_MASK)); line over 96 characters -- To view, visit https://review.coreboot.org/c/coreboot/+/54092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I435de402fef6d4702c9c7250c8bd31243a04a46e Gerrit-Change-Number: 54092 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Comment-Date: Wed, 12 May 2021 14:33:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/cbnt: Add logging
by build bot (Jenkins) (Code Review) 12 May '21

12 May '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Arthur Heymans, Morgan Jang, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54093 ) Change subject: security/intel/cbnt: Add logging ...................................................................... Patch Set 3: (9 comments) File src/security/intel/cbnt/logging.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/80d8d2f7_2d4a6f81 PS3, Line 21: uint64_t : 24; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/346677ac_c247af10 PS3, Line 23: uint64_t : 1; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/c7516640_e75ec60a PS3, Line 25: uint64_t : 29; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/b35173fe_57b9dabe PS3, Line 32: static const char *tpm_type[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/99d2cef8_93a6e25a PS3, Line 41: uint64_t : 59; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/97ca4484_ada16119 PS3, Line 56: uint32_t : 15; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/5c96f222_15ee1c97 PS3, Line 66: uint32_t : 5; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/6d967648_d13788c3 PS3, Line 83: uint32_t : 2; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119160): https://review.coreboot.org/c/coreboot/+/54093/comment/bd51d54e_1b009aab PS3, Line 94: uint32_t : 6; space prohibited before that ':' (ctx:WxW) -- To view, visit https://review.coreboot.org/c/coreboot/+/54093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b57132bedbd944b9861ab0e2e0d14723cb61635 Gerrit-Change-Number: 54093 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 12 May 2021 14:33:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/cbnt: Add logging
by Arthur Heymans (Code Review) 12 May '21

12 May '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang, Patrick Rudolph. Hello build bot (Jenkins), Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54093 to look at the new patch set (#3). Change subject: security/intel/cbnt: Add logging ...................................................................... security/intel/cbnt: Add logging This decodes and logs the CBnT status and error registers. Change-Id: I8b57132bedbd944b9861ab0e2e0d14723cb61635 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/security/intel/cbnt/Kconfig M src/security/intel/cbnt/Makefile.inc A src/security/intel/cbnt/cbnt.h A src/security/intel/cbnt/logging.c M src/security/intel/txt/ramstage.c M src/soc/intel/xeon_sp/bootblock.c 6 files changed, 238 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/54093/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/54093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b57132bedbd944b9861ab0e2e0d14723cb61635 Gerrit-Change-Number: 54093 Gerrit-PatchSet: 3 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: security/intel/txt: Split of microcode error type printing
by Arthur Heymans (Code Review) 12 May '21

12 May '21

Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/54092 ) Change subject: security/intel/txt: Split of microcode error type printing ...................................................................... security/intel/txt: Split of microcode error type printing The purpose is to reuse the types string in CBnT error printing. Change-Id: I435de402fef6d4702c9c7250c8bd31243a04a46e Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/security/intel/txt/Makefile.inc M src/security/intel/txt/logging.c M src/security/intel/txt/txt.h 3 files changed, 33 insertions(+), 41 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/54092/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54092 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I435de402fef6d4702c9c7250c8bd31243a04a46e Gerrit-Change-Number: 54092 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: nb/amd/pi/00730F01: Use generic allocation functions for northbridge
by Felix Held (Code Review) 12 May '21

12 May '21

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52926 ) Change subject: nb/amd/pi/00730F01: Use generic allocation functions for northbridge ...................................................................... Patch Set 5: (1 comment) Patchset: PS3: > Felix, 4 days passed without any action. […] i'm ok with that. sorry, didn't get around to have a closer look yet; busy with my main work -- To view, visit https://review.coreboot.org/c/coreboot/+/52926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8dd5e40bce513c5ba7f1d42a06e7ab0846666942 Gerrit-Change-Number: 52926 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 12 May 2021 14:32:17 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: tests: Enable config override for tests
by Paul Fagerburg (Code Review) 12 May '21

12 May '21

Attention is currently required from: Jakub Czapiga, Julius Werner, Jan Dabros. Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52937 ) Change subject: tests: Enable config override for tests ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52937 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I1aeb78362c2609fbefbfd91c0f58ec19ed258ee1 Gerrit-Change-Number: 52937 Gerrit-PatchSet: 3 Gerrit-Owner: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Jan Dabros <jsd(a)semihalf.com> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Paul Fagerburg <pfagerburg(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Jan Dabros <jsd(a)semihalf.com> Gerrit-Comment-Date: Wed, 12 May 2021 14:31:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/cbnt: Add logging
by build bot (Jenkins) (Code Review) 12 May '21

12 May '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Arthur Heymans, Morgan Jang, Patrick Rudolph. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54093 ) Change subject: security/intel/cbnt: Add logging ...................................................................... Patch Set 2: (9 comments) File src/security/intel/cbnt/logging.c: Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/597dafb5_bb7aa45a PS2, Line 21: uint64_t : 24; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/e35b58fe_00a3b87c PS2, Line 23: uint64_t : 1; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/1dcb67e8_439de789 PS2, Line 25: uint64_t : 29; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/ce73c894_0bbdb162 PS2, Line 32: static const char *tpm_type[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/ac207c1c_755c59f8 PS2, Line 41: uint64_t : 59; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/508c7f53_de0c5f6f PS2, Line 56: uint32_t : 15; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/2c4271d3_94cbc6c6 PS2, Line 66: uint32_t : 5; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/ea94308c_ff0528d0 PS2, Line 83: uint32_t : 2; space prohibited before that ':' (ctx:WxW) Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-119158): https://review.coreboot.org/c/coreboot/+/54093/comment/fa1a0181_b5472e2c PS2, Line 94: uint32_t : 6; space prohibited before that ':' (ctx:WxW) -- To view, visit https://review.coreboot.org/c/coreboot/+/54093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b57132bedbd944b9861ab0e2e0d14723cb61635 Gerrit-Change-Number: 54093 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-Comment-Date: Wed, 12 May 2021 14:26:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: security/intel/cbnt: Add logging
by Arthur Heymans (Code Review) 12 May '21

12 May '21

Attention is currently required from: Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang, Patrick Rudolph. Hello Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang, Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54093 to look at the new patch set (#2). Change subject: security/intel/cbnt: Add logging ...................................................................... security/intel/cbnt: Add logging This decodes and logs the CBnT status and error registers. Change-Id: I8b57132bedbd944b9861ab0e2e0d14723cb61635 Signed-off-by: Arthur Heymans <arthur(a)aheymans.xyz> --- M src/security/intel/cbnt/Kconfig M src/security/intel/cbnt/Makefile.inc A src/security/intel/cbnt/cbnt.h A src/security/intel/cbnt/logging.c M src/security/intel/txt/ramstage.c M src/soc/intel/xeon_sp/bootblock.c 6 files changed, 237 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/93/54093/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54093 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8b57132bedbd944b9861ab0e2e0d14723cb61635 Gerrit-Change-Number: 54093 Gerrit-PatchSet: 2 Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org> Gerrit-CC: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org> Gerrit-MessageType: newpatchset

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021