coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: mb/google/mancomb: Update HUB_RST_L setting in GPIO
by Martin Roth (Code Review) 12 May '21

12 May '21

Attention is currently required from: Ivy Jian. Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54078 ) Change subject: mb/google/mancomb: Update HUB_RST_L setting in GPIO ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54078 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I94e4806c7463030df31f8d819510f9533a622f2a Gerrit-Change-Number: 54078 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Comment-Date: Wed, 12 May 2021 15:15:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: util/genbuild_h: Update IASL location finding code
by Patrick Georgi (Code Review) 12 May '21

12 May '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54001 ) Change subject: util/genbuild_h: Update IASL location finding code ...................................................................... util/genbuild_h: Update IASL location finding code Update the iasl path finding code to use XGCCPATH if it's set, and to look for iasl on the path if it's not set and not under util/crossgcc. On the jenkins builders, iasl is in the path, not in util/crossgcc/xgcc. On the systems of people who have multiple copies of coreboot, it makes sense to just have a single copy of the toolchain and define XGCCPATH in the environment to point to it. Previously, either of these situations resulted in a warning from the genbuild_h tool that iasl was not found under util/crossgcc, which was true, but not particularly relevant, and generated confusion. If xcompile already existed before make was run, the correct path would be found, but on an initial build, this check couldn't find iasl. BUG=None TEST=Build with iasl in /util/crossgcc/xgcc/bin, in the path and in a directory pointed to with XGCCPATH. Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: Ic2f8dca0be8bfb54d3c672fab6cf6f005bb394c3 Reviewed-on: https://review.coreboot.org/c/coreboot/+/54001 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M util/genbuild_h/genbuild_h.sh 1 file changed, 10 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/util/genbuild_h/genbuild_h.sh b/util/genbuild_h/genbuild_h.sh index 10ca0c5..c898fb6 100755 --- a/util/genbuild_h/genbuild_h.sh +++ b/util/genbuild_h/genbuild_h.sh @@ -5,6 +5,7 @@ DATE="" GITREV="" TIMESOURCE="" +XGCCPATH="${XGCCPATH:-util/crossgcc/xgcc/bin/}" export LANG=C export LC_ALL=C @@ -47,8 +48,15 @@ esac } -IASL=util/crossgcc/xgcc/bin/iasl +# Look for IASL in XGCCPATH and xcompile. Unfortunately, +# xcompile isn't available on the first build. +# If neither of those gives a valid iasl, check the path. +IASL="${XGCCPATH}iasl" eval $(grep ^IASL:= "$XCOMPILE" 2>/dev/null | sed s,:=,=,) +if [ ! -x "${IASL}" ]; then + IASL=$(command -v iasl) +fi +IASLVERSION="$(${IASL} -v | grep version | sed 's/.*version //')" >/dev/null #Print out the information that goes into build.h printf "/* build system definitions (autogenerated) */\n" @@ -72,5 +80,5 @@ printf "#define COREBOOT_DMI_DATE \"$(our_date "$DATE" +%m/%d/%Y)\"\n" printf "\n" printf "#define COREBOOT_COMPILE_TIME \"$(our_date "$DATE" +%T)\"\n" -printf "#define ASL_VERSION 0x%d\n" `$IASL -v | grep version | sed 's/.*version //'` +printf "#define ASL_VERSION 0x%d\n" "${IASLVERSION}" printf "#endif\n" -- To view, visit https://review.coreboot.org/c/coreboot/+/54001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2f8dca0be8bfb54d3c672fab6cf6f005bb394c3 Gerrit-Change-Number: 54001 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: util/genbuild_h: Update IASL location finding code
by Patrick Georgi (Code Review) 12 May '21

12 May '21

Attention is currently required from: Nico Huber, Martin Roth. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54001 ) Change subject: util/genbuild_h: Update IASL location finding code ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54001 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ic2f8dca0be8bfb54d3c672fab6cf6f005bb394c3 Gerrit-Change-Number: 54001 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas(a)noos.fr> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 12 May 2021 15:14:25 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush,mancomb: select GOOGLE_SMBIOS_MAINBOARD_VERSION
by Eric Peers (Code Review) 12 May '21

12 May '21

Attention is currently required from: Martin Roth, Bhanu Prakash Maiya, Rob Barnes, Ivy Jian, Karthik Ramasubramanian. Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54084 ) Change subject: mb/google/guybrush,mancomb: select GOOGLE_SMBIOS_MAINBOARD_VERSION ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/54084 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I48dc83d85cfc49e2e4155e389814fce08693c4bd Gerrit-Change-Number: 54084 Gerrit-PatchSet: 1 Gerrit-Owner: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Reviewer: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Reviewer: Eric Peers <epeers(a)google.com> Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Rob Barnes <robbarnes(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Van Chen <van_chen(a)compal.corp-partner.google.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Bhanu Prakash Maiya <bhanumaiya(a)google.com> Gerrit-Attention: Rob Barnes <robbarnes(a)google.com> Gerrit-Attention: Ivy Jian <ivy_jian(a)compal.corp-partner.google.com> Gerrit-Attention: Karthik Ramasubramanian <kramasub(a)google.com> Gerrit-Comment-Date: Wed, 12 May 2021 15:14:18 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: Makefile: Don't run genbuild_h if not doing a build
by Patrick Georgi (Code Review) 12 May '21

12 May '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/53997 ) Change subject: Makefile: Don't run genbuild_h if not doing a build ...................................................................... Makefile: Don't run genbuild_h if not doing a build genbuild_h was being run on every make invocation - clean, distclean, etc. to get the source date epoch value. This value isn't used unless a build is being done, so don't run it on non-compile make invocations. Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: I2afc0affc17116e0db849ea968474bc19dbb0ae1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/53997 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M Makefile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/Makefile b/Makefile index 02c6288..e25c081 100644 --- a/Makefile +++ b/Makefile @@ -24,7 +24,9 @@ LANG:=C LC_ALL:=C TZ:=UTC0 +ifneq ($(NOCOMPILE),1) SOURCE_DATE_EPOCH := $(shell $(top)/util/genbuild_h/genbuild_h.sh . | sed -n 's/^.define COREBOOT_BUILD_EPOCH\>.*"$.*$".*/\1/p') +endif # don't use COREBOOT_EXPORTS to ensure build steps outside the coreboot build system # are reproducible export LANG LC_ALL TZ SOURCE_DATE_EPOCH -- To view, visit https://review.coreboot.org/c/coreboot/+/53997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2afc0affc17116e0db849ea968474bc19dbb0ae1 Gerrit-Change-Number: 53997 Gerrit-PatchSet: 3 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: src/security/intel/stm: Add warning for non-reproducible build
by Patrick Georgi (Code Review) 12 May '21

12 May '21

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/54020 ) Change subject: src/security/intel/stm: Add warning for non-reproducible build ...................................................................... src/security/intel/stm: Add warning for non-reproducible build Because the STM build doesn't use the coreboot toolchain it's not reproducible. Make sure that's displayed during the build. Signed-off-by: Martin Roth <martin(a)coreboot.org> Change-Id: I3f0101400dc221eca09c928705f30d30492f171f Reviewed-on: https://review.coreboot.org/c/coreboot/+/54020 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Angel Pons <th3fanbus(a)gmail.com> Reviewed-by: Patrick Georgi <pgeorgi(a)google.com> --- M src/security/intel/stm/Makefile 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve diff --git a/src/security/intel/stm/Makefile b/src/security/intel/stm/Makefile index 1493869..31e5bdd 100644 --- a/src/security/intel/stm/Makefile +++ b/src/security/intel/stm/Makefile @@ -18,6 +18,8 @@ build: echo "STM - Build" + echo "-- WARNING: This uses the system toolchain instead of" + echo " the coreboot toolchain, so is not reproducible." cd $(project_dir)/Stm; \ mkdir -p build; \ cd build; \ -- To view, visit https://review.coreboot.org/c/coreboot/+/54020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f0101400dc221eca09c928705f30d30492f171f Gerrit-Change-Number: 54020 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: Makefile: Don't run genbuild_h if not doing a build
by Patrick Georgi (Code Review) 12 May '21

12 May '21

Attention is currently required from: Nico Huber, Martin Roth. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53997 ) Change subject: Makefile: Don't run genbuild_h if not doing a build ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/53997 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I2afc0affc17116e0db849ea968474bc19dbb0ae1 Gerrit-Change-Number: 53997 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Nico Huber <nico.h(a)gmx.de> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Comment-Date: Wed, 12 May 2021 15:13:32 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: src/security/intel/stm: Add warning for non-reproducible build
by Patrick Georgi (Code Review) 12 May '21

12 May '21

Attention is currently required from: Martin Roth, Eugene Myers. Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54020 ) Change subject: src/security/intel/stm: Add warning for non-reproducible build ...................................................................... Patch Set 1: Code-Review+2 (1 comment) Patchset: PS1: Not sure such warnings help much, but it's better than nothing. -- To view, visit https://review.coreboot.org/c/coreboot/+/54020 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3f0101400dc221eca09c928705f30d30492f171f Gerrit-Change-Number: 54020 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Eugene Myers <cedarhouse1(a)comcast.net> Gerrit-Comment-Date: Wed, 12 May 2021 15:13:09 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/guybrush,mancomb: Adjust GBB size to 12KB
by Martin Roth (Code Review) 12 May '21

12 May '21

Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/52764 ) Change subject: mb/google/guybrush,mancomb: Adjust GBB size to 12KB ...................................................................... mb/google/guybrush,mancomb: Adjust GBB size to 12KB The 448KB size of the GBB is larger than is needed, so adjust it down to the minimum size needed. BUG=b:186761897 TEST=Build & Boot guybrush Signed-off-by: Martin Roth <martinroth(a)chromium.org> Change-Id: I7a24945cd9ecc8872871f57b09ca71fc40e92473 Reviewed-on: https://review.coreboot.org/c/coreboot/+/52764 Tested-by: build bot (Jenkins) <no-reply(a)coreboot.org> Reviewed-by: Raul Rangel <rrangel(a)chromium.org> Reviewed-by: Furquan Shaikh <furquan(a)google.com> --- M src/mainboard/google/guybrush/chromeos.fmd M src/mainboard/google/mancomb/chromeos.fmd 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Raul Rangel: Looks good to me, approved diff --git a/src/mainboard/google/guybrush/chromeos.fmd b/src/mainboard/google/guybrush/chromeos.fmd index be43e8a..3875700 100644 --- a/src/mainboard/google/guybrush/chromeos.fmd +++ b/src/mainboard/google/guybrush/chromeos.fmd @@ -25,7 +25,7 @@ RO_SECTION { FMAP 2K RO_FRID 64 - GBB@4K 448K + GBB@4K 12K COREBOOT(CBFS) } } diff --git a/src/mainboard/google/mancomb/chromeos.fmd b/src/mainboard/google/mancomb/chromeos.fmd index be43e8a..3875700 100644 --- a/src/mainboard/google/mancomb/chromeos.fmd +++ b/src/mainboard/google/mancomb/chromeos.fmd @@ -25,7 +25,7 @@ RO_SECTION { FMAP 2K RO_FRID 64 - GBB@4K 448K + GBB@4K 12K COREBOOT(CBFS) } } -- To view, visit https://review.coreboot.org/c/coreboot/+/52764 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7a24945cd9ecc8872871f57b09ca71fc40e92473 Gerrit-Change-Number: 52764 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Raul Rangel <rrangel(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-MessageType: merged

1 0

Change in coreboot[master]: nb/amd/pi/00730F01: Use generic allocation functions for northbridge
by Michał Żygowski (Code Review) 12 May '21

12 May '21

Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52926 ) Change subject: nb/amd/pi/00730F01: Use generic allocation functions for northbridge ...................................................................... Patch Set 5: (1 comment) Patchset: PS3: > i'm ok with that. […] No problem. If anything arises, I am open to fix it. -- To view, visit https://review.coreboot.org/c/coreboot/+/52926 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I8dd5e40bce513c5ba7f1d42a06e7ab0846666942 Gerrit-Change-Number: 52926 Gerrit-PatchSet: 5 Gerrit-Owner: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-Reviewer: Krystian Hebel <krystian.hebel(a)3mdeb.com> Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Reviewer: Michał Żygowski <michal.zygowski(a)3mdeb.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Comment-Date: Wed, 12 May 2021 14:58:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com> Comment-In-Reply-To: Felix Held <felix-coreboot(a)felixheld.de> Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021