Attention is currently required from: Christian Walter.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54095 )
Change subject: src/security/tpm: Deal with zero length tlcl writes
......................................................................
Patch Set 1: Code-Review+1
--
To view, visit https://review.coreboot.org/c/coreboot/+/54095
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idbffa508c2cd68790efbc0b4ab97ae1b4d85ad51
Gerrit-Change-Number: 54095
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Christian Walter <christian.walter(a)9elements.com>
Gerrit-Comment-Date: Thu, 13 May 2021 09:35:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Stefan Ott, Xi Chen, Anjaneya "Reddy" Chagam, Jonathan Zhang, Johnny Lin, Morgan Jang, Alexander Couzens, Patrick Rudolph.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54094 )
Change subject: src: Match array format in function declarations and definitions
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit https://review.coreboot.org/c/coreboot/+/54094
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5a1b3824a85a178431177620c4c0d5fddc993b4f
Gerrit-Change-Number: 54094
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Felix Singer <felixsinger(a)posteo.net>
Gerrit-Reviewer: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com>
Gerrit-Reviewer: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Reviewer: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org>
Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Attention: Stefan Ott <coreboot(a)desire.ch>
Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com>
Gerrit-Attention: Anjaneya "Reddy" Chagam <anjaneya.chagam(a)intel.com>
Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com>
Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com>
Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com>
Gerrit-Attention: Alexander Couzens <lynxis(a)fe80.eu>
Gerrit-Attention: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Comment-Date: Thu, 13 May 2021 09:34:45 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Attention is currently required from: Rex-BC Chen.
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54229 )
Change subject: soc/mediatek/mt8195: Initialize DRAM in romstage
......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54229/comment/3d629574_766c9628
PS1, Line 9: and porting DRAM fast-k.
> dram fast-k is included in this patch.
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/54229/comment/fd443069_38fba6b8
PS3, Line 9: Initialize DRAM in romstage.
: Add DRAM fast calibration support
Initialize DRAM in romstage and configure to support DRAM
fast calibration.
--
To view, visit https://review.coreboot.org/c/coreboot/+/54229
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89b87be62c8e88ae4a620d56aa7a35e47f97952d
Gerrit-Change-Number: 54229
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Comment-Date: Thu, 13 May 2021 09:25:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Comment-In-Reply-To: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: comment
Attention is currently required from: David Wu, Furquan Shaikh, Henry Sun.
Marco Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52851 )
Change subject: mb/google/dedede/var/magolor: Select touchscreen based on SSFC in FW_CONFIG
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
Patchset:
PS7:
Hi Furquan and Patrick,
Could you support to merge this CL? And may we know when will be the next batch downstreamed to Chromium? Thanks.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52851
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I087ea677a8865fc8c5b3f7c9773bd7f97924dbb3
Gerrit-Change-Number: 52851
Gerrit-PatchSet: 7
Gerrit-Owner: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com>
Gerrit-Reviewer: Henry Sun <henrysun(a)google.com>
Gerrit-Reviewer: Karthik Ramasubramanian <kramasub(a)google.com>
Gerrit-Reviewer: Marco Chen <marcochen(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: David Wu <david_wu(a)quanta.corp-partner.google.com>
Gerrit-Attention: Furquan Shaikh <furquan(a)google.com>
Gerrit-Attention: Henry Sun <henrysun(a)google.com>
Gerrit-Comment-Date: Thu, 13 May 2021 09:21:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52850 )
Change subject: drivers/intel/fsp2_0: Fix the FSP-T position
......................................................................
Patch Set 5:
(1 comment)
File src/drivers/intel/fsp2_0/Kconfig:
https://review.coreboot.org/c/coreboot/+/52850/comment/8f9b2f12_70f7e04d
PS2, Line 81: The location for FSP-T.
> Ack
I recall Skylake/Kabylake did not relocate it when I was developing Boot Guard support back then. That said, things may have changed and this may no longer be true. I will revisit it and if needed upload a patch.
--
To view, visit https://review.coreboot.org/c/coreboot/+/52850
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ec8b238384684dccf39e5da902d426d3a32b9db
Gerrit-Change-Number: 52850
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Andrey Petrov <andrey.petrov(a)gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-Reviewer: Patrick Georgi <pgeorgi(a)google.com>
Gerrit-Reviewer: Patrick Rudolph <siro(a)das-labor.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-CC: 9elements QA <hardwaretestrobot(a)gmail.com>
Gerrit-CC: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org>
Gerrit-Comment-Date: Thu, 13 May 2021 08:55:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michał Żygowski <michal.zygowski(a)3mdeb.com>
Comment-In-Reply-To: Paul Menzel <paulepanter(a)mailbox.org>
Comment-In-Reply-To: Arthur Heymans <arthur(a)aheymans.xyz>
Gerrit-MessageType: comment
Attention is currently required from: Hung-Te Lin.
Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54229 )
Change subject: soc/mediatek/mt8195: Initialize DRAM in romstage
......................................................................
Patch Set 3:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54229/comment/cd446d7e_5fdff0e6
PS1, Line 9: and porting DRAM fast-k.
> this is not included in this patch? or is it?
dram fast-k is included in this patch.
File src/soc/mediatek/mt8195/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/54229/comment/adfe027c_a4ad4e86
PS1, Line 31: ../common/memory_test.c
> move to next line.
Done
https://review.coreboot.org/c/coreboot/+/54229/comment/a7d11305_c24566d7
PS1, Line 61: BL31_MAKEARGS += PLAT=mt8195
> this should not be included in this patch
Done
--
To view, visit https://review.coreboot.org/c/coreboot/+/54229
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89b87be62c8e88ae4a620d56aa7a35e47f97952d
Gerrit-Change-Number: 54229
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Comment-Date: Thu, 13 May 2021 08:47:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-MessageType: comment
Attention is currently required from: Rex-BC Chen.
Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54230
to look at the new patch set (#3).
Change subject: vendor/mediatek: Add MT8195 dram initialization code
......................................................................
vendor/mediatek: Add MT8195 dram initialization code
This is the DRAM initialization code from the reference
implementation released by Mediatek for MT8195.
The DRAM calibration code can be taken as a standalone
library, used by different boot loaders for initializing
DRAM and following a different coding style (coreboot was
using Linux Kernel coding style), so we have to put it
in vendor code folder.
Signed-off-by: Ryan Chuang <ryan.chuang(a)mediatek.com>
Change-Id: Iada3ec5ae8a39a8e9253caba550c834d486dddcd
---
M src/vendorcode/mediatek/Makefile.inc
A src/vendorcode/mediatek/mt8195/Makefile.inc
A src/vendorcode/mediatek/mt8195/dramc/ANA_init_config.c
A src/vendorcode/mediatek/mt8195/dramc/DIG_NONSHUF_config.c
A src/vendorcode/mediatek/mt8195/dramc/DIG_SHUF_config.c
A src/vendorcode/mediatek/mt8195/dramc/DRAMC_SUBSYS_config.c
A src/vendorcode/mediatek/mt8195/dramc/DRAM_config_collctioin.c
A src/vendorcode/mediatek/mt8195/dramc/Hal_io.c
A src/vendorcode/mediatek/mt8195/dramc/LP4_dram_init.c
A src/vendorcode/mediatek/mt8195/dramc/Makefile.inc
A src/vendorcode/mediatek/mt8195/dramc/dramc_actiming.c
A src/vendorcode/mediatek/mt8195/dramc/dramc_debug.c
A src/vendorcode/mediatek/mt8195/dramc/dramc_dv_freq_related.c
A src/vendorcode/mediatek/mt8195/dramc/dramc_dvfs.c
A src/vendorcode/mediatek/mt8195/dramc/dramc_lowpower.c
A src/vendorcode/mediatek/mt8195/dramc/dramc_pi_basic_api.c
A src/vendorcode/mediatek/mt8195/dramc/dramc_pi_calibration_api.c
A src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c
A src/vendorcode/mediatek/mt8195/dramc/dramc_top.c
A src/vendorcode/mediatek/mt8195/dramc/dramc_tracking.c
A src/vendorcode/mediatek/mt8195/dramc/dramc_utility.c
A src/vendorcode/mediatek/mt8195/dramc/emi.c
A src/vendorcode/mediatek/mt8195/include/8195_Register_DDRPHY_AO.h
A src/vendorcode/mediatek/mt8195/include/8195_Register_DDRPHY_MD32.h
A src/vendorcode/mediatek/mt8195/include/8195_Register_DDRPHY_NAO.h
A src/vendorcode/mediatek/mt8195/include/8195_Register_DRAMC_AO.h
A src/vendorcode/mediatek/mt8195/include/8195_Register_DRAMC_NAO.h
A src/vendorcode/mediatek/mt8195/include/dramc_actiming.h
A src/vendorcode/mediatek/mt8195/include/dramc_common.h
A src/vendorcode/mediatek/mt8195/include/dramc_custom.h
A src/vendorcode/mediatek/mt8195/include/dramc_dv_init.h
A src/vendorcode/mediatek/mt8195/include/dramc_int_global.h
A src/vendorcode/mediatek/mt8195/include/dramc_int_slt.h
A src/vendorcode/mediatek/mt8195/include/dramc_pi_api.h
A src/vendorcode/mediatek/mt8195/include/dramc_register.h
A src/vendorcode/mediatek/mt8195/include/dramc_top.h
A src/vendorcode/mediatek/mt8195/include/dramc_typedefs.h
A src/vendorcode/mediatek/mt8195/include/emi.h
A src/vendorcode/mediatek/mt8195/include/emi_hw.h
A src/vendorcode/mediatek/mt8195/include/emi_mpu_mt.h
A src/vendorcode/mediatek/mt8195/include/mt8195.h
A src/vendorcode/mediatek/mt8195/include/pll.h
A src/vendorcode/mediatek/mt8195/include/print.h
A src/vendorcode/mediatek/mt8195/include/reg.h
A src/vendorcode/mediatek/mt8195/include/sv_c_data_traffic.h
A src/vendorcode/mediatek/mt8195/include/x_hal_io.h
46 files changed, 96,771 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/54230/3
--
To view, visit https://review.coreboot.org/c/coreboot/+/54230
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iada3ec5ae8a39a8e9253caba550c834d486dddcd
Gerrit-Change-Number: 54230
Gerrit-PatchSet: 3
Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org>
Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com>
Gerrit-MessageType: newpatchset