coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: cbfs: Increase mcache size defaults
by Angel Pons (Code Review) 13 May '21

13 May '21

Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Julius Werner, Aaron Durbin. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54146 ) Change subject: cbfs: Increase mcache size defaults ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/54146 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I046ae18c9db9a5d682384edde303c07e0be9d790 Gerrit-Change-Number: 54146 Gerrit-PatchSet: 1 Gerrit-Owner: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Furquan Shaikh <furquan(a)google.com> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Aaron Durbin <adurbin(a)chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 10:00:24 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: Add fast calibration support
by Yu-Ping Wu (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54269 ) Change subject: mb/google/cherry: Add fast calibration support ...................................................................... Patch Set 2: (2 comments) File src/mainboard/google/cherry/sdram_configs.c: https://review.coreboot.org/c/coreboot/+/54269/comment/0635119f_5de0339a PS2, Line 8: , . https://review.coreboot.org/c/coreboot/+/54269/comment/53b9869e_9d17b7ea PS2, Line 9: t T -- To view, visit https://review.coreboot.org/c/coreboot/+/54269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27 Gerrit-Change-Number: 54269 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 13 May 2021 09:59:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: payload/tianocore: Drop IA32 option when UEFIPAYLOAD select
by Angel Pons (Code Review) 13 May '21

13 May '21

Attention is currently required from: Lance Zhao, Bora Guvendik, Lijian Zhao, Martin Roth, Matt DeVillier, John Zhao, Stefan Reinauer. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54189 ) Change subject: payload/tianocore: Drop IA32 option when UEFIPAYLOAD select ...................................................................... Patch Set 2: (1 comment) Patchset: PS2: There's plans to remove CorebootPayloadPkg support, see CB:54019 for more details. -- To view, visit https://review.coreboot.org/c/coreboot/+/54189 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iadd9a3c455fad4eede8a0a017415acd2c57fba04 Gerrit-Change-Number: 54189 Gerrit-PatchSet: 2 Gerrit-Owner: Lance Zhao Gerrit-Reviewer: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Reviewer: John Zhao <john.zhao(a)intel.com> Gerrit-Reviewer: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Reviewer: Martin Roth <martinroth(a)google.com> Gerrit-Reviewer: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Lance Zhao Gerrit-Attention: Bora Guvendik <bora.guvendik(a)intel.com> Gerrit-Attention: Lijian Zhao <lijian.zhao(a)intel.com> Gerrit-Attention: Martin Roth <martinroth(a)google.com> Gerrit-Attention: Matt DeVillier <matt.devillier(a)gmail.com> Gerrit-Attention: John Zhao <john.zhao(a)intel.com> Gerrit-Attention: Stefan Reinauer <stefan.reinauer(a)coreboot.org> Gerrit-Comment-Date: Thu, 13 May 2021 09:55:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Initialize DRAM in romstage
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54229 ) Change subject: soc/mediatek/mt8195: Initialize DRAM in romstage ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54229/comment/084da6cf_e2092fcb PS3, Line 9: Initialize DRAM in romstage. : Add DRAM fast calibration support > Initialize DRAM in romstage and configure to support DRAM […] Done -- To view, visit https://review.coreboot.org/c/coreboot/+/54229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89b87be62c8e88ae4a620d56aa7a35e47f97952d Gerrit-Change-Number: 54229 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 09:43:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: DO-NOT-SUBMIT: MT8195 Cherry review ToT
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu, Yidi Lin. Rex-BC Chen has uploaded a new patch set (#79) to the change originally created by Yidi Lin. ( https://review.coreboot.org/c/coreboot/+/52260 ) Change subject: DO-NOT-SUBMIT: MT8195 Cherry review ToT ...................................................................... DO-NOT-SUBMIT: MT8195 Cherry review ToT Signed-off-by: Yidi Lin <yidi.lin(a)mediatek.com> Change-Id: I3ed96b245bbb52501e9b7d6b89ed42468f505ab0 --- M 3rdparty/amd_blobs M 3rdparty/blobs M 3rdparty/intel-microcode M README.md 4 files changed, 4 insertions(+), 3 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/60/52260/79 -- To view, visit https://review.coreboot.org/c/coreboot/+/52260 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I3ed96b245bbb52501e9b7d6b89ed42468f505ab0 Gerrit-Change-Number: 52260 Gerrit-PatchSet: 79 Gerrit-Owner: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Joel Kitching <kitching(a)google.com> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-CC: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Attention: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/google/cherry: Add fast calibration support
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54269 to look at the new patch set (#2). Change subject: mb/google/cherry: Add fast calibration support ...................................................................... mb/google/cherry: Add fast calibration support Signed-off-by: Ryan Chuang <ryan.chuang(a)mediatek.com> Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27 --- M src/mainboard/google/cherry/Makefile.inc A src/mainboard/google/cherry/boardid.c M src/mainboard/google/cherry/romstage.c A src/mainboard/google/cherry/sdram_configs.c 4 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/54269/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27 Gerrit-Change-Number: 54269 Gerrit-PatchSet: 2 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vendor/mediatek: Add MT8195 dram initialization code
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54230 to look at the new patch set (#4). Change subject: vendor/mediatek: Add MT8195 dram initialization code ...................................................................... vendor/mediatek: Add MT8195 dram initialization code This is the DRAM initialization code from the reference implementation released by Mediatek for MT8195. The DRAM calibration code can be taken as a standalone library, used by different boot loaders for initializing DRAM and following a different coding style (coreboot was using Linux Kernel coding style), so we have to put it in vendor code folder. Signed-off-by: Ryan Chuang <ryan.chuang(a)mediatek.com> Change-Id: Iada3ec5ae8a39a8e9253caba550c834d486dddcd --- M src/vendorcode/mediatek/Makefile.inc A src/vendorcode/mediatek/mt8195/Makefile.inc A src/vendorcode/mediatek/mt8195/dramc/ANA_init_config.c A src/vendorcode/mediatek/mt8195/dramc/DIG_NONSHUF_config.c A src/vendorcode/mediatek/mt8195/dramc/DIG_SHUF_config.c A src/vendorcode/mediatek/mt8195/dramc/DRAMC_SUBSYS_config.c A src/vendorcode/mediatek/mt8195/dramc/DRAM_config_collctioin.c A src/vendorcode/mediatek/mt8195/dramc/Hal_io.c A src/vendorcode/mediatek/mt8195/dramc/LP4_dram_init.c A src/vendorcode/mediatek/mt8195/dramc/Makefile.inc A src/vendorcode/mediatek/mt8195/dramc/dramc_actiming.c A src/vendorcode/mediatek/mt8195/dramc/dramc_debug.c A src/vendorcode/mediatek/mt8195/dramc/dramc_dv_freq_related.c A src/vendorcode/mediatek/mt8195/dramc/dramc_dvfs.c A src/vendorcode/mediatek/mt8195/dramc/dramc_lowpower.c A src/vendorcode/mediatek/mt8195/dramc/dramc_pi_basic_api.c A src/vendorcode/mediatek/mt8195/dramc/dramc_pi_calibration_api.c A src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c A src/vendorcode/mediatek/mt8195/dramc/dramc_top.c A src/vendorcode/mediatek/mt8195/dramc/dramc_tracking.c A src/vendorcode/mediatek/mt8195/dramc/dramc_utility.c A src/vendorcode/mediatek/mt8195/dramc/emi.c A src/vendorcode/mediatek/mt8195/include/8195_Register_DDRPHY_AO.h A src/vendorcode/mediatek/mt8195/include/8195_Register_DDRPHY_MD32.h A src/vendorcode/mediatek/mt8195/include/8195_Register_DDRPHY_NAO.h A src/vendorcode/mediatek/mt8195/include/8195_Register_DRAMC_AO.h A src/vendorcode/mediatek/mt8195/include/8195_Register_DRAMC_NAO.h A src/vendorcode/mediatek/mt8195/include/dramc_actiming.h A src/vendorcode/mediatek/mt8195/include/dramc_common.h A src/vendorcode/mediatek/mt8195/include/dramc_custom.h A src/vendorcode/mediatek/mt8195/include/dramc_dv_init.h A src/vendorcode/mediatek/mt8195/include/dramc_int_global.h A src/vendorcode/mediatek/mt8195/include/dramc_int_slt.h A src/vendorcode/mediatek/mt8195/include/dramc_pi_api.h A src/vendorcode/mediatek/mt8195/include/dramc_register.h A src/vendorcode/mediatek/mt8195/include/dramc_top.h A src/vendorcode/mediatek/mt8195/include/dramc_typedefs.h A src/vendorcode/mediatek/mt8195/include/emi.h A src/vendorcode/mediatek/mt8195/include/emi_hw.h A src/vendorcode/mediatek/mt8195/include/emi_mpu_mt.h A src/vendorcode/mediatek/mt8195/include/mt8195.h A src/vendorcode/mediatek/mt8195/include/pll.h A src/vendorcode/mediatek/mt8195/include/print.h A src/vendorcode/mediatek/mt8195/include/reg.h A src/vendorcode/mediatek/mt8195/include/sv_c_data_traffic.h A src/vendorcode/mediatek/mt8195/include/x_hal_io.h 46 files changed, 96,771 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/54230/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/54230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iada3ec5ae8a39a8e9253caba550c834d486dddcd Gerrit-Change-Number: 54230 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8195: enable ARM64_USE_ARM_TRUSTED_FIRMWARE
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin, Paul Menzel. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/53898 to look at the new patch set (#9). Change subject: soc/mediatek/mt8195: enable ARM64_USE_ARM_TRUSTED_FIRMWARE ...................................................................... soc/mediatek/mt8195: enable ARM64_USE_ARM_TRUSTED_FIRMWARE Enable ATF configuration to support multi-core. TEST=boot to kernel with multi-core support. BUG=b:177593590 Signed-off-by: Yidi Lin <yidi.lin(a)mediatek.com> Change-Id: Id1ef29894fa3a6022574c3874dee62617133b12c --- M src/soc/mediatek/mt8195/Kconfig M src/soc/mediatek/mt8195/Makefile.inc 2 files changed, 3 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/98/53898/9 -- To view, visit https://review.coreboot.org/c/coreboot/+/53898 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Id1ef29894fa3a6022574c3874dee62617133b12c Gerrit-Change-Number: 53898 Gerrit-PatchSet: 9 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Initialize DRAM in romstage
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Rex-BC Chen. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54229 to look at the new patch set (#4). Change subject: soc/mediatek/mt8195: Initialize DRAM in romstage ...................................................................... soc/mediatek/mt8195: Initialize DRAM in romstage Initialize DRAM in romstage and configure to support DRAM fast calibration. Change-Id: I89b87be62c8e88ae4a620d56aa7a35e47f97952d Signed-off-by: Yidi Lin <yidi.lin(a)mediatek.com> Signed-off-by: Ryan Chuang <ryan.chuang(a)mediatek.com> --- M src/soc/mediatek/mt8195/Kconfig M src/soc/mediatek/mt8195/Makefile.inc A src/soc/mediatek/mt8195/include/soc/dramc_soc.h D src/soc/mediatek/mt8195/include/soc/emi.h 4 files changed, 66 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/54229/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/54229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89b87be62c8e88ae4a620d56aa7a35e47f97952d Gerrit-Change-Number: 54229 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vc/mediatek: Align code indent with code flow
by Angel Pons (Code Review) 13 May '21

13 May '21

Attention is currently required from: Xi Chen, Julius Werner, Yu-Ping Wu. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54096 ) Change subject: vc/mediatek: Align code indent with code flow ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/54096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b8cacd48e86284c5145c4e8ffb6add75a743108 Gerrit-Change-Number: 54096 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 13 May 2021 09:37:21 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021