coreboot-gerrit May 2021

coreboot-gerrit@coreboot.org

1 participants
6048 discussions

Change in coreboot[master]: Documentation/distributions: Separate parenthesis by dashes
by Paul Menzel (Code Review) 13 May '21

13 May '21

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/54270 ) Change subject: Documentation/distributions: Separate parenthesis by dashes ...................................................................... Documentation/distributions: Separate parenthesis by dashes Change-Id: I5d6095c6d8423e3a67f027f23d4c00dcb34a50cb Signed-off-by: Paul Menzel <pmenzel(a)molgen.mpg.de> --- M Documentation/distributions.md 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/54270/1 diff --git a/Documentation/distributions.md b/Documentation/distributions.md index fbfeb7c..75ac698 100644 --- a/Documentation/distributions.md +++ b/Documentation/distributions.md @@ -20,8 +20,8 @@ All ChromeOS devices ([Chromebooks](https://chromebookdb.com/), Chromeboxes, Chromebit, etc) released from 2012 onward use coreboot for their main system firmware. Additionally, starting with the 2013 Chromebook Pixel, the firmware -running on the Embedded Controller (EC - a small microcontroller which provides -functions like battery management, keyboard support, and sensor interfacing) +running on the Embedded Controller (EC) – a small microcontroller which provides +functions like battery management, keyboard support, and sensor interfacing – is open source as well. ### Libretrend -- To view, visit https://review.coreboot.org/c/coreboot/+/54270 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d6095c6d8423e3a67f027f23d4c00dcb34a50cb Gerrit-Change-Number: 54270 Gerrit-PatchSet: 1 Gerrit-Owner: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Initialize DRAM in romstage
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54229 ) Change subject: soc/mediatek/mt8195: Initialize DRAM in romstage ...................................................................... Patch Set 5: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54229/comment/ce40a134_7480d543 PS4, Line 9: Initialize DRAM in romstage and configure to : support DRAM fast calibration. > Reflow the text so that the line length <= 72 characters. Done -- To view, visit https://review.coreboot.org/c/coreboot/+/54229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89b87be62c8e88ae4a620d56aa7a35e47f97952d Gerrit-Change-Number: 54229 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Comment-Date: Thu, 13 May 2021 10:08:38 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: Add fast calibration support
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

1 0

Change in coreboot[master]: vendor/mediatek: Add MT8195 dram initialization code
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54230 to look at the new patch set (#5). Change subject: vendor/mediatek: Add MT8195 dram initialization code ...................................................................... vendor/mediatek: Add MT8195 dram initialization code This is the DRAM initialization code from the reference implementation released by Mediatek for MT8195. The DRAM calibration code can be taken as a standalone library, used by different boot loaders for initializing DRAM and following a different coding style (coreboot was using Linux Kernel coding style), so we have to put it in vendor code folder. Signed-off-by: Ryan Chuang <ryan.chuang(a)mediatek.com> Change-Id: Iada3ec5ae8a39a8e9253caba550c834d486dddcd --- M src/vendorcode/mediatek/Makefile.inc A src/vendorcode/mediatek/mt8195/Makefile.inc A src/vendorcode/mediatek/mt8195/dramc/ANA_init_config.c A src/vendorcode/mediatek/mt8195/dramc/DIG_NONSHUF_config.c A src/vendorcode/mediatek/mt8195/dramc/DIG_SHUF_config.c A src/vendorcode/mediatek/mt8195/dramc/DRAMC_SUBSYS_config.c A src/vendorcode/mediatek/mt8195/dramc/DRAM_config_collctioin.c A src/vendorcode/mediatek/mt8195/dramc/Hal_io.c A src/vendorcode/mediatek/mt8195/dramc/LP4_dram_init.c A src/vendorcode/mediatek/mt8195/dramc/Makefile.inc A src/vendorcode/mediatek/mt8195/dramc/dramc_actiming.c A src/vendorcode/mediatek/mt8195/dramc/dramc_debug.c A src/vendorcode/mediatek/mt8195/dramc/dramc_dv_freq_related.c A src/vendorcode/mediatek/mt8195/dramc/dramc_dvfs.c A src/vendorcode/mediatek/mt8195/dramc/dramc_lowpower.c A src/vendorcode/mediatek/mt8195/dramc/dramc_pi_basic_api.c A src/vendorcode/mediatek/mt8195/dramc/dramc_pi_calibration_api.c A src/vendorcode/mediatek/mt8195/dramc/dramc_pi_main.c A src/vendorcode/mediatek/mt8195/dramc/dramc_top.c A src/vendorcode/mediatek/mt8195/dramc/dramc_tracking.c A src/vendorcode/mediatek/mt8195/dramc/dramc_utility.c A src/vendorcode/mediatek/mt8195/dramc/emi.c A src/vendorcode/mediatek/mt8195/include/8195_Register_DDRPHY_AO.h A src/vendorcode/mediatek/mt8195/include/8195_Register_DDRPHY_MD32.h A src/vendorcode/mediatek/mt8195/include/8195_Register_DDRPHY_NAO.h A src/vendorcode/mediatek/mt8195/include/8195_Register_DRAMC_AO.h A src/vendorcode/mediatek/mt8195/include/8195_Register_DRAMC_NAO.h A src/vendorcode/mediatek/mt8195/include/dramc_actiming.h A src/vendorcode/mediatek/mt8195/include/dramc_common.h A src/vendorcode/mediatek/mt8195/include/dramc_custom.h A src/vendorcode/mediatek/mt8195/include/dramc_dv_init.h A src/vendorcode/mediatek/mt8195/include/dramc_int_global.h A src/vendorcode/mediatek/mt8195/include/dramc_int_slt.h A src/vendorcode/mediatek/mt8195/include/dramc_pi_api.h A src/vendorcode/mediatek/mt8195/include/dramc_register.h A src/vendorcode/mediatek/mt8195/include/dramc_top.h A src/vendorcode/mediatek/mt8195/include/dramc_typedefs.h A src/vendorcode/mediatek/mt8195/include/emi.h A src/vendorcode/mediatek/mt8195/include/emi_hw.h A src/vendorcode/mediatek/mt8195/include/emi_mpu_mt.h A src/vendorcode/mediatek/mt8195/include/mt8195.h A src/vendorcode/mediatek/mt8195/include/pll.h A src/vendorcode/mediatek/mt8195/include/print.h A src/vendorcode/mediatek/mt8195/include/reg.h A src/vendorcode/mediatek/mt8195/include/sv_c_data_traffic.h A src/vendorcode/mediatek/mt8195/include/x_hal_io.h 46 files changed, 96,771 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/54230/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/54230 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iada3ec5ae8a39a8e9253caba550c834d486dddcd Gerrit-Change-Number: 54230 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Initialize DRAM in romstage
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, Yidi Lin, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54229 to look at the new patch set (#5). Change subject: soc/mediatek/mt8195: Initialize DRAM in romstage ...................................................................... soc/mediatek/mt8195: Initialize DRAM in romstage Initialize DRAM in romstage and configure to support fast calibration. Change-Id: I89b87be62c8e88ae4a620d56aa7a35e47f97952d Signed-off-by: Yidi Lin <yidi.lin(a)mediatek.com> Signed-off-by: Ryan Chuang <ryan.chuang(a)mediatek.com> --- M src/soc/mediatek/mt8195/Kconfig M src/soc/mediatek/mt8195/Makefile.inc A src/soc/mediatek/mt8195/include/soc/dramc_soc.h D src/soc/mediatek/mt8195/include/soc/emi.h 4 files changed, 66 insertions(+), 10 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/29/54229/5 -- To view, visit https://review.coreboot.org/c/coreboot/+/54229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89b87be62c8e88ae4a620d56aa7a35e47f97952d Gerrit-Change-Number: 54229 Gerrit-PatchSet: 5 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: soc/mediatek/mt8195: Initialize DRAM in romstage
by Yu-Ping Wu (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54229 ) Change subject: soc/mediatek/mt8195: Initialize DRAM in romstage ...................................................................... Patch Set 4: (1 comment) Commit Message: https://review.coreboot.org/c/coreboot/+/54229/comment/e0df4b86_3d5d4655 PS4, Line 9: Initialize DRAM in romstage and configure to : support DRAM fast calibration. Reflow the text so that the line length <= 72 characters. -- To view, visit https://review.coreboot.org/c/coreboot/+/54229 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I89b87be62c8e88ae4a620d56aa7a35e47f97952d Gerrit-Change-Number: 54229 Gerrit-PatchSet: 4 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yidi Lin <yidi.lin(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Comment-Date: Thu, 13 May 2021 10:04:48 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: Add fast calibration support
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin. Rex-BC Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54269 ) Change subject: mb/google/cherry: Add fast calibration support ...................................................................... Patch Set 3: (2 comments) File src/mainboard/google/cherry/sdram_configs.c: https://review.coreboot.org/c/coreboot/+/54269/comment/b1a919bd_abf3c014 PS2, Line 8: , > . Done https://review.coreboot.org/c/coreboot/+/54269/comment/c5e93f02_b61114bc PS2, Line 9: t > T Done -- To view, visit https://review.coreboot.org/c/coreboot/+/54269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27 Gerrit-Change-Number: 54269 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 10:02:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Yu-Ping Wu <yupingso(a)google.com> Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: Add fast calibration support
by Yu-Ping Wu (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54269 ) Change subject: mb/google/cherry: Add fast calibration support ...................................................................... Patch Set 3: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27 Gerrit-Change-Number: 54269 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 10:02:11 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/google/cherry: Add fast calibration support
by Rex-BC Chen (Code Review) 13 May '21

13 May '21

Attention is currently required from: Hung-Te Lin, Rex-BC Chen. Hello Hung-Te Lin, build bot (Jenkins), Yu-Ping Wu, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/54269 to look at the new patch set (#3). Change subject: mb/google/cherry: Add fast calibration support ...................................................................... mb/google/cherry: Add fast calibration support Signed-off-by: Ryan Chuang <ryan.chuang(a)mediatek.com> Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27 --- M src/mainboard/google/cherry/Makefile.inc A src/mainboard/google/cherry/boardid.c M src/mainboard/google/cherry/romstage.c A src/mainboard/google/cherry/sdram_configs.c 4 files changed, 27 insertions(+), 0 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/54269/3 -- To view, visit https://review.coreboot.org/c/coreboot/+/54269 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ib7677baef126ee60bf35da3a4eaf720eaa118a27 Gerrit-Change-Number: 54269 Gerrit-PatchSet: 3 Gerrit-Owner: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-Reviewer: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Hung-Te Lin <hungte(a)chromium.org> Gerrit-Attention: Rex-BC Chen <rex-bc.chen(a)mediatek.corp-partner.google.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: vc/mediatek: Align code indent with code flow
by Yu-Ping Wu (Code Review) 13 May '21

13 May '21

Attention is currently required from: Xi Chen, Julius Werner. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54096 ) Change subject: vc/mediatek: Align code indent with code flow ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/54096 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I7b8cacd48e86284c5145c4e8ffb6add75a743108 Gerrit-Change-Number: 54096 Gerrit-PatchSet: 1 Gerrit-Owner: Patrick Georgi <pgeorgi(a)google.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Jacob Garber <jgarber1(a)ualberta.ca> Gerrit-Reviewer: Julius Werner <jwerner(a)chromium.org> Gerrit-Reviewer: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Reviewer: Yu-Ping Wu <yupingso(a)google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)mailbox.org> Gerrit-Attention: Xi Chen <xixi.chen(a)mediatek.com> Gerrit-Attention: Julius Werner <jwerner(a)chromium.org> Gerrit-Comment-Date: Thu, 13 May 2021 10:01:30 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit May 2021