coreboot-gerrit April 2021

coreboot-gerrit@coreboot.org

1 participants
6269 discussions

Change in coreboot[master]: lib: Add obvious definition for `calloc`
by Nico Huber (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Tim Wawrzynczak. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51949 ) Change subject: lib: Add obvious definition for `calloc` ...................................................................... Patch Set 8: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/51949 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I57a568e323344a97b35014b7b8bec16adc2fd720 Gerrit-Change-Number: 51949 Gerrit-PatchSet: 8 Gerrit-Owner: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Reviewer: Furquan Shaikh <furquan(a)google.com> Gerrit-Reviewer: Jakub Czapiga <jacz(a)semihalf.com> Gerrit-Reviewer: Nico Huber <nico.h(a)gmx.de> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Tim Wawrzynczak <twawrzynczak(a)chromium.org> Gerrit-Comment-Date: Fri, 02 Apr 2021 11:09:52 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: cpu/x86/smm: Add log_level that can be overridden for SMM log level
by Nico Huber (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Marc Jones, Patrick Rudolph, Jonathan Zhang, Johnny Lin, Rocky Phagura, Jingle Hsu, Angel Pons, Arthur Heymans, Morgan Jang, Kyösti Mälkki. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49460 ) Change subject: cpu/x86/smm: Add log_level that can be overridden for SMM log level ...................................................................... Patch Set 9: (2 comments) Commit Message: https://review.coreboot.org/c/coreboot/+/49460/comment/7e87d9ec_4697336f PS9, Line 16: for SMM. I couldn't find any discussion about this issue. Sorry if I just missed it somewhere else. Please provide more details. For instance, is it too much time for every SMI? or is it generally too much time, even if you'd only query VPD once during boot in SMM? Patchset: PS9: I don't understand why OVERRIDE_CONSOLE_LOGLEVEL is used to guard here. Your VPD/SMM situation is not the only reason why it might be set. So guarding or not, you'd add the code for builds that wouldn't make use of it. That you need the `weak` declaration makes that obvious. There's a lot of #if in .c files, please avoid that. But maybe first, we should talk about your requirements; see inline comment. Probably a dumb question: Can't you just cache the loglevel in your get_console_loglevel() after its first invocation? Then the VPD code would only run once. Is that bad already? If you really need to pass the loglevel from ramstage, I think you should do either of these two: o Make passing the loglevel to SMM an option for everyone. Without the need for additional code. o Use a generic mechanism to pass board-specific information into SMM. That it's about the console shouldn't be visible to the SMM-loader code. But don't mix these things. -- To view, visit https://review.coreboot.org/c/coreboot/+/49460 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I81722a4f1bf75ec942cc06e403ad702dfe938e71 Gerrit-Change-Number: 49460 Gerrit-PatchSet: 9 Gerrit-Owner: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Reviewer: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Reviewer: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Reviewer: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Reviewer: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Reviewer: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Reviewer: Rocky Phagura <rphagura(a)fb.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-CC: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-CC: Nico Huber <nico.h(a)gmx.de> Gerrit-CC: Paul Menzel <paulepanter(a)users.sourceforge.net> Gerrit-Attention: Marc Jones <marc(a)marcjonesconsulting.com> Gerrit-Attention: Patrick Rudolph <patrick.rudolph(a)9elements.com> Gerrit-Attention: Jonathan Zhang <jonzhang(a)fb.com> Gerrit-Attention: Johnny Lin <Johnny_Lin(a)wiwynn.com> Gerrit-Attention: Rocky Phagura <rphagura(a)fb.com> Gerrit-Attention: Jingle Hsu <jingle_hsu(a)wiwynn.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Attention: Arthur Heymans <arthur(a)aheymans.xyz> Gerrit-Attention: Morgan Jang <Morgan_Jang(a)wiwynn.com> Gerrit-Attention: Kyösti Mälkki <kyosti.malkki(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Apr 2021 10:58:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/facebook/monolith: Update VBOOT settings
by Wim Vervoorn (Code Review) 02 Apr '21

02 Apr '21

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52053 ) Change subject: mb/facebook/monolith: Update VBOOT settings ...................................................................... mb/facebook/monolith: Update VBOOT settings Make sure the standard for the board options are set when VBOOT is enabled. BUG=N/A TEST=tested on facebook monolith Change-Id: I9749eeeffbd26e7c5caaeb7c0407a765cf093337 Signed-off-by: Wim Vervoorn <wvervoorn(a)eltan.com> --- M src/mainboard/facebook/monolith/Kconfig 1 file changed, 6 insertions(+), 5 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/53/52053/1 diff --git a/src/mainboard/facebook/monolith/Kconfig b/src/mainboard/facebook/monolith/Kconfig index ddbc27e..1962352 100644 --- a/src/mainboard/facebook/monolith/Kconfig +++ b/src/mainboard/facebook/monolith/Kconfig @@ -80,14 +80,15 @@ bool default n +config VBOOT + select VBOOT_NO_BOARD_SUPPORT + select VBOOT_SLOTS_RW_A + select VBOOT_ALWAYS_ENABLE_DISPLAY + select VBOOT_ENABLE_CBFS_FALLBACK + config RW_REGION_ONLY string "Files in RW only" -config VBOOT_ENABLE_CBFS_FALLBACK - bool - default y - depends on VBOOT - config VBOOT_ALWAYS_ALLOW_UDC def_bool y depends on VBOOT && !CHROMEOS -- To view, visit https://review.coreboot.org/c/coreboot/+/52053 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I9749eeeffbd26e7c5caaeb7c0407a765cf093337 Gerrit-Change-Number: 52053 Gerrit-PatchSet: 1 Gerrit-Owner: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/facebook/monolith: Allow TPM initialization
by Wim Vervoorn (Code Review) 02 Apr '21

02 Apr '21

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52052 ) Change subject: mb/facebook/monolith: Allow TPM initialization ...................................................................... mb/facebook/monolith: Allow TPM initialization TPM_INIT is disabled by default. This prevents TPM to be operational when VBOOT is disabled. Remove the TPM_INIT disable. BUG=N/A TEST=tested on facebook monolith with VBOOT disabled. Change-Id: I84d525a18c84643903922fef0a11dcf98abbbe4d Signed-off-by: Wim Vervoorn <wvervoorn(a)eltan.com> --- M src/mainboard/facebook/monolith/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/52052/1 diff --git a/src/mainboard/facebook/monolith/Kconfig b/src/mainboard/facebook/monolith/Kconfig index ddbc27e..be1f593 100644 --- a/src/mainboard/facebook/monolith/Kconfig +++ b/src/mainboard/facebook/monolith/Kconfig @@ -68,10 +68,6 @@ int default 2 -config TPM_INIT - bool - default n - config MAINBOARD_SUPPORTS_SKYLAKE_CPU bool default n -- To view, visit https://review.coreboot.org/c/coreboot/+/52052 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84d525a18c84643903922fef0a11dcf98abbbe4d Gerrit-Change-Number: 52052 Gerrit-PatchSet: 1 Gerrit-Owner: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-MessageType: newchange

1 0

Change in coreboot[master]: mb/facebook/fbg1701/Kconfig: Remove TPM_INIT
by Angel Pons (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Frans Hendriks. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52051 ) Change subject: mb/facebook/fbg1701/Kconfig: Remove TPM_INIT ...................................................................... Patch Set 1: Code-Review+1 -- To view, visit https://review.coreboot.org/c/coreboot/+/52051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91bde691d445d4210429c928e90e16653092f1cb Gerrit-Change-Number: 52051 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Comment-Date: Fri, 02 Apr 2021 10:05:45 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/tpm/Kconfig: TPM_INIT for measured boot only
by Wim Vervoorn (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Frans Hendriks, Angel Pons. Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52050 ) Change subject: drivers/tpm/Kconfig: TPM_INIT for measured boot only ...................................................................... Patch Set 2: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03f8457731c73c653bd82b1042bda3fc2d797feb Gerrit-Change-Number: 52050 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Apr 2021 09:53:41 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: mb/facebook/fbg1701/Kconfig: Remove TPM_INIT
by Wim Vervoorn (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Frans Hendriks, Angel Pons. Wim Vervoorn has removed a vote from this change. ( https://review.coreboot.org/c/coreboot/+/52051 ) Change subject: mb/facebook/fbg1701/Kconfig: Remove TPM_INIT ...................................................................... Removed Code-Review+2 by Wim Vervoorn <wvervoorn(a)eltan.com> -- To view, visit https://review.coreboot.org/c/coreboot/+/52051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91bde691d445d4210429c928e90e16653092f1cb Gerrit-Change-Number: 52051 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-MessageType: deleteVote

1 0

Change in coreboot[master]: mb/facebook/fbg1701/Kconfig: Remove TPM_INIT
by Wim Vervoorn (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Frans Hendriks, Angel Pons. Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52051 ) Change subject: mb/facebook/fbg1701/Kconfig: Remove TPM_INIT ...................................................................... Patch Set 1: Code-Review+2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91bde691d445d4210429c928e90e16653092f1cb Gerrit-Change-Number: 52051 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply(a)coreboot.org> Gerrit-Attention: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Attention: Angel Pons <th3fanbus(a)gmail.com> Gerrit-Comment-Date: Fri, 02 Apr 2021 09:52:20 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

1 0

Change in coreboot[master]: drivers/tpm/Kconfig: TPM_INIT for measured boot only
by Frans Hendriks (Code Review) 02 Apr '21

02 Apr '21

Frans Hendriks has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/52050 ) Change subject: drivers/tpm/Kconfig: TPM_INIT for measured boot only ...................................................................... drivers/tpm/Kconfig: TPM_INIT for measured boot only TPM_INIT depends on VBOOT but should also depend on VENDORCODE_ELTAN_xBOOT. Add dependency. TPM_INIT will be enable for measured boot only. BUG = NA TEST = Boot Facebook FB1701 with possible combinaties of VBOOT, measured boot and eltan security. Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> Change-Id: I03f8457731c73c653bd82b1042bda3fc2d797feb --- M src/drivers/tpm/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/50/52050/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/52050 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I03f8457731c73c653bd82b1042bda3fc2d797feb Gerrit-Change-Number: 52050 Gerrit-PatchSet: 2 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-MessageType: newpatchset

1 0

Change in coreboot[master]: mb/facebook/fbg1701/Kconfig: Remove TPM_INIT
by Frans Hendriks (Code Review) 02 Apr '21

02 Apr '21

Attention is currently required from: Wim Vervoorn. Frans Hendriks has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/52051 ) Change subject: mb/facebook/fbg1701/Kconfig: Remove TPM_INIT ...................................................................... mb/facebook/fbg1701/Kconfig: Remove TPM_INIT TPM_INIT needs to be enabled for measured boot only configuration. In patchset dependency of TPM_INIT is correct. Config of TPM_INIT can be removed. BUG = NA TEST = Boot possible combinations of VBOOT, measured boot and vendorcode security. Signed-off-by: Frans Hendriks <fhendriks(a)eltan.com> Change-Id: I91bde691d445d4210429c928e90e16653092f1cb --- M src/mainboard/facebook/fbg1701/Kconfig 1 file changed, 0 insertions(+), 4 deletions(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/52051/1 diff --git a/src/mainboard/facebook/fbg1701/Kconfig b/src/mainboard/facebook/fbg1701/Kconfig index e01f979..e93fdfa 100644 --- a/src/mainboard/facebook/fbg1701/Kconfig +++ b/src/mainboard/facebook/fbg1701/Kconfig @@ -88,10 +88,6 @@ bool default y -config TPM_INIT - bool "TPM Setup in RAMSTAGE" - default n - config VENDORCODE_ELTAN_VBOOT_SIGNED_MANIFEST depends on USE_VENDORCODE_ELTAN bool -- To view, visit https://review.coreboot.org/c/coreboot/+/52051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I91bde691d445d4210429c928e90e16653092f1cb Gerrit-Change-Number: 52051 Gerrit-PatchSet: 1 Gerrit-Owner: Frans Hendriks <fhendriks(a)eltan.com> Gerrit-Reviewer: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-Attention: Wim Vervoorn <wvervoorn(a)eltan.com> Gerrit-MessageType: newchange

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

coreboot-gerrit April 2021